)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":29100,"name":"Jason Anderson","email":"jasonanderson@uchicago.edu","username":"jasonanderson"},"change_message_id":"ef140046e4218d6b4f73594567a425a752a40ed7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"28c10060_a1fb89af","updated":"2021-12-20 23:37:25.000000000","message":"This looks good, but I think does need a release notes (was this filed as a bug? If so it should also say closes-bug in the commit body).","commit_id":"69169d140d416d807f15f267d5665180dd0b16a4"},{"author":{"_account_id":33582,"name":"Mark Powers","email":"markpowers@uchicago.edu","username":"markpowers"},"change_message_id":"0c0aa570a512aa1b804f2c2f69cf363b4cb5bd4f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5960f4ae_4ff3c659","updated":"2021-12-15 21:50:54.000000000","message":"recheck","commit_id":"69169d140d416d807f15f267d5665180dd0b16a4"},{"author":{"_account_id":29100,"name":"Jason Anderson","email":"jasonanderson@uchicago.edu","username":"jasonanderson"},"change_message_id":"6f71e28b573669a85205c0d45f1414493c9fbd9a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"837f6a47_0e1fa0bd","in_reply_to":"28c10060_a1fb89af","updated":"2021-12-20 23:38:11.000000000","message":"(nvm I see you have the bug referenced :)) -- just add a releasenotes, for bugs I usually call them fix-\u003cbug_number\u003e","commit_id":"69169d140d416d807f15f267d5665180dd0b16a4"},{"author":{"_account_id":33582,"name":"Mark Powers","email":"markpowers@uchicago.edu","username":"markpowers"},"change_message_id":"a2facb97174804cd8f2063cd1f5ab743a2738f33","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"861e6b12_81351cfa","in_reply_to":"837f6a47_0e1fa0bd","updated":"2021-12-21 16:55:42.000000000","message":"Ack","commit_id":"69169d140d416d807f15f267d5665180dd0b16a4"},{"author":{"_account_id":33582,"name":"Mark Powers","email":"markpowers@uchicago.edu","username":"markpowers"},"change_message_id":"a2facb97174804cd8f2063cd1f5ab743a2738f33","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"efa51a75_30115ef9","in_reply_to":"837f6a47_0e1fa0bd","updated":"2021-12-21 16:55:42.000000000","message":"Done","commit_id":"69169d140d416d807f15f267d5665180dd0b16a4"},{"author":{"_account_id":29100,"name":"Jason Anderson","email":"jasonanderson@uchicago.edu","username":"jasonanderson"},"change_message_id":"304cf4315f9a4c44de079f755186f66729d9ac78","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"2762ccf6_475caacd","updated":"2022-01-14 22:49:07.000000000","message":"I added a test case for this functionality, as I didn\u0027t see one from before. Otherwise this looks good to go, thanks Mark","commit_id":"8a8135ae2433ed92bf860de2926b8690a40b0492"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"52a1fc8e7acbcb8a6b9b5cf70ec506e165eb78de","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"6a3b587b_c37b186f","updated":"2022-02-04 08:09:27.000000000","message":"Earlier version approved by Jason, no functional changs.","commit_id":"d4cb8f428e4f23add5fc643ad23366ec58d7ec9d"}],"blazar/manager/service.py":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"626c253bc2485b94122921ae47e02c89ff4d9d30","unresolved":true,"context_lines":[{"line_number":399,"context_line":"    @status.lease.lease_status("},{"line_number":400,"context_line":"        transition\u003dstatus.lease.UPDATING,"},{"line_number":401,"context_line":"        result_in\u003dstatus.lease.STABLE,"},{"line_number":402,"context_line":"        non_fatal_exceptions\u003d["},{"line_number":403,"context_line":"            common_ex.InvalidInput,"},{"line_number":404,"context_line":"            exceptions.InvalidRange,"},{"line_number":405,"context_line":"            exceptions.MissingParameter,"},{"line_number":406,"context_line":"            exceptions.MalformedRequirements,"},{"line_number":407,"context_line":"            exceptions.MalformedParameter,"},{"line_number":408,"context_line":"            exceptions.NotEnoughHostsAvailable,"},{"line_number":409,"context_line":"            exceptions.InvalidDate,"},{"line_number":410,"context_line":"        ]"},{"line_number":411,"context_line":"    )"},{"line_number":412,"context_line":"    def update_lease(self, lease_id, values):"},{"line_number":413,"context_line":"        if not values:"}],"source_content_type":"text/x-python","patch_set":3,"id":"e515ce7f_3100142a","line":410,"range":{"start_line":402,"start_character":0,"end_line":410,"end_character":9},"updated":"2022-01-12 22:49:58.000000000","message":"I think we should add more exceptions:\n\nCantUpdateParameter\nInvalidPeriod","commit_id":"8f955e3215fb53c5acee82e391c3804140f9f2b6"},{"author":{"_account_id":33582,"name":"Mark Powers","email":"markpowers@uchicago.edu","username":"markpowers"},"change_message_id":"f0e2fe757df28f89c049f7ae13ec009f764a9700","unresolved":false,"context_lines":[{"line_number":399,"context_line":"    @status.lease.lease_status("},{"line_number":400,"context_line":"        transition\u003dstatus.lease.UPDATING,"},{"line_number":401,"context_line":"        result_in\u003dstatus.lease.STABLE,"},{"line_number":402,"context_line":"        non_fatal_exceptions\u003d["},{"line_number":403,"context_line":"            common_ex.InvalidInput,"},{"line_number":404,"context_line":"            exceptions.InvalidRange,"},{"line_number":405,"context_line":"            exceptions.MissingParameter,"},{"line_number":406,"context_line":"            exceptions.MalformedRequirements,"},{"line_number":407,"context_line":"            exceptions.MalformedParameter,"},{"line_number":408,"context_line":"            exceptions.NotEnoughHostsAvailable,"},{"line_number":409,"context_line":"            exceptions.InvalidDate,"},{"line_number":410,"context_line":"        ]"},{"line_number":411,"context_line":"    )"},{"line_number":412,"context_line":"    def update_lease(self, lease_id, values):"},{"line_number":413,"context_line":"        if not values:"}],"source_content_type":"text/x-python","patch_set":3,"id":"02cac614_b42a32a0","line":410,"range":{"start_line":402,"start_character":0,"end_line":410,"end_character":9},"in_reply_to":"94713f15_10d4136d","updated":"2022-01-13 15:38:28.000000000","message":"Done","commit_id":"8f955e3215fb53c5acee82e391c3804140f9f2b6"},{"author":{"_account_id":33582,"name":"Mark Powers","email":"markpowers@uchicago.edu","username":"markpowers"},"change_message_id":"f0e2fe757df28f89c049f7ae13ec009f764a9700","unresolved":false,"context_lines":[{"line_number":399,"context_line":"    @status.lease.lease_status("},{"line_number":400,"context_line":"        transition\u003dstatus.lease.UPDATING,"},{"line_number":401,"context_line":"        result_in\u003dstatus.lease.STABLE,"},{"line_number":402,"context_line":"        non_fatal_exceptions\u003d["},{"line_number":403,"context_line":"            common_ex.InvalidInput,"},{"line_number":404,"context_line":"            exceptions.InvalidRange,"},{"line_number":405,"context_line":"            exceptions.MissingParameter,"},{"line_number":406,"context_line":"            exceptions.MalformedRequirements,"},{"line_number":407,"context_line":"            exceptions.MalformedParameter,"},{"line_number":408,"context_line":"            exceptions.NotEnoughHostsAvailable,"},{"line_number":409,"context_line":"            exceptions.InvalidDate,"},{"line_number":410,"context_line":"        ]"},{"line_number":411,"context_line":"    )"},{"line_number":412,"context_line":"    def update_lease(self, lease_id, values):"},{"line_number":413,"context_line":"        if not values:"}],"source_content_type":"text/x-python","patch_set":3,"id":"755ae0c9_9948ba37","line":410,"range":{"start_line":402,"start_character":0,"end_line":410,"end_character":9},"in_reply_to":"94713f15_10d4136d","updated":"2022-01-13 15:38:28.000000000","message":"Done","commit_id":"8f955e3215fb53c5acee82e391c3804140f9f2b6"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"cb488b3ae28f7763b45a8399e5db635fff5eba3b","unresolved":true,"context_lines":[{"line_number":399,"context_line":"    @status.lease.lease_status("},{"line_number":400,"context_line":"        transition\u003dstatus.lease.UPDATING,"},{"line_number":401,"context_line":"        result_in\u003dstatus.lease.STABLE,"},{"line_number":402,"context_line":"        non_fatal_exceptions\u003d["},{"line_number":403,"context_line":"            common_ex.InvalidInput,"},{"line_number":404,"context_line":"            exceptions.InvalidRange,"},{"line_number":405,"context_line":"            exceptions.MissingParameter,"},{"line_number":406,"context_line":"            exceptions.MalformedRequirements,"},{"line_number":407,"context_line":"            exceptions.MalformedParameter,"},{"line_number":408,"context_line":"            exceptions.NotEnoughHostsAvailable,"},{"line_number":409,"context_line":"            exceptions.InvalidDate,"},{"line_number":410,"context_line":"        ]"},{"line_number":411,"context_line":"    )"},{"line_number":412,"context_line":"    def update_lease(self, lease_id, values):"},{"line_number":413,"context_line":"        if not values:"}],"source_content_type":"text/x-python","patch_set":3,"id":"94713f15_10d4136d","line":410,"range":{"start_line":402,"start_character":0,"end_line":410,"end_character":9},"in_reply_to":"d6fafb04_3807d997","updated":"2022-01-13 14:29:17.000000000","message":"See https://bugs.launchpad.net/blazar/+bug/1957761 and https://review.opendev.org/c/openstack/blazar/+/824579","commit_id":"8f955e3215fb53c5acee82e391c3804140f9f2b6"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"d4a4ced59f2cee51a0d6cd6b59c1f053e098ad48","unresolved":true,"context_lines":[{"line_number":399,"context_line":"    @status.lease.lease_status("},{"line_number":400,"context_line":"        transition\u003dstatus.lease.UPDATING,"},{"line_number":401,"context_line":"        result_in\u003dstatus.lease.STABLE,"},{"line_number":402,"context_line":"        non_fatal_exceptions\u003d["},{"line_number":403,"context_line":"            common_ex.InvalidInput,"},{"line_number":404,"context_line":"            exceptions.InvalidRange,"},{"line_number":405,"context_line":"            exceptions.MissingParameter,"},{"line_number":406,"context_line":"            exceptions.MalformedRequirements,"},{"line_number":407,"context_line":"            exceptions.MalformedParameter,"},{"line_number":408,"context_line":"            exceptions.NotEnoughHostsAvailable,"},{"line_number":409,"context_line":"            exceptions.InvalidDate,"},{"line_number":410,"context_line":"        ]"},{"line_number":411,"context_line":"    )"},{"line_number":412,"context_line":"    def update_lease(self, lease_id, values):"},{"line_number":413,"context_line":"        if not values:"}],"source_content_type":"text/x-python","patch_set":3,"id":"d6fafb04_3807d997","line":410,"range":{"start_line":402,"start_character":0,"end_line":410,"end_character":9},"in_reply_to":"e515ce7f_3100142a","updated":"2022-01-13 09:51:45.000000000","message":"Although this is really more a bug in the current code (not this patch). I will open a bug report and submit a patch.","commit_id":"8f955e3215fb53c5acee82e391c3804140f9f2b6"}]}