)]}'
{"climate/manager/service.py":[{"author":{"_account_id":7075,"name":"Swann Croiset","email":"scroiset@mirantis.com","username":"swann"},"change_message_id":"f3bc512044bfa915984e020b949106a902dc6919","unresolved":false,"context_lines":[{"line_number":205,"context_line":"            lease_id \u003d lease[\u0027id\u0027]"},{"line_number":206,"context_line":"        except db_ex.ClimateDBDuplicateEntry:"},{"line_number":207,"context_line":"            LOG.exception(\u0027Cannot create a lease - duplicated lease name\u0027)"},{"line_number":208,"context_line":"            raise exceptions.LeaseNameAlreadyExists(name\u003dlease_values[\u0027name\u0027])"},{"line_number":209,"context_line":"        except db_ex.ClimateDBException:"},{"line_number":210,"context_line":"            LOG.exception(\u0027Cannot create a lease\u0027)"},{"line_number":211,"context_line":"            raise"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F9Qd4%3D","line":208,"updated":"2014-04-07 16:28:36.000000000","message":"IIRC here you\u0027re not sure this is the root cause: not necessary a lease name duplicate but can be an error in Event creation ..  ( or Reservation creation )\n\nthen the LeaseNameAlreadyExists exception can hide the real source of the error.\n\nsee: climate/db/sqlalchemy/api.py  lease_create()\n\nA propositions could be:\n\ncheck the ClimateDBDuplicateEntry.model \u003d\u003d  \u0027Lease | Resa | Event\u0027\n\nname \u003d lease_values[\u0027name\u0027]\n# or\nname \u003d events names ..\n# or \nnames \u003d reservation names ..\n\nand raise a generic NameMustBeUniq(for\u003de.model, name\u003dname)","commit_id":"fd46fa74439f960d2c76629351c46ad8f9b9be48"},{"author":{"_account_id":10945,"name":"Micha? Kami?ski","email":"michal.kaminski@amg.net.pl","username":"mkaminsk"},"change_message_id":"dcef5cdfac8aaa4eaf771da61fe0e25ec20be4b0","unresolved":false,"context_lines":[{"line_number":205,"context_line":"            lease_id \u003d lease[\u0027id\u0027]"},{"line_number":206,"context_line":"        except db_ex.ClimateDBDuplicateEntry:"},{"line_number":207,"context_line":"            LOG.exception(\u0027Cannot create a lease - duplicated lease name\u0027)"},{"line_number":208,"context_line":"            raise exceptions.LeaseNameAlreadyExists(name\u003dlease_values[\u0027name\u0027])"},{"line_number":209,"context_line":"        except db_ex.ClimateDBException:"},{"line_number":210,"context_line":"            LOG.exception(\u0027Cannot create a lease\u0027)"},{"line_number":211,"context_line":"            raise"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWn%2F%2F%2BFQ%3D","line":208,"in_reply_to":"AAAAWH%2F9QHk%3D","updated":"2014-04-08 07:06:59.000000000","message":"Yes, currently one constraint is only for the name of the lease. Moreover only the lease has property name, so adding a generic exception handling will not work in this case. Please remove -1.","commit_id":"fd46fa74439f960d2c76629351c46ad8f9b9be48"},{"author":{"_account_id":3012,"name":"Dina Belova","email":"dbelova@mirantis.com","username":"dbelova"},"change_message_id":"853e32922e0c1270b5b811495a3526ba491315ef","unresolved":false,"context_lines":[{"line_number":205,"context_line":"            lease_id \u003d lease[\u0027id\u0027]"},{"line_number":206,"context_line":"        except db_ex.ClimateDBDuplicateEntry:"},{"line_number":207,"context_line":"            LOG.exception(\u0027Cannot create a lease - duplicated lease name\u0027)"},{"line_number":208,"context_line":"            raise exceptions.LeaseNameAlreadyExists(name\u003dlease_values[\u0027name\u0027])"},{"line_number":209,"context_line":"        except db_ex.ClimateDBException:"},{"line_number":210,"context_line":"            LOG.exception(\u0027Cannot create a lease\u0027)"},{"line_number":211,"context_line":"            raise"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F9QHk%3D","line":208,"in_reply_to":"AAAAWH%2F9Qd4%3D","updated":"2014-04-07 16:37:54.000000000","message":"well, the thing is that currently event/reservation won\u0027t raise duplicate, although there is error handling in the code. That\u0027s because lease has unique constraint https://github.com/stackforge/climate/blob/master/climate/db/sqlalchemy/models.py#L53 - and events/reservations do not. So this change is correct due to current code.","commit_id":"fd46fa74439f960d2c76629351c46ad8f9b9be48"},{"author":{"_account_id":7075,"name":"Swann Croiset","email":"scroiset@mirantis.com","username":"swann"},"change_message_id":"f77d3e661375f06eb759f479f1820183c10020fe","unresolved":false,"context_lines":[{"line_number":205,"context_line":"            lease_id \u003d lease[\u0027id\u0027]"},{"line_number":206,"context_line":"        except db_ex.ClimateDBDuplicateEntry:"},{"line_number":207,"context_line":"            LOG.exception(\u0027Cannot create a lease - duplicated lease name\u0027)"},{"line_number":208,"context_line":"            raise exceptions.LeaseNameAlreadyExists(name\u003dlease_values[\u0027name\u0027])"},{"line_number":209,"context_line":"        except db_ex.ClimateDBException:"},{"line_number":210,"context_line":"            LOG.exception(\u0027Cannot create a lease\u0027)"},{"line_number":211,"context_line":"            raise"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWn%2F%2F94o%3D","line":208,"in_reply_to":"AAAAWn%2F%2F%2BFQ%3D","updated":"2014-04-08 07:39:31.000000000","message":"ok your\u0027re right.","commit_id":"fd46fa74439f960d2c76629351c46ad8f9b9be48"}]}