)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9331,"name":"Pablo Andres Fuente","email":"pablo.andres.fuente@gmail.com","username":"pafuent"},"change_message_id":"f55c0c0a8cd623007429f676aec47c548b1126fd","unresolved":false,"context_lines":[{"line_number":14,"context_line":"tempest code, we built a similar hierachy (check manager and scenario"},{"line_number":15,"context_line":"classes and their parents)."},{"line_number":16,"context_line":"As long for the config_resource_reservation file, we added some"},{"line_number":17,"context_line":"params to handle the timeout checks (please, check if this is appropriate)"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"The test added follow these steps:"},{"line_number":20,"context_line":"    1) Create an instance with the hint parameters"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAW3%2F%2Faag%3D","line":17,"updated":"2014-04-14 20:50:42.000000000","message":"Please remove the (please...) and add that in a review comment.","commit_id":"69a85b962625ccf3ff9806f6c45fcc2484fa37f6"},{"author":{"_account_id":3012,"name":"Dina Belova","email":"dbelova@mirantis.com","username":"dbelova"},"change_message_id":"ac6dc2e9ce737242f58e3ac06036339ca70962bb","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"The test added follow these steps:"},{"line_number":20,"context_line":"    1) Create an instance with the hint parameters"},{"line_number":21,"context_line":"\t* start_date: now + 1 minute"},{"line_number":22,"context_line":"\t* end_date: start_date + 3 minutes"},{"line_number":23,"context_line":"    2) check vm was shelved"},{"line_number":24,"context_line":"    3) check vm became active"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAW3%2F%2FRbk%3D","line":21,"updated":"2014-04-15 16:37:31.000000000","message":"please remove tabs here too","commit_id":"69a85b962625ccf3ff9806f6c45fcc2484fa37f6"}],"contrib/tempest/README.rst":[{"author":{"_account_id":9331,"name":"Pablo Andres Fuente","email":"pablo.andres.fuente@gmail.com","username":"pafuent"},"change_message_id":"1759c588dccf0b280b0a44053b3e7b041579fdf5","unresolved":false,"context_lines":[{"line_number":20,"context_line":"$ tox -eclimate"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"To debug tests with pdb or ipdb debuggers, run the following:"},{"line_number":23,"context_line":"$ python -m testtools.run tempest.\"path_to_your_test_file\".\"test_file_name\".\"your_test_suite_name\""}],"source_content_type":"text/x-rst","patch_set":2,"id":"AAAAXH%2F%2Fxig%3D","line":23,"updated":"2014-04-17 15:11:45.000000000","message":"path_to_your_test_file could be confusing, because this is a \"python module path\". Maybe something like \"modules_to_your_test_file\" or something better.","commit_id":"0bf7ab8b1befea42276ea84543a7e4e8a93678bb"},{"author":{"_account_id":10200,"name":"Christian Martinez","email":"chmartinez35@gmail.com","username":"cmart"},"change_message_id":"1e8eddcb33d9f5d88da10263d3171a27c2d63fd8","unresolved":false,"context_lines":[{"line_number":20,"context_line":"$ tox -eclimate"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"To debug tests with pdb or ipdb debuggers, run the following:"},{"line_number":23,"context_line":"$ python -m testtools.run tempest.\"path_to_your_test_file\".\"test_file_name\".\"your_test_suite_name\""}],"source_content_type":"text/x-rst","patch_set":2,"id":"AAAAXH%2F%2FxKI%3D","line":23,"in_reply_to":"AAAAXH%2F%2Fxig%3D","updated":"2014-04-17 15:44:21.000000000","message":"Done","commit_id":"0bf7ab8b1befea42276ea84543a7e4e8a93678bb"}],"contrib/tempest/tempest/config_resource_reservation.py":[{"author":{"_account_id":10200,"name":"Christian Martinez","email":"chmartinez35@gmail.com","username":"cmart"},"change_message_id":"b3831d88ec909941b6ed0f29344038057bd0491b","unresolved":false,"context_lines":[{"line_number":36,"context_line":"               choices\u003d[\u0027public\u0027, \u0027admin\u0027, \u0027internal\u0027,"},{"line_number":37,"context_line":"                        \u0027publicURL\u0027, \u0027adminURL\u0027, \u0027internalURL\u0027],"},{"line_number":38,"context_line":"               help\u003d\"The endpoint type to use for the resource_reservation \""},{"line_number":39,"context_line":"                    \"service.\"),"},{"line_number":40,"context_line":"    cfg.IntOpt(\u0027lease_interval\u0027,"},{"line_number":41,"context_line":"               default\u003d10,"},{"line_number":42,"context_line":"               help\u003d\"Time in seconds between lease status checks.\"),"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAXH%2F%2F7JQ%3D","line":39,"updated":"2014-04-16 13:36:21.000000000","message":"Please, check if this is the appropriate way of storing these configuration attributes","commit_id":"69a85b962625ccf3ff9806f6c45fcc2484fa37f6"}],"contrib/tempest/tempest/resource_reservation_client_manager.py":[{"author":{"_account_id":3012,"name":"Dina Belova","email":"dbelova@mirantis.com","username":"dbelova"},"change_message_id":"6fe50a3b1900568556d3d7dd3232553f7fd62c89","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"class ResourceReservationManager(manager.OfficialClientManager):"},{"line_number":26,"context_line":"    \"\"\"Manager that provides access to the python climate client."},{"line_number":27,"context_line":"    \"\"\""},{"line_number":28,"context_line":"    CLIMATECLIENT_VERSION \u003d \u00271\u0027"},{"line_number":29,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAXH%2F%2Fd8Q%3D","line":26,"updated":"2014-04-21 15:00:52.000000000","message":"the same as in the next file","commit_id":"3d92a50e16558175d29844ede7adf0a351d46ad9"}],"contrib/tempest/tempest/scenario/resource_reservation_scenario.py":[{"author":{"_account_id":9331,"name":"Pablo Andres Fuente","email":"pablo.andres.fuente@gmail.com","username":"pafuent"},"change_message_id":"f55c0c0a8cd623007429f676aec47c548b1126fd","unresolved":false,"context_lines":[{"line_number":43,"context_line":"            cls.manager.resource_reservation_client"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    @classmethod"},{"line_number":46,"context_line":"    def credentials(cls):"},{"line_number":47,"context_line":"        return cls._get_credentials(cls.isolated_creds.get_primary_creds, \u0027\u0027)"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    def get_lease_by_name(self, lease_name):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAW3%2F%2FaXc%3D","line":46,"updated":"2014-04-14 20:50:42.000000000","message":"This method could be removed. Is the same that OfficialClientTest.credentials()","commit_id":"69a85b962625ccf3ff9806f6c45fcc2484fa37f6"},{"author":{"_account_id":10200,"name":"Christian Martinez","email":"chmartinez35@gmail.com","username":"cmart"},"change_message_id":"9ea84edf0f2da232b549b6335dd69e6694bdd594","unresolved":false,"context_lines":[{"line_number":43,"context_line":"            cls.manager.resource_reservation_client"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    @classmethod"},{"line_number":46,"context_line":"    def credentials(cls):"},{"line_number":47,"context_line":"        return cls._get_credentials(cls.isolated_creds.get_primary_creds, \u0027\u0027)"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    def get_lease_by_name(self, lease_name):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAXH%2F%2F7Io%3D","line":46,"in_reply_to":"AAAAW3%2F%2FaXc%3D","updated":"2014-04-16 15:48:29.000000000","message":"Done","commit_id":"69a85b962625ccf3ff9806f6c45fcc2484fa37f6"},{"author":{"_account_id":9331,"name":"Pablo Andres Fuente","email":"pablo.andres.fuente@gmail.com","username":"pafuent"},"change_message_id":"f55c0c0a8cd623007429f676aec47c548b1126fd","unresolved":false,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":"        def check_lease_end():"},{"line_number":68,"context_line":"            events \u003d \\"},{"line_number":69,"context_line":"                self.resource_reservation_client.lease.get(lease_id)[\u0027events\u0027]"},{"line_number":70,"context_line":"            return len(filter(lambda evt: evt[\u0027event_type\u0027] \u003d\u003d \u0027end_lease\u0027 and"},{"line_number":71,"context_line":"                              evt[\u0027status\u0027] \u003d\u003d \u0027DONE\u0027,"},{"line_number":72,"context_line":"                              events)) \u003e 0"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAW3%2F%2FaV8%3D","line":69,"updated":"2014-04-14 20:50:42.000000000","message":"Please check that you get the lease before accessing the lease events.","commit_id":"69a85b962625ccf3ff9806f6c45fcc2484fa37f6"},{"author":{"_account_id":3012,"name":"Dina Belova","email":"dbelova@mirantis.com","username":"dbelova"},"change_message_id":"6fe50a3b1900568556d3d7dd3232553f7fd62c89","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"class ResourceReservationScenarioTest(clientTest.OfficialClientTest):"},{"line_number":30,"context_line":"    \"\"\"Base class for resource reservation scenario tests."},{"line_number":31,"context_line":"    \"\"\""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAXH%2F%2Fd8g%3D","line":30,"updated":"2014-04-21 15:00:52.000000000","message":"I prefer keep \"\"\"\u003c...\u003e\"\"\" on one line due to http://legacy.python.org/dev/peps/pep-0257/\n\nPlease move \"\"\" to the previous line","commit_id":"3d92a50e16558175d29844ede7adf0a351d46ad9"},{"author":{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},"change_message_id":"0ba1008d2d520328038e778f962b40faaf11885e","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from tempest import config_resource_reservation as config"},{"line_number":17,"context_line":"from tempest import resource_reservation_client_manager as clients"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from tempest import exceptions"},{"line_number":20,"context_line":"from tempest.openstack.common import log"},{"line_number":21,"context_line":"from tempest.scenario import manager as clientTest"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAXX%2F%2F5XE%3D","line":18,"updated":"2014-04-25 13:29:26.000000000","message":"No need to add this blank space","commit_id":"cf7430fe22b93c423f2f4485958071923b48d31c"},{"author":{"_account_id":10200,"name":"Christian Martinez","email":"chmartinez35@gmail.com","username":"cmart"},"change_message_id":"47d6d90d8585d9008c62d0b8063aa9a5e5ea5507","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from tempest import config_resource_reservation as config"},{"line_number":17,"context_line":"from tempest import resource_reservation_client_manager as clients"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from tempest import exceptions"},{"line_number":20,"context_line":"from tempest.openstack.common import log"},{"line_number":21,"context_line":"from tempest.scenario import manager as clientTest"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAXX%2F%2F5N8%3D","line":18,"in_reply_to":"AAAAXX%2F%2F5XE%3D","updated":"2014-04-25 13:57:56.000000000","message":"Done","commit_id":"cf7430fe22b93c423f2f4485958071923b48d31c"},{"author":{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},"change_message_id":"0ba1008d2d520328038e778f962b40faaf11885e","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        username, password, tenant_name \u003d cls.credentials()"},{"line_number":39,"context_line":"        cls.manager \u003d clients.ResourceReservationManager("},{"line_number":40,"context_line":"            username, password, tenant_name)"},{"line_number":41,"context_line":"        cls.resource_reservation_client \u003d \\"},{"line_number":42,"context_line":"            cls.manager.resource_reservation_client"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    def get_lease_by_name(self, lease_name):"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAXX%2F%2F5W8%3D","line":41,"updated":"2014-04-25 13:29:26.000000000","message":"It is better use () for a long sentence.\n\ncls.resource_reservation_client \u003d (\n     cls.manager.resource_reservation_client)","commit_id":"cf7430fe22b93c423f2f4485958071923b48d31c"},{"author":{"_account_id":10200,"name":"Christian Martinez","email":"chmartinez35@gmail.com","username":"cmart"},"change_message_id":"47d6d90d8585d9008c62d0b8063aa9a5e5ea5507","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        username, password, tenant_name \u003d cls.credentials()"},{"line_number":39,"context_line":"        cls.manager \u003d clients.ResourceReservationManager("},{"line_number":40,"context_line":"            username, password, tenant_name)"},{"line_number":41,"context_line":"        cls.resource_reservation_client \u003d \\"},{"line_number":42,"context_line":"            cls.manager.resource_reservation_client"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    def get_lease_by_name(self, lease_name):"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAXX%2F%2F5NY%3D","line":41,"in_reply_to":"AAAAXX%2F%2F5W8%3D","updated":"2014-04-25 13:57:56.000000000","message":"Done","commit_id":"cf7430fe22b93c423f2f4485958071923b48d31c"},{"author":{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},"change_message_id":"0ba1008d2d520328038e778f962b40faaf11885e","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        named_lease \u003d []"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"        # and then search by lease_name"},{"line_number":50,"context_line":"        named_lease \u003d \\"},{"line_number":51,"context_line":"            filter(lambda lease: lease[\u0027name\u0027] \u003d\u003d lease_name, lease_list)"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"        if named_lease:"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAXX%2F%2F5Vg%3D","line":50,"updated":"2014-04-25 13:29:26.000000000","message":"ditto","commit_id":"cf7430fe22b93c423f2f4485958071923b48d31c"},{"author":{"_account_id":10200,"name":"Christian Martinez","email":"chmartinez35@gmail.com","username":"cmart"},"change_message_id":"47d6d90d8585d9008c62d0b8063aa9a5e5ea5507","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        named_lease \u003d []"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"        # and then search by lease_name"},{"line_number":50,"context_line":"        named_lease \u003d \\"},{"line_number":51,"context_line":"            filter(lambda lease: lease[\u0027name\u0027] \u003d\u003d lease_name, lease_list)"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"        if named_lease:"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAXX%2F%2F5NU%3D","line":50,"in_reply_to":"AAAAXX%2F%2F5Vg%3D","updated":"2014-04-25 13:57:56.000000000","message":"Done","commit_id":"cf7430fe22b93c423f2f4485958071923b48d31c"}],"contrib/tempest/tempest/scenario/test_resource_reservation.py":[{"author":{"_account_id":3012,"name":"Dina Belova","email":"dbelova@mirantis.com","username":"dbelova"},"change_message_id":"ac6dc2e9ce737242f58e3ac06036339ca70962bb","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"class TestResourceReservationScenario(rrs.ResourceReservationScenarioTest):"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    \"\"\"Tests that checks the resource reservation scenario."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    The following is the scenario outline:"},{"line_number":46,"context_line":"    1) Create an instance with the hint parameters"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAW3%2F%2FRZY%3D","line":43,"updated":"2014-04-15 16:37:31.000000000","message":"Test?","commit_id":"69a85b962625ccf3ff9806f6c45fcc2484fa37f6"},{"author":{"_account_id":10200,"name":"Christian Martinez","email":"chmartinez35@gmail.com","username":"cmart"},"change_message_id":"9ea84edf0f2da232b549b6335dd69e6694bdd594","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"class TestResourceReservationScenario(rrs.ResourceReservationScenarioTest):"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    \"\"\"Tests that checks the resource reservation scenario."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    The following is the scenario outline:"},{"line_number":46,"context_line":"    1) Create an instance with the hint parameters"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAXH%2F%2F7Bo%3D","line":43,"in_reply_to":"AAAAW3%2F%2FRZY%3D","updated":"2014-04-16 15:48:29.000000000","message":"OK","commit_id":"69a85b962625ccf3ff9806f6c45fcc2484fa37f6"},{"author":{"_account_id":9331,"name":"Pablo Andres Fuente","email":"pablo.andres.fuente@gmail.com","username":"pafuent"},"change_message_id":"f55c0c0a8cd623007429f676aec47c548b1126fd","unresolved":false,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    \"\"\""},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    scenario_utils \u003d test_utils.InputScenarioUtils()"},{"line_number":57,"context_line":"    scenario_flavor \u003d scenario_utils.scenario_flavors"},{"line_number":58,"context_line":"    scenario_image \u003d scenario_utils.scenario_images"},{"line_number":59,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAW3%2F%2FaTA%3D","line":56,"updated":"2014-04-14 20:50:42.000000000","message":"I think we don\u0027t need this. The Climate test here and the ones that I can foresee aren\u0027t affected by the flavor or the image used during the test. Of course I can miss some test that really needs this.","commit_id":"69a85b962625ccf3ff9806f6c45fcc2484fa37f6"},{"author":{"_account_id":10200,"name":"Christian Martinez","email":"chmartinez35@gmail.com","username":"cmart"},"change_message_id":"9ea84edf0f2da232b549b6335dd69e6694bdd594","unresolved":false,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    \"\"\""},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    scenario_utils \u003d test_utils.InputScenarioUtils()"},{"line_number":57,"context_line":"    scenario_flavor \u003d scenario_utils.scenario_flavors"},{"line_number":58,"context_line":"    scenario_image \u003d scenario_utils.scenario_images"},{"line_number":59,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAXH%2F%2F6H0%3D","line":56,"in_reply_to":"AAAAW3%2F%2FaTA%3D","updated":"2014-04-16 15:48:29.000000000","message":"Agree. Will remove this","commit_id":"69a85b962625ccf3ff9806f6c45fcc2484fa37f6"},{"author":{"_account_id":9331,"name":"Pablo Andres Fuente","email":"pablo.andres.fuente@gmail.com","username":"pafuent"},"change_message_id":"f55c0c0a8cd623007429f676aec47c548b1126fd","unresolved":false,"context_lines":[{"line_number":77,"context_line":"                )"},{"line_number":78,"context_line":"            )"},{"line_number":79,"context_line":"        self.run_ssh \u003d CONF.compute.run_ssh and\\"},{"line_number":80,"context_line":"            self.image_utils.is_sshable_image(self.image_ref)"},{"line_number":81,"context_line":"        self.ssh_user \u003d self.image_utils.ssh_user(self.image_ref)"},{"line_number":82,"context_line":"        LOG.debug(\u0027Starting test for i:{image}, f:{flavor}. \u0027"},{"line_number":83,"context_line":"                  \u0027Run ssh: {ssh}, user: {ssh_user}\u0027.format("}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAW3%2F%2FZyM%3D","line":80,"updated":"2014-04-14 20:50:42.000000000","message":"We really need to know if an image is sshable? I remember that I read something about that this is the method that tempest uses to know if the VM is up and running, but I\u0027m not sure if we need it.","commit_id":"69a85b962625ccf3ff9806f6c45fcc2484fa37f6"},{"author":{"_account_id":9331,"name":"Pablo Andres Fuente","email":"pablo.andres.fuente@gmail.com","username":"pafuent"},"change_message_id":"f55c0c0a8cd623007429f676aec47c548b1126fd","unresolved":false,"context_lines":[{"line_number":147,"context_line":"            images_list \u003d self.compute_client.images.list()"},{"line_number":148,"context_line":"            self.assertNotEmpty("},{"line_number":149,"context_line":"                filter(lambda image: image.name \u003d\u003d image_name, images_list))"},{"line_number":150,"context_line":"            self.remove_image_snapshot(image_name)"},{"line_number":151,"context_line":"        except Exception as e:"},{"line_number":152,"context_line":"            message \u003d \"Unable to find image with name \u0027%s\u0027. \" \\"},{"line_number":153,"context_line":"                      \"Exception: %s\" % (image_name, e.message)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAW3%2F%2FZvM%3D","line":150,"updated":"2014-04-14 20:50:42.000000000","message":"Please change the name in order to be clear that you are removing the snapshot. In other words, If I use a check method, I expect that nothing has changed.","commit_id":"69a85b962625ccf3ff9806f6c45fcc2484fa37f6"},{"author":{"_account_id":10200,"name":"Christian Martinez","email":"chmartinez35@gmail.com","username":"cmart"},"change_message_id":"9ea84edf0f2da232b549b6335dd69e6694bdd594","unresolved":false,"context_lines":[{"line_number":147,"context_line":"            images_list \u003d self.compute_client.images.list()"},{"line_number":148,"context_line":"            self.assertNotEmpty("},{"line_number":149,"context_line":"                filter(lambda image: image.name \u003d\u003d image_name, images_list))"},{"line_number":150,"context_line":"            self.remove_image_snapshot(image_name)"},{"line_number":151,"context_line":"        except Exception as e:"},{"line_number":152,"context_line":"            message \u003d \"Unable to find image with name \u0027%s\u0027. \" \\"},{"line_number":153,"context_line":"                      \"Exception: %s\" % (image_name, e.message)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAXH%2F%2F6CM%3D","line":150,"in_reply_to":"AAAAW3%2F%2FZvM%3D","updated":"2014-04-16 15:48:29.000000000","message":"Done","commit_id":"69a85b962625ccf3ff9806f6c45fcc2484fa37f6"},{"author":{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},"change_message_id":"0ba1008d2d520328038e778f962b40faaf11885e","unresolved":false,"context_lines":[{"line_number":18,"context_line":"import json"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from novaclient import exceptions as nova_exceptions"},{"line_number":21,"context_line":"from tempest import config"},{"line_number":22,"context_line":"from tempest import exceptions"},{"line_number":23,"context_line":"from tempest import test"},{"line_number":24,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAXX%2F%2F5VM%3D","line":21,"updated":"2014-04-25 13:29:26.000000000","message":"tempest should be put to third section","commit_id":"cf7430fe22b93c423f2f4485958071923b48d31c"},{"author":{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},"change_message_id":"30d83875762be046ffac4b540f4494dd0d04e067","unresolved":false,"context_lines":[{"line_number":22,"context_line":"from tempest import config"},{"line_number":23,"context_line":"from tempest import exceptions"},{"line_number":24,"context_line":"from tempest import test"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"from tempest.common.utils import test_utils"},{"line_number":27,"context_line":"from tempest.openstack.common import log as logging"},{"line_number":28,"context_line":"from tempest.scenario import resource_reservation_scenario as rrs"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAXX%2F%2F4a0%3D","line":25,"updated":"2014-04-25 15:30:00.000000000","message":"This should also be removed ;-)","commit_id":"d322121d25d2b023148a13850f9ba2615b064d58"},{"author":{"_account_id":3012,"name":"Dina Belova","email":"dbelova@mirantis.com","username":"dbelova"},"change_message_id":"e67b212b5731e30913162b3708948cecdcdd29b5","unresolved":false,"context_lines":[{"line_number":22,"context_line":"from tempest import config"},{"line_number":23,"context_line":"from tempest import exceptions"},{"line_number":24,"context_line":"from tempest import test"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"from tempest.common.utils import test_utils"},{"line_number":27,"context_line":"from tempest.openstack.common import log as logging"},{"line_number":28,"context_line":"from tempest.scenario import resource_reservation_scenario as rrs"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAXX%2F%2FvgQ%3D","line":25,"in_reply_to":"AAAAXX%2F%2F0sQ%3D","updated":"2014-04-28 10:19:55.000000000","message":"+1 to Jay Lau - we *should* follow the pep8 importing rules where that\u0027s possible (no import errors will occur) - so I\u0027m really sorry, but please merge these sections in one","commit_id":"d322121d25d2b023148a13850f9ba2615b064d58"},{"author":{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},"change_message_id":"7859b92314b3565cdfe7c96b2f840419a4f2f80e","unresolved":false,"context_lines":[{"line_number":22,"context_line":"from tempest import config"},{"line_number":23,"context_line":"from tempest import exceptions"},{"line_number":24,"context_line":"from tempest import test"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"from tempest.common.utils import test_utils"},{"line_number":27,"context_line":"from tempest.openstack.common import log as logging"},{"line_number":28,"context_line":"from tempest.scenario import resource_reservation_scenario as rrs"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAXX%2F%2F0sQ%3D","line":25,"in_reply_to":"AAAAXX%2F%2F1%2BI%3D","updated":"2014-04-26 02:02:20.000000000","message":"I have no comments if want to leave the space but it certainly violating the coding standard.\n\nI also tried to submit a similar patch in nova but was rejected and I have to update the import section to follow the standards. ;-(","commit_id":"d322121d25d2b023148a13850f9ba2615b064d58"},{"author":{"_account_id":9331,"name":"Pablo Andres Fuente","email":"pablo.andres.fuente@gmail.com","username":"pafuent"},"change_message_id":"7b0885a61a800d2b529c9b30c76785337e4578dc","unresolved":false,"context_lines":[{"line_number":22,"context_line":"from tempest import config"},{"line_number":23,"context_line":"from tempest import exceptions"},{"line_number":24,"context_line":"from tempest import test"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"from tempest.common.utils import test_utils"},{"line_number":27,"context_line":"from tempest.openstack.common import log as logging"},{"line_number":28,"context_line":"from tempest.scenario import resource_reservation_scenario as rrs"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAXX%2F%2F1%2BI%3D","line":25,"in_reply_to":"AAAAXX%2F%2F1%2FM%3D","updated":"2014-04-25 20:30:44.000000000","message":"+1 to leave the space.","commit_id":"d322121d25d2b023148a13850f9ba2615b064d58"},{"author":{"_account_id":10200,"name":"Christian Martinez","email":"chmartinez35@gmail.com","username":"cmart"},"change_message_id":"778f0c56558d4ebaa267f23bc0e7146f38765f8a","unresolved":false,"context_lines":[{"line_number":22,"context_line":"from tempest import config"},{"line_number":23,"context_line":"from tempest import exceptions"},{"line_number":24,"context_line":"from tempest import test"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"from tempest.common.utils import test_utils"},{"line_number":27,"context_line":"from tempest.openstack.common import log as logging"},{"line_number":28,"context_line":"from tempest.scenario import resource_reservation_scenario as rrs"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAXX%2F%2F1%2FM%3D","line":25,"in_reply_to":"AAAAXX%2F%2F4a0%3D","updated":"2014-04-25 20:27:19.000000000","message":"If I remove this line, I\u0027ll need to modify the entire order and it will look like this:\n\n  from tempest.common.utils import test_utils\n  from tempest import config\n  from tempest import exceptions\n  from tempest.openstack.common import log as logging\n  from tempest.scenario import resource_reservation_scenario as rrs\n  from tempest import test\n\nThat\u0027s why I didn\u0027t remove it. It seems cleaner in this way :)","commit_id":"d322121d25d2b023148a13850f9ba2615b064d58"}]}