)]}'
{"id":"openstack%2Fblazar~910376","triplet_id":"openstack%2Fblazar~master~I96cec1e848e6a4d88ad192e2032393f50d331ef7","project":"openstack/blazar","branch":"master","topic":"compute_host_disabled_field","hashtags":[],"change_id":"I96cec1e848e6a4d88ad192e2032393f50d331ef7","subject":"Disabled field in computehost","status":"ABANDONED","created":"2024-02-27 17:46:49.000000000","updated":"2024-02-27 17:53:14.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"0430b06649d81f2be3f6792ac5fa6b7b749d052e","_number":910376,"virtual_id_number":910376,"owner":{"_account_id":36611,"name":"Anish Reddy","display_name":"Anish Ravula","email":"2anishreddy@gmail.com","username":"aravula"},"actions":{},"labels":{"Verified":{"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{},"pending_reviewers":{},"reviewer_updates":[],"messages":[{"id":"7e4853f51d9d7296bc345487a772f6b2bd92772f","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":36611,"name":"Anish Reddy","display_name":"Anish Ravula","email":"2anishreddy@gmail.com","username":"aravula"},"date":"2024-02-27 17:46:49.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"5f21d9ce331196ae342f031708b7726ab5feaffe","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":36611,"name":"Anish Reddy","display_name":"Anish Ravula","email":"2anishreddy@gmail.com","username":"aravula"},"date":"2024-02-27 17:52:43.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"0430b06649d81f2be3f6792ac5fa6b7b749d052e","tag":"autogenerated:gerrit:abandon","author":{"_account_id":36611,"name":"Anish Reddy","display_name":"Anish Ravula","email":"2anishreddy@gmail.com","username":"aravula"},"date":"2024-02-27 17:53:14.000000000","message":"Abandoned\n\ncreated incorrectly","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"bc3745db3a82b372e2854a2ef2304bbca4ed9c58","revisions":{"7c5d95f6f310576f0954da3b8831f815a9908086":{"kind":"REWORK","_number":1,"created":"2024-02-27 17:46:49.000000000","uploader":{"_account_id":36611,"name":"Anish Reddy","display_name":"Anish Ravula","email":"2anishreddy@gmail.com","username":"aravula"},"ref":"refs/changes/76/910376/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/blazar","ref":"refs/changes/76/910376/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/blazar refs/changes/76/910376/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/blazar refs/changes/76/910376/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/blazar refs/changes/76/910376/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/blazar refs/changes/76/910376/1"}}},"commit":{"parents":[{"commit":"7240764cb3748a34667d377b80cd7774149524f0","subject":"Use bool_from_string to correctly parse disabled attribute","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/blazar/commit/7240764cb3748a34667d377b80cd7774149524f0"}]}],"author":{"name":"Anish Reddy Ravula","email":"2anishreddy@gmail.com","date":"2024-02-27 17:46:18.000000000","tz":-360},"committer":{"name":"Anish Reddy Ravula","email":"2anishreddy@gmail.com","date":"2024-02-27 17:46:18.000000000","tz":-360},"subject":"Update API docs/ref for host disabled change","message":"Update API docs/ref for host disabled change\n\nChange-Id: I96cec1e848e6a4d88ad192e2032393f50d331ef7\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/blazar/commit/7c5d95f6f310576f0954da3b8831f815a9908086"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/blazar/commit/7c5d95f6f310576f0954da3b8831f815a9908086"}]},"branch":"refs/heads/master"},"bc3745db3a82b372e2854a2ef2304bbca4ed9c58":{"kind":"REWORK","_number":2,"created":"2024-02-27 17:52:43.000000000","uploader":{"_account_id":36611,"name":"Anish Reddy","display_name":"Anish Ravula","email":"2anishreddy@gmail.com","username":"aravula"},"ref":"refs/changes/76/910376/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/blazar","ref":"refs/changes/76/910376/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/blazar refs/changes/76/910376/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/blazar refs/changes/76/910376/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/blazar refs/changes/76/910376/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/blazar refs/changes/76/910376/2"}}},"commit":{"parents":[{"commit":"667a8bd782579a81fab0a5048a6d44fc2bfc7059","subject":"Update bindep package list for Debian Bookworm","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/blazar/commit/667a8bd782579a81fab0a5048a6d44fc2bfc7059"}]}],"author":{"name":"Anish Reddy Ravula","email":"2anishreddy@gmail.com","date":"2024-02-27 17:50:36.000000000","tz":-360},"committer":{"name":"Anish Reddy Ravula","email":"2anishreddy@gmail.com","date":"2024-02-27 17:52:11.000000000","tz":-360},"subject":"Disabled field in computehost","message":"Disabled field in computehost\n\n- The idea is to enable operator to reserve a non reservable node and\n  perform tests\n- Only operator/admin should be able to reserve such nodes\n- Polling monitor should not automatically make the node reservable\n  if the \u0027disabled\u0027 flag is True\n\nSet disabled field True for a host\n`openstack reservation host set \u003chost_id/name\u003e --extra disabled\u003dTrue`\n\nSet disabled field False for a host\n`openstack reservation host set \u003chost_id/name\u003e --extra disabled`\n\nWIP: Setting disabled field works as desired (only admin can set/unset)\nCreating lease on a disabled\u003dTrue node doesn\u0027t work as desired\n  (any project and user can reserve such node)\nExpected behaviour: Only admins/admin project should be able\n  to create lease on such nodes\n\nLooks like using context policy.enforce does not work if an explicit\n  policy is not defined.\nDo we need to have an endpoint to define a policy? Not sure if we can\n  check in `_matching_hosts` is a user is admin or from admi$\n\nChange-Id: I1496b68436bb434ac2c34343564ce8e149ccf284\n\nUse bool_from_string to correctly parse disabled attribute\n\nChange-Id: I7eadbcebbbf5a5dc2cbe20882c07b78c1f7589dc\n\nUpdate API docs/ref for host disabled change\n\nChange-Id: I96cec1e848e6a4d88ad192e2032393f50d331ef7\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/blazar/commit/bc3745db3a82b372e2854a2ef2304bbca4ed9c58"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/blazar/commit/bc3745db3a82b372e2854a2ef2304bbca4ed9c58"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Review-Priority","description":"Review priority","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"-label:Review-Priority\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":[],"failing_atoms":["label:Review-Priority\u003dMIN"],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Workflow\u003dMAX","label:Workflow\u003dMIN"],"atom_explanations":{}}}]}