)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"1edefaaa49c2cf767ff5d2245a158ad331009879","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"64a7747d_c6b44d61","updated":"2024-05-27 15:16:21.000000000","message":"Approving to fix CI","commit_id":"8f9dbeaf80cf8437094f94b1d0bdfaf58479a8b3"}],"blazar/plugins/oshosts/host_plugin.py":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"82ea7669b139d65f3c47c661619728fb94718051","unresolved":true,"context_lines":[{"line_number":237,"context_line":"    def _check_server_deletion(self, pool, host_reservation):"},{"line_number":238,"context_line":"        servers \u003d []"},{"line_number":239,"context_line":"        for host in pool.get_computehosts(host_reservation[\u0027aggregate_id\u0027]):"},{"line_number":240,"context_line":"            servers.append("},{"line_number":241,"context_line":"                self.nova.servers.list(search_opts\u003d{\"host\": host,"},{"line_number":242,"context_line":"                                                    \"all_tenants\": 1},"},{"line_number":243,"context_line":"                                       detailed\u003dFalse))"},{"line_number":244,"context_line":"        if servers:"},{"line_number":245,"context_line":"            LOG.info(\u0027Waiting to delete servers: %s \u0027, servers)"},{"line_number":246,"context_line":"            return False"}],"source_content_type":"text/x-python","patch_set":3,"id":"222ac581_2f10ae2c","line":243,"range":{"start_line":240,"start_character":0,"end_line":243,"end_character":55},"updated":"2024-05-22 13:11:12.000000000","message":"I think I used the wrong function, it should have been extend instead of append?","commit_id":"a57aa99781c51324b4361bd53886605f13b68a8d"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"eb31ab054195bf99d99f8714268a9716bec35598","unresolved":false,"context_lines":[{"line_number":237,"context_line":"    def _check_server_deletion(self, pool, host_reservation):"},{"line_number":238,"context_line":"        servers \u003d []"},{"line_number":239,"context_line":"        for host in pool.get_computehosts(host_reservation[\u0027aggregate_id\u0027]):"},{"line_number":240,"context_line":"            servers.append("},{"line_number":241,"context_line":"                self.nova.servers.list(search_opts\u003d{\"host\": host,"},{"line_number":242,"context_line":"                                                    \"all_tenants\": 1},"},{"line_number":243,"context_line":"                                       detailed\u003dFalse))"},{"line_number":244,"context_line":"        if servers:"},{"line_number":245,"context_line":"            LOG.info(\u0027Waiting to delete servers: %s \u0027, servers)"},{"line_number":246,"context_line":"            return False"}],"source_content_type":"text/x-python","patch_set":3,"id":"282a69f6_ca77b4e8","line":243,"range":{"start_line":240,"start_character":0,"end_line":243,"end_character":55},"in_reply_to":"222ac581_2f10ae2c","updated":"2024-05-22 13:32:12.000000000","message":"Yes, extend does the job nicer than my change. Have updated.","commit_id":"a57aa99781c51324b4361bd53886605f13b68a8d"}]}
