)]}'
{"climate/manager/service.py":[{"author":{"_account_id":7535,"name":"Nikolay Starodubtsev","email":"starodubcevna@gmail.com","username":"Kezar"},"change_message_id":"43d2a5c54f73e01c1e1d6f22eeba9813395a07f7","unresolved":false,"context_lines":[{"line_number":449,"context_line":"        if event[\u0027time\u0027] \u003c lease[\u0027start_date\u0027]:"},{"line_number":450,"context_line":"            LOG.warning(\"New start_date greater than before_end_date. \""},{"line_number":451,"context_line":"                        \"Setting before_end_date to %s for lease %s\""},{"line_number":452,"context_line":"                        % (lease[\u0027start_date\u0027], lease.get(\u0027id\u0027, None)))"},{"line_number":453,"context_line":"            event[\u0027time\u0027] \u003d lease[\u0027start_date\u0027]"},{"line_number":454,"context_line":""},{"line_number":455,"context_line":"    def _update_before_end_event(self, old_lease, new_lease,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_e3d24133","line":452,"updated":"2014-06-17 22:24:39.000000000","message":"Looks good. But I\u0027m a little bit out of track. Is this logically correct? If yes I\u0027ll put +2","commit_id":"f56efac8f8d5e61db2805c4fd8c253de72c18b4a"},{"author":{"_account_id":9331,"name":"Pablo Andres Fuente","email":"pablo.andres.fuente@gmail.com","username":"pafuent"},"change_message_id":"ac8b5c8e133dd5f3b1d84007285f57bc37214bb2","unresolved":false,"context_lines":[{"line_number":449,"context_line":"        if event[\u0027time\u0027] \u003c lease[\u0027start_date\u0027]:"},{"line_number":450,"context_line":"            LOG.warning(\"New start_date greater than before_end_date. \""},{"line_number":451,"context_line":"                        \"Setting before_end_date to %s for lease %s\""},{"line_number":452,"context_line":"                        % (lease[\u0027start_date\u0027], lease.get(\u0027id\u0027, None)))"},{"line_number":453,"context_line":"            event[\u0027time\u0027] \u003d lease[\u0027start_date\u0027]"},{"line_number":454,"context_line":""},{"line_number":455,"context_line":"    def _update_before_end_event(self, old_lease, new_lease,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_807a34b8","line":452,"in_reply_to":"1ae5cdf2_e3d24133","updated":"2014-06-18 14:26:24.000000000","message":"What do you mean with \"logically correct\"?","commit_id":"f56efac8f8d5e61db2805c4fd8c253de72c18b4a"},{"author":{"_account_id":7535,"name":"Nikolay Starodubtsev","email":"starodubcevna@gmail.com","username":"Kezar"},"change_message_id":"0fad3a8a189d522f1ac2f1e22dee1da020775104","unresolved":false,"context_lines":[{"line_number":460,"context_line":"        if event[\u0027time\u0027] \u003c lease[\u0027start_date\u0027]:"},{"line_number":461,"context_line":"            LOG.warning(\"New start_date greater than before_end_date. \""},{"line_number":462,"context_line":"                        \"Setting before_end_date to %s for lease %s\""},{"line_number":463,"context_line":"                        % (lease[\u0027start_date\u0027], lease.get(\u0027id\u0027, None)))"},{"line_number":464,"context_line":"            event[\u0027time\u0027] \u003d lease[\u0027start_date\u0027]"},{"line_number":465,"context_line":""},{"line_number":466,"context_line":"    def _update_before_end_event(self, old_lease, new_lease,"}],"source_content_type":"text/x-python","patch_set":5,"id":"1ae5cdf2_0c6e3a64","line":463,"updated":"2014-06-26 21:50:18.000000000","message":"may be we should use lease.get(\u0027id\u0027, \u0027name\u0027) or just name. As far as I know lease names can\u0027t be duplicated","commit_id":"afb429c81427472e5f5c9acee9f1356c01a6fd81"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"42b4a92aae2b28877d13de1f16ab3edd7aefba6b","unresolved":false,"context_lines":[{"line_number":460,"context_line":"        if event[\u0027time\u0027] \u003c lease[\u0027start_date\u0027]:"},{"line_number":461,"context_line":"            LOG.warning(\"New start_date greater than before_end_date. \""},{"line_number":462,"context_line":"                        \"Setting before_end_date to %s for lease %s\""},{"line_number":463,"context_line":"                        % (lease[\u0027start_date\u0027], lease.get(\u0027id\u0027, None)))"},{"line_number":464,"context_line":"            event[\u0027time\u0027] \u003d lease[\u0027start_date\u0027]"},{"line_number":465,"context_line":""},{"line_number":466,"context_line":"    def _update_before_end_event(self, old_lease, new_lease,"}],"source_content_type":"text/x-python","patch_set":5,"id":"1ae5cdf2_2da84677","line":463,"in_reply_to":"1ae5cdf2_0c6e3a64","updated":"2014-06-27 07:50:06.000000000","message":"no need to specify .get(\u0027whatever\u0027, None), the default value of get is None\n\nNikolay, you\u0027re right, there is a constraint on names in SQLA so +1 with having the failback value to name (as it\u0027s mandatory to define a name even if you don\u0027t yet have an id)","commit_id":"afb429c81427472e5f5c9acee9f1356c01a6fd81"}]}