)]}'
{"castellan/key_manager/migration.py":[{"author":{"_account_id":21797,"name":"Jeremy Liu","display_name":"Jeremy Liu","email":"liujiong.cc@gmail.com","username":"liujiong"},"change_message_id":"0ec1452049e6051291be140a71794f6eef176965","unresolved":false,"context_lines":[{"line_number":58,"context_line":""},{"line_number":59,"context_line":"            def delete(self, context, managed_object_id):"},{"line_number":60,"context_line":"                if managed_object_id \u003d\u003d self.fixed_key_id:"},{"line_number":61,"context_line":"                    LOG.debug(\"Not deleting key associated with with\""},{"line_number":62,"context_line":"                              \" fixed_key key ID\")"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"                    if context is None:"}],"source_content_type":"text/x-python","patch_set":7,"id":"ff82abbf_1e04e914","line":61,"range":{"start_line":61,"start_character":59,"end_line":61,"end_character":68},"updated":"2017-11-21 04:29:51.000000000","message":"duplicate","commit_id":"b37c5ad35ee09f79fbb8f4ba180ed9aebc031107"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"45b769e1f7a3306ff6dbdfbb928fb52656a46a5a","unresolved":false,"context_lines":[{"line_number":58,"context_line":""},{"line_number":59,"context_line":"            def delete(self, context, managed_object_id):"},{"line_number":60,"context_line":"                if managed_object_id \u003d\u003d self.fixed_key_id:"},{"line_number":61,"context_line":"                    LOG.debug(\"Not deleting key associated with with\""},{"line_number":62,"context_line":"                              \" fixed_key key ID\")"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"                    if context is None:"}],"source_content_type":"text/x-python","patch_set":7,"id":"ff82abbf_6fa2129d","line":61,"range":{"start_line":61,"start_character":59,"end_line":61,"end_character":68},"in_reply_to":"ff82abbf_1e04e914","updated":"2017-11-21 14:24:46.000000000","message":"Done","commit_id":"b37c5ad35ee09f79fbb8f4ba180ed9aebc031107"}],"castellan/tests/unit/key_manager/test_migration_key_manager.py":[{"author":{"_account_id":21797,"name":"Jeremy Liu","display_name":"Jeremy Liu","email":"liujiong.cc@gmail.com","username":"liujiong"},"change_message_id":"0ec1452049e6051291be140a71794f6eef176965","unresolved":false,"context_lines":[{"line_number":66,"context_line":"    def test_get_fixed_key(self):"},{"line_number":67,"context_line":"        self.assertEqual(type(self.key_mgr).__name__, \u0027MigrationKeyManager\u0027)"},{"line_number":68,"context_line":"        secret \u003d self.key_mgr.get(self.ctxt, self.fixed_key_id)"},{"line_number":69,"context_line":"        self.assertEqual(secret, self.fixed_key_secret)"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    def test_get_fixed_key_fail_bad_context(self):"},{"line_number":72,"context_line":"        self.assertRaises(exception.Forbidden,"}],"source_content_type":"text/x-python","patch_set":7,"id":"ff82abbf_3e544dca","line":69,"range":{"start_line":69,"start_character":25,"end_line":69,"end_character":54},"updated":"2017-11-21 04:29:51.000000000","message":"exchange parameters order to match assertEqual(expected, observed). change all the usages below.","commit_id":"b37c5ad35ee09f79fbb8f4ba180ed9aebc031107"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"45b769e1f7a3306ff6dbdfbb928fb52656a46a5a","unresolved":false,"context_lines":[{"line_number":66,"context_line":"    def test_get_fixed_key(self):"},{"line_number":67,"context_line":"        self.assertEqual(type(self.key_mgr).__name__, \u0027MigrationKeyManager\u0027)"},{"line_number":68,"context_line":"        secret \u003d self.key_mgr.get(self.ctxt, self.fixed_key_id)"},{"line_number":69,"context_line":"        self.assertEqual(secret, self.fixed_key_secret)"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    def test_get_fixed_key_fail_bad_context(self):"},{"line_number":72,"context_line":"        self.assertRaises(exception.Forbidden,"}],"source_content_type":"text/x-python","patch_set":7,"id":"ff82abbf_8f9f564f","line":69,"range":{"start_line":69,"start_character":25,"end_line":69,"end_character":54},"in_reply_to":"ff82abbf_3e544dca","updated":"2017-11-21 14:24:46.000000000","message":"Done","commit_id":"b37c5ad35ee09f79fbb8f4ba180ed9aebc031107"},{"author":{"_account_id":21797,"name":"Jeremy Liu","display_name":"Jeremy Liu","email":"liujiong.cc@gmail.com","username":"liujiong"},"change_message_id":"0ec1452049e6051291be140a71794f6eef176965","unresolved":false,"context_lines":[{"line_number":87,"context_line":"                          managed_object_id\u003dself.fixed_key_id)"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    def test_get_other_key(self):"},{"line_number":90,"context_line":"        # Request to get other_key_id should be passed on to Barbican,"},{"line_number":91,"context_line":"        # who will throw an error because we don\u0027t have a valid context."},{"line_number":92,"context_line":"        self.assertRaises(exception.KeyManagerError,"},{"line_number":93,"context_line":"                          self.key_mgr.get,"}],"source_content_type":"text/x-python","patch_set":7,"id":"ff82abbf_1e0aa9d1","line":90,"range":{"start_line":90,"start_character":61,"end_line":90,"end_character":69},"updated":"2017-11-21 04:29:51.000000000","message":"Perhaps not Barbican(we support barbican/vault now), change all the description below.","commit_id":"b37c5ad35ee09f79fbb8f4ba180ed9aebc031107"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"45b769e1f7a3306ff6dbdfbb928fb52656a46a5a","unresolved":false,"context_lines":[{"line_number":87,"context_line":"                          managed_object_id\u003dself.fixed_key_id)"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    def test_get_other_key(self):"},{"line_number":90,"context_line":"        # Request to get other_key_id should be passed on to Barbican,"},{"line_number":91,"context_line":"        # who will throw an error because we don\u0027t have a valid context."},{"line_number":92,"context_line":"        self.assertRaises(exception.KeyManagerError,"},{"line_number":93,"context_line":"                          self.key_mgr.get,"}],"source_content_type":"text/x-python","patch_set":7,"id":"ff82abbf_4fa94e79","line":90,"range":{"start_line":90,"start_character":61,"end_line":90,"end_character":69},"in_reply_to":"ff82abbf_1e0aa9d1","updated":"2017-11-21 14:24:46.000000000","message":"Done","commit_id":"b37c5ad35ee09f79fbb8f4ba180ed9aebc031107"}],"releasenotes/notes/support-legacy-fixed-key-id-9fa897b547111610.yaml":[{"author":{"_account_id":21797,"name":"Jeremy Liu","display_name":"Jeremy Liu","email":"liujiong.cc@gmail.com","username":"liujiong"},"change_message_id":"0ec1452049e6051291be140a71794f6eef176965","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    ConfKeyManager. The purpose of this feature is to help users migrate from"},{"line_number":7,"context_line":"    the ConfKeyManager to a modern key manager such as Barbican. The feature"},{"line_number":8,"context_line":"    works by ensuring the ConfKeyManager\u0027s all-zeros key ID continues to"},{"line_number":9,"context_line":"    function when Barbican is the key manager."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"ff82abbf_fe61053b","line":9,"range":{"start_line":9,"start_character":18,"end_line":9,"end_character":26},"updated":"2017-11-21 04:29:51.000000000","message":"Barbican or Vault","commit_id":"b37c5ad35ee09f79fbb8f4ba180ed9aebc031107"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"45b769e1f7a3306ff6dbdfbb928fb52656a46a5a","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    ConfKeyManager. The purpose of this feature is to help users migrate from"},{"line_number":7,"context_line":"    the ConfKeyManager to a modern key manager such as Barbican. The feature"},{"line_number":8,"context_line":"    works by ensuring the ConfKeyManager\u0027s all-zeros key ID continues to"},{"line_number":9,"context_line":"    function when Barbican is the key manager."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"ff82abbf_efb702d8","line":9,"range":{"start_line":9,"start_character":18,"end_line":9,"end_character":26},"in_reply_to":"ff82abbf_fe61053b","updated":"2017-11-21 14:24:46.000000000","message":"Done","commit_id":"b37c5ad35ee09f79fbb8f4ba180ed9aebc031107"}]}