)]}'
{"castellan/key_manager/barbican_key_manager.py":[{"author":{"_account_id":8866,"name":"Raildo Mascena de Sousa Filho","email":"rmascena@redhat.com","username":"raildo"},"change_message_id":"50f8535d144eb3ffae1d04c0aca7e5c974bb9992","unresolved":false,"context_lines":[{"line_number":80,"context_line":""},{"line_number":81,"context_line":"_BARBICAN_OPT_GROUP \u003d \u0027barbican\u0027"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"_LOG \u003d logging.getLogger(__name__)"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"class BarbicanKeyManager(key_manager.KeyManager):"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_73f8714a","line":83,"updated":"2020-02-07 12:18:03.000000000","message":"That\u0027s not a common behavior, why do we need to change it?","commit_id":"150c70672e1617f32c0a4d9f3f80af7d65ef441a"}],"castellan/key_manager/vault_key_manager.py":[{"author":{"_account_id":8866,"name":"Raildo Mascena de Sousa Filho","email":"rmascena@redhat.com","username":"raildo"},"change_message_id":"50f8535d144eb3ffae1d04c0aca7e5c974bb9992","unresolved":false,"context_lines":[{"line_number":43,"context_line":"from castellan.i18n import _"},{"line_number":44,"context_line":"from castellan.key_manager import key_manager"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"_DEFAULT_VAULT_URL \u003d \"http://127.0.0.1:8200\""},{"line_number":47,"context_line":"_DEFAULT_MOUNTPOINT \u003d \"secret\""},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"_vault_opts \u003d ["}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_93988d1a","line":46,"updated":"2020-02-07 12:18:03.000000000","message":"same here, I don\u0027t think that we need to be changing all of these constants\u0027 visibility.","commit_id":"150c70672e1617f32c0a4d9f3f80af7d65ef441a"}],"releasenotes/notes/implements-keymanager-option-discovery-13a46c1dfc036a3f.yaml":[{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"49c79b35fcfdf7db40fd381f46fe9e3fefb6c507","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    their options. The purpose of this feature is to have a correct listing of"},{"line_number":6,"context_line":"    the supported key managers, now each key manager is responsible for"},{"line_number":7,"context_line":"    advertising the oslo.config groups/options they consume."},{"line_number":8,"context_line":"other:"},{"line_number":9,"context_line":"  - |"},{"line_number":10,"context_line":"    The visibility of module variables and constants related to oslo.config"},{"line_number":11,"context_line":"    options changed to private in both barbican and vault key managers. The"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3fa7e38b_5b57b25a","line":8,"updated":"2020-02-21 16:25:26.000000000","message":"I would generally put something like this in upgrade since it has an upgrade impact, but as long as it\u0027s there somewhere it should be fine.","commit_id":"943150ee512e8882408bd37c6a6cc3e235368d1c"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"8a8e9fef708707debe230d253afcc53303abd7c4","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    their options. The purpose of this feature is to have a correct listing of"},{"line_number":6,"context_line":"    the supported key managers, now each key manager is responsible for"},{"line_number":7,"context_line":"    advertising the oslo.config groups/options they consume."},{"line_number":8,"context_line":"other:"},{"line_number":9,"context_line":"  - |"},{"line_number":10,"context_line":"    The visibility of module variables and constants related to oslo.config"},{"line_number":11,"context_line":"    options changed to private in both barbican and vault key managers. The"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3fa7e38b_fe576c27","line":8,"in_reply_to":"3fa7e38b_5b57b25a","updated":"2020-02-21 17:15:17.000000000","message":"Yep good point Moisés and I discussed on IRC about this point and which section to chose for this topic, I was not sure what chose between \"other\" and \"upgrade\".\n\nGood to know.","commit_id":"943150ee512e8882408bd37c6a6cc3e235368d1c"}]}