)]}'
{"castellan/common/objects/certificate.py":[{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"cad950545fd2e89c29d8eb9023596b1f5257c81e","unresolved":false,"context_lines":[{"line_number":26,"context_line":"from castellan.common.objects import managed_object"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"@six.add_metaclass(abc.ABCMeta)"},{"line_number":30,"context_line":"class Certificate(managed_object.ManagedObject):"},{"line_number":31,"context_line":"    \"\"\"Base class to represent all certificates.\"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"1fa4df85_0502b70a","side":"PARENT","line":29,"range":{"start_line":29,"start_character":19,"end_line":29,"end_character":30},"updated":"2020-03-09 11:04:20.000000000","message":"If I\u0027m right this should be moved to class\u0027s signature:\n\n```\nclass Certficate(managed_object.ManagedObject, metaclass\u003dabc.ABCMeta)\n```","commit_id":"ec760471f835ee2ca2a759091e9c35b819854665"},{"author":{"_account_id":27954,"name":"Moisés Guimarães de Medeiros","email":"guimaraes@pm.me","username":"moguimar"},"change_message_id":"a666072bf8713165431f0c1d06c42d63f5fccf86","unresolved":false,"context_lines":[{"line_number":26,"context_line":"from castellan.common.objects import managed_object"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"@six.add_metaclass(abc.ABCMeta)"},{"line_number":30,"context_line":"class Certificate(managed_object.ManagedObject):"},{"line_number":31,"context_line":"    \"\"\"Base class to represent all certificates.\"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"1fa4df85_c5557ffb","side":"PARENT","line":29,"range":{"start_line":29,"start_character":19,"end_line":29,"end_character":30},"in_reply_to":"1fa4df85_0502b70a","updated":"2020-03-09 11:13:37.000000000","message":"Hervé, ManagedObject already has ABCMeta as metaclass, I stated that in the commit message.","commit_id":"ec760471f835ee2ca2a759091e9c35b819854665"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"5d8c91b7cad1addd894fbf0d534b46b5fce2f3b8","unresolved":false,"context_lines":[{"line_number":26,"context_line":"from castellan.common.objects import managed_object"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"@six.add_metaclass(abc.ABCMeta)"},{"line_number":30,"context_line":"class Certificate(managed_object.ManagedObject):"},{"line_number":31,"context_line":"    \"\"\"Base class to represent all certificates.\"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"1fa4df85_a5dac374","side":"PARENT","line":29,"range":{"start_line":29,"start_character":19,"end_line":29,"end_character":30},"in_reply_to":"1fa4df85_c5557ffb","updated":"2020-03-09 11:19:52.000000000","message":"Oh sorry, I missed that point. Then LGTM","commit_id":"ec760471f835ee2ca2a759091e9c35b819854665"}],"castellan/common/objects/key.py":[{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"cad950545fd2e89c29d8eb9023596b1f5257c81e","unresolved":false,"context_lines":[{"line_number":28,"context_line":"import six"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"@six.add_metaclass(abc.ABCMeta)"},{"line_number":32,"context_line":"class Key(managed_object.ManagedObject):"},{"line_number":33,"context_line":"    \"\"\"Base class to represent all keys.\"\"\""},{"line_number":34,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1fa4df85_e50afb1d","side":"PARENT","line":31,"range":{"start_line":31,"start_character":19,"end_line":31,"end_character":30},"updated":"2020-03-09 11:04:20.000000000","message":"This should be moved to metaclass\u003dabc.ABCMeta in the class below.","commit_id":"ec760471f835ee2ca2a759091e9c35b819854665"},{"author":{"_account_id":27954,"name":"Moisés Guimarães de Medeiros","email":"guimaraes@pm.me","username":"moguimar"},"change_message_id":"a666072bf8713165431f0c1d06c42d63f5fccf86","unresolved":false,"context_lines":[{"line_number":28,"context_line":"import six"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"@six.add_metaclass(abc.ABCMeta)"},{"line_number":32,"context_line":"class Key(managed_object.ManagedObject):"},{"line_number":33,"context_line":"    \"\"\"Base class to represent all keys.\"\"\""},{"line_number":34,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1fa4df85_05795792","side":"PARENT","line":31,"range":{"start_line":31,"start_character":19,"end_line":31,"end_character":30},"in_reply_to":"1fa4df85_e50afb1d","updated":"2020-03-09 11:13:37.000000000","message":"Same case as Certificate, ManagedObject already covers that.","commit_id":"ec760471f835ee2ca2a759091e9c35b819854665"}]}