)]}'
{"castellan/key_manager/hvac_key_manager.py":[{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"003f83b3907377215201acb8683a30b3bad42435","unresolved":false,"context_lines":[{"line_number":78,"context_line":"        self._client.secrets.kv.default_kv_version \u003d conf.hvac.kv_version"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    def _store_key_value(self, secret_id, secret):"},{"line_number":81,"context_line":"        if not secret_id:"},{"line_number":82,"context_line":"            raise exception.KeyManagerError(\"secret identifier not provided\")"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"        if secret.managed_type() not in objects.KNOWN_MANAGED_OBJECTS_BY_TYPE:"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf51134e_0af304a1","line":81,"range":{"start_line":81,"start_character":8,"end_line":81,"end_character":25},"updated":"2020-07-22 11:37:57.000000000","message":"This is a positional parameter so I wondering if we will fall in this scenario apart if we pass (None|0|\"\"). In this case we will never raise the following exception. Maybe you used this condition to avoid previous values, I\u0027m right?\n\nMaybe I missed a point in this case ignore my comment.","commit_id":"244f12b6011a8170ad80f2bda5bb482016589ca7"},{"author":{"_account_id":27954,"name":"Moisés Guimarães de Medeiros","email":"guimaraes@pm.me","username":"moguimar"},"change_message_id":"632840fe18c85357c851ac3e99c8da28d3b6c1c2","unresolved":false,"context_lines":[{"line_number":78,"context_line":"        self._client.secrets.kv.default_kv_version \u003d conf.hvac.kv_version"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    def _store_key_value(self, secret_id, secret):"},{"line_number":81,"context_line":"        if not secret_id:"},{"line_number":82,"context_line":"            raise exception.KeyManagerError(\"secret identifier not provided\")"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"        if secret.managed_type() not in objects.KNOWN_MANAGED_OBJECTS_BY_TYPE:"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf51134e_118cba33","line":81,"range":{"start_line":81,"start_character":8,"end_line":81,"end_character":25},"in_reply_to":"bf51134e_0af304a1","updated":"2020-07-23 09:57:27.000000000","message":"Fixed to \"is None\"","commit_id":"244f12b6011a8170ad80f2bda5bb482016589ca7"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"003f83b3907377215201acb8683a30b3bad42435","unresolved":false,"context_lines":[{"line_number":100,"context_line":"        return secret_id"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"    def get(self, context, secret_id, metadata_only\u003dFalse):"},{"line_number":103,"context_line":"        if not secret_id:"},{"line_number":104,"context_line":"            raise exception.KeyManagerError(\"secret identifier not provided\")"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf51134e_8a071482","line":103,"range":{"start_line":103,"start_character":15,"end_line":103,"end_character":24},"updated":"2020-07-22 11:37:57.000000000","message":"same thing","commit_id":"244f12b6011a8170ad80f2bda5bb482016589ca7"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"003f83b3907377215201acb8683a30b3bad42435","unresolved":false,"context_lines":[{"line_number":113,"context_line":"        )"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"    def delete(self, context, secret_id):"},{"line_number":116,"context_line":"        if not secret_id:"},{"line_number":117,"context_line":"            raise exception.KeyManagerError(\"secret identifier not provided\")"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"        # NOTE(moguimar): delete_metadata_and_all_versions() will return"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf51134e_eafe9069","line":116,"range":{"start_line":116,"start_character":8,"end_line":116,"end_character":25},"updated":"2020-07-22 11:37:57.000000000","message":"Same things.","commit_id":"244f12b6011a8170ad80f2bda5bb482016589ca7"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"a79b8db33d32a21de1a30aea891b58ab4bf50da5","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"_hvac_opts \u003d ["},{"line_number":30,"context_line":"    cfg.StrOpt("},{"line_number":31,"context_line":"        \"url\","},{"line_number":32,"context_line":"        default\u003d\"https://localhost:8200\","},{"line_number":33,"context_line":"        help\u003d\"Use this endpoint to connect to Vault.\","},{"line_number":34,"context_line":"    ),"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_1cbd5eb6","line":31,"range":{"start_line":31,"start_character":8,"end_line":31,"end_character":13},"updated":"2020-08-10 19:53:05.000000000","message":"To be consistent with other options, should be \"endpoint\", and to be clear between existing options, should really be \"vault_endpoint\" or \"hvac_endpoint\", something along those lines at least.","commit_id":"d972149f0b840d5334a6790c8f4c9c18a5555452"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"a79b8db33d32a21de1a30aea891b58ab4bf50da5","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        help\u003d\"Use this endpoint to connect to Vault.\","},{"line_number":34,"context_line":"    ),"},{"line_number":35,"context_line":"    cfg.StrOpt(\"token\", help\u003d\"Token for vault\"),"},{"line_number":36,"context_line":"    # TLS config"},{"line_number":37,"context_line":"    cfg.StrOpt(\"ca_path\", help\u003d\"Absolute path to ca cert file\"),"},{"line_number":38,"context_line":"    cfg.StrOpt(\"client_cert_path\", help\u003d\"Absolute path to ca cert file\"),"},{"line_number":39,"context_line":"    cfg.StrOpt(\"client_key_path\", help\u003d\"Absolute path to ca cert file\"),"},{"line_number":40,"context_line":"    # KV Secrets Engine config"},{"line_number":41,"context_line":"    cfg.StrOpt("}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_bccd5267","line":38,"range":{"start_line":36,"start_character":0,"end_line":38,"end_character":73},"updated":"2020-08-10 19:53:05.000000000","message":"We have the options \"verify_ssl\" and \"verify_ssl_path\" already defined in the barbican key manager. I think it would be better to reuse those, if possible. Might be worth moving the option definitions to the base KeyManager so it\u0027s more obviously a set of common config options.","commit_id":"d972149f0b840d5334a6790c8f4c9c18a5555452"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"a79b8db33d32a21de1a30aea891b58ab4bf50da5","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    # TLS config"},{"line_number":37,"context_line":"    cfg.StrOpt(\"ca_path\", help\u003d\"Absolute path to ca cert file\"),"},{"line_number":38,"context_line":"    cfg.StrOpt(\"client_cert_path\", help\u003d\"Absolute path to ca cert file\"),"},{"line_number":39,"context_line":"    cfg.StrOpt(\"client_key_path\", help\u003d\"Absolute path to ca cert file\"),"},{"line_number":40,"context_line":"    # KV Secrets Engine config"},{"line_number":41,"context_line":"    cfg.StrOpt("},{"line_number":42,"context_line":"        \"kv_version\","}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_9c916e55","line":39,"range":{"start_line":39,"start_character":60,"end_line":39,"end_character":64},"updated":"2020-08-10 19:53:05.000000000","message":"key?","commit_id":"d972149f0b840d5334a6790c8f4c9c18a5555452"}],"castellan/key_manager/key_manager.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"a79b8db33d32a21de1a30aea891b58ab4bf50da5","unresolved":false,"context_lines":[{"line_number":16,"context_line":"\"\"\""},{"line_number":17,"context_line":"Key manager API"},{"line_number":18,"context_line":"\"\"\""},{"line_number":19,"context_line":"from cryptography.hazmat.backends import default_backend"},{"line_number":20,"context_line":"from cryptography.hazmat.primitives.asymmetric import rsa"},{"line_number":21,"context_line":"from cryptography.hazmat.primitives.serialization import Encoding"},{"line_number":22,"context_line":"from cryptography.hazmat.primitives.serialization import NoEncryption"},{"line_number":23,"context_line":"from cryptography.hazmat.primitives.serialization import PrivateFormat"},{"line_number":24,"context_line":"from cryptography.hazmat.primitives.serialization import PublicFormat"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"import abc"},{"line_number":27,"context_line":"import os"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_3ca302b4","line":24,"range":{"start_line":19,"start_character":0,"end_line":24,"end_character":69},"updated":"2020-08-10 19:53:05.000000000","message":"Should import modules, not classes.\n\nAnd cryptography is a third party lib, so it should be in an import group after the standard lib import group below.","commit_id":"d972149f0b840d5334a6790c8f4c9c18a5555452"}]}