)]}'
{"castellan/key_manager/barbican_key_manager.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"289e2e123a0e5b8a98c66e29d7c9a4b1aa9ea88e","unresolved":true,"context_lines":[{"line_number":96,"context_line":"token ensures the REST API request will still be accepted by the keystone"},{"line_number":97,"context_line":"middleware."},{"line_number":98,"context_line":"\"\"\"),"},{"line_number":99,"context_line":"]"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"_BARBICAN_OPT_GROUP \u003d \u0027barbican\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"ef9ce164_b50f5647","line":99,"updated":"2021-02-03 12:07:08.000000000","message":"Is there a reason this would not be enabled? Is it a common design practice to make this configurable?\n\nLater: I see nova uses the same practice so I\u0027m guessing the answer to both questions is yes, though I don\u0027t know why.","commit_id":"48337fe13d54d289f7017569c2f62fe4fbf3955a"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"685679dff3cbaf210d6ca91b1567035250aa4b69","unresolved":false,"context_lines":[{"line_number":96,"context_line":"token ensures the REST API request will still be accepted by the keystone"},{"line_number":97,"context_line":"middleware."},{"line_number":98,"context_line":"\"\"\"),"},{"line_number":99,"context_line":"]"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"_BARBICAN_OPT_GROUP \u003d \u0027barbican\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"9187fe8f_89290cd8","line":99,"in_reply_to":"1dcbda64_f9915a85","updated":"2021-02-03 15:56:55.000000000","message":"Ack","commit_id":"48337fe13d54d289f7017569c2f62fe4fbf3955a"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"babdc3602d291b35e3baf542e8534ccfa8eefe26","unresolved":true,"context_lines":[{"line_number":96,"context_line":"token ensures the REST API request will still be accepted by the keystone"},{"line_number":97,"context_line":"middleware."},{"line_number":98,"context_line":"\"\"\"),"},{"line_number":99,"context_line":"]"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"_BARBICAN_OPT_GROUP \u003d \u0027barbican\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"1dcbda64_f9915a85","line":99,"in_reply_to":"ef9ce164_b50f5647","updated":"2021-02-03 15:04:08.000000000","message":"There\u0027s some overhead involved in generating a service token with every request. Probably also backwards compatibility too, since it requires credentials to be configured for it to work.","commit_id":"48337fe13d54d289f7017569c2f62fe4fbf3955a"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"289e2e123a0e5b8a98c66e29d7c9a4b1aa9ea88e","unresolved":true,"context_lines":[{"line_number":100,"context_line":""},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"_BARBICAN_OPT_GROUP \u003d \u0027barbican\u0027"},{"line_number":103,"context_line":"_BARBICAN_SERVICE_USER_OPT_GROUP \u003d \u0027barbican_service_user\u0027"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":106,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"760e0328_c32d784b","line":103,"updated":"2021-02-03 12:07:08.000000000","message":"Any particular reason to use a separate group?\n\nLater: I assume this is based on the nova pattern. I think that makes sense there since we need _somewhere_ to put the opt that isn\u0027t \u0027DEFAULT\u0027, however, we already have a perfectly good \u0027barbican\u0027 group we could use here, right?","commit_id":"48337fe13d54d289f7017569c2f62fe4fbf3955a"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"e247da6f2faec3292416e8059de34a01bda43a8f","unresolved":true,"context_lines":[{"line_number":100,"context_line":""},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"_BARBICAN_OPT_GROUP \u003d \u0027barbican\u0027"},{"line_number":103,"context_line":"_BARBICAN_SERVICE_USER_OPT_GROUP \u003d \u0027barbican_service_user\u0027"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":106,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5f20c36f_a43c79ad","line":103,"in_reply_to":"27279a87_2492a4a4","updated":"2021-02-03 16:27:57.000000000","message":"That\u0027s not really what I was suggesting 😊 I was pointing out that you can do this:\n\n[some-section]\nusername\u003d\npassword\u003d\n\n[barbican_service_user]\nsend_service_user_token\u003dTrue\nauth_section\u003dsome-section\n\nI guess I can move it, although to me it makes more sense where it is now.","commit_id":"48337fe13d54d289f7017569c2f62fe4fbf3955a"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"d4125a95f6ebb461d66cd4febeac4d0e3ec166f9","unresolved":false,"context_lines":[{"line_number":100,"context_line":""},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"_BARBICAN_OPT_GROUP \u003d \u0027barbican\u0027"},{"line_number":103,"context_line":"_BARBICAN_SERVICE_USER_OPT_GROUP \u003d \u0027barbican_service_user\u0027"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":106,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"f4bd2a4a_2d641157","line":103,"in_reply_to":"5f20c36f_a43c79ad","updated":"2021-02-03 16:48:46.000000000","message":"Ah, I misread that /o\\ Thanks for moving it, even if you don\u0027t agree entirely, heh","commit_id":"48337fe13d54d289f7017569c2f62fe4fbf3955a"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"babdc3602d291b35e3baf542e8534ccfa8eefe26","unresolved":true,"context_lines":[{"line_number":100,"context_line":""},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"_BARBICAN_OPT_GROUP \u003d \u0027barbican\u0027"},{"line_number":103,"context_line":"_BARBICAN_SERVICE_USER_OPT_GROUP \u003d \u0027barbican_service_user\u0027"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":106,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"cf76a048_742d4948","line":103,"in_reply_to":"760e0328_c32d784b","updated":"2021-02-03 15:04:08.000000000","message":"We might want to use different credentials to communicate with barbican vs. generating a service token. It\u0027s possible to specify the name of another config section to pull the credentials from via the auth_section option, if you wanted to make them the same and avoid duplication.","commit_id":"48337fe13d54d289f7017569c2f62fe4fbf3955a"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"685679dff3cbaf210d6ca91b1567035250aa4b69","unresolved":true,"context_lines":[{"line_number":100,"context_line":""},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"_BARBICAN_OPT_GROUP \u003d \u0027barbican\u0027"},{"line_number":103,"context_line":"_BARBICAN_SERVICE_USER_OPT_GROUP \u003d \u0027barbican_service_user\u0027"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":106,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"27279a87_2492a4a4","line":103,"in_reply_to":"cf76a048_742d4948","updated":"2021-02-03 15:56:55.000000000","message":"Oh, of course. Thanks for the clarification. I do think the \u0027send_service_user_token\u0027 would make more sense in the \u0027[barbican]\u0027 group (enable it there, then use the other group to configure it). Could we move that there as you\u0027ve suggested?","commit_id":"48337fe13d54d289f7017569c2f62fe4fbf3955a"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"289e2e123a0e5b8a98c66e29d7c9a4b1aa9ea88e","unresolved":true,"context_lines":[{"line_number":216,"context_line":""},{"line_number":217,"context_line":"        service_user_conf \u003d getattr(self.conf,"},{"line_number":218,"context_line":"                                    _BARBICAN_SERVICE_USER_OPT_GROUP)"},{"line_number":219,"context_line":"        if service_user_conf.send_service_user_token:"},{"line_number":220,"context_line":"            service_auth \u003d loading.load_auth_from_conf_options("},{"line_number":221,"context_line":"                self.conf,"},{"line_number":222,"context_line":"                group\u003d_BARBICAN_SERVICE_USER_OPT_GROUP)"}],"source_content_type":"text/x-python","patch_set":3,"id":"14b39b63_e132bc18","line":219,"updated":"2021-02-03 12:07:08.000000000","message":"This is rather strange. Why not simply:\n\n  if conf.barbican_service_user.send_service_user_token:\n\nYes, it\u0027s duplication of the string but it\u0027s not like it\u0027ll pass if the group name had a typo in it.","commit_id":"48337fe13d54d289f7017569c2f62fe4fbf3955a"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"babdc3602d291b35e3baf542e8534ccfa8eefe26","unresolved":true,"context_lines":[{"line_number":216,"context_line":""},{"line_number":217,"context_line":"        service_user_conf \u003d getattr(self.conf,"},{"line_number":218,"context_line":"                                    _BARBICAN_SERVICE_USER_OPT_GROUP)"},{"line_number":219,"context_line":"        if service_user_conf.send_service_user_token:"},{"line_number":220,"context_line":"            service_auth \u003d loading.load_auth_from_conf_options("},{"line_number":221,"context_line":"                self.conf,"},{"line_number":222,"context_line":"                group\u003d_BARBICAN_SERVICE_USER_OPT_GROUP)"}],"source_content_type":"text/x-python","patch_set":3,"id":"18f5e64f_7f4becbc","line":219,"in_reply_to":"14b39b63_e132bc18","updated":"2021-02-03 15:04:08.000000000","message":"I\u0027ll change it","commit_id":"48337fe13d54d289f7017569c2f62fe4fbf3955a"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"685679dff3cbaf210d6ca91b1567035250aa4b69","unresolved":false,"context_lines":[{"line_number":216,"context_line":""},{"line_number":217,"context_line":"        service_user_conf \u003d getattr(self.conf,"},{"line_number":218,"context_line":"                                    _BARBICAN_SERVICE_USER_OPT_GROUP)"},{"line_number":219,"context_line":"        if service_user_conf.send_service_user_token:"},{"line_number":220,"context_line":"            service_auth \u003d loading.load_auth_from_conf_options("},{"line_number":221,"context_line":"                self.conf,"},{"line_number":222,"context_line":"                group\u003d_BARBICAN_SERVICE_USER_OPT_GROUP)"}],"source_content_type":"text/x-python","patch_set":3,"id":"b0d29dd8_e00c8f5c","line":219,"in_reply_to":"18f5e64f_7f4becbc","updated":"2021-02-03 15:56:55.000000000","message":"Ack","commit_id":"48337fe13d54d289f7017569c2f62fe4fbf3955a"},{"author":{"_account_id":27954,"name":"Moisés Guimarães de Medeiros","email":"guimaraes@pm.me","username":"moguimar"},"change_message_id":"e8f640948538386df84ecc849926f84f262d2e8b","unresolved":true,"context_lines":[{"line_number":678,"context_line":""},{"line_number":679,"context_line":"    def list_options_for_discovery(self):"},{"line_number":680,"context_line":"        barbican_opts \u003d _barbican_opts"},{"line_number":681,"context_line":"        barbican_opts +\u003d loading.get_session_conf_options()"},{"line_number":682,"context_line":""},{"line_number":683,"context_line":"        barbican_service_user_opts \u003d loading.get_session_conf_options()"},{"line_number":684,"context_line":"        barbican_service_user_opts +\u003d loading.get_auth_common_conf_options()"}],"source_content_type":"text/x-python","patch_set":7,"id":"479bfad2_1b00621b","line":681,"range":{"start_line":681,"start_character":25,"end_line":681,"end_character":59},"updated":"2021-03-24 14:49:36.000000000","message":"I wonder why do we need to add these options to the [barbican] group as well, and second, this will append to the opts list in each call, if we need this, we have to copy _barbican_opts first into the local variable.\n\nIn [1]: a \u003d [1, 2, 3]\n\nIn [2]: b \u003d a\n\nIn [3]: a\nOut[3]: [1, 2, 3]\n\nIn [4]: b\nOut[4]: [1, 2, 3]\n\nIn [5]: b +\u003d [4, 5, 6]\n\nIn [6]: a\nOut[6]: [1, 2, 3, 4, 5, 6]\n\nIn [7]: b\nOut[7]: [1, 2, 3, 4, 5, 6]","commit_id":"3da0f4f03266712255ed4be83ab2097f2d9c6710"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"6822d592ca139088c1056268a93e201526b3e577","unresolved":true,"context_lines":[{"line_number":678,"context_line":""},{"line_number":679,"context_line":"    def list_options_for_discovery(self):"},{"line_number":680,"context_line":"        barbican_opts \u003d _barbican_opts"},{"line_number":681,"context_line":"        barbican_opts +\u003d loading.get_session_conf_options()"},{"line_number":682,"context_line":""},{"line_number":683,"context_line":"        barbican_service_user_opts \u003d loading.get_session_conf_options()"},{"line_number":684,"context_line":"        barbican_service_user_opts +\u003d loading.get_auth_common_conf_options()"}],"source_content_type":"text/x-python","patch_set":7,"id":"a95bae04_6448e0ec","line":681,"range":{"start_line":681,"start_character":25,"end_line":681,"end_character":59},"in_reply_to":"479bfad2_1b00621b","updated":"2021-03-24 14:57:52.000000000","message":"First question: the options were added on L112, before this patch. You could argue it\u0027s a separate issue, but I\u0027ll leave it up to you whether it\u0027s worth splitting out. I suppose the main question would be whether it\u0027s worth backporting.\n\nValid concern here about modifying the global opts list. In practice this will only be run during config generation, but I\u0027ll fix.","commit_id":"3da0f4f03266712255ed4be83ab2097f2d9c6710"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"4aee780488f69ac503704e2c9fa5cd608f2d2aab","unresolved":true,"context_lines":[{"line_number":678,"context_line":""},{"line_number":679,"context_line":"    def list_options_for_discovery(self):"},{"line_number":680,"context_line":"        barbican_opts \u003d _barbican_opts"},{"line_number":681,"context_line":"        barbican_opts +\u003d loading.get_session_conf_options()"},{"line_number":682,"context_line":""},{"line_number":683,"context_line":"        barbican_service_user_opts \u003d loading.get_session_conf_options()"},{"line_number":684,"context_line":"        barbican_service_user_opts +\u003d loading.get_auth_common_conf_options()"}],"source_content_type":"text/x-python","patch_set":7,"id":"f4b3d4b9_3df00ef7","line":681,"range":{"start_line":681,"start_character":25,"end_line":681,"end_character":59},"in_reply_to":"6a441662_6a5a4e3a","updated":"2021-03-24 17:59:29.000000000","message":"I have to admit, I can\u0027t see where the session options from the [barbican] section are used, although they were present prior to this patch. Typically the auth is loaded from the request context rather than config, although config does have an affect on the client creation. It\u0027s possible we should be using load_session_from_conf_options to create the session.\n\nFor the [barbican_service_user] section, we can either put the auth \u0026 session config in that section, or use the auth_section option to reference another section containing auth \u0026 session config.","commit_id":"3da0f4f03266712255ed4be83ab2097f2d9c6710"},{"author":{"_account_id":27954,"name":"Moisés Guimarães de Medeiros","email":"guimaraes@pm.me","username":"moguimar"},"change_message_id":"14dd5ee8a1c486cd7f810f2632f71ed9b9f5a1d9","unresolved":true,"context_lines":[{"line_number":678,"context_line":""},{"line_number":679,"context_line":"    def list_options_for_discovery(self):"},{"line_number":680,"context_line":"        barbican_opts \u003d _barbican_opts"},{"line_number":681,"context_line":"        barbican_opts +\u003d loading.get_session_conf_options()"},{"line_number":682,"context_line":""},{"line_number":683,"context_line":"        barbican_service_user_opts \u003d loading.get_session_conf_options()"},{"line_number":684,"context_line":"        barbican_service_user_opts +\u003d loading.get_auth_common_conf_options()"}],"source_content_type":"text/x-python","patch_set":7,"id":"6a441662_6a5a4e3a","line":681,"range":{"start_line":681,"start_character":25,"end_line":681,"end_character":59},"in_reply_to":"a95bae04_6448e0ec","updated":"2021-03-24 15:14:27.000000000","message":"L112: cool, I missed that.\n\nI think we should be good with _barbican_opts.copy() and +\u003d the remaining opts.\n\nNow I have a new concern, why are we registering the same options into two different groups?\n\nL112 loading.register_session_conf_options(self.conf, _BARBICAN_OPT_GROUP)\nL113\nL114 loading.register_session_conf_options(self.conf,\n                                           _BARBICAN_SERVICE_USER_OPT_GROUP)\n\nI think this will bring confusion when filling option values an probably lead to missconfiguration.","commit_id":"3da0f4f03266712255ed4be83ab2097f2d9c6710"},{"author":{"_account_id":27954,"name":"Moisés Guimarães de Medeiros","email":"guimaraes@pm.me","username":"moguimar"},"change_message_id":"e8f640948538386df84ecc849926f84f262d2e8b","unresolved":true,"context_lines":[{"line_number":681,"context_line":"        barbican_opts +\u003d loading.get_session_conf_options()"},{"line_number":682,"context_line":""},{"line_number":683,"context_line":"        barbican_service_user_opts \u003d loading.get_session_conf_options()"},{"line_number":684,"context_line":"        barbican_service_user_opts +\u003d loading.get_auth_common_conf_options()"},{"line_number":685,"context_line":""},{"line_number":686,"context_line":"        return ["},{"line_number":687,"context_line":"            (_BARBICAN_OPT_GROUP, barbican_opts),"}],"source_content_type":"text/x-python","patch_set":7,"id":"57093326_0a97ce77","line":684,"updated":"2021-03-24 14:49:36.000000000","message":"same concern here about using +\u003d, maybe use extend() instead:\n\nIn [8]: a \u003d list()\n\nIn [9]: a.extend([1, 2, 3])\n\nIn [10]: a.extend([4, 5, 6])\n\nIn [11]: a\nOut[11]: [1, 2, 3, 4, 5, 6]","commit_id":"3da0f4f03266712255ed4be83ab2097f2d9c6710"},{"author":{"_account_id":27954,"name":"Moisés Guimarães de Medeiros","email":"guimaraes@pm.me","username":"moguimar"},"change_message_id":"696cd445d2fef65c791dfac86baf520543e133e3","unresolved":false,"context_lines":[{"line_number":681,"context_line":"        barbican_opts +\u003d loading.get_session_conf_options()"},{"line_number":682,"context_line":""},{"line_number":683,"context_line":"        barbican_service_user_opts \u003d loading.get_session_conf_options()"},{"line_number":684,"context_line":"        barbican_service_user_opts +\u003d loading.get_auth_common_conf_options()"},{"line_number":685,"context_line":""},{"line_number":686,"context_line":"        return ["},{"line_number":687,"context_line":"            (_BARBICAN_OPT_GROUP, barbican_opts),"}],"source_content_type":"text/x-python","patch_set":7,"id":"2552051e_98e6f978","line":684,"in_reply_to":"4bd11deb_93186d37","updated":"2021-03-24 15:09:08.000000000","message":"Ack","commit_id":"3da0f4f03266712255ed4be83ab2097f2d9c6710"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"6822d592ca139088c1056268a93e201526b3e577","unresolved":true,"context_lines":[{"line_number":681,"context_line":"        barbican_opts +\u003d loading.get_session_conf_options()"},{"line_number":682,"context_line":""},{"line_number":683,"context_line":"        barbican_service_user_opts \u003d loading.get_session_conf_options()"},{"line_number":684,"context_line":"        barbican_service_user_opts +\u003d loading.get_auth_common_conf_options()"},{"line_number":685,"context_line":""},{"line_number":686,"context_line":"        return ["},{"line_number":687,"context_line":"            (_BARBICAN_OPT_GROUP, barbican_opts),"}],"source_content_type":"text/x-python","patch_set":7,"id":"4bd11deb_93186d37","line":684,"in_reply_to":"57093326_0a97ce77","updated":"2021-03-24 14:57:52.000000000","message":"I think +\u003d and extend have the same behaviour here. In this case it\u0027s not a problem because loading.get_session_conf_options() creates the returned list.","commit_id":"3da0f4f03266712255ed4be83ab2097f2d9c6710"},{"author":{"_account_id":27954,"name":"Moisés Guimarães de Medeiros","email":"guimaraes@pm.me","username":"moguimar"},"change_message_id":"660c5e071b2ef120dfe33642b33797020c7b7888","unresolved":true,"context_lines":[{"line_number":687,"context_line":"        barbican_opts \u003d _barbican_opts[:]"},{"line_number":688,"context_line":"        barbican_opts +\u003d loading.get_session_conf_options()"},{"line_number":689,"context_line":""},{"line_number":690,"context_line":"        barbican_service_user_opts \u003d loading.get_session_conf_options()"},{"line_number":691,"context_line":"        barbican_service_user_opts +\u003d loading.get_auth_common_conf_options()"},{"line_number":692,"context_line":""},{"line_number":693,"context_line":"        return ["}],"source_content_type":"text/x-python","patch_set":9,"id":"c011b93e_5297123c","line":690,"updated":"2021-05-25 13:36:59.000000000","message":"my concern here is that loading.get_session_conf_options() is being added to two different option groups, and we will eventually consume the values from only one of them. The other one can be a cause of confusion and misconfiguration.","commit_id":"30aa0b0aedb526b6d96e9155cd1d85612ffec1c1"},{"author":{"_account_id":27954,"name":"Moisés Guimarães de Medeiros","email":"guimaraes@pm.me","username":"moguimar"},"change_message_id":"f9ddeeb9b1d7c85740082be2ce75780194eb4483","unresolved":true,"context_lines":[{"line_number":687,"context_line":"        barbican_opts \u003d _barbican_opts[:]"},{"line_number":688,"context_line":"        barbican_opts +\u003d loading.get_session_conf_options()"},{"line_number":689,"context_line":""},{"line_number":690,"context_line":"        barbican_service_user_opts \u003d loading.get_session_conf_options()"},{"line_number":691,"context_line":"        barbican_service_user_opts +\u003d loading.get_auth_common_conf_options()"},{"line_number":692,"context_line":""},{"line_number":693,"context_line":"        return ["}],"source_content_type":"text/x-python","patch_set":9,"id":"d6386de5_540e47fb","line":690,"in_reply_to":"c011b93e_5297123c","updated":"2021-06-21 16:40:47.000000000","message":"this concern is still valid.","commit_id":"30aa0b0aedb526b6d96e9155cd1d85612ffec1c1"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"e7dc0a9ac17814137ed50e87911e5e3780f6a58e","unresolved":true,"context_lines":[{"line_number":687,"context_line":"        barbican_opts \u003d _barbican_opts[:]"},{"line_number":688,"context_line":"        barbican_opts +\u003d loading.get_session_conf_options()"},{"line_number":689,"context_line":""},{"line_number":690,"context_line":"        barbican_service_user_opts \u003d loading.get_session_conf_options()"},{"line_number":691,"context_line":"        barbican_service_user_opts +\u003d loading.get_auth_common_conf_options()"},{"line_number":692,"context_line":""},{"line_number":693,"context_line":"        return ["}],"source_content_type":"text/x-python","patch_set":9,"id":"57b18fed_c03c4725","line":690,"in_reply_to":"d6386de5_540e47fb","updated":"2021-06-21 17:04:34.000000000","message":"Perhaps. I\u0027m unsure whether the session opts registered in the barbican group will be used. I can try to look into that. However, I would say that is a separate issue from this patch, and any fix required should go in a separate patch.","commit_id":"30aa0b0aedb526b6d96e9155cd1d85612ffec1c1"}],"castellan/tests/unit/key_manager/test_barbican_key_manager.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"289e2e123a0e5b8a98c66e29d7c9a4b1aa9ea88e","unresolved":true,"context_lines":[{"line_number":40,"context_line":"        # Create fake auth_token"},{"line_number":41,"context_line":"        self.ctxt \u003d mock.Mock()"},{"line_number":42,"context_line":"        self.ctxt.auth_token \u003d \"fake_token\""},{"line_number":43,"context_line":"        self.ctxt.__class__.__name__ \u003d \"RequestContext\""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"        # Create mock barbican client"},{"line_number":46,"context_line":"        self._build_mock_barbican()"}],"source_content_type":"text/x-python","patch_set":3,"id":"a774b91e_d66f9766","line":43,"updated":"2021-02-03 12:07:08.000000000","message":"Rather than doing this, could you use the real RequestContext as a spec?\n\n  \u003e\u003e\u003e from oslo_context import context\n  \u003e\u003e\u003e from unittest import mock\n  \u003e\u003e\u003e ctxt \u003d mock.Mock(spec\u003dcontext.RequestContext)\n  \u003e\u003e\u003e ctxt.__class__.__name__\n  \u0027RequestContext\u0027\n\nThat gives us other benefits also, like not being able to set attributes/call methods that don\u0027t exist","commit_id":"48337fe13d54d289f7017569c2f62fe4fbf3955a"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"babdc3602d291b35e3baf542e8534ccfa8eefe26","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        # Create fake auth_token"},{"line_number":41,"context_line":"        self.ctxt \u003d mock.Mock()"},{"line_number":42,"context_line":"        self.ctxt.auth_token \u003d \"fake_token\""},{"line_number":43,"context_line":"        self.ctxt.__class__.__name__ \u003d \"RequestContext\""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"        # Create mock barbican client"},{"line_number":46,"context_line":"        self._build_mock_barbican()"}],"source_content_type":"text/x-python","patch_set":3,"id":"c39f564d_7397fbfc","line":43,"in_reply_to":"a774b91e_d66f9766","updated":"2021-02-03 15:04:08.000000000","message":"Done. I had to set a couple of properties to make it work.","commit_id":"48337fe13d54d289f7017569c2f62fe4fbf3955a"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"289e2e123a0e5b8a98c66e29d7c9a4b1aa9ea88e","unresolved":true,"context_lines":[{"line_number":83,"context_line":"        self.assertEqual(auth, self.ctxt.get_auth_plugin())"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    def test__get_keystone_auth_service_user(self):"},{"line_number":86,"context_line":"        self.key_mgr.conf.barbican_service_user.send_service_user_token \u003d True"},{"line_number":87,"context_line":"        auth \u003d self.key_mgr._get_keystone_auth(self.ctxt)"},{"line_number":88,"context_line":"        self.assertIsInstance(auth, service_token.ServiceTokenAuthWrapper)"},{"line_number":89,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"27f4d070_363e141d","line":86,"updated":"2021-02-03 12:07:08.000000000","message":"Hmm, I expected to see something like\n\n  CONF.set_override(...)\n\nhere, but I guess this works also?","commit_id":"48337fe13d54d289f7017569c2f62fe4fbf3955a"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"babdc3602d291b35e3baf542e8534ccfa8eefe26","unresolved":true,"context_lines":[{"line_number":83,"context_line":"        self.assertEqual(auth, self.ctxt.get_auth_plugin())"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    def test__get_keystone_auth_service_user(self):"},{"line_number":86,"context_line":"        self.key_mgr.conf.barbican_service_user.send_service_user_token \u003d True"},{"line_number":87,"context_line":"        auth \u003d self.key_mgr._get_keystone_auth(self.ctxt)"},{"line_number":88,"context_line":"        self.assertIsInstance(auth, service_token.ServiceTokenAuthWrapper)"},{"line_number":89,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"c0566437_e0762139","line":86,"in_reply_to":"27f4d070_363e141d","updated":"2021-02-03 15:04:08.000000000","message":"Either way should work. I just followed the style of other tests in the file.","commit_id":"48337fe13d54d289f7017569c2f62fe4fbf3955a"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"685679dff3cbaf210d6ca91b1567035250aa4b69","unresolved":false,"context_lines":[{"line_number":83,"context_line":"        self.assertEqual(auth, self.ctxt.get_auth_plugin())"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    def test__get_keystone_auth_service_user(self):"},{"line_number":86,"context_line":"        self.key_mgr.conf.barbican_service_user.send_service_user_token \u003d True"},{"line_number":87,"context_line":"        auth \u003d self.key_mgr._get_keystone_auth(self.ctxt)"},{"line_number":88,"context_line":"        self.assertIsInstance(auth, service_token.ServiceTokenAuthWrapper)"},{"line_number":89,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"50c3400a_e749af11","line":86,"in_reply_to":"c0566437_e0762139","updated":"2021-02-03 15:56:55.000000000","message":"This works so let\u0027s keep it as-is","commit_id":"48337fe13d54d289f7017569c2f62fe4fbf3955a"}],"releasenotes/notes/barbican-service-user-11ebbfcd33dace9d.yaml":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"289e2e123a0e5b8a98c66e29d7c9a4b1aa9ea88e","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds support for using a service user with the Barbican key manager."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"2e658142_d6255f1f","line":4,"updated":"2021-02-03 12:07:08.000000000","message":"A reference to the config option that can be used to enable it would be useful IMO","commit_id":"48337fe13d54d289f7017569c2f62fe4fbf3955a"}]}