)]}'
{"castellan/key_manager/barbican_key_manager.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"babe0fe6a0e15b0a6707fc58e825cd06db84cc1d","unresolved":true,"context_lines":[{"line_number":79,"context_line":"                    \u0027public, private, and admin\u0027),"},{"line_number":80,"context_line":"    cfg.StrOpt(\u0027barbican_region_name\u0027,"},{"line_number":81,"context_line":"               default\u003dNone,"},{"line_number":82,"context_line":"               help\u003d\u0027Specifies the region of endpoint.\u0027),"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"]"},{"line_number":85,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"c547a1f4_a3fd9e8c","line":82,"range":{"start_line":82,"start_character":44,"end_line":82,"end_character":45},"updated":"2021-02-03 12:09:14.000000000","message":"the","commit_id":"7b09fc64e3ae8830020b0c3873f7ba1150a19b00"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"9ccd290a1f351b2f6c1d023a5e9a57016bf9b35d","unresolved":false,"context_lines":[{"line_number":79,"context_line":"                    \u0027public, private, and admin\u0027),"},{"line_number":80,"context_line":"    cfg.StrOpt(\u0027barbican_region_name\u0027,"},{"line_number":81,"context_line":"               default\u003dNone,"},{"line_number":82,"context_line":"               help\u003d\u0027Specifies the region of endpoint.\u0027),"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"]"},{"line_number":85,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"c940543b_bcfb1907","line":82,"range":{"start_line":82,"start_character":44,"end_line":82,"end_character":45},"in_reply_to":"c547a1f4_a3fd9e8c","updated":"2021-02-03 13:35:52.000000000","message":"Done","commit_id":"7b09fc64e3ae8830020b0c3873f7ba1150a19b00"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"babe0fe6a0e15b0a6707fc58e825cd06db84cc1d","unresolved":true,"context_lines":[{"line_number":207,"context_line":"            return auth.get_endpoint(sess, **service_parameters)"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"    def _create_base_url(self, auth, sess, endpoint):"},{"line_number":210,"context_line":"        barbican \u003d self.conf.barbican"},{"line_number":211,"context_line":"        api_version \u003d None"},{"line_number":212,"context_line":"        if barbican.barbican_api_version:"},{"line_number":213,"context_line":"            api_version \u003d barbican.barbican_api_version"}],"source_content_type":"text/x-python","patch_set":3,"id":"b98e949b_7dd9226c","line":210,"updated":"2021-02-03 12:09:14.000000000","message":"Why not just use this directly? It would be clearer IMO","commit_id":"7b09fc64e3ae8830020b0c3873f7ba1150a19b00"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"d11d6c9877077c0a0556c0a0aca41832d41b0cf2","unresolved":true,"context_lines":[{"line_number":207,"context_line":"            return auth.get_endpoint(sess, **service_parameters)"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"    def _create_base_url(self, auth, sess, endpoint):"},{"line_number":210,"context_line":"        barbican \u003d self.conf.barbican"},{"line_number":211,"context_line":"        api_version \u003d None"},{"line_number":212,"context_line":"        if barbican.barbican_api_version:"},{"line_number":213,"context_line":"            api_version \u003d barbican.barbican_api_version"}],"source_content_type":"text/x-python","patch_set":3,"id":"e85caeb3_0557853e","line":210,"in_reply_to":"b98e949b_7dd9226c","updated":"2021-02-03 12:26:10.000000000","message":"I followed the same way how we use these config parameters in _get_barbican_endpoint .\n\nI prefer direct reference, though. Maybe we can replace the usage of that redundant reference later also in _get_barbican_endpoint.","commit_id":"7b09fc64e3ae8830020b0c3873f7ba1150a19b00"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"9ccd290a1f351b2f6c1d023a5e9a57016bf9b35d","unresolved":true,"context_lines":[{"line_number":207,"context_line":"            return auth.get_endpoint(sess, **service_parameters)"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"    def _create_base_url(self, auth, sess, endpoint):"},{"line_number":210,"context_line":"        barbican \u003d self.conf.barbican"},{"line_number":211,"context_line":"        api_version \u003d None"},{"line_number":212,"context_line":"        if barbican.barbican_api_version:"},{"line_number":213,"context_line":"            api_version \u003d barbican.barbican_api_version"}],"source_content_type":"text/x-python","patch_set":3,"id":"1318acfe_3f51c750","line":210,"in_reply_to":"e85caeb3_0557853e","updated":"2021-02-03 13:35:52.000000000","message":"Yes, if you can provide a patch to fix these then I\u0027d be happy to review it","commit_id":"7b09fc64e3ae8830020b0c3873f7ba1150a19b00"}],"castellan/tests/unit/key_manager/test_barbican_key_manager.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"babe0fe6a0e15b0a6707fc58e825cd06db84cc1d","unresolved":true,"context_lines":[{"line_number":84,"context_line":"        auth.service_catalog.endpoint_data_for.return_value \u003d endpoint_data"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"        endpoint \u003d self.key_mgr._get_barbican_endpoint(auth,"},{"line_number":87,"context_line":"                                                       mock.Mock())"},{"line_number":88,"context_line":"        self.assertEqual(endpoint, \u0027http://localhost:9311\u0027)"},{"line_number":89,"context_line":"        auth.service_catalog.endpoint_data_for.assert_called_once_with("},{"line_number":90,"context_line":"            service_type\u003d\u0027key-manager\u0027, interface\u003d\u0027public\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"96332ad5_9803ae2a","line":87,"updated":"2021-02-03 12:09:14.000000000","message":"nit: would fit on one line. Below also","commit_id":"7b09fc64e3ae8830020b0c3873f7ba1150a19b00"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"9ccd290a1f351b2f6c1d023a5e9a57016bf9b35d","unresolved":false,"context_lines":[{"line_number":84,"context_line":"        auth.service_catalog.endpoint_data_for.return_value \u003d endpoint_data"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"        endpoint \u003d self.key_mgr._get_barbican_endpoint(auth,"},{"line_number":87,"context_line":"                                                       mock.Mock())"},{"line_number":88,"context_line":"        self.assertEqual(endpoint, \u0027http://localhost:9311\u0027)"},{"line_number":89,"context_line":"        auth.service_catalog.endpoint_data_for.assert_called_once_with("},{"line_number":90,"context_line":"            service_type\u003d\u0027key-manager\u0027, interface\u003d\u0027public\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"4f3dc039_ef2dc101","line":87,"in_reply_to":"96332ad5_9803ae2a","updated":"2021-02-03 13:35:52.000000000","message":"Done","commit_id":"7b09fc64e3ae8830020b0c3873f7ba1150a19b00"}],"releasenotes/notes/use-barbican-region-name-config-option-31bec809292302b8.yaml":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"babe0fe6a0e15b0a6707fc58e825cd06db84cc1d","unresolved":true,"context_lines":[{"line_number":5,"context_line":"    This parameter is used to determine the proper barbican endpoint in"},{"line_number":6,"context_line":"    the multi-region deployment which has a different Barbican endpoint in"},{"line_number":7,"context_line":"    each region."},{"line_number":8,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"a59cc087_7225188c","line":8,"updated":"2021-02-03 12:09:14.000000000","message":"nit: trailing newline","commit_id":"7b09fc64e3ae8830020b0c3873f7ba1150a19b00"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"9ccd290a1f351b2f6c1d023a5e9a57016bf9b35d","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    This parameter is used to determine the proper barbican endpoint in"},{"line_number":6,"context_line":"    the multi-region deployment which has a different Barbican endpoint in"},{"line_number":7,"context_line":"    each region."},{"line_number":8,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"7f61db17_3a9d2a33","line":8,"in_reply_to":"a59cc087_7225188c","updated":"2021-02-03 13:35:52.000000000","message":"Done","commit_id":"7b09fc64e3ae8830020b0c3873f7ba1150a19b00"}]}