)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"6bed8310f0c6b847755e20c776d97a19d36211ee","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"672d9d92_ce6d581d","updated":"2025-06-12 11:11:35.000000000","message":"Not really sure TBH about the \u0027proper\u0027 deprecation - the option does nothing now, simply removing it breaks nothing, having unregistered option in config also does not break anything, and we\u0027ll mention removal in release notes...\n\nbut OK.","commit_id":"6f64e4ce44df540a9a4b6d84888ed174e1a0e156"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"4cb32378a4ad50f6953a0b802492bf5b481a0955","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"d15be41d_70548265","in_reply_to":"672d9d92_ce6d581d","updated":"2025-06-12 16:10:33.000000000","message":"Sad fact is that operators don\u0027t always pay attention to release note. keeping the option deprecated triggers warning when the option is left in the config file, and allows more chance to them to remove it.","commit_id":"6f64e4ce44df540a9a4b6d84888ed174e1a0e156"}],"castellan/key_manager/vault_key_manager.py":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"d709f2721f8b3c171b84c1f3b2f8d916243f01a0","unresolved":true,"context_lines":[{"line_number":68,"context_line":"               help\u003d\u0027Use this endpoint to connect to Vault, for example: \u0027"},{"line_number":69,"context_line":"                    \u0027\"%s\"\u0027 % _DEFAULT_VAULT_URL),"},{"line_number":70,"context_line":"    cfg.StrOpt(\u0027ssl_ca_crt_file\u0027,"},{"line_number":71,"context_line":"               help\u003d\u0027Absolute path to ca cert file\u0027),"},{"line_number":72,"context_line":"    cfg.BoolOpt(\u0027use_ssl\u0027,"},{"line_number":73,"context_line":"                default\u003dFalse,"},{"line_number":74,"context_line":"                help\u003d_(\u0027SSL Enabled/Disabled\u0027)),"},{"line_number":75,"context_line":"    cfg.StrOpt(\"namespace\","},{"line_number":76,"context_line":"               help\u003d_(\"Vault Namespace to use for all requests to Vault. \""},{"line_number":77,"context_line":"                      \"Vault Namespaces feature is available only in \""}],"source_content_type":"text/x-python","patch_set":2,"id":"bbc8b705_04b47c80","side":"PARENT","line":74,"range":{"start_line":71,"start_character":53,"end_line":74,"end_character":48},"updated":"2025-06-12 03:52:19.000000000","message":"IMO we should not drop the option from config. It should be kept deprecated, to let users be aware that this option should be removed from their config.","commit_id":"b670de7508c1d7b22c54d247102c5cb3ae800f8c"}],"castellan/options.py":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"d709f2721f8b3c171b84c1f3b2f8d916243f01a0","unresolved":true,"context_lines":[{"line_number":34,"context_line":"_DEFAULT_LOG_LEVELS \u003d [\u0027castellan\u003dWARN\u0027]"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"@removals.removed_kwarg(\"vault_use_ssl\", message\u003d\"This option was a no-op\")"},{"line_number":38,"context_line":"def set_defaults(conf, backend\u003dNone, barbican_endpoint\u003dNone,"},{"line_number":39,"context_line":"                 barbican_api_version\u003dNone, auth_endpoint\u003dNone,"},{"line_number":40,"context_line":"                 retry_delay\u003dNone, number_of_retries\u003dNone, verify_ssl\u003dNone,"}],"source_content_type":"text/x-python","patch_set":2,"id":"bcda4500_8165fbd8","line":37,"range":{"start_line":37,"start_character":0,"end_line":37,"end_character":75},"updated":"2025-06-12 03:52:19.000000000","message":"I\u0027ve seen this pattern in a few places, but this does not work in case the option is set in args (though I don\u0027t know how often users use args for it).\n\nI\u0027d rather suggest adding this into the function.\n```\nif vault_use_ssl is not None:\n    warning.warnings(\u0027vault_use_ssl is deprecated.\u0027, DeprecationWarning)\n```","commit_id":"6f64e4ce44df540a9a4b6d84888ed174e1a0e156"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"4cb32378a4ad50f6953a0b802492bf5b481a0955","unresolved":true,"context_lines":[{"line_number":34,"context_line":"_DEFAULT_LOG_LEVELS \u003d [\u0027castellan\u003dWARN\u0027]"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"@removals.removed_kwarg(\"vault_use_ssl\", message\u003d\"This option was a no-op\")"},{"line_number":38,"context_line":"def set_defaults(conf, backend\u003dNone, barbican_endpoint\u003dNone,"},{"line_number":39,"context_line":"                 barbican_api_version\u003dNone, auth_endpoint\u003dNone,"},{"line_number":40,"context_line":"                 retry_delay\u003dNone, number_of_retries\u003dNone, verify_ssl\u003dNone,"}],"source_content_type":"text/x-python","patch_set":2,"id":"fcfc254a_e218c6ba","line":37,"range":{"start_line":37,"start_character":0,"end_line":37,"end_character":75},"in_reply_to":"7764bf53_d35c64a4","updated":"2025-06-12 16:10:33.000000000","message":"I agree it\u0027s doublt-able, though another advantage of this approach is that we don\u0027t have to pull a new dependency just to show a warning. I don\u0027t have strong opinion about this point, so would be open for any feedback from the other cores.","commit_id":"6f64e4ce44df540a9a4b6d84888ed174e1a0e156"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"6bed8310f0c6b847755e20c776d97a19d36211ee","unresolved":true,"context_lines":[{"line_number":34,"context_line":"_DEFAULT_LOG_LEVELS \u003d [\u0027castellan\u003dWARN\u0027]"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"@removals.removed_kwarg(\"vault_use_ssl\", message\u003d\"This option was a no-op\")"},{"line_number":38,"context_line":"def set_defaults(conf, backend\u003dNone, barbican_endpoint\u003dNone,"},{"line_number":39,"context_line":"                 barbican_api_version\u003dNone, auth_endpoint\u003dNone,"},{"line_number":40,"context_line":"                 retry_delay\u003dNone, number_of_retries\u003dNone, verify_ssl\u003dNone,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7764bf53_d35c64a4","line":37,"range":{"start_line":37,"start_character":0,"end_line":37,"end_character":75},"in_reply_to":"bcda4500_8165fbd8","updated":"2025-06-12 11:11:35.000000000","message":"not sure wdym by \u0027option set in args\u0027? like when I pass everything as *args relying on their order in the function definition?\n\nif yes, then somehow I do really doubt it is used anywhere like this, at least in this particular case :-) passing 20 kwargs as args seems super weird and brittle to me...","commit_id":"6f64e4ce44df540a9a4b6d84888ed174e1a0e156"}]}