)]}'
{"castellan/key_manager/vault_key_manager.py":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"27b346dc2d2002bd21c90f0b198e0fae8807947c","unresolved":true,"context_lines":[{"line_number":301,"context_line":""},{"line_number":302,"context_line":"        return self._store_key_value(key_id, key)"},{"line_number":303,"context_line":""},{"line_number":304,"context_line":"    def store(self, context, key_value, expiration\u003dNone):"},{"line_number":305,"context_line":"        \"\"\"Stores (i.e., registers) a key with the key manager.\"\"\""},{"line_number":306,"context_line":""},{"line_number":307,"context_line":"        key_id \u003d uuid.uuid4().hex"}],"source_content_type":"text/x-python","patch_set":1,"id":"1c11d0f0_f3b30dae","line":304,"range":{"start_line":304,"start_character":29,"end_line":304,"end_character":38},"updated":"2026-04-16 15:24:42.000000000","message":"I just noticed that the argument name is different (we use managed_object for the other places. I wonder if we want to rename it now though I know it may affect any existing usage with the specific kwarg call.","commit_id":"31c133205674fe6a9dcfdeb56d52a658275adf78"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8979c9503e1f683a33c28c168b643b05a3e586c3","unresolved":true,"context_lines":[{"line_number":301,"context_line":""},{"line_number":302,"context_line":"        return self._store_key_value(key_id, key)"},{"line_number":303,"context_line":""},{"line_number":304,"context_line":"    def store(self, context, key_value, expiration\u003dNone):"},{"line_number":305,"context_line":"        \"\"\"Stores (i.e., registers) a key with the key manager.\"\"\""},{"line_number":306,"context_line":""},{"line_number":307,"context_line":"        key_id \u003d uuid.uuid4().hex"}],"source_content_type":"text/x-python","patch_set":1,"id":"93ac54ae_24757ae8","line":304,"range":{"start_line":304,"start_character":29,"end_line":304,"end_character":38},"in_reply_to":"1c11d0f0_f3b30dae","updated":"2026-04-16 15:26:31.000000000","message":"Good point. I am happy to change and believe the risk of someone calling this with a kwarg is low-to-zero. Let me stick on a follow-up.","commit_id":"31c133205674fe6a9dcfdeb56d52a658275adf78"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"a7210f440583aaa683212d0d38fd89aa0035a4bb","unresolved":true,"context_lines":[{"line_number":301,"context_line":""},{"line_number":302,"context_line":"        return self._store_key_value(key_id, key)"},{"line_number":303,"context_line":""},{"line_number":304,"context_line":"    def store(self, context, key_value, expiration\u003dNone):"},{"line_number":305,"context_line":"        \"\"\"Stores (i.e., registers) a key with the key manager.\"\"\""},{"line_number":306,"context_line":""},{"line_number":307,"context_line":"        key_id \u003d uuid.uuid4().hex"}],"source_content_type":"text/x-python","patch_set":1,"id":"ca99a6a0_5b9d3c9e","line":304,"range":{"start_line":304,"start_character":29,"end_line":304,"end_character":38},"in_reply_to":"93ac54ae_24757ae8","updated":"2026-04-16 15:33:33.000000000","message":"OK. We should probably bump a major version when we create a new release.","commit_id":"31c133205674fe6a9dcfdeb56d52a658275adf78"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"9f1f2eef31efde5fa20c671dfe8f22235a368216","unresolved":false,"context_lines":[{"line_number":301,"context_line":""},{"line_number":302,"context_line":"        return self._store_key_value(key_id, key)"},{"line_number":303,"context_line":""},{"line_number":304,"context_line":"    def store(self, context, key_value, expiration\u003dNone):"},{"line_number":305,"context_line":"        \"\"\"Stores (i.e., registers) a key with the key manager.\"\"\""},{"line_number":306,"context_line":""},{"line_number":307,"context_line":"        key_id \u003d uuid.uuid4().hex"}],"source_content_type":"text/x-python","patch_set":1,"id":"91621f8d_ea940467","line":304,"range":{"start_line":304,"start_character":29,"end_line":304,"end_character":38},"in_reply_to":"ca99a6a0_5b9d3c9e","updated":"2026-04-16 17:46:57.000000000","message":"Done in the last patch in the series https://review.opendev.org/c/openstack/castellan/+/984842","commit_id":"31c133205674fe6a9dcfdeb56d52a658275adf78"}]}