)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"3847dce4d08de9044a69911de5b47873c88e36b3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"2d06e295_22d4367d","updated":"2023-12-26 15:52:06.000000000","message":"This is proven to work by https://review.opendev.org/c/openstack/ceilometermiddleware/+/904336 .","commit_id":"841b04d64716863e15aa9076accb796d842d6247"},{"author":{"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"},"change_message_id":"f4aaa71cd9bc11168b77f496e42585278c684a17","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"bee29594_eb05af64","updated":"2024-01-26 12:34:28.000000000","message":"thank you. I spotted a typo, otherwise looks good to me.","commit_id":"841b04d64716863e15aa9076accb796d842d6247"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"46927a330187d6939d6e753b7595fc55a8242133","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"1161ed81_a533fc28","updated":"2024-04-18 09:11:53.000000000","message":"Just question about the error handling, otherwise looks good to me.","commit_id":"0c5de2df506507e89e764a0e36cdcd2d9dde09a4"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"f98d229cb7c3a80575badcfcbbaa21e1d4e5d000","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"2835c590_793a0bba","updated":"2024-04-19 17:29:19.000000000","message":"GR8 LGTM, thanks Takashi!","commit_id":"74dac1ca2fe78c82e2cc1c3e8955762002636068"}],"ceilometermiddleware/swift.py":[{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"46927a330187d6939d6e753b7595fc55a8242133","unresolved":true,"context_lines":[{"line_number":175,"context_line":"        except cfg.RequiredOptError:"},{"line_number":176,"context_line":"            # When authtoken middleware is enabled, CONF.__call__ fails because"},{"line_number":177,"context_line":"            # the required [keystone_authtoken] auth_url option is not set."},{"line_number":178,"context_line":"            pass"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"        oslo_messaging.set_transport_defaults(conf.get(\u0027control_exchange\u0027,"},{"line_number":181,"context_line":"                                                       \u0027swift\u0027))"}],"source_content_type":"text/x-python","patch_set":6,"id":"b8effce3_3139881e","line":178,"updated":"2024-04-18 09:11:53.000000000","message":"Shouldn\u0027t we log that and let the operator know that we couldn\u0027t apply their extra configs?","commit_id":"0c5de2df506507e89e764a0e36cdcd2d9dde09a4"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"845e93c167b94077d7f54388372a7fce57f0be56","unresolved":false,"context_lines":[{"line_number":175,"context_line":"        except cfg.RequiredOptError:"},{"line_number":176,"context_line":"            # When authtoken middleware is enabled, CONF.__call__ fails because"},{"line_number":177,"context_line":"            # the required [keystone_authtoken] auth_url option is not set."},{"line_number":178,"context_line":"            pass"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"        oslo_messaging.set_transport_defaults(conf.get(\u0027control_exchange\u0027,"},{"line_number":181,"context_line":"                                                       \u0027swift\u0027))"}],"source_content_type":"text/x-python","patch_set":6,"id":"124f06d6_b6366773","line":178,"in_reply_to":"9fa611d1_b34ba342","updated":"2024-04-18 15:12:11.000000000","message":"I updated the implementation to use dedicated ConfigOpts instance. This allows us to avoid problems caused by authtoken options and we can load only oslo.messaging options from these dedicated files.","commit_id":"0c5de2df506507e89e764a0e36cdcd2d9dde09a4"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"be510d613c0222a95bf8546b405891f6c82c643f","unresolved":true,"context_lines":[{"line_number":175,"context_line":"        except cfg.RequiredOptError:"},{"line_number":176,"context_line":"            # When authtoken middleware is enabled, CONF.__call__ fails because"},{"line_number":177,"context_line":"            # the required [keystone_authtoken] auth_url option is not set."},{"line_number":178,"context_line":"            pass"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"        oslo_messaging.set_transport_defaults(conf.get(\u0027control_exchange\u0027,"},{"line_number":181,"context_line":"                                                       \u0027swift\u0027))"}],"source_content_type":"text/x-python","patch_set":6,"id":"9fa611d1_b34ba342","line":178,"in_reply_to":"b8effce3_3139881e","updated":"2024-04-18 10:01:30.000000000","message":"I can add a log but it\u0027s not very useful because the excepton tells only one of the missing optionsand we always getwat least one error about the keystonemiddleware option.\n\nI\u0027ll give this another thougt but we might be able to use a dedicated instance to avid the problem. let me put wip now and I\u0027ll update you soon.","commit_id":"0c5de2df506507e89e764a0e36cdcd2d9dde09a4"}],"releasenotes/notes/bug-1673738-ec8f7dd8ac43ad54.yaml":[{"author":{"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"},"change_message_id":"f4aaa71cd9bc11168b77f496e42585278c684a17","unresolved":true,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The ceilometer middleware now supports loading additional config files to"},{"line_number":5,"context_line":"    look up oslo.messaging lbirary options. Set the ``extra_config_files``"},{"line_number":6,"context_line":"    parameter or the ``extra_config_dirs`` parameter in the ceilometer"},{"line_number":7,"context_line":"    middleware section in the swift proxy server config file."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"54b122b8_9eee6caa","line":5,"updated":"2024-01-26 12:34:28.000000000","message":"*library*","commit_id":"841b04d64716863e15aa9076accb796d842d6247"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"e454c1787a0e62df30462c9ce715333c131603d4","unresolved":false,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The ceilometer middleware now supports loading additional config files to"},{"line_number":5,"context_line":"    look up oslo.messaging lbirary options. Set the ``extra_config_files``"},{"line_number":6,"context_line":"    parameter or the ``extra_config_dirs`` parameter in the ceilometer"},{"line_number":7,"context_line":"    middleware section in the swift proxy server config file."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"f0dbe99e_cf621e71","line":5,"in_reply_to":"54b122b8_9eee6caa","updated":"2024-01-26 12:36:36.000000000","message":"Done","commit_id":"841b04d64716863e15aa9076accb796d842d6247"}]}