)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"77e86e72f6ef6ff70eb9a504f09cf404eb41fe0f","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Ilya Tyaptin \u003cityaptin@mirantis.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-06-17 18:06:40 +0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[Hbase] Add column for source filter in _get_meter_samples."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Earlier column for source was not created and \"get_samples\""},{"line_number":10,"context_line":"method with source query worked incorrect. In this change"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1ae5cdf2_af99f37a","line":7,"updated":"2014-06-18 04:33:17.000000000","message":"the trailing dot breaks hacking rule, sigh","commit_id":"dab8743de33d5340cb0ff626519dd7bee1ee35b1"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"77e86e72f6ef6ff70eb9a504f09cf404eb41fe0f","unresolved":false,"context_lines":[{"line_number":7,"context_line":"[Hbase] Add column for source filter in _get_meter_samples."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Earlier column for source was not created and \"get_samples\""},{"line_number":10,"context_line":"method with source query worked incorrect. In this change"},{"line_number":11,"context_line":"it is fixed."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Fixes: bug #1330989"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1ae5cdf2_ef8a1b19","line":10,"updated":"2014-06-18 04:33:17.000000000","message":"is it possible to add a scenarios test for this case?","commit_id":"dab8743de33d5340cb0ff626519dd7bee1ee35b1"}],"ceilometer/storage/hbase/utils.py":[{"author":{"_account_id":3012,"name":"Dina Belova","email":"dbelova@mirantis.com","username":"dbelova"},"change_message_id":"e3dd0375614143ef1c8113c84e5e385da96d94b4","unresolved":false,"context_lines":[{"line_number":195,"context_line":"def get_meter_columns(metaquery, need_timestamp, **kwargs):"},{"line_number":196,"context_line":"    \"\"\"Return a list of required columns in meter table to be scanned ."},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"    :param metaquery: optional metaquery dict"},{"line_number":199,"context_line":"    :param kwargs: key-value pairs to filter on. Key should be a real"},{"line_number":200,"context_line":"      column name in db"},{"line_number":201,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"baada198_a710b450","line":198,"updated":"2014-07-15 17:48:45.000000000","message":"add need_timestamp to the doc please","commit_id":"cd23f6699e15d7dc3ffc3b5d18e221c4b3a9ba0f"},{"author":{"_account_id":7478,"name":"Nadya Shakhat","email":"nadmi4@gmail.com","username":"nprivalova"},"change_message_id":"94d417c8aa1fc515db34ebb65124132dfebc1961","unresolved":false,"context_lines":[{"line_number":192,"context_line":"    return res_q"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"def get_meter_columns(metaquery\u003dNone, need_timestamp\u003dNone, **kwargs):"},{"line_number":196,"context_line":"    \"\"\"Return a list of required columns in meter table to be scanned ."},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"    :param metaquery: optional metaquery dict"}],"source_content_type":"text/x-python","patch_set":5,"id":"baada198_37338b63","line":195,"updated":"2014-07-31 11:34:45.000000000","message":"Ilya, could you please add comment that explains the lines you\u0027ve added? \nMaybe with example. e.g.:\n\nSingleColumnFilter has \u0027columns\u0027 filter that should be used to determine what columns we are interested in. But if we want to use \u0027filter\u0027 and \u0027columns\u0027 together we have to include columns we are filter by to columns list. Please see an example:\n1. scan \u0027meter\u0027, {FILTER \u003d\u003e \"SingleColumnValueFilter (\u0027f\u0027, \u0027s_test-1\u0027, \u003d, \u0027binary:\\\"1\\\"\u0027, true, true)\", COLUMNS \u003d\u003e \u0027f:rts\u0027}\nThe output here will be always empty because only \u0027rts\u0027 will be returned and  filter will be applied to this data so \u0027s_test-1\u0027 cannot be find.\n\nTo make this request correct it should be fixed as follows:\n{FILTER \u003d\u003e \"SingleColumnValueFilter (\u0027f\u0027, \u0027s_test-1\u0027, \u003d, \u0027binary:\\\"1\\\"\u0027, true, true)\", COLUMNS \u003d\u003e [\u0027f:rts\u0027,\u0027f:s_test-1\u0027]}","commit_id":"f91625bbc240e1bb5e6412cdadc98a354dc3e0f3"},{"author":{"_account_id":3012,"name":"Dina Belova","email":"dbelova@mirantis.com","username":"dbelova"},"change_message_id":"fbebe5bd8f9a2bb17b1c61782c0572c7d78c6349","unresolved":false,"context_lines":[{"line_number":196,"context_line":"    \"\"\"Return a list of required columns in meter table to be scanned."},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"    SingleColumnFilter has \u0027columns\u0027 filter that should be used to determine"},{"line_number":199,"context_line":"    what columns we are interested in.But if we want to use \u0027filter\u0027 and"},{"line_number":200,"context_line":"    \u0027columns\u0027 together we have to include columns we are filter by"},{"line_number":201,"context_line":"    to columns list."},{"line_number":202,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"baada198_39be9264","line":199,"range":{"start_line":199,"start_character":37,"end_line":199,"end_character":38},"updated":"2014-08-05 07:14:40.000000000","message":"insert whitespace after a dot please :)","commit_id":"c33614bc4951055edf418486a309d752b6d5dc97"},{"author":{"_account_id":3012,"name":"Dina Belova","email":"dbelova@mirantis.com","username":"dbelova"},"change_message_id":"fbebe5bd8f9a2bb17b1c61782c0572c7d78c6349","unresolved":false,"context_lines":[{"line_number":197,"context_line":""},{"line_number":198,"context_line":"    SingleColumnFilter has \u0027columns\u0027 filter that should be used to determine"},{"line_number":199,"context_line":"    what columns we are interested in.But if we want to use \u0027filter\u0027 and"},{"line_number":200,"context_line":"    \u0027columns\u0027 together we have to include columns we are filter by"},{"line_number":201,"context_line":"    to columns list."},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"    Please see an example: If we make scan with filter"}],"source_content_type":"text/x-python","patch_set":6,"id":"baada198_99aebe2d","line":200,"range":{"start_line":200,"start_character":57,"end_line":200,"end_character":63},"updated":"2014-08-05 07:14:40.000000000","message":"filter -\u003e filtering","commit_id":"c33614bc4951055edf418486a309d752b6d5dc97"},{"author":{"_account_id":3012,"name":"Dina Belova","email":"dbelova@mirantis.com","username":"dbelova"},"change_message_id":"fbebe5bd8f9a2bb17b1c61782c0572c7d78c6349","unresolved":false,"context_lines":[{"line_number":223,"context_line":"    source \u003d kwargs.get(\u0027source\u0027)"},{"line_number":224,"context_line":"    if source:"},{"line_number":225,"context_line":"        columns.append(\"f:s_%s\" % source)"},{"line_number":226,"context_line":"    if need_timestamp:"},{"line_number":227,"context_line":"        columns.append(\"f:rts\")"},{"line_number":228,"context_line":"        columns.append(\"f:timestamp\")"},{"line_number":229,"context_line":"    return columns"}],"source_content_type":"text/x-python","patch_set":6,"id":"baada198_9975decd","line":226,"range":{"start_line":226,"start_character":7,"end_line":226,"end_character":21},"updated":"2014-08-05 07:14:40.000000000","message":"why need_timestamp is none by default, not False? It looks more logical for me here in this case, as we\u0027re just extending the columns list without any values passing there, etc.","commit_id":"c33614bc4951055edf418486a309d752b6d5dc97"},{"author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"change_message_id":"b35e478c77a84a270d9f904c962493097678d78a","unresolved":false,"context_lines":[{"line_number":225,"context_line":"        columns.append(\"f:s_%s\" % source)"},{"line_number":226,"context_line":"    if need_timestamp:"},{"line_number":227,"context_line":"        columns.append(\"f:rts\")"},{"line_number":228,"context_line":"        columns.append(\"f:timestamp\")"},{"line_number":229,"context_line":"    return columns"},{"line_number":230,"context_line":""},{"line_number":231,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"baada198_0dfc330c","line":228,"updated":"2014-08-05 02:03:49.000000000","message":"nit: this two line can be merged to:\ncolumns.extend([\"f:rts\", \"f:timestamp\"])\n\nnon-blocking :)","commit_id":"c33614bc4951055edf418486a309d752b6d5dc97"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"bcabc5f8c53d6c9310dda944e10c222445eda2a4","unresolved":false,"context_lines":[{"line_number":260,"context_line":"        res_q \u003d ts_query if ts_query else None"},{"line_number":261,"context_line":""},{"line_number":262,"context_line":"    columns \u003d get_meter_columns(metaquery\u003dsample_filter.metaquery,"},{"line_number":263,"context_line":"                                need_timestamp\u003d(sample_filter.start or"},{"line_number":264,"context_line":"                                                sample_filter.end), **kwargs)"},{"line_number":265,"context_line":"    return res_q, start_row, end_row, columns"},{"line_number":266,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"baada198_9a874511","line":263,"updated":"2014-08-06 20:14:54.000000000","message":"i understand why this is done but this seems super hacky to have a random \u0027need_timestamp\u0027 param... \n\nsince columns and query are connected, it\u0027d be nice if they were actually calculated together","commit_id":"bcd4c5a0b269a049aaa124e51beb616590d59a9d"}]}