)]}'
{"ceilometer/tests/energy/test_kwapi.py":[{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"f782b4cb1fbc9dd46714cf1d47b1ac3edb2443f5","unresolved":false,"context_lines":[{"line_number":80,"context_line":""},{"line_number":81,"context_line":"class _TestPollster(_BaseTestCase):"},{"line_number":82,"context_line":"    pollster_cls \u003d kwapi.EnergyPollster"},{"line_number":83,"context_line":"    unit \u003d \u0027kwh\u0027"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    def setUp(self):"},{"line_number":86,"context_line":"        super(_TestPollster, self).setUp()"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_9c50ca5f","line":83,"updated":"2014-06-26 13:50:07.000000000","message":"would like it better if this was defined in TestEnergyPollster","commit_id":"424543dce4e5ebfffc3b898697219773e5063e11"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"de80f9a23980847ab55bccdf5ee2a0365018db12","unresolved":false,"context_lines":[{"line_number":80,"context_line":""},{"line_number":81,"context_line":"class _TestPollster(_BaseTestCase):"},{"line_number":82,"context_line":"    pollster_cls \u003d kwapi.EnergyPollster"},{"line_number":83,"context_line":"    unit \u003d \u0027kwh\u0027"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    def setUp(self):"},{"line_number":86,"context_line":"        super(_TestPollster, self).setUp()"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_4ac3bd57","line":83,"in_reply_to":"1ae5cdf2_9c50ca5f","updated":"2014-06-27 03:32:19.000000000","message":"I noticed that even the class is defined with leading \u0027_\u0027, the method test_sample is still run. So in next patchset I choose a way of hacking which is learned from neutron project","commit_id":"424543dce4e5ebfffc3b898697219773e5063e11"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"f782b4cb1fbc9dd46714cf1d47b1ac3edb2443f5","unresolved":false,"context_lines":[{"line_number":119,"context_line":""},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"class _TestPollsterCache(_BaseTestCase):"},{"line_number":122,"context_line":"    pollster_cls \u003d kwapi.EnergyPollster"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"    def test_get_samples_cached(self):"},{"line_number":125,"context_line":"        probe \u003d {\u0027id\u0027: \u0027A\u0027}"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_bc4906ba","line":122,"updated":"2014-06-26 13:50:07.000000000","message":"would like it better if this was defined in TestEnergyPollsterCache","commit_id":"424543dce4e5ebfffc3b898697219773e5063e11"},{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"7aa8e08e8207a84b544be019d32ac5491a3977e3","unresolved":false,"context_lines":[{"line_number":170,"context_line":"            self.assertEqual(probe[\u0027w\u0027], sample.volume)"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"class TestPowerPollsterCache(test.BaseTestCase):"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"    @mock.patch(\u0027ceilometer.pipeline.setup_pipeline\u0027, mock.MagicMock())"},{"line_number":176,"context_line":"    def setUp(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_51f1f2ff","side":"PARENT","line":173,"updated":"2014-07-31 08:55:52.000000000","message":"why drop this test case?","commit_id":"09720bf5248b3802cb5e08c7051669fda55984c3"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"8c7df985af772a777811bca5a5568ecf31842672","unresolved":false,"context_lines":[{"line_number":170,"context_line":"            self.assertEqual(probe[\u0027w\u0027], sample.volume)"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"class TestPowerPollsterCache(test.BaseTestCase):"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"    @mock.patch(\u0027ceilometer.pipeline.setup_pipeline\u0027, mock.MagicMock())"},{"line_number":176,"context_line":"    def setUp(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a8c0949_52cd825c","side":"PARENT","line":173,"in_reply_to":"baada198_51f1f2ff","updated":"2014-11-07 02:34:58.000000000","message":"@Lianhao Lu\n\nIt is not droped, just inherits from TestEnergyPollsterCache class, so it actually is same as current behavior","commit_id":"09720bf5248b3802cb5e08c7051669fda55984c3"},{"author":{"_account_id":3012,"name":"Dina Belova","email":"dbelova@mirantis.com","username":"dbelova"},"change_message_id":"2df69683ee120d6a9fe717e5c1c1630a5cccde5d","unresolved":false,"context_lines":[{"line_number":170,"context_line":"            self.assertEqual(probe[\u0027w\u0027], sample.volume)"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"class TestPowerPollsterCache(test.BaseTestCase):"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"    @mock.patch(\u0027ceilometer.pipeline.setup_pipeline\u0027, mock.MagicMock())"},{"line_number":176,"context_line":"    def setUp(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa98f980_c5718645","side":"PARENT","line":173,"in_reply_to":"baada198_51f1f2ff","updated":"2014-09-03 12:38:32.000000000","message":"take a look on 188 line","commit_id":"09720bf5248b3802cb5e08c7051669fda55984c3"},{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"7aa8e08e8207a84b544be019d32ac5491a3977e3","unresolved":false,"context_lines":[{"line_number":109,"context_line":"            self.assertEqual(probe[self.unit], sample.volume)"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"# Note(zqfan): not \u0027is a\u0027 relationship but a code hack"},{"line_number":113,"context_line":"class TestPowerPollster(TestEnergyPollster):"},{"line_number":114,"context_line":"    pollster_cls \u003d kwapi.PowerPollster"},{"line_number":115,"context_line":"    unit \u003d \u0027w\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_b1a7ae08","line":112,"updated":"2014-07-31 08:55:52.000000000","message":"What does this mean?","commit_id":"708fec0849e3dadd58a2a69938a72c5ea638555e"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"8c7df985af772a777811bca5a5568ecf31842672","unresolved":false,"context_lines":[{"line_number":109,"context_line":"            self.assertEqual(probe[self.unit], sample.volume)"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"# Note(zqfan): not \u0027is a\u0027 relationship but a code hack"},{"line_number":113,"context_line":"class TestPowerPollster(TestEnergyPollster):"},{"line_number":114,"context_line":"    pollster_cls \u003d kwapi.PowerPollster"},{"line_number":115,"context_line":"    unit \u003d \u0027w\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a8c0949_52910251","line":112,"in_reply_to":"baada198_b1a7ae08","updated":"2014-11-07 02:34:58.000000000","message":"@Lianhao lu\n\nYes, as Dina Belova said, TestPowerPollster inherits from TestEnergyPollster, but they are not \u0027is a\u0027 relationship,","commit_id":"708fec0849e3dadd58a2a69938a72c5ea638555e"},{"author":{"_account_id":3012,"name":"Dina Belova","email":"dbelova@mirantis.com","username":"dbelova"},"change_message_id":"2df69683ee120d6a9fe717e5c1c1630a5cccde5d","unresolved":false,"context_lines":[{"line_number":109,"context_line":"            self.assertEqual(probe[self.unit], sample.volume)"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"# Note(zqfan): not \u0027is a\u0027 relationship but a code hack"},{"line_number":113,"context_line":"class TestPowerPollster(TestEnergyPollster):"},{"line_number":114,"context_line":"    pollster_cls \u003d kwapi.PowerPollster"},{"line_number":115,"context_line":"    unit \u003d \u0027w\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa98f980_8594de43","line":112,"in_reply_to":"baada198_b1a7ae08","updated":"2014-09-03 12:38:32.000000000","message":"this is the explanation that we actually have one base test class and all other are different only because of the pollster_cls and unit set, test cases are the same actually. So that\u0027s normal","commit_id":"708fec0849e3dadd58a2a69938a72c5ea638555e"},{"author":{"_account_id":10987,"name":"Igor Degtiarov","username":"tovstun","inactive":true},"change_message_id":"350bb1f97241be454d466beae7e0c808b203efaf","unresolved":false,"context_lines":[{"line_number":84,"context_line":""},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"class TestEnergyPollster(_BaseTestCase):"},{"line_number":87,"context_line":"    pollster_cls \u003d kwapi.EnergyPollster"},{"line_number":88,"context_line":"    unit \u003d \u0027kwh\u0027"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    def setUp(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a8c0949_c28c3d38","line":87,"updated":"2014-11-07 09:11:37.000000000","message":"I don\u0027t think that line 87 with additional variable is really needed.","commit_id":"0c960dc0a2536323bf54fdc30f4ba16d675c02de"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"ffe2b95a04e6eaa90040e5147736dde6ac4e7163","unresolved":false,"context_lines":[{"line_number":84,"context_line":""},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"class TestEnergyPollster(_BaseTestCase):"},{"line_number":87,"context_line":"    pollster_cls \u003d kwapi.EnergyPollster"},{"line_number":88,"context_line":"    unit \u003d \u0027kwh\u0027"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    def setUp(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a8c0949_f5e1f5fe","line":87,"in_reply_to":"7a8c0949_c28c3d38","updated":"2014-11-07 09:36:42.000000000","message":"It should have, otherwise there will be an error, see L109. The most important is that this enables TestPowerPollster can inherit and work with only two variables assignment.","commit_id":"0c960dc0a2536323bf54fdc30f4ba16d675c02de"},{"author":{"_account_id":10987,"name":"Igor Degtiarov","username":"tovstun","inactive":true},"change_message_id":"2cdc1ba0331684d7a51ebcf3c23e63c892fd53ca","unresolved":false,"context_lines":[{"line_number":84,"context_line":""},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"class TestEnergyPollster(_BaseTestCase):"},{"line_number":87,"context_line":"    pollster_cls \u003d kwapi.EnergyPollster"},{"line_number":88,"context_line":"    unit \u003d \u0027kwh\u0027"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    def setUp(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a8c0949_55dc8912","line":87,"in_reply_to":"7a8c0949_f5e1f5fe","updated":"2014-11-07 09:48:54.000000000","message":"yes, I got it. thank you.","commit_id":"0c960dc0a2536323bf54fdc30f4ba16d675c02de"},{"author":{"_account_id":10987,"name":"Igor Degtiarov","username":"tovstun","inactive":true},"change_message_id":"350bb1f97241be454d466beae7e0c808b203efaf","unresolved":false,"context_lines":[{"line_number":119,"context_line":"            self.assertEqual(probe[self.unit], sample.volume)"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"class TestPowerPollster(TestEnergyPollster):"},{"line_number":123,"context_line":"    pollster_cls \u003d kwapi.PowerPollster"},{"line_number":124,"context_line":"    unit \u003d \u0027w\u0027"},{"line_number":125,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7a8c0949_e2369951","line":122,"updated":"2014-11-07 09:11:37.000000000","message":"could you clarify why do we need classes in tests that are not inherited and don\u0027t have tests inside?","commit_id":"0c960dc0a2536323bf54fdc30f4ba16d675c02de"},{"author":{"_account_id":10987,"name":"Igor Degtiarov","username":"tovstun","inactive":true},"change_message_id":"2cdc1ba0331684d7a51ebcf3c23e63c892fd53ca","unresolved":false,"context_lines":[{"line_number":119,"context_line":"            self.assertEqual(probe[self.unit], sample.volume)"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"class TestPowerPollster(TestEnergyPollster):"},{"line_number":123,"context_line":"    pollster_cls \u003d kwapi.PowerPollster"},{"line_number":124,"context_line":"    unit \u003d \u0027w\u0027"},{"line_number":125,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7a8c0949_f51015aa","line":122,"in_reply_to":"7a8c0949_02bba572","updated":"2014-11-07 09:48:54.000000000","message":"yes sure! It is seems I\u0027m steel sleeping :)","commit_id":"0c960dc0a2536323bf54fdc30f4ba16d675c02de"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"ffe2b95a04e6eaa90040e5147736dde6ac4e7163","unresolved":false,"context_lines":[{"line_number":119,"context_line":"            self.assertEqual(probe[self.unit], sample.volume)"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"class TestPowerPollster(TestEnergyPollster):"},{"line_number":123,"context_line":"    pollster_cls \u003d kwapi.PowerPollster"},{"line_number":124,"context_line":"    unit \u003d \u0027w\u0027"},{"line_number":125,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7a8c0949_02bba572","line":122,"in_reply_to":"7a8c0949_e2369951","updated":"2014-11-07 09:36:42.000000000","message":"Ah, it is a bit hard to to me to meet everyone.. Please see patch set 3\u0027s comment\n\nYes, the two classes are not a strict \u0027is a\u0027 relationship, it is just a code hack.\n\nIt definitely has tests, it is a subclass of another test class! You can verify it in you local environment, just run `tox -epy27 -- tests.energy.test_kwapi`, it has only 7 tests before and after this change, you will see the power pollster test case in the list.","commit_id":"0c960dc0a2536323bf54fdc30f4ba16d675c02de"}]}