)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"7726f7879b3fdcf2b78b3a7293c7eec391d8b36e","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix SQL exception getting statitics with metaquery"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In the scenario with mysql as storage backend, when getting statistics"},{"line_number":10,"context_line":"with metaquery, sqlalchemy will raise an exception of \"Unknown column"},{"line_number":11,"context_line":"\u0027sample.id\u0027 in \u0027on clause\", this is because of a wrong usage of JOIN"},{"line_number":12,"context_line":"clause."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"dab895d6_a717c950","line":9,"updated":"2014-06-30 06:33:07.000000000","message":"how about add a new unit test for this bug in ceilometer/tests/api/v2/test_statistics_scenarios.py?","commit_id":"22a258f033c003b445eb24183db3ecba48d3ec31"},{"author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"change_message_id":"a18e24fa88dcc2148dc8cb8239e263ee8ca4d27f","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix SQL exception getting statitics with metaquery"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In the scenario with mysql as storage backend, when getting statistics"},{"line_number":10,"context_line":"with metaquery, sqlalchemy will raise an exception of \"Unknown column"},{"line_number":11,"context_line":"\u0027sample.id\u0027 in \u0027on clause\", this is because of a wrong usage of JOIN"},{"line_number":12,"context_line":"clause."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"dab895d6_cdb5bbce","line":9,"in_reply_to":"dab895d6_a717c950","updated":"2014-06-30 08:07:44.000000000","message":"@ZhiQiang Fan, It seems a bit difficult to write the relevant tests.this change modify the code which accordingly modify the SQL statements (according to:http://stackoverflow.com/questions/2820724/mysql-5-left-join-unknown-column), but I cannot find a good way to test the changes of SQL statements .","commit_id":"22a258f033c003b445eb24183db3ecba48d3ec31"},{"author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"change_message_id":"791cc1e380767bf3ac4a473936ecebfdf7c66c95","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix SQL exception getting statitics with metaquery"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In the scenario with mysql as storage backend, when getting statistics"},{"line_number":10,"context_line":"with metaquery, sqlalchemy will raise an exception of \"Unknown column"},{"line_number":11,"context_line":"\u0027sample.id\u0027 in \u0027on clause\", this is because of a wrong usage of JOIN"},{"line_number":12,"context_line":"clause."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"dab895d6_c7403c59","line":9,"in_reply_to":"dab895d6_a717c950","updated":"2014-06-30 07:05:21.000000000","message":"thanks, yeah I am planing try to add a test :)","commit_id":"22a258f033c003b445eb24183db3ecba48d3ec31"},{"author":{"_account_id":3012,"name":"Dina Belova","email":"dbelova@mirantis.com","username":"dbelova"},"change_message_id":"14d73d205e66e2238e86bc7041f90d1d62f7a0d6","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In the scenario with mysql as storage backend, when getting statistics"},{"line_number":10,"context_line":"with metaquery, sqlalchemy will raise an exception of \"Unknown column"},{"line_number":11,"context_line":"\u0027sample.id\u0027 in \u0027on clause\", this is because of a wrong usage of JOIN"},{"line_number":12,"context_line":"clause."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I6f140952082ab245f27d576ee9629a086104f8b1"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"baada198_b2156241","line":11,"updated":"2014-07-08 02:27:43.000000000","message":"just a nit: you seem to miss one \u0027 symbol -\n\n\u0027on clause\" -\u003e \u0027on_clause\u0027 \"","commit_id":"22a258f033c003b445eb24183db3ecba48d3ec31"},{"author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"change_message_id":"e560091c4eba8d55478b7f6fbaa8c7957bfa0296","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In the scenario with mysql as storage backend, when getting statistics"},{"line_number":10,"context_line":"with metaquery, sqlalchemy will raise an exception of \"Unknown column"},{"line_number":11,"context_line":"\u0027sample.id\u0027 in \u0027on clause\", this is because of a wrong usage of JOIN"},{"line_number":12,"context_line":"clause."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I6f140952082ab245f27d576ee9629a086104f8b1"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"baada198_9b04c8c7","line":11,"in_reply_to":"baada198_b2156241","updated":"2014-07-09 09:13:25.000000000","message":"thanks, Done :)","commit_id":"22a258f033c003b445eb24183db3ecba48d3ec31"}]}