)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"3a7a790a34c4487265b27f16760a805db23edeee","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix H307 violations and re-enable gating"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"H307 got stricter in hacking 0.9, so fix new violations and"},{"line_number":11,"context_line":"re-enable gating."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"1ae5cdf2_67dd14dd","line":9,"updated":"2014-06-27 02:55:18.000000000","message":"nit: no need two blank lines","commit_id":"045772db76fad9342a90e7c2a3437e20659545be"},{"author":{"_account_id":10987,"name":"Igor Degtiarov","username":"tovstun","inactive":true},"change_message_id":"5e84b3f9537425e69f2d712bdc2019df1ce1d743","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix H307 violations and re-enable gating"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"H307 got stricter in hacking 0.9, so fix new violations and"},{"line_number":11,"context_line":"re-enable gating."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"1ae5cdf2_00d7d1bf","line":9,"in_reply_to":"1ae5cdf2_67dd14dd","updated":"2014-06-27 08:46:27.000000000","message":"Done","commit_id":"045772db76fad9342a90e7c2a3437e20659545be"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"3a7a790a34c4487265b27f16760a805db23edeee","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix H307 violations and re-enable gating"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"H307 got stricter in hacking 0.9, so fix new violations and"},{"line_number":11,"context_line":"re-enable gating."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I805d10427ebeaee36589936f77a2cf0932c1378e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"1ae5cdf2_a7f2bc6c","line":10,"updated":"2014-06-27 02:55:18.000000000","message":"nit: actually, h307 is a new rule, be careful when C\u0026P","commit_id":"045772db76fad9342a90e7c2a3437e20659545be"},{"author":{"_account_id":10987,"name":"Igor Degtiarov","username":"tovstun","inactive":true},"change_message_id":"5e84b3f9537425e69f2d712bdc2019df1ce1d743","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix H307 violations and re-enable gating"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"H307 got stricter in hacking 0.9, so fix new violations and"},{"line_number":11,"context_line":"re-enable gating."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I805d10427ebeaee36589936f77a2cf0932c1378e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"1ae5cdf2_80f2016d","line":10,"in_reply_to":"1ae5cdf2_a7f2bc6c","updated":"2014-06-27 08:46:27.000000000","message":"Thanks, I will! Changed.","commit_id":"045772db76fad9342a90e7c2a3437e20659545be"}],"ceilometer/alarm/notifier/rest.py":[{"author":{"_account_id":3012,"name":"Dina Belova","email":"dbelova@mirantis.com","username":"dbelova"},"change_message_id":"76a610fc168a662dcc5b303ac57b3a110a8732f1","unresolved":false,"context_lines":[{"line_number":25,"context_line":"from ceilometer.openstack.common import jsonutils"},{"line_number":26,"context_line":"from ceilometer.openstack.common import log"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"from oslo.config import cfg"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"LOG \u003d log.getLogger(__name__)"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_99180a20","line":28,"updated":"2014-06-25 13:28:27.000000000","message":"it should be ok to leave this as is - oslo.config is requirement stuff","commit_id":"0e5017fc2de8982b30ae1280f8693864094a953d"},{"author":{"_account_id":10987,"name":"Igor Degtiarov","username":"tovstun","inactive":true},"change_message_id":"916a16b4a2f703935c610e040f92f04d726ebfca","unresolved":false,"context_lines":[{"line_number":25,"context_line":"from ceilometer.openstack.common import jsonutils"},{"line_number":26,"context_line":"from ceilometer.openstack.common import log"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"from oslo.config import cfg"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"LOG \u003d log.getLogger(__name__)"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_99048a19","line":28,"in_reply_to":"1ae5cdf2_19e79aad","updated":"2014-06-25 13:55:18.000000000","message":"Done","commit_id":"0e5017fc2de8982b30ae1280f8693864094a953d"},{"author":{"_account_id":3012,"name":"Dina Belova","email":"dbelova@mirantis.com","username":"dbelova"},"change_message_id":"50570cf126bfb448fc69edb90a2a4a4d1dff6ccb","unresolved":false,"context_lines":[{"line_number":25,"context_line":"from ceilometer.openstack.common import jsonutils"},{"line_number":26,"context_line":"from ceilometer.openstack.common import log"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"from oslo.config import cfg"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"LOG \u003d log.getLogger(__name__)"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_19e79aad","line":28,"in_reply_to":"1ae5cdf2_99180a20","updated":"2014-06-25 13:30:05.000000000","message":"also move six to the 2nd group","commit_id":"0e5017fc2de8982b30ae1280f8693864094a953d"}],"ceilometer/cli.py":[{"author":{"_account_id":3012,"name":"Dina Belova","email":"dbelova@mirantis.com","username":"dbelova"},"change_message_id":"76a610fc168a662dcc5b303ac57b3a110a8732f1","unresolved":false,"context_lines":[{"line_number":44,"context_line":"from ceilometer import storage"},{"line_number":45,"context_line":"from ceilometer import transformer"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"from oslo.config import cfg"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"OPTS \u003d ["},{"line_number":50,"context_line":"    cfg.StrOpt(\u0027evaluation_service\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_d99ff263","line":47,"updated":"2014-06-25 13:28:27.000000000","message":"ditto previous file","commit_id":"0e5017fc2de8982b30ae1280f8693864094a953d"},{"author":{"_account_id":10987,"name":"Igor Degtiarov","username":"tovstun","inactive":true},"change_message_id":"916a16b4a2f703935c610e040f92f04d726ebfca","unresolved":false,"context_lines":[{"line_number":44,"context_line":"from ceilometer import storage"},{"line_number":45,"context_line":"from ceilometer import transformer"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"from oslo.config import cfg"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"OPTS \u003d ["},{"line_number":50,"context_line":"    cfg.StrOpt(\u0027evaluation_service\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_f424b5b3","line":47,"in_reply_to":"1ae5cdf2_d99ff263","updated":"2014-06-25 13:55:18.000000000","message":"Done","commit_id":"0e5017fc2de8982b30ae1280f8693864094a953d"},{"author":{"_account_id":3012,"name":"Dina Belova","email":"dbelova@mirantis.com","username":"dbelova"},"change_message_id":"4e9aad8f8e36e729754e718a47ac9b9388253cf7","unresolved":false,"context_lines":[{"line_number":27,"context_line":"eventlet.monkey_patch(socket\u003dTrue, select\u003dTrue, thread\u003dTrue)"},{"line_number":28,"context_line":"import logging"},{"line_number":29,"context_line":"from oslo.config import cfg"},{"line_number":30,"context_line":"import sys"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"from ceilometer.alarm import service as alarm_service"},{"line_number":33,"context_line":"from ceilometer.api import app"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_4fdf943a","line":30,"updated":"2014-06-25 14:12:16.000000000","message":"sys and logging are built-in","commit_id":"978cadec199ae2c81b2332e06f101ea8d9c3b445"},{"author":{"_account_id":10987,"name":"Igor Degtiarov","username":"tovstun","inactive":true},"change_message_id":"6da2d4137d25180c5ab9827917aad645ddd07326","unresolved":false,"context_lines":[{"line_number":27,"context_line":"eventlet.monkey_patch(socket\u003dTrue, select\u003dTrue, thread\u003dTrue)"},{"line_number":28,"context_line":"import logging"},{"line_number":29,"context_line":"from oslo.config import cfg"},{"line_number":30,"context_line":"import sys"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"from ceilometer.alarm import service as alarm_service"},{"line_number":33,"context_line":"from ceilometer.api import app"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_4fe954b6","line":30,"in_reply_to":"1ae5cdf2_4fdf943a","updated":"2014-06-25 14:17:04.000000000","message":"Done","commit_id":"978cadec199ae2c81b2332e06f101ea8d9c3b445"}],"ceilometer/compute/nova_notifier.py":[{"author":{"_account_id":3012,"name":"Dina Belova","email":"dbelova@mirantis.com","username":"dbelova"},"change_message_id":"76a610fc168a662dcc5b303ac57b3a110a8732f1","unresolved":false,"context_lines":[{"line_number":24,"context_line":"for name in [\u0027openstack\u0027, \u0027openstack.common\u0027, \u0027openstack.common.log\u0027]:"},{"line_number":25,"context_line":"    sys.modules[\u0027ceilometer.\u0027 + name] \u003d sys.modules[\u0027nova.\u0027 + name]"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"from ceilometer.compute.virt import inspector"},{"line_number":28,"context_line":"from ceilometer.openstack.common.gettextutils import _"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"from nova.compute import flavors"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_19987a69","line":27,"updated":"2014-06-25 13:28:27.000000000","message":"wrong order of the groups - ceilometer group should be the last one","commit_id":"0e5017fc2de8982b30ae1280f8693864094a953d"},{"author":{"_account_id":10987,"name":"Igor Degtiarov","username":"tovstun","inactive":true},"change_message_id":"916a16b4a2f703935c610e040f92f04d726ebfca","unresolved":false,"context_lines":[{"line_number":24,"context_line":"for name in [\u0027openstack\u0027, \u0027openstack.common\u0027, \u0027openstack.common.log\u0027]:"},{"line_number":25,"context_line":"    sys.modules[\u0027ceilometer.\u0027 + name] \u003d sys.modules[\u0027nova.\u0027 + name]"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"from ceilometer.compute.virt import inspector"},{"line_number":28,"context_line":"from ceilometer.openstack.common.gettextutils import _"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"from nova.compute import flavors"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_34c9bdac","line":27,"in_reply_to":"1ae5cdf2_19987a69","updated":"2014-06-25 13:55:18.000000000","message":"Done","commit_id":"0e5017fc2de8982b30ae1280f8693864094a953d"},{"author":{"_account_id":3012,"name":"Dina Belova","email":"dbelova@mirantis.com","username":"dbelova"},"change_message_id":"4e9aad8f8e36e729754e718a47ac9b9388253cf7","unresolved":false,"context_lines":[{"line_number":19,"context_line":"# sys.modules as though it was the copy from ceilometer, so that when"},{"line_number":20,"context_line":"# we use modules from ceilometer below they do not re-define options."},{"line_number":21,"context_line":"# use the real ceilometer base package import ceilometer nova"},{"line_number":22,"context_line":"import sys"},{"line_number":23,"context_line":"for name in [\u0027openstack\u0027, \u0027openstack.common\u0027, \u0027openstack.common.log\u0027]:"},{"line_number":24,"context_line":"    sys.modules[\u0027ceilometer.\u0027 + name] \u003d sys.modules[\u0027nova.\u0027 + name]"},{"line_number":25,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_efb860ea","line":22,"updated":"2014-06-25 14:12:16.000000000","message":"some extra line between the import and its usage will be good","commit_id":"978cadec199ae2c81b2332e06f101ea8d9c3b445"},{"author":{"_account_id":10987,"name":"Igor Degtiarov","username":"tovstun","inactive":true},"change_message_id":"6da2d4137d25180c5ab9827917aad645ddd07326","unresolved":false,"context_lines":[{"line_number":19,"context_line":"# sys.modules as though it was the copy from ceilometer, so that when"},{"line_number":20,"context_line":"# we use modules from ceilometer below they do not re-define options."},{"line_number":21,"context_line":"# use the real ceilometer base package import ceilometer nova"},{"line_number":22,"context_line":"import sys"},{"line_number":23,"context_line":"for name in [\u0027openstack\u0027, \u0027openstack.common\u0027, \u0027openstack.common.log\u0027]:"},{"line_number":24,"context_line":"    sys.modules[\u0027ceilometer.\u0027 + name] \u003d sys.modules[\u0027nova.\u0027 + name]"},{"line_number":25,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_ef022071","line":22,"in_reply_to":"1ae5cdf2_efb860ea","updated":"2014-06-25 14:17:04.000000000","message":"Done","commit_id":"978cadec199ae2c81b2332e06f101ea8d9c3b445"},{"author":{"_account_id":3012,"name":"Dina Belova","email":"dbelova@mirantis.com","username":"dbelova"},"change_message_id":"8e5a13ded51d3449df1c124bf3703241ae48451f","unresolved":false,"context_lines":[{"line_number":25,"context_line":"# sys.modules as though it was the copy from ceilometer, so that when"},{"line_number":26,"context_line":"# we use modules from ceilometer below they do not re-define options."},{"line_number":27,"context_line":"# use the real ceilometer base package"},{"line_number":28,"context_line":"import ceilometer  # noqa"},{"line_number":29,"context_line":"for name in [\u0027openstack\u0027, \u0027openstack.common\u0027, \u0027openstack.common.log\u0027]:"},{"line_number":30,"context_line":"    sys.modules[\u0027ceilometer.\u0027 + name] \u003d sys.modules[\u0027nova.\u0027 + name]"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1ae5cdf2_e3e85818","side":"PARENT","line":28,"updated":"2014-06-26 09:21:49.000000000","message":"please return back this import, it\u0027s needed","commit_id":"a440759d40902edeee8590e20ff04efa8892f858"},{"author":{"_account_id":10987,"name":"Igor Degtiarov","username":"tovstun","inactive":true},"change_message_id":"323dfc1efc73c7e3face9723c5ef851070952e6a","unresolved":false,"context_lines":[{"line_number":25,"context_line":"# sys.modules as though it was the copy from ceilometer, so that when"},{"line_number":26,"context_line":"# we use modules from ceilometer below they do not re-define options."},{"line_number":27,"context_line":"# use the real ceilometer base package"},{"line_number":28,"context_line":"import ceilometer  # noqa"},{"line_number":29,"context_line":"for name in [\u0027openstack\u0027, \u0027openstack.common\u0027, \u0027openstack.common.log\u0027]:"},{"line_number":30,"context_line":"    sys.modules[\u0027ceilometer.\u0027 + name] \u003d sys.modules[\u0027nova.\u0027 + name]"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1ae5cdf2_83c6b447","side":"PARENT","line":28,"in_reply_to":"1ae5cdf2_e3e85818","updated":"2014-06-26 09:31:34.000000000","message":"Done","commit_id":"a440759d40902edeee8590e20ff04efa8892f858"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"3a7a790a34c4487265b27f16760a805db23edeee","unresolved":false,"context_lines":[{"line_number":15,"context_line":"# License for the specific language governing permissions and limitations"},{"line_number":16,"context_line":"# under the License."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"import sys"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"for name in [\u0027openstack\u0027, \u0027openstack.common\u0027, \u0027openstack.common.log\u0027]:"}],"source_content_type":"text/x-python","patch_set":6,"id":"1ae5cdf2_6750b42c","line":18,"updated":"2014-06-27 02:55:18.000000000","message":"nit: no need add extra blank line","commit_id":"045772db76fad9342a90e7c2a3437e20659545be"},{"author":{"_account_id":10987,"name":"Igor Degtiarov","username":"tovstun","inactive":true},"change_message_id":"5e84b3f9537425e69f2d712bdc2019df1ce1d743","unresolved":false,"context_lines":[{"line_number":15,"context_line":"# License for the specific language governing permissions and limitations"},{"line_number":16,"context_line":"# under the License."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"import sys"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"for name in [\u0027openstack\u0027, \u0027openstack.common\u0027, \u0027openstack.common.log\u0027]:"}],"source_content_type":"text/x-python","patch_set":6,"id":"1ae5cdf2_8064c149","line":18,"in_reply_to":"1ae5cdf2_6750b42c","updated":"2014-06-27 08:46:27.000000000","message":"Done","commit_id":"045772db76fad9342a90e7c2a3437e20659545be"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"3a7a790a34c4487265b27f16760a805db23edeee","unresolved":false,"context_lines":[{"line_number":19,"context_line":"import sys"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"for name in [\u0027openstack\u0027, \u0027openstack.common\u0027, \u0027openstack.common.log\u0027]:"},{"line_number":22,"context_line":"    sys.modules[\u0027ceilometer.\u0027 + name] \u003d sys.modules[\u0027nova.\u0027 + name]"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"from nova.compute import flavors"},{"line_number":25,"context_line":"from nova import conductor"}],"source_content_type":"text/x-python","patch_set":6,"id":"1ae5cdf2_aa51a10f","line":22,"updated":"2014-06-27 02:55:18.000000000","message":"-1: I think this is not the right place to put such statements, maybe it should behind all import groups","commit_id":"045772db76fad9342a90e7c2a3437e20659545be"},{"author":{"_account_id":10987,"name":"Igor Degtiarov","username":"tovstun","inactive":true},"change_message_id":"5e84b3f9537425e69f2d712bdc2019df1ce1d743","unresolved":false,"context_lines":[{"line_number":19,"context_line":"import sys"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"for name in [\u0027openstack\u0027, \u0027openstack.common\u0027, \u0027openstack.common.log\u0027]:"},{"line_number":22,"context_line":"    sys.modules[\u0027ceilometer.\u0027 + name] \u003d sys.modules[\u0027nova.\u0027 + name]"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"from nova.compute import flavors"},{"line_number":25,"context_line":"from nova import conductor"}],"source_content_type":"text/x-python","patch_set":6,"id":"1ae5cdf2_605fb575","line":22,"in_reply_to":"1ae5cdf2_aa51a10f","updated":"2014-06-27 08:46:27.000000000","message":"Done","commit_id":"045772db76fad9342a90e7c2a3437e20659545be"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"3a7a790a34c4487265b27f16760a805db23edeee","unresolved":false,"context_lines":[{"line_number":32,"context_line":"# HACK(dhellmann): Insert the nova version of openstack.common into"},{"line_number":33,"context_line":"# sys.modules as though it was the copy from ceilometer, so that when"},{"line_number":34,"context_line":"# we use modules from ceilometer below they do not re-define options."},{"line_number":35,"context_line":"# use the real ceilometer base package"},{"line_number":36,"context_line":"import ceilometer  # noqa"},{"line_number":37,"context_line":"from ceilometer.compute.virt import inspector"},{"line_number":38,"context_line":"from ceilometer.openstack.common.gettextutils import _"}],"source_content_type":"text/x-python","patch_set":6,"id":"1ae5cdf2_87306008","line":35,"updated":"2014-06-27 02:55:18.000000000","message":"-1: please read this comment, it is very tight to L21","commit_id":"045772db76fad9342a90e7c2a3437e20659545be"},{"author":{"_account_id":10987,"name":"Igor Degtiarov","username":"tovstun","inactive":true},"change_message_id":"5e84b3f9537425e69f2d712bdc2019df1ce1d743","unresolved":false,"context_lines":[{"line_number":32,"context_line":"# HACK(dhellmann): Insert the nova version of openstack.common into"},{"line_number":33,"context_line":"# sys.modules as though it was the copy from ceilometer, so that when"},{"line_number":34,"context_line":"# we use modules from ceilometer below they do not re-define options."},{"line_number":35,"context_line":"# use the real ceilometer base package"},{"line_number":36,"context_line":"import ceilometer  # noqa"},{"line_number":37,"context_line":"from ceilometer.compute.virt import inspector"},{"line_number":38,"context_line":"from ceilometer.openstack.common.gettextutils import _"}],"source_content_type":"text/x-python","patch_set":6,"id":"1ae5cdf2_a0553d53","line":35,"in_reply_to":"1ae5cdf2_87306008","updated":"2014-06-27 08:46:27.000000000","message":"Done","commit_id":"045772db76fad9342a90e7c2a3437e20659545be"}],"ceilometer/dispatcher/__init__.py":[{"author":{"_account_id":3012,"name":"Dina Belova","email":"dbelova@mirantis.com","username":"dbelova"},"change_message_id":"76a610fc168a662dcc5b303ac57b3a110a8732f1","unresolved":false,"context_lines":[{"line_number":21,"context_line":"from ceilometer.openstack.common.gettextutils import _"},{"line_number":22,"context_line":"from ceilometer.openstack.common import log"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"from oslo.config import cfg"},{"line_number":25,"context_line":"from stevedore import named"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_59a12294","line":24,"updated":"2014-06-25 13:28:27.000000000","message":"wrong order of the groups - ceilo group should be the last","commit_id":"0e5017fc2de8982b30ae1280f8693864094a953d"},{"author":{"_account_id":10987,"name":"Igor Degtiarov","username":"tovstun","inactive":true},"change_message_id":"916a16b4a2f703935c610e040f92f04d726ebfca","unresolved":false,"context_lines":[{"line_number":21,"context_line":"from ceilometer.openstack.common.gettextutils import _"},{"line_number":22,"context_line":"from ceilometer.openstack.common import log"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"from oslo.config import cfg"},{"line_number":25,"context_line":"from stevedore import named"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_5443a912","line":24,"in_reply_to":"1ae5cdf2_59a12294","updated":"2014-06-25 13:55:18.000000000","message":"Done","commit_id":"0e5017fc2de8982b30ae1280f8693864094a953d"}],"ceilometer/notifier.py":[{"author":{"_account_id":3012,"name":"Dina Belova","email":"dbelova@mirantis.com","username":"dbelova"},"change_message_id":"76a610fc168a662dcc5b303ac57b3a110a8732f1","unresolved":false,"context_lines":[{"line_number":19,"context_line":"from ceilometer.openstack.common.gettextutils import _"},{"line_number":20,"context_line":"from ceilometer.openstack.common import log as logging"},{"line_number":21,"context_line":"from ceilometer import pipeline"},{"line_number":22,"context_line":"from ceilometer import transformer"},{"line_number":23,"context_line":"from stevedore import extension"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_d9b452d6","line":22,"updated":"2014-06-25 13:28:27.000000000","message":"wrong order of the groups - ceilo group should be the last","commit_id":"0e5017fc2de8982b30ae1280f8693864094a953d"},{"author":{"_account_id":10987,"name":"Igor Degtiarov","username":"tovstun","inactive":true},"change_message_id":"916a16b4a2f703935c610e040f92f04d726ebfca","unresolved":false,"context_lines":[{"line_number":19,"context_line":"from ceilometer.openstack.common.gettextutils import _"},{"line_number":20,"context_line":"from ceilometer.openstack.common import log as logging"},{"line_number":21,"context_line":"from ceilometer import pipeline"},{"line_number":22,"context_line":"from ceilometer import transformer"},{"line_number":23,"context_line":"from stevedore import extension"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_54df293a","line":22,"in_reply_to":"1ae5cdf2_d9b452d6","updated":"2014-06-25 13:55:18.000000000","message":"Done","commit_id":"0e5017fc2de8982b30ae1280f8693864094a953d"}],"ceilometer/storage/impl_mongodb.py":[{"author":{"_account_id":3012,"name":"Dina Belova","email":"dbelova@mirantis.com","username":"dbelova"},"change_message_id":"4e9aad8f8e36e729754e718a47ac9b9388253cf7","unresolved":false,"context_lines":[{"line_number":21,"context_line":"\"\"\"MongoDB storage backend\"\"\""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"import bson.code"},{"line_number":24,"context_line":"import bson.objectid"},{"line_number":25,"context_line":"import calendar"},{"line_number":26,"context_line":"import copy"},{"line_number":27,"context_line":"import datetime"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_8f8efc30","line":24,"updated":"2014-06-25 14:12:16.000000000","message":"bson is sub-module of the pymongo, keep in in the 2nd group","commit_id":"978cadec199ae2c81b2332e06f101ea8d9c3b445"},{"author":{"_account_id":10987,"name":"Igor Degtiarov","username":"tovstun","inactive":true},"change_message_id":"6da2d4137d25180c5ab9827917aad645ddd07326","unresolved":false,"context_lines":[{"line_number":21,"context_line":"\"\"\"MongoDB storage backend\"\"\""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"import bson.code"},{"line_number":24,"context_line":"import bson.objectid"},{"line_number":25,"context_line":"import calendar"},{"line_number":26,"context_line":"import copy"},{"line_number":27,"context_line":"import datetime"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_8f66fc53","line":24,"in_reply_to":"1ae5cdf2_8f8efc30","updated":"2014-06-25 14:17:04.000000000","message":"Done","commit_id":"978cadec199ae2c81b2332e06f101ea8d9c3b445"}],"ceilometer/tests/alarm/test_singleton_alarm_svc.py":[{"author":{"_account_id":3012,"name":"Dina Belova","email":"dbelova@mirantis.com","username":"dbelova"},"change_message_id":"76a610fc168a662dcc5b303ac57b3a110a8732f1","unresolved":false,"context_lines":[{"line_number":16,"context_line":"# under the License."},{"line_number":17,"context_line":"\"\"\"Tests for ceilometer.alarm.service.SingletonAlarmService."},{"line_number":18,"context_line":"\"\"\""},{"line_number":19,"context_line":"import mock"},{"line_number":20,"context_line":"from stevedore import extension"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from ceilometer.alarm import service"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_d9db721f","line":19,"updated":"2014-06-25 13:28:27.000000000","message":"mock is a built-in lib, leave this file as is","commit_id":"0e5017fc2de8982b30ae1280f8693864094a953d"},{"author":{"_account_id":3012,"name":"Dina Belova","email":"dbelova@mirantis.com","username":"dbelova"},"change_message_id":"be66dd43dd238d11dfa59363fbbd616935538384","unresolved":false,"context_lines":[{"line_number":16,"context_line":"# under the License."},{"line_number":17,"context_line":"\"\"\"Tests for ceilometer.alarm.service.SingletonAlarmService."},{"line_number":18,"context_line":"\"\"\""},{"line_number":19,"context_line":"import mock"},{"line_number":20,"context_line":"from stevedore import extension"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from ceilometer.alarm import service"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_d47a59b9","line":19,"in_reply_to":"1ae5cdf2_34aa9d85","updated":"2014-06-25 13:57:29.000000000","message":"yes, sorry, lost my mind","commit_id":"0e5017fc2de8982b30ae1280f8693864094a953d"},{"author":{"_account_id":10987,"name":"Igor Degtiarov","username":"tovstun","inactive":true},"change_message_id":"916a16b4a2f703935c610e040f92f04d726ebfca","unresolved":false,"context_lines":[{"line_number":16,"context_line":"# under the License."},{"line_number":17,"context_line":"\"\"\"Tests for ceilometer.alarm.service.SingletonAlarmService."},{"line_number":18,"context_line":"\"\"\""},{"line_number":19,"context_line":"import mock"},{"line_number":20,"context_line":"from stevedore import extension"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from ceilometer.alarm import service"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_34aa9d85","line":19,"in_reply_to":"1ae5cdf2_d9db721f","updated":"2014-06-25 13:55:18.000000000","message":"mock is required lib that is mentioned in test_requirement.txt so it should to be changed","commit_id":"0e5017fc2de8982b30ae1280f8693864094a953d"}],"ceilometer/tests/compute/virt/vmware/test_inspector.py":[{"author":{"_account_id":3012,"name":"Dina Belova","email":"dbelova@mirantis.com","username":"dbelova"},"change_message_id":"76a610fc168a662dcc5b303ac57b3a110a8732f1","unresolved":false,"context_lines":[{"line_number":16,"context_line":"Tests for VMware Vsphere inspector."},{"line_number":17,"context_line":"\"\"\""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"import mock"},{"line_number":20,"context_line":"from oslo.vmware import api"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from ceilometer.compute.virt import inspector as virt_inspector"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_39e9b6b7","line":19,"updated":"2014-06-25 13:28:27.000000000","message":"ditto - mock is built-in","commit_id":"0e5017fc2de8982b30ae1280f8693864094a953d"},{"author":{"_account_id":10987,"name":"Igor Degtiarov","username":"tovstun","inactive":true},"change_message_id":"916a16b4a2f703935c610e040f92f04d726ebfca","unresolved":false,"context_lines":[{"line_number":16,"context_line":"Tests for VMware Vsphere inspector."},{"line_number":17,"context_line":"\"\"\""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"import mock"},{"line_number":20,"context_line":"from oslo.vmware import api"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from ceilometer.compute.virt import inspector as virt_inspector"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_14068185","line":19,"in_reply_to":"1ae5cdf2_39e9b6b7","updated":"2014-06-25 13:55:18.000000000","message":"answered earlier :)","commit_id":"0e5017fc2de8982b30ae1280f8693864094a953d"}],"ceilometer/tests/event/test_endpoint.py":[{"author":{"_account_id":3012,"name":"Dina Belova","email":"dbelova@mirantis.com","username":"dbelova"},"change_message_id":"76a610fc168a662dcc5b303ac57b3a110a8732f1","unresolved":false,"context_lines":[{"line_number":16,"context_line":"# under the License."},{"line_number":17,"context_line":"\"\"\"Tests for Ceilometer notify daemon.\"\"\""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"import mock"},{"line_number":20,"context_line":"from oslo.config import cfg"},{"line_number":21,"context_line":"import oslo.messaging"},{"line_number":22,"context_line":"from stevedore import extension"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_79ca5e47","line":19,"updated":"2014-06-25 13:28:27.000000000","message":"ditto","commit_id":"0e5017fc2de8982b30ae1280f8693864094a953d"},{"author":{"_account_id":10987,"name":"Igor Degtiarov","username":"tovstun","inactive":true},"change_message_id":"916a16b4a2f703935c610e040f92f04d726ebfca","unresolved":false,"context_lines":[{"line_number":16,"context_line":"# under the License."},{"line_number":17,"context_line":"\"\"\"Tests for Ceilometer notify daemon.\"\"\""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"import mock"},{"line_number":20,"context_line":"from oslo.config import cfg"},{"line_number":21,"context_line":"import oslo.messaging"},{"line_number":22,"context_line":"from stevedore import extension"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_94f1b198","line":19,"in_reply_to":"1ae5cdf2_79ca5e47","updated":"2014-06-25 13:55:18.000000000","message":"answered earlier!","commit_id":"0e5017fc2de8982b30ae1280f8693864094a953d"}],"ceilometer/tests/network/statistics/opendaylight/test_client.py":[{"author":{"_account_id":3012,"name":"Dina Belova","email":"dbelova@mirantis.com","username":"dbelova"},"change_message_id":"76a610fc168a662dcc5b303ac57b3a110a8732f1","unresolved":false,"context_lines":[{"line_number":12,"context_line":"# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":13,"context_line":"# License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"# under the License."},{"line_number":15,"context_line":"import mock"},{"line_number":16,"context_line":"from requests import auth as req_auth"},{"line_number":17,"context_line":"import six"},{"line_number":18,"context_line":"from six.moves.urllib import parse as url_parse"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_b9d4e6e9","line":15,"updated":"2014-06-25 13:28:27.000000000","message":"ditto","commit_id":"0e5017fc2de8982b30ae1280f8693864094a953d"},{"author":{"_account_id":10987,"name":"Igor Degtiarov","username":"tovstun","inactive":true},"change_message_id":"916a16b4a2f703935c610e040f92f04d726ebfca","unresolved":false,"context_lines":[{"line_number":12,"context_line":"# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":13,"context_line":"# License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"# under the License."},{"line_number":15,"context_line":"import mock"},{"line_number":16,"context_line":"from requests import auth as req_auth"},{"line_number":17,"context_line":"import six"},{"line_number":18,"context_line":"from six.moves.urllib import parse as url_parse"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_142da1fd","line":15,"in_reply_to":"1ae5cdf2_b9d4e6e9","updated":"2014-06-25 13:55:18.000000000","message":"answered earlier!","commit_id":"0e5017fc2de8982b30ae1280f8693864094a953d"}],"ceilometer/tests/network/statistics/opendaylight/test_driver.py":[{"author":{"_account_id":3012,"name":"Dina Belova","email":"dbelova@mirantis.com","username":"dbelova"},"change_message_id":"76a610fc168a662dcc5b303ac57b3a110a8732f1","unresolved":false,"context_lines":[{"line_number":13,"context_line":"# License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"# under the License."},{"line_number":15,"context_line":"import abc"},{"line_number":16,"context_line":"import mock"},{"line_number":17,"context_line":"import six"},{"line_number":18,"context_line":"from six import moves"},{"line_number":19,"context_line":"from six.moves.urllib import parse as url_parse"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_b9eb06a3","line":16,"updated":"2014-06-25 13:28:27.000000000","message":"ditto - leave a is, abc and mock are built-in, six is 3rd party","commit_id":"0e5017fc2de8982b30ae1280f8693864094a953d"},{"author":{"_account_id":10987,"name":"Igor Degtiarov","username":"tovstun","inactive":true},"change_message_id":"916a16b4a2f703935c610e040f92f04d726ebfca","unresolved":false,"context_lines":[{"line_number":13,"context_line":"# License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"# under the License."},{"line_number":15,"context_line":"import abc"},{"line_number":16,"context_line":"import mock"},{"line_number":17,"context_line":"import six"},{"line_number":18,"context_line":"from six import moves"},{"line_number":19,"context_line":"from six.moves.urllib import parse as url_parse"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_d44259aa","line":16,"in_reply_to":"1ae5cdf2_b9eb06a3","updated":"2014-06-25 13:55:18.000000000","message":"abc moved to first group","commit_id":"0e5017fc2de8982b30ae1280f8693864094a953d"}],"ceilometer/tests/objectstore/test_swift_middleware.py":[{"author":{"_account_id":3012,"name":"Dina Belova","email":"dbelova@mirantis.com","username":"dbelova"},"change_message_id":"76a610fc168a662dcc5b303ac57b3a110a8732f1","unresolved":false,"context_lines":[{"line_number":16,"context_line":"# License for the specific language governing permissions and limitations"},{"line_number":17,"context_line":"# under the License."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"import mock"},{"line_number":20,"context_line":"import six"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_99472abc","line":19,"updated":"2014-06-25 13:28:27.000000000","message":"add line between mock and six, they should be in separated groups","commit_id":"0e5017fc2de8982b30ae1280f8693864094a953d"},{"author":{"_account_id":10987,"name":"Igor Degtiarov","username":"tovstun","inactive":true},"change_message_id":"916a16b4a2f703935c610e040f92f04d726ebfca","unresolved":false,"context_lines":[{"line_number":16,"context_line":"# License for the specific language governing permissions and limitations"},{"line_number":17,"context_line":"# under the License."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"import mock"},{"line_number":20,"context_line":"import six"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_d447b9a1","line":19,"in_reply_to":"1ae5cdf2_99472abc","updated":"2014-06-25 13:55:18.000000000","message":"answered earlier!","commit_id":"0e5017fc2de8982b30ae1280f8693864094a953d"}],"ceilometer/tests/test_notification.py":[{"author":{"_account_id":3012,"name":"Dina Belova","email":"dbelova@mirantis.com","username":"dbelova"},"change_message_id":"76a610fc168a662dcc5b303ac57b3a110a8732f1","unresolved":false,"context_lines":[{"line_number":17,"context_line":"\"\"\"Tests for Ceilometer notify daemon.\"\"\""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"import eventlet"},{"line_number":20,"context_line":"import mock"},{"line_number":21,"context_line":"import oslo.messaging"},{"line_number":22,"context_line":"import oslo.messaging.conffixture"},{"line_number":23,"context_line":"from stevedore import extension"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_596be21e","line":20,"updated":"2014-06-25 13:28:27.000000000","message":"keep different groups and move yaml to the 1st one","commit_id":"0e5017fc2de8982b30ae1280f8693864094a953d"},{"author":{"_account_id":3012,"name":"Dina Belova","email":"dbelova@mirantis.com","username":"dbelova"},"change_message_id":"aaf2ad5a41da450839e94c3550a323d19be17c78","unresolved":false,"context_lines":[{"line_number":17,"context_line":"\"\"\"Tests for Ceilometer notify daemon.\"\"\""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"import eventlet"},{"line_number":20,"context_line":"import mock"},{"line_number":21,"context_line":"import oslo.messaging"},{"line_number":22,"context_line":"import oslo.messaging.conffixture"},{"line_number":23,"context_line":"from stevedore import extension"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_4f595434","line":20,"in_reply_to":"1ae5cdf2_5414894c","updated":"2014-06-25 14:01:49.000000000","message":"sorry, that looks as pyyaml submodule","commit_id":"0e5017fc2de8982b30ae1280f8693864094a953d"},{"author":{"_account_id":10987,"name":"Igor Degtiarov","username":"tovstun","inactive":true},"change_message_id":"916a16b4a2f703935c610e040f92f04d726ebfca","unresolved":false,"context_lines":[{"line_number":17,"context_line":"\"\"\"Tests for Ceilometer notify daemon.\"\"\""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"import eventlet"},{"line_number":20,"context_line":"import mock"},{"line_number":21,"context_line":"import oslo.messaging"},{"line_number":22,"context_line":"import oslo.messaging.conffixture"},{"line_number":23,"context_line":"from stevedore import extension"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_94d451bc","line":20,"in_reply_to":"1ae5cdf2_596be21e","updated":"2014-06-25 13:55:18.000000000","message":"yaml is also in requirement.txt so it should be in second group as mock does.","commit_id":"0e5017fc2de8982b30ae1280f8693864094a953d"},{"author":{"_account_id":3012,"name":"Dina Belova","email":"dbelova@mirantis.com","username":"dbelova"},"change_message_id":"9a177e36fe3a07b7e628e6bcd3a7b89edaaa0e88","unresolved":false,"context_lines":[{"line_number":17,"context_line":"\"\"\"Tests for Ceilometer notify daemon.\"\"\""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"import eventlet"},{"line_number":20,"context_line":"import mock"},{"line_number":21,"context_line":"import oslo.messaging"},{"line_number":22,"context_line":"import oslo.messaging.conffixture"},{"line_number":23,"context_line":"from stevedore import extension"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_5414894c","line":20,"in_reply_to":"1ae5cdf2_94d451bc","updated":"2014-06-25 13:59:26.000000000","message":"there is no yaml, it\u0027s PyYaml - it\u0027s other module","commit_id":"0e5017fc2de8982b30ae1280f8693864094a953d"}],"tox.ini":[{"author":{"_account_id":3012,"name":"Dina Belova","email":"dbelova@mirantis.com","username":"dbelova"},"change_message_id":"76a610fc168a662dcc5b303ac57b3a110a8732f1","unresolved":false,"context_lines":[{"line_number":40,"context_line":"# H305 imports not grouped correctly"},{"line_number":41,"context_line":"# H307 like imports should be grouped together"},{"line_number":42,"context_line":"# H405 multi line docstring summary not separated with an empty line"},{"line_number":43,"context_line":"# H904 Wrap long lines in parentheses instead of a backslash "},{"line_number":44,"context_line":"ignore \u003d H305,H307,H405,H904"},{"line_number":45,"context_line":"builtins \u003d _"},{"line_number":46,"context_line":"exclude\u003d.venv,.git,.tox,dist,doc,./ceilometer/openstack/common,*lib/python*,*egg,tools,nova_tests,build"}],"source_content_type":"text/x-properties","patch_set":1,"id":"1ae5cdf2_9953aae1","side":"PARENT","line":43,"updated":"2014-06-25 13:28:27.000000000","message":"this trailing space should be fixed in previous change","commit_id":"15accedcb6c78e8c6766a413d4462553c6c604bf"},{"author":{"_account_id":10987,"name":"Igor Degtiarov","username":"tovstun","inactive":true},"change_message_id":"916a16b4a2f703935c610e040f92f04d726ebfca","unresolved":false,"context_lines":[{"line_number":40,"context_line":"# H305 imports not grouped correctly"},{"line_number":41,"context_line":"# H307 like imports should be grouped together"},{"line_number":42,"context_line":"# H405 multi line docstring summary not separated with an empty line"},{"line_number":43,"context_line":"# H904 Wrap long lines in parentheses instead of a backslash "},{"line_number":44,"context_line":"ignore \u003d H305,H307,H405,H904"},{"line_number":45,"context_line":"builtins \u003d _"},{"line_number":46,"context_line":"exclude\u003d.venv,.git,.tox,dist,doc,./ceilometer/openstack/common,*lib/python*,*egg,tools,nova_tests,build"}],"source_content_type":"text/x-properties","patch_set":1,"id":"1ae5cdf2_7400a535","side":"PARENT","line":43,"in_reply_to":"1ae5cdf2_9953aae1","updated":"2014-06-25 13:55:18.000000000","message":"Done","commit_id":"15accedcb6c78e8c6766a413d4462553c6c604bf"}]}