)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":3012,"name":"Dina Belova","email":"dbelova@mirantis.com","username":"dbelova"},"change_message_id":"9b209f1dc2f929a678242f60c0a1a406c36a1a71","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     liu-sheng \u003cliusheng@huawei.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-06-27 18:07:01 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Make the error message of alarm-not-found clearly"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When creating a alarm combination with invalid project, ceilometer will"},{"line_number":10,"context_line":"raise alarm-Not-Found error, even though the specified alarm ids is"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1ae5cdf2_c3040e80","line":7,"range":{"start_line":7,"start_character":42,"end_line":7,"end_character":49},"updated":"2014-06-27 11:55:25.000000000","message":"clearly -\u003e clear probably?","commit_id":"bf201eaf4a0619ac5e41ef03c37b77ccc655bdef"},{"author":{"_account_id":3012,"name":"Dina Belova","email":"dbelova@mirantis.com","username":"dbelova"},"change_message_id":"9b209f1dc2f929a678242f60c0a1a406c36a1a71","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Make the error message of alarm-not-found clearly"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When creating a alarm combination with invalid project, ceilometer will"},{"line_number":10,"context_line":"raise alarm-Not-Found error, even though the specified alarm ids is"},{"line_number":11,"context_line":"existent. The error message is easily misleading."},{"line_number":12,"context_line":"This change give a explicit presentation of this case."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1ae5cdf2_a3e9c2ac","line":10,"range":{"start_line":10,"start_character":65,"end_line":10,"end_character":67},"updated":"2014-06-27 11:55:25.000000000","message":"is -\u003e are","commit_id":"bf201eaf4a0619ac5e41ef03c37b77ccc655bdef"},{"author":{"_account_id":3012,"name":"Dina Belova","email":"dbelova@mirantis.com","username":"dbelova"},"change_message_id":"9b209f1dc2f929a678242f60c0a1a406c36a1a71","unresolved":false,"context_lines":[{"line_number":9,"context_line":"When creating a alarm combination with invalid project, ceilometer will"},{"line_number":10,"context_line":"raise alarm-Not-Found error, even though the specified alarm ids is"},{"line_number":11,"context_line":"existent. The error message is easily misleading."},{"line_number":12,"context_line":"This change give a explicit presentation of this case."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Id189209ed4ccf27543f8dc628ca5f82eeeeeaa44"},{"line_number":15,"context_line":"Closes-bug: #1320433"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1ae5cdf2_0332765d","line":12,"range":{"start_line":12,"start_character":12,"end_line":12,"end_character":16},"updated":"2014-06-27 11:55:25.000000000","message":"give -\u003e gives","commit_id":"bf201eaf4a0619ac5e41ef03c37b77ccc655bdef"}],"ceilometer/api/controllers/v2.py":[{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"291b7a8311c0c9198adf9c6e60ed89c369bd5745","unresolved":false,"context_lines":[{"line_number":1891,"context_line":"        auth_project \u003d acl.get_limited_to_project(pecan.request.headers)"},{"line_number":1892,"context_line":"        alarms \u003d list(self.conn.get_alarms(alarm_id\u003dself._id,"},{"line_number":1893,"context_line":"                                           project\u003dauth_project))"},{"line_number":1894,"context_line":"        if not alarms:"},{"line_number":1895,"context_line":"            raise EntityNotFound(_(\u0027Alarm\u0027), self._id)"},{"line_number":1896,"context_line":"        return alarms[0]"},{"line_number":1897,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_39d32402","line":1894,"updated":"2014-06-27 10:12:38.000000000","message":"You must change that one too\n\nPerhaps we need to create a AlarmNotFound class that inherit from EntityNotFound, to ensure all \u0027alarms not found\u0027 exception are always in sync","commit_id":"bf201eaf4a0619ac5e41ef03c37b77ccc655bdef"},{"author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"change_message_id":"0bc9eded7fd701ff77480fb620826008a2bd92cf","unresolved":false,"context_lines":[{"line_number":1891,"context_line":"        auth_project \u003d acl.get_limited_to_project(pecan.request.headers)"},{"line_number":1892,"context_line":"        alarms \u003d list(self.conn.get_alarms(alarm_id\u003dself._id,"},{"line_number":1893,"context_line":"                                           project\u003dauth_project))"},{"line_number":1894,"context_line":"        if not alarms:"},{"line_number":1895,"context_line":"            raise EntityNotFound(_(\u0027Alarm\u0027), self._id)"},{"line_number":1896,"context_line":"        return alarms[0]"},{"line_number":1897,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_b912d45e","line":1894,"in_reply_to":"1ae5cdf2_39d32402","updated":"2014-06-27 10:26:37.000000000","message":"thanks for review, will be done","commit_id":"bf201eaf4a0619ac5e41ef03c37b77ccc655bdef"},{"author":{"_account_id":8052,"name":"Nejc Saje","email":"nejc@saje.info","username":"nsaje"},"change_message_id":"da0be9925799fc90b6c65463383ae6cc748c847c","unresolved":false,"context_lines":[{"line_number":91,"context_line":"class AlarmNotFound(ClientSideError):"},{"line_number":92,"context_line":"    def __init__(self, alarm, auth_project):"},{"line_number":93,"context_line":"        if not auth_project:"},{"line_number":94,"context_line":"            msg \u003d _(\u0027Alarm:%s not found\u0027) % alarm"},{"line_number":95,"context_line":"        else:"},{"line_number":96,"context_line":"            msg \u003d _(\u0027Alarm:%(alarm_id)s not found in project:%\u0027"},{"line_number":97,"context_line":"                    \u0027(project)s\u0027) % {"}],"source_content_type":"text/x-python","patch_set":8,"id":"baada198_f1385f3f","line":94,"updated":"2014-07-10 05:28:45.000000000","message":"Just a nit, but is there any specific reason that the wording of the message was changed from the way it is in the EntityNotFound exception? It is far more common in OpenStack to say \"Alarm %s not found\" as opposed to using a colon and without the space.","commit_id":"5c4c6b9f95165cf41a6504522528e71c2e69a75b"},{"author":{"_account_id":8052,"name":"Nejc Saje","email":"nejc@saje.info","username":"nsaje"},"change_message_id":"da0be9925799fc90b6c65463383ae6cc748c847c","unresolved":false,"context_lines":[{"line_number":93,"context_line":"        if not auth_project:"},{"line_number":94,"context_line":"            msg \u003d _(\u0027Alarm:%s not found\u0027) % alarm"},{"line_number":95,"context_line":"        else:"},{"line_number":96,"context_line":"            msg \u003d _(\u0027Alarm:%(alarm_id)s not found in project:%\u0027"},{"line_number":97,"context_line":"                    \u0027(project)s\u0027) % {"},{"line_number":98,"context_line":"                        \u0027alarm_id\u0027: alarm, \u0027project\u0027: auth_project}"},{"line_number":99,"context_line":"        super(AlarmNotFound, self).__init__(msg, status_code\u003d404)"}],"source_content_type":"text/x-python","patch_set":8,"id":"baada198_113f9326","line":96,"updated":"2014-07-10 05:28:45.000000000","message":"Same here","commit_id":"5c4c6b9f95165cf41a6504522528e71c2e69a75b"}]}