)]}'
{"ceilometer/network/services/base.py":[{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"5046bc009c0b5e72b65b0f3196720729d4a18bf6","unresolved":false,"context_lines":[{"line_number":46,"context_line":"    @staticmethod"},{"line_number":47,"context_line":"    def get_status_id(value):"},{"line_number":48,"context_line":"        status \u003d value.lower()"},{"line_number":49,"context_line":"        if status not in STATUS:"},{"line_number":50,"context_line":"            return -1"},{"line_number":51,"context_line":"        return STATUS[status]"}],"source_content_type":"text/x-python","patch_set":9,"id":"baada198_aa4f8669","line":49,"updated":"2014-07-22 15:23:24.000000000","message":"could probably be return STATUS.get(status, -1)","commit_id":"68402375740ccc31ca6b4977938765ac66b966f6"},{"author":{"_account_id":6924,"name":"Pradeep Kilambi","email":"pkilambi@redhat.com","username":"pkilambi"},"change_message_id":"623c26d59207e47d7a9f1bfb6768a829e2774a21","unresolved":false,"context_lines":[{"line_number":46,"context_line":"    @staticmethod"},{"line_number":47,"context_line":"    def get_status_id(value):"},{"line_number":48,"context_line":"        status \u003d value.lower()"},{"line_number":49,"context_line":"        if status not in STATUS:"},{"line_number":50,"context_line":"            return -1"},{"line_number":51,"context_line":"        return STATUS[status]"}],"source_content_type":"text/x-python","patch_set":9,"id":"baada198_608aed65","line":49,"in_reply_to":"baada198_aa4f8669","updated":"2014-07-22 15:35:13.000000000","message":"sure, I\u0027m ok with that","commit_id":"68402375740ccc31ca6b4977938765ac66b966f6"}],"ceilometer/network/services/discovery.py":[{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"5046bc009c0b5e72b65b0f3196720729d4a18bf6","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# -*- encoding: utf-8 -*-"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Copyright © 2014 Cisco Systems, Inc"},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":9,"id":"baada198_8a71e2ad","line":1,"updated":"2014-07-22 15:23:24.000000000","message":"remove this","commit_id":"68402375740ccc31ca6b4977938765ac66b966f6"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"5046bc009c0b5e72b65b0f3196720729d4a18bf6","unresolved":false,"context_lines":[{"line_number":30,"context_line":"class LBPoolsDiscovery(_BaseServicesDiscovery):"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    def __init__(self):"},{"line_number":33,"context_line":"        super(LBPoolsDiscovery, self).__init__()"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    def discover(self, param\u003dNone):"},{"line_number":36,"context_line":"        \"\"\"Discover resources to monitor.\"\"\""}],"source_content_type":"text/x-python","patch_set":9,"id":"baada198_2a90d695","line":33,"updated":"2014-07-22 15:23:24.000000000","message":"not needed... same as below","commit_id":"68402375740ccc31ca6b4977938765ac66b966f6"},{"author":{"_account_id":6924,"name":"Pradeep Kilambi","email":"pkilambi@redhat.com","username":"pkilambi"},"change_message_id":"623c26d59207e47d7a9f1bfb6768a829e2774a21","unresolved":false,"context_lines":[{"line_number":30,"context_line":"class LBPoolsDiscovery(_BaseServicesDiscovery):"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    def __init__(self):"},{"line_number":33,"context_line":"        super(LBPoolsDiscovery, self).__init__()"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    def discover(self, param\u003dNone):"},{"line_number":36,"context_line":"        \"\"\"Discover resources to monitor.\"\"\""}],"source_content_type":"text/x-python","patch_set":9,"id":"baada198_c03e598b","line":33,"in_reply_to":"baada198_2a90d695","updated":"2014-07-22 15:35:13.000000000","message":"agreed, will remove","commit_id":"68402375740ccc31ca6b4977938765ac66b966f6"}],"ceilometer/network/services/lbaas.py":[{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"5046bc009c0b5e72b65b0f3196720729d4a18bf6","unresolved":false,"context_lines":[{"line_number":49,"context_line":"              ]"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    def get_samples(self, manager, cache, resources\u003dNone):"},{"line_number":52,"context_line":"        for pool in resources:"},{"line_number":53,"context_line":"            LOG.debug(\"Load Balancer Pool : %s\" % pool)"},{"line_number":54,"context_line":"            status \u003d self.get_status_id(pool[\u0027status\u0027])"},{"line_number":55,"context_line":"            if status \u003d\u003d -1:"}],"source_content_type":"text/x-python","patch_set":9,"id":"baada198_ca6afaec","line":52,"updated":"2014-07-22 15:23:24.000000000","message":"if resources is None, this will throw an error... same for below","commit_id":"68402375740ccc31ca6b4977938765ac66b966f6"},{"author":{"_account_id":6924,"name":"Pradeep Kilambi","email":"pkilambi@redhat.com","username":"pkilambi"},"change_message_id":"623c26d59207e47d7a9f1bfb6768a829e2774a21","unresolved":false,"context_lines":[{"line_number":49,"context_line":"              ]"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    def get_samples(self, manager, cache, resources\u003dNone):"},{"line_number":52,"context_line":"        for pool in resources:"},{"line_number":53,"context_line":"            LOG.debug(\"Load Balancer Pool : %s\" % pool)"},{"line_number":54,"context_line":"            status \u003d self.get_status_id(pool[\u0027status\u0027])"},{"line_number":55,"context_line":"            if status \u003d\u003d -1:"}],"source_content_type":"text/x-python","patch_set":9,"id":"baada198_400089ab","line":52,"in_reply_to":"baada198_ca6afaec","updated":"2014-07-22 15:35:13.000000000","message":"so basically add a check to see if resources is None and set it to an empty list. Sure makes sense.","commit_id":"68402375740ccc31ca6b4977938765ac66b966f6"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"f648de2dca8e78d0a6e22fe6bdd544195af0250e","unresolved":false,"context_lines":[{"line_number":219,"context_line":"    def _get_sample(pool, c_data):"},{"line_number":220,"context_line":"        \"\"\"Return one Sample.\"\"\""},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"    def get_samples(self, manager, cache, resources\u003dNone):"},{"line_number":223,"context_line":"        for pool in self._get_lb_pools():"},{"line_number":224,"context_line":"            try:"},{"line_number":225,"context_line":"                c_data \u003d self._populate_stats_cache(pool[\u0027id\u0027], cache)"}],"source_content_type":"text/x-python","patch_set":9,"id":"baada198_94ebc0db","line":222,"updated":"2014-07-22 16:12:50.000000000","message":"should this be resources as well?","commit_id":"68402375740ccc31ca6b4977938765ac66b966f6"}],"ceilometer/neutron_client.py":[{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"5046bc009c0b5e72b65b0f3196720729d4a18bf6","unresolved":false,"context_lines":[{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    @logged"},{"line_number":81,"context_line":"    def pool_get_all(self):"},{"line_number":82,"context_line":"        LOG.debug(\"NEUTRON POOL GET\")"},{"line_number":83,"context_line":"        resp \u003d self.client.list_pools()"},{"line_number":84,"context_line":"        return resp.get(\u0027pools\u0027)"},{"line_number":85,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"baada198_25900796","line":82,"updated":"2014-07-22 15:23:24.000000000","message":"is this for testing? why is it useful here and not for other items?","commit_id":"68402375740ccc31ca6b4977938765ac66b966f6"},{"author":{"_account_id":6924,"name":"Pradeep Kilambi","email":"pkilambi@redhat.com","username":"pkilambi"},"change_message_id":"623c26d59207e47d7a9f1bfb6768a829e2774a21","unresolved":false,"context_lines":[{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    @logged"},{"line_number":81,"context_line":"    def pool_get_all(self):"},{"line_number":82,"context_line":"        LOG.debug(\"NEUTRON POOL GET\")"},{"line_number":83,"context_line":"        resp \u003d self.client.list_pools()"},{"line_number":84,"context_line":"        return resp.get(\u0027pools\u0027)"},{"line_number":85,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"baada198_6014ade9","line":82,"in_reply_to":"baada198_25900796","updated":"2014-07-22 15:35:13.000000000","message":"yea, will clean this out.","commit_id":"68402375740ccc31ca6b4977938765ac66b966f6"}],"ceilometer/tests/network/services/test_discovery.py":[{"author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"change_message_id":"e926fe36b5cee2d5126cac7d60a3f43d31da9c28","unresolved":false,"context_lines":[{"line_number":30,"context_line":"        func \u003d super(TestPollsterLBPool, self).get_samples"},{"line_number":31,"context_line":"        return func(manager\u003dmanager,"},{"line_number":32,"context_line":"                    cache\u003dcache,"},{"line_number":33,"context_line":"                    resources\u003dresources)"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"class TestNetworkServicesDiscovery(agentbase.BaseAgentManagerTestCase):"}],"source_content_type":"text/x-python","patch_set":6,"id":"baada198_ce1b60c9","line":33,"updated":"2014-07-19 17:04:42.000000000","message":"I\u0027m a bit confused by the purpose this TestPollsterLBPool class, given that the get_samples methid simply calls up to the superclass.","commit_id":"54437c06f43b1f27d301d39d863e42ba9a05c3b4"},{"author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"change_message_id":"e926fe36b5cee2d5126cac7d60a3f43d31da9c28","unresolved":false,"context_lines":[{"line_number":33,"context_line":"                    resources\u003dresources)"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"class TestNetworkServicesDiscovery(agentbase.BaseAgentManagerTestCase):"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    class PollsterLBPool(TestPollsterLBPool):"},{"line_number":39,"context_line":"        samples \u003d []"}],"source_content_type":"text/x-python","patch_set":6,"id":"baada198_4eb2f096","line":36,"updated":"2014-07-19 17:04:42.000000000","message":"The BaseAgentManagerTestCase was intended to act a base class for tests of specific agent managers (i.e. for the compute or central agent), as opposed to a tests for specific discovery extensions.\n\nSo I think you could significantly simplify this test by removing much of the logic to assert on say polling task setup etc. as this is already tested elsewhere. Instead the test only really needs to ensure that the discovery extension work as expected *in isolation*.","commit_id":"54437c06f43b1f27d301d39d863e42ba9a05c3b4"}],"ceilometer/tests/network/services/test_lbaas.py":[{"author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"change_message_id":"2d22061db08362ed2a50b35efd2e3f59d7ac3c25","unresolved":false,"context_lines":[{"line_number":343,"context_line":"            self.manager, {},"},{"line_number":344,"context_line":"            self.fake_get_health_monitor()))"},{"line_number":345,"context_line":"        self.assertEqual(set([\u0027network.services.lb.health_monitor\u0027]),"},{"line_number":346,"context_line":"                         set([s.name for s in samples]))"},{"line_number":347,"context_line":""},{"line_number":348,"context_line":""},{"line_number":349,"context_line":"class TestLBStatsPollster(_BaseTestLBPollster):"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_b09d1769","line":346,"updated":"2014-07-16 19:17:07.000000000","message":"No tests for the new discovery logic, or am I missing something?","commit_id":"0635ec03411129284ae67e82c21b71897e09b74f"},{"author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"change_message_id":"416fcdcd39f7c419a4e7ad80ff6cbc9328607486","unresolved":false,"context_lines":[{"line_number":343,"context_line":"            self.manager, {},"},{"line_number":344,"context_line":"            self.fake_get_health_monitor()))"},{"line_number":345,"context_line":"        self.assertEqual(set([\u0027network.services.lb.health_monitor\u0027]),"},{"line_number":346,"context_line":"                         set([s.name for s in samples]))"},{"line_number":347,"context_line":""},{"line_number":348,"context_line":""},{"line_number":349,"context_line":"class TestLBStatsPollster(_BaseTestLBPollster):"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_bc717046","line":346,"in_reply_to":"baada198_1016c3a7","updated":"2014-07-16 21:07:28.000000000","message":"Excellent, thank you sir!","commit_id":"0635ec03411129284ae67e82c21b71897e09b74f"},{"author":{"_account_id":6924,"name":"Pradeep Kilambi","email":"pkilambi@redhat.com","username":"pkilambi"},"change_message_id":"268457423af7167453ec149892cb4dbe0fb8fe29","unresolved":false,"context_lines":[{"line_number":343,"context_line":"            self.manager, {},"},{"line_number":344,"context_line":"            self.fake_get_health_monitor()))"},{"line_number":345,"context_line":"        self.assertEqual(set([\u0027network.services.lb.health_monitor\u0027]),"},{"line_number":346,"context_line":"                         set([s.name for s in samples]))"},{"line_number":347,"context_line":""},{"line_number":348,"context_line":""},{"line_number":349,"context_line":"class TestLBStatsPollster(_BaseTestLBPollster):"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_1016c3a7","line":346,"in_reply_to":"baada198_b09d1769","updated":"2014-07-16 19:23:45.000000000","message":"yep working on those","commit_id":"0635ec03411129284ae67e82c21b71897e09b74f"}],"etc/ceilometer/pipeline.yaml":[{"author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"change_message_id":"2d22061db08362ed2a50b35efd2e3f59d7ac3c25","unresolved":false,"context_lines":[{"line_number":108,"context_line":"                    type: \"gauge\""},{"line_number":109,"context_line":"      publishers:"},{"line_number":110,"context_line":"          - rpc://"},{"line_number":111,"context_line":"    - name: network_services_sink"},{"line_number":112,"context_line":"      transformers:"},{"line_number":113,"context_line":"      publishers:"},{"line_number":114,"context_line":"          - rpc://"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"baada198_30b3c70b","line":111,"updated":"2014-07-16 19:17:07.000000000","message":"Why do you need a separate network_services_sink?\n\nWouldn\u0027t the generic meter_sink do the job?","commit_id":"0635ec03411129284ae67e82c21b71897e09b74f"},{"author":{"_account_id":6924,"name":"Pradeep Kilambi","email":"pkilambi@redhat.com","username":"pkilambi"},"change_message_id":"268457423af7167453ec149892cb4dbe0fb8fe29","unresolved":false,"context_lines":[{"line_number":108,"context_line":"                    type: \"gauge\""},{"line_number":109,"context_line":"      publishers:"},{"line_number":110,"context_line":"          - rpc://"},{"line_number":111,"context_line":"    - name: network_services_sink"},{"line_number":112,"context_line":"      transformers:"},{"line_number":113,"context_line":"      publishers:"},{"line_number":114,"context_line":"          - rpc://"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"baada198_904f33be","line":111,"in_reply_to":"baada198_30b3c70b","updated":"2014-07-16 19:23:45.000000000","message":"kept it separate in case we add a transformer in future to handle stats/usage like we discussed. If you prefer to punt this to a later date until such use case becomes real, I\u0027m ok just using the meter_sink","commit_id":"0635ec03411129284ae67e82c21b71897e09b74f"},{"author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"change_message_id":"416fcdcd39f7c419a4e7ad80ff6cbc9328607486","unresolved":false,"context_lines":[{"line_number":108,"context_line":"                    type: \"gauge\""},{"line_number":109,"context_line":"      publishers:"},{"line_number":110,"context_line":"          - rpc://"},{"line_number":111,"context_line":"    - name: network_services_sink"},{"line_number":112,"context_line":"      transformers:"},{"line_number":113,"context_line":"      publishers:"},{"line_number":114,"context_line":"          - rpc://"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"baada198_7c77d83b","line":111,"in_reply_to":"baada198_904f33be","updated":"2014-07-16 21:07:28.000000000","message":"Yeah, I think it would be a good idea to punt, and only introduce the extra sink when we need it to accommodate a transformer.","commit_id":"0635ec03411129284ae67e82c21b71897e09b74f"}],"setup.cfg":[{"author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"change_message_id":"9dcae66950a94796931020195e04c43809b312a3","unresolved":false,"context_lines":[{"line_number":138,"context_line":"    network.services.lb.pool \u003d ceilometer.network.services.lbaas:LBPoolPollster"},{"line_number":139,"context_line":"    network.services.lb.vip \u003d ceilometer.network.services.lbaas:LBVipPollster"},{"line_number":140,"context_line":"    network.services.lb.member \u003d ceilometer.network.services.lbaas:LBMemberPollster"},{"line_number":141,"context_line":"    network.services.lb.health_monitor \u003d ceilometer.network.services.lbaas:LBHealthMonitorPollster"},{"line_number":142,"context_line":"    network.services.lb.total.connections \u003d ceilometer.network.services.lbaas:LBTotalConnectionsPollster"},{"line_number":143,"context_line":"    network.services.lb.active.connections \u003d ceilometer.network.services.lbaas:LBActiveConnectionsPollster"},{"line_number":144,"context_line":"    network.services.lb.incoming.bytes \u003d ceilometer.network.services.lbaas:LBBytesInPollster"}],"source_content_type":"text/x-ttcn-cfg","patch_set":2,"id":"baada198_d5ed20b9","side":"PARENT","line":141,"updated":"2014-07-16 17:40:35.000000000","message":"You need to restore these pollsters, otherwise the new discovery logic will never be called.\n\nIf the relevant pollsters aren\u0027t even loaded, there is never any polling task created that will use those discovery extensions.","commit_id":"303a1ce7046def34ed14abb75b4cf5e553c421d5"}]}