)]}'
{"ceilometer/service.py":[{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"4af9e7de9ca0c13230bb845f18171a3450701942","unresolved":false,"context_lines":[{"line_number":120,"context_line":"                         \u0027suds\u003dINFO\u0027,"},{"line_number":121,"context_line":"                         \u0027oslo.messaging\u003dINFO\u0027,"},{"line_number":122,"context_line":"                         \u0027iso8601\u003dWARN\u0027,"},{"line_number":123,"context_line":"                         \u0027requests.packages.urllib3.connectionpool\u003dWARN\u0027,"},{"line_number":124,"context_line":"                         \u0027stevedore\u003dINFO\u0027,"},{"line_number":125,"context_line":"                         \u0027keystoneclient\u003dINFO\u0027])"},{"line_number":126,"context_line":"    if argv is None:"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_c19c116d","line":123,"updated":"2014-07-04 08:29:13.000000000","message":"In oslo-incubator there is one more option in the default log level list: \u0027urllib3.connectionpool\u003dWARN\u0027. It is not included here because we will not need this, right?","commit_id":"4d864cef5a2c8ec912bda5b208771d3b7c966934"},{"author":{"_account_id":3012,"name":"Dina Belova","email":"dbelova@mirantis.com","username":"dbelova"},"change_message_id":"957c84b1d0d59ed7c9ac00f7eaae4476c65f5d07","unresolved":false,"context_lines":[{"line_number":120,"context_line":"                         \u0027suds\u003dINFO\u0027,"},{"line_number":121,"context_line":"                         \u0027oslo.messaging\u003dINFO\u0027,"},{"line_number":122,"context_line":"                         \u0027iso8601\u003dWARN\u0027,"},{"line_number":123,"context_line":"                         \u0027requests.packages.urllib3.connectionpool\u003dWARN\u0027,"},{"line_number":124,"context_line":"                         \u0027stevedore\u003dINFO\u0027,"},{"line_number":125,"context_line":"                         \u0027keystoneclient\u003dINFO\u0027])"},{"line_number":126,"context_line":"    if argv is None:"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_8442273c","line":123,"in_reply_to":"baada198_41100159","updated":"2014-07-04 08:54:53.000000000","message":"@ZhiQiang Fan, that\u0027s good idea indeed :)","commit_id":"4d864cef5a2c8ec912bda5b208771d3b7c966934"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"a8d2ec557a7cbebb3d6b8e5b79e79a8a3b9bdb3b","unresolved":false,"context_lines":[{"line_number":120,"context_line":"                         \u0027suds\u003dINFO\u0027,"},{"line_number":121,"context_line":"                         \u0027oslo.messaging\u003dINFO\u0027,"},{"line_number":122,"context_line":"                         \u0027iso8601\u003dWARN\u0027,"},{"line_number":123,"context_line":"                         \u0027requests.packages.urllib3.connectionpool\u003dWARN\u0027,"},{"line_number":124,"context_line":"                         \u0027stevedore\u003dINFO\u0027,"},{"line_number":125,"context_line":"                         \u0027keystoneclient\u003dINFO\u0027])"},{"line_number":126,"context_line":"    if argv is None:"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_a41e4b0a","line":123,"in_reply_to":"baada198_41100159","updated":"2014-07-04 09:05:09.000000000","message":"read my mind :)","commit_id":"4d864cef5a2c8ec912bda5b208771d3b7c966934"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"780a83d16d02760c91561042b5fdf40b148ce078","unresolved":false,"context_lines":[{"line_number":120,"context_line":"                         \u0027suds\u003dINFO\u0027,"},{"line_number":121,"context_line":"                         \u0027oslo.messaging\u003dINFO\u0027,"},{"line_number":122,"context_line":"                         \u0027iso8601\u003dWARN\u0027,"},{"line_number":123,"context_line":"                         \u0027requests.packages.urllib3.connectionpool\u003dWARN\u0027,"},{"line_number":124,"context_line":"                         \u0027stevedore\u003dINFO\u0027,"},{"line_number":125,"context_line":"                         \u0027keystoneclient\u003dINFO\u0027])"},{"line_number":126,"context_line":"    if argv is None:"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_41100159","line":123,"in_reply_to":"baada198_c19c116d","updated":"2014-07-04 08:53:01.000000000","message":"@Ildiko Vancsa\n\nthat code has not sync-ed to ceilometer yet.\n\n@gordon chung\n\nhow about this:\n\n    default_levels \u003d cfg.default_log_levels.extend([\n        \u0027stevedore\u003dINFO\u0027, \u0027keystoneclient\u003dINFO\u0027])\n    cfg.set_defaults(log.log_opts, default_log_levels\u003ddefault_levels)\n\nthen no matter how upstream changes, we are solid. (even though there may be duplicate, but the code in oslo.log will take the last one, see https://github.com/openstack/oslo-incubator/blob/master/openstack/common/log.py#L523)","commit_id":"4d864cef5a2c8ec912bda5b208771d3b7c966934"},{"author":{"_account_id":3012,"name":"Dina Belova","email":"dbelova@mirantis.com","username":"dbelova"},"change_message_id":"e8082eeb1cf134cd2a0c6214030699d8334f1c6c","unresolved":false,"context_lines":[{"line_number":120,"context_line":"                         \u0027suds\u003dINFO\u0027,"},{"line_number":121,"context_line":"                         \u0027oslo.messaging\u003dINFO\u0027,"},{"line_number":122,"context_line":"                         \u0027iso8601\u003dWARN\u0027,"},{"line_number":123,"context_line":"                         \u0027requests.packages.urllib3.connectionpool\u003dWARN\u0027,"},{"line_number":124,"context_line":"                         \u0027stevedore\u003dINFO\u0027,"},{"line_number":125,"context_line":"                         \u0027keystoneclient\u003dINFO\u0027])"},{"line_number":126,"context_line":"    if argv is None:"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_a4380bd4","line":123,"in_reply_to":"baada198_c19c116d","updated":"2014-07-04 08:54:17.000000000","message":"I guess the reason is also in the fact that our copy of log module in openstack.common https://github.com/openstack/ceilometer/blob/master/ceilometer/openstack/common/log.py#L158 does not contain this. Probably we need to update this module, or just keep things as is.","commit_id":"4d864cef5a2c8ec912bda5b208771d3b7c966934"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"89953984746f815c94e3ee7ab62759ad37ab3f6e","unresolved":false,"context_lines":[{"line_number":87,"context_line":"]"},{"line_number":88,"context_line":"cfg.CONF.register_cli_opts(CLI_OPTIONS, group\u003d\"service_credentials\")"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"cfg.CONF.import_opt(\u0027default_log_levels\u0027,"},{"line_number":91,"context_line":"                    \u0027ceilometer.openstack.common.log\u0027)"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"LOG \u003d log.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":4,"id":"baada198_356503b5","line":90,"updated":"2014-07-04 10:20:34.000000000","message":"-1: I think the import_opt is not necessary, because openstack.common.log will **register** that opt in global scope. Since we already import that module, this has been done in importing time.","commit_id":"385bdbafc1604ac0a3f07f3e469b19bf80e51145"},{"author":{"_account_id":3012,"name":"Dina Belova","email":"dbelova@mirantis.com","username":"dbelova"},"change_message_id":"2cd722da5945ce0c3401e14f19d87144feb7cc0c","unresolved":false,"context_lines":[{"line_number":87,"context_line":"]"},{"line_number":88,"context_line":"cfg.CONF.register_cli_opts(CLI_OPTIONS, group\u003d\"service_credentials\")"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"cfg.CONF.import_opt(\u0027default_log_levels\u0027,"},{"line_number":91,"context_line":"                    \u0027ceilometer.openstack.common.log\u0027)"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"LOG \u003d log.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":4,"id":"baada198_3006f11d","line":90,"in_reply_to":"baada198_356503b5","updated":"2014-07-04 10:49:34.000000000","message":"this thing only imports the original module and guarantees that default_log_level will be in this module. It does not *imports* the opt, it *makes sure* that file where this opt was defined is available here - with the opt, actually.","commit_id":"385bdbafc1604ac0a3f07f3e469b19bf80e51145"}]}