)]}'
{"ceilometer/central/plugin.py":[{"author":{"_account_id":7729,"name":"Ilya Tyaptin","email":"ityaptin@mirantis.com","username":"ityaptin"},"change_message_id":"dbd4015c18c952d6ab64894b3df098bc389405c7","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    def wrapped(f):"},{"line_number":40,"context_line":"        def func(self, *args, **kwargs):"},{"line_number":41,"context_line":"            if client:"},{"line_number":42,"context_line":"                manager \u003d getattr(self, client, None)"},{"line_number":43,"context_line":"            else:"},{"line_number":44,"context_line":"                manager \u003d kwargs.get(\u0027manager\u0027)"},{"line_number":45,"context_line":"            if not manager and len(args) \u003e 0:"}],"source_content_type":"text/x-python","patch_set":8,"id":"baada198_85de2169","line":42,"range":{"start_line":42,"start_character":40,"end_line":42,"end_character":46},"updated":"2014-08-13 13:53:27.000000000","message":"For reducing \"if\" size and improving code clearance you may write \nif client:\n    manager \u003d getattr(self, client, kwargs.get(\u0027manager\u0027))\n\ninstead if client: ... else: ...","commit_id":"ce6847c5ee83df43d8dd8a65ddb3cb73915b8708"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"99ca39626ce4d5bb24a0206ae9cf23b603e3d6ae","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    def wrapped(f):"},{"line_number":40,"context_line":"        def func(self, *args, **kwargs):"},{"line_number":41,"context_line":"            if client:"},{"line_number":42,"context_line":"                manager \u003d getattr(self, client, None)"},{"line_number":43,"context_line":"            else:"},{"line_number":44,"context_line":"                manager \u003d kwargs.get(\u0027manager\u0027)"},{"line_number":45,"context_line":"            if not manager and len(args) \u003e 0:"}],"source_content_type":"text/x-python","patch_set":8,"id":"baada198_29052fc1","line":42,"in_reply_to":"baada198_85de2169","updated":"2014-08-13 14:42:44.000000000","message":"that isn\u0027t logically the same. the intent is that we use client if given. if it is not, we check for manager param. the above would skip the second part.","commit_id":"ce6847c5ee83df43d8dd8a65ddb3cb73915b8708"}],"ceilometer/network/services/lbaas.py":[{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"7e56ac2278cc1296e3e9b81eb7bc97aab3fc174b","unresolved":false,"context_lines":[{"line_number":80,"context_line":"    def _get_lb_pools(self):"},{"line_number":81,"context_line":"        return self.nc.pool_get_all()"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    @plugin.check_keystone"},{"line_number":84,"context_line":"    def get_samples(self, manager, cache, resources\u003dNone):"},{"line_number":85,"context_line":"        for pool in self._iter_cache(cache, \u0027pool\u0027, self._get_lb_pools):"},{"line_number":86,"context_line":"            LOG.debug(\"Load Balancer Pool : %s\" % pool)"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_a0970939","line":83,"updated":"2014-07-04 18:18:53.000000000","message":"need to mock manager.keystone in ut\n\nand curious for why the keystone check relates to neutron config","commit_id":"b9df030640b681a8ae7437006577045e745d39b9"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"366bf3a02e5484bfeea8dfa9bc8048611be8dbfa","unresolved":false,"context_lines":[{"line_number":80,"context_line":"    def _get_lb_pools(self):"},{"line_number":81,"context_line":"        return self.nc.pool_get_all()"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    @plugin.check_keystone"},{"line_number":84,"context_line":"    def get_samples(self, manager, cache, resources\u003dNone):"},{"line_number":85,"context_line":"        for pool in self._iter_cache(cache, \u0027pool\u0027, self._get_lb_pools):"},{"line_number":86,"context_line":"            LOG.debug(\"Load Balancer Pool : %s\" % pool)"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_0f6efd95","line":83,"in_reply_to":"baada198_a0970939","updated":"2014-07-21 22:16:54.000000000","message":"i guess it technically doesn\u0027t. i\u0027m just reusing the same mechanism since if neutron isn\u0027t set up, the keystone component of client won\u0027t be either","commit_id":"b9df030640b681a8ae7437006577045e745d39b9"}],"ceilometer/tests/network/services/test_fwaas.py":[{"author":{"_account_id":3012,"name":"Dina Belova","email":"dbelova@mirantis.com","username":"dbelova"},"change_message_id":"4a605a08b696b699a0ffcd3ff983dd7c5d701c4b","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        self.context \u003d context.get_admin_context()"},{"line_number":36,"context_line":"        self.manager \u003d manager.AgentManager()"},{"line_number":37,"context_line":"        cli.Client.keystone \u003d mock.Mock()"},{"line_number":38,"context_line":"        cli.Client.keystone.service_catalog.get_endpoints \u003d mock.Mock("},{"line_number":39,"context_line":"            return_value\u003d{\u0027network\u0027: mock.ANY})"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"baada198_ce0f198a","line":38,"updated":"2014-07-31 13:18:24.000000000","message":"why do these changes are needed only for the network and image tests? Sorry if question is stupid :)","commit_id":"ce6847c5ee83df43d8dd8a65ddb3cb73915b8708"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"99ca39626ce4d5bb24a0206ae9cf23b603e3d6ae","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        self.context \u003d context.get_admin_context()"},{"line_number":36,"context_line":"        self.manager \u003d manager.AgentManager()"},{"line_number":37,"context_line":"        cli.Client.keystone \u003d mock.Mock()"},{"line_number":38,"context_line":"        cli.Client.keystone.service_catalog.get_endpoints \u003d mock.Mock("},{"line_number":39,"context_line":"            return_value\u003d{\u0027network\u0027: mock.ANY})"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"baada198_e94097a4","line":38,"in_reply_to":"baada198_ce0f198a","updated":"2014-08-13 14:42:44.000000000","message":"i needed them to pass the tests:) ... it\u0027s also because the other tests mocked out the keystone part of code.","commit_id":"ce6847c5ee83df43d8dd8a65ddb3cb73915b8708"}]}