)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":3012,"name":"Dina Belova","email":"dbelova@mirantis.com","username":"dbelova"},"change_message_id":"8d3c6a575f0a9b39c31984d5774d558dba8992e4","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Rikimaru Honjo \u003chonjo.rikimaru@po.ntts.co.jp\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-07-11 17:19:26 +0900"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Set page size when Glance API request is called"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Central Agent (actually plugins defined in ceilometer/image/glance.py) uses"},{"line_number":10,"context_line":"glanceclient to get image-list from glance."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"baada198_5ce48d3b","line":7,"updated":"2014-07-11 09:23:36.000000000","message":"probably called -\u003e processed will look better here","commit_id":"67ba5584e52746cc3f03c81c6db685c0ec3757b0"},{"author":{"_account_id":8988,"name":"Rikimaru Honjo","email":"honjo.rikimaru@ntt-tx.co.jp","username":"rikimaru.honjo","inactive":true},"change_message_id":"f85ed0e640d53d21bfe6fa085241dca472081ff6","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Rikimaru Honjo \u003chonjo.rikimaru@po.ntts.co.jp\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-07-11 17:19:26 +0900"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Set page size when Glance API request is called"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Central Agent (actually plugins defined in ceilometer/image/glance.py) uses"},{"line_number":10,"context_line":"glanceclient to get image-list from glance."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"baada198_1714ae42","line":7,"in_reply_to":"baada198_5ce48d3b","updated":"2014-07-11 09:42:51.000000000","message":"Thank you for your comment.\n\nI\u0027ll adopt your suggestion.","commit_id":"67ba5584e52746cc3f03c81c6db685c0ec3757b0"},{"author":{"_account_id":3012,"name":"Dina Belova","email":"dbelova@mirantis.com","username":"dbelova"},"change_message_id":"8d3c6a575f0a9b39c31984d5774d558dba8992e4","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Central Agent (actually plugins defined in ceilometer/image/glance.py) uses"},{"line_number":10,"context_line":"glanceclient to get image-list from glance."},{"line_number":11,"context_line":"Since glanceclient has pagenation feature, it calls glance API for every"},{"line_number":12,"context_line":"page sizes. When glanceclient is used by Cetral Agent, default value of page"},{"line_number":13,"context_line":"size, that is 20, is used, since Central Agent doesn\u0027t specify page size."},{"line_number":14,"context_line":"However, default value of page size is too small when there is a large"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"baada198_9c38e5a1","line":11,"range":{"start_line":11,"start_character":23,"end_line":11,"end_character":33},"updated":"2014-07-11 09:23:36.000000000","message":"pagenation -\u003e pagination :)","commit_id":"67ba5584e52746cc3f03c81c6db685c0ec3757b0"},{"author":{"_account_id":8988,"name":"Rikimaru Honjo","email":"honjo.rikimaru@ntt-tx.co.jp","username":"rikimaru.honjo","inactive":true},"change_message_id":"f85ed0e640d53d21bfe6fa085241dca472081ff6","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Central Agent (actually plugins defined in ceilometer/image/glance.py) uses"},{"line_number":10,"context_line":"glanceclient to get image-list from glance."},{"line_number":11,"context_line":"Since glanceclient has pagenation feature, it calls glance API for every"},{"line_number":12,"context_line":"page sizes. When glanceclient is used by Cetral Agent, default value of page"},{"line_number":13,"context_line":"size, that is 20, is used, since Central Agent doesn\u0027t specify page size."},{"line_number":14,"context_line":"However, default value of page size is too small when there is a large"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"baada198_7717aa45","line":11,"in_reply_to":"baada198_9c38e5a1","updated":"2014-07-11 09:42:51.000000000","message":"Oh, Sorry.\n\nI\u0027ll fix.","commit_id":"67ba5584e52746cc3f03c81c6db685c0ec3757b0"},{"author":{"_account_id":3012,"name":"Dina Belova","email":"dbelova@mirantis.com","username":"dbelova"},"change_message_id":"8d3c6a575f0a9b39c31984d5774d558dba8992e4","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Central Agent (actually plugins defined in ceilometer/image/glance.py) uses"},{"line_number":10,"context_line":"glanceclient to get image-list from glance."},{"line_number":11,"context_line":"Since glanceclient has pagenation feature, it calls glance API for every"},{"line_number":12,"context_line":"page sizes. When glanceclient is used by Cetral Agent, default value of page"},{"line_number":13,"context_line":"size, that is 20, is used, since Central Agent doesn\u0027t specify page size."},{"line_number":14,"context_line":"However, default value of page size is too small when there is a large"},{"line_number":15,"context_line":"number of images."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"baada198_3c499931","line":12,"range":{"start_line":12,"start_character":41,"end_line":12,"end_character":47},"updated":"2014-07-11 09:23:36.000000000","message":"Cetral -\u003e Central","commit_id":"67ba5584e52746cc3f03c81c6db685c0ec3757b0"},{"author":{"_account_id":8988,"name":"Rikimaru Honjo","email":"honjo.rikimaru@ntt-tx.co.jp","username":"rikimaru.honjo","inactive":true},"change_message_id":"f85ed0e640d53d21bfe6fa085241dca472081ff6","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Central Agent (actually plugins defined in ceilometer/image/glance.py) uses"},{"line_number":10,"context_line":"glanceclient to get image-list from glance."},{"line_number":11,"context_line":"Since glanceclient has pagenation feature, it calls glance API for every"},{"line_number":12,"context_line":"page sizes. When glanceclient is used by Cetral Agent, default value of page"},{"line_number":13,"context_line":"size, that is 20, is used, since Central Agent doesn\u0027t specify page size."},{"line_number":14,"context_line":"However, default value of page size is too small when there is a large"},{"line_number":15,"context_line":"number of images."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"baada198_b72ce29a","line":12,"in_reply_to":"baada198_3c499931","updated":"2014-07-11 09:42:51.000000000","message":"I\u0027ll fix.","commit_id":"67ba5584e52746cc3f03c81c6db685c0ec3757b0"},{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"171c886dd50d7248ffa878c5d02f8459a5ef6b58","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Set page size when Glance API request is processed"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Central Agent (actually plugins defined in ceilometer/image/glance.py) uses"},{"line_number":10,"context_line":"glanceclient to get image-list from glance."},{"line_number":11,"context_line":"Since glanceclient has pagination feature, it calls glance API for every"},{"line_number":12,"context_line":"page sizes. When glanceclient is used by Central Agent, default value of page"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"baada198_e51a216a","line":9,"updated":"2014-08-01 02:30:36.000000000","message":"how about re-phrase this to \"The glance related pollsters in central agent uses ...\"?","commit_id":"bd70540b1911cbd05b695a6fa53e111ae5ff8933"},{"author":{"_account_id":8988,"name":"Rikimaru Honjo","email":"honjo.rikimaru@ntt-tx.co.jp","username":"rikimaru.honjo","inactive":true},"change_message_id":"5f39e254e8a1b6e17a7880a44450b855cd1cdf1d","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Set page size when Glance API request is processed"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Central Agent (actually plugins defined in ceilometer/image/glance.py) uses"},{"line_number":10,"context_line":"glanceclient to get image-list from glance."},{"line_number":11,"context_line":"Since glanceclient has pagination feature, it calls glance API for every"},{"line_number":12,"context_line":"page sizes. When glanceclient is used by Central Agent, default value of page"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"baada198_e1dcc7e3","line":9,"in_reply_to":"baada198_e51a216a","updated":"2014-08-01 11:31:41.000000000","message":"Done.","commit_id":"bd70540b1911cbd05b695a6fa53e111ae5ff8933"},{"author":{"_account_id":3012,"name":"Dina Belova","email":"dbelova@mirantis.com","username":"dbelova"},"change_message_id":"416d67375836ceade43eb1aa7c21a4493a7fa3b2","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Set page size when Glance API request is called"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The glance related pollsters in central agent uses glanceclient to get"},{"line_number":10,"context_line":"image-list from glance. Since glanceclient has pagenation feature,"},{"line_number":11,"context_line":"it calls glance API for every page sizes. When glanceclient is used by"},{"line_number":12,"context_line":"Central Agent, default value of page size, that is 20, is used, since"},{"line_number":13,"context_line":"Central Agent doesn\u0027t specify page size. However, default value of page"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"baada198_51bfc4aa","line":10,"range":{"start_line":10,"start_character":47,"end_line":10,"end_character":57},"updated":"2014-08-04 10:23:10.000000000","message":"pagination :)","commit_id":"1037075be0010057390f97296c4b67bed2596f0f"},{"author":{"_account_id":8988,"name":"Rikimaru Honjo","email":"honjo.rikimaru@ntt-tx.co.jp","username":"rikimaru.honjo","inactive":true},"change_message_id":"f5f399bd3c0e4f267651c58995a2ec09d8a6fe1d","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Set page size when Glance API request is called"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The glance related pollsters in central agent uses glanceclient to get"},{"line_number":10,"context_line":"image-list from glance. Since glanceclient has pagenation feature,"},{"line_number":11,"context_line":"it calls glance API for every page sizes. When glanceclient is used by"},{"line_number":12,"context_line":"Central Agent, default value of page size, that is 20, is used, since"},{"line_number":13,"context_line":"Central Agent doesn\u0027t specify page size. However, default value of page"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"baada198_58309d55","line":10,"in_reply_to":"baada198_51bfc4aa","updated":"2014-08-05 09:15:20.000000000","message":"Oh, Sorry.\n\nI\u0027ve fixed it.","commit_id":"1037075be0010057390f97296c4b67bed2596f0f"}],"ceilometer/image/glance.py":[{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"31e32db0da7216e9ae7b1c748d7da128533f0b66","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"OPTS \u003d ["},{"line_number":32,"context_line":"    cfg.IntOpt(\u0027glance_page_size\u0027,"},{"line_number":33,"context_line":"               default\u003d0,"},{"line_number":34,"context_line":"               help\u003d\"Number of items to request in \""},{"line_number":35,"context_line":"                    \"each paginated Glance API request \""},{"line_number":36,"context_line":"                    \"(parameter used by glancecelient). \""}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_1bf7b4d5","line":33,"updated":"2014-07-23 10:31:09.000000000","message":"The associated bug points out that the default value used by glanceclient is non-performant. Would it make sense to set a higher numbered default here so that people get benefits without changing their config?","commit_id":"9219936495dc9979e096e71ab29ddd8f523e612f"},{"author":{"_account_id":8988,"name":"Rikimaru Honjo","email":"honjo.rikimaru@ntt-tx.co.jp","username":"rikimaru.honjo","inactive":true},"change_message_id":"261003765839e1f2c49bc92df01a2d6ffd2a9d79","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"OPTS \u003d ["},{"line_number":32,"context_line":"    cfg.IntOpt(\u0027glance_page_size\u0027,"},{"line_number":33,"context_line":"               default\u003d0,"},{"line_number":34,"context_line":"               help\u003d\"Number of items to request in \""},{"line_number":35,"context_line":"                    \"each paginated Glance API request \""},{"line_number":36,"context_line":"                    \"(parameter used by glancecelient). \""}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_2e85f5ce","line":33,"in_reply_to":"baada198_1bf7b4d5","updated":"2014-07-24 06:31:31.000000000","message":"It is true that the default value used by glanceclient is non-performant in this case.\n\nHowever, it is not sure that higher value is appropriate for other cases. Furthermore, there is a trade-off that higher value improves the performance, but increases the response time for each request.\n\nTherefore, it is better to check and set appropriate value in line with each environment when calling glanceclient, than to define higher default value.","commit_id":"9219936495dc9979e096e71ab29ddd8f523e612f"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"31e32db0da7216e9ae7b1c748d7da128533f0b66","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        # TODO(eglynn): use pagination to protect against unbounded"},{"line_number":63,"context_line":"        #              memory usage"},{"line_number":64,"context_line":"        page_size \u003d cfg.CONF.glance_page_size"},{"line_number":65,"context_line":"        if page_size \u003c\u003d 0:"},{"line_number":66,"context_line":"            rawImageList \u003d list(itertools.chain("},{"line_number":67,"context_line":"                client.images.list(filters\u003d{\"is_public\": True}),"},{"line_number":68,"context_line":"                # TODO(eglynn): extend glance API with all_tenants logic to"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_9b5ca4f2","line":65,"updated":"2014-07-23 10:31:09.000000000","message":"You can probably make this chunk a bit tidier (less duplication) by doing something like:\n\n   kwargs \u003d {}\n   if page_size \u003e 0:\n        kwargs[\u0027page_size\u0027] \u003d page_size\n   rawImageList \u003d list(itertools.chain(\n        client.images.list(filters\u003d{\"is_public\": True}, **kwargs),\n        client.images.list(filters\u003d{\"is_public\": False}, **kwargs)))\n\n(untested, but should show the gist of what I mean).","commit_id":"9219936495dc9979e096e71ab29ddd8f523e612f"},{"author":{"_account_id":8988,"name":"Rikimaru Honjo","email":"honjo.rikimaru@ntt-tx.co.jp","username":"rikimaru.honjo","inactive":true},"change_message_id":"261003765839e1f2c49bc92df01a2d6ffd2a9d79","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        # TODO(eglynn): use pagination to protect against unbounded"},{"line_number":63,"context_line":"        #              memory usage"},{"line_number":64,"context_line":"        page_size \u003d cfg.CONF.glance_page_size"},{"line_number":65,"context_line":"        if page_size \u003c\u003d 0:"},{"line_number":66,"context_line":"            rawImageList \u003d list(itertools.chain("},{"line_number":67,"context_line":"                client.images.list(filters\u003d{\"is_public\": True}),"},{"line_number":68,"context_line":"                # TODO(eglynn): extend glance API with all_tenants logic to"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_ee613d39","line":65,"in_reply_to":"baada198_9b5ca4f2","updated":"2014-07-24 06:31:31.000000000","message":"Done.","commit_id":"9219936495dc9979e096e71ab29ddd8f523e612f"},{"author":{"_account_id":10987,"name":"Igor Degtiarov","username":"tovstun","inactive":true},"change_message_id":"8a2816f797c6fc49088b42e7f7d9abadc75b353b","unresolved":false,"context_lines":[{"line_number":66,"context_line":"        if page_size \u003e 0:"},{"line_number":67,"context_line":"            kwargs[\u0027page_size\u0027] \u003d page_size"},{"line_number":68,"context_line":"        rawImageList \u003d list(itertools.chain("},{"line_number":69,"context_line":"            client.images.list(filters\u003d{\"is_public\": True},"},{"line_number":70,"context_line":"                               **kwargs),"},{"line_number":71,"context_line":"            # TODO(eglynn): extend glance API with all_tenants logic to"},{"line_number":72,"context_line":"            #              avoid second call to retrieve private images"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_e813edb4","line":69,"updated":"2014-07-24 10:13:58.000000000","message":"Probably it would be better to write all params in one line.","commit_id":"0dc7804870738b27cf2838b07c2d2aa25d091f3b"},{"author":{"_account_id":8988,"name":"Rikimaru Honjo","email":"honjo.rikimaru@ntt-tx.co.jp","username":"rikimaru.honjo","inactive":true},"change_message_id":"e70ef41f5fe6589f17593e18d25f16cc662001ca","unresolved":false,"context_lines":[{"line_number":66,"context_line":"        if page_size \u003e 0:"},{"line_number":67,"context_line":"            kwargs[\u0027page_size\u0027] \u003d page_size"},{"line_number":68,"context_line":"        rawImageList \u003d list(itertools.chain("},{"line_number":69,"context_line":"            client.images.list(filters\u003d{\"is_public\": True},"},{"line_number":70,"context_line":"                               **kwargs),"},{"line_number":71,"context_line":"            # TODO(eglynn): extend glance API with all_tenants logic to"},{"line_number":72,"context_line":"            #              avoid second call to retrieve private images"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_067138ab","line":69,"in_reply_to":"baada198_e813edb4","updated":"2014-07-30 00:57:58.000000000","message":"Done.","commit_id":"0dc7804870738b27cf2838b07c2d2aa25d091f3b"},{"author":{"_account_id":10987,"name":"Igor Degtiarov","username":"tovstun","inactive":true},"change_message_id":"8a2816f797c6fc49088b42e7f7d9abadc75b353b","unresolved":false,"context_lines":[{"line_number":70,"context_line":"                               **kwargs),"},{"line_number":71,"context_line":"            # TODO(eglynn): extend glance API with all_tenants logic to"},{"line_number":72,"context_line":"            #              avoid second call to retrieve private images"},{"line_number":73,"context_line":"            client.images.list(filters\u003d{\"is_public\": False},"},{"line_number":74,"context_line":"                               **kwargs)))"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"        # When retrieving images from glance, glance will check"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_280ec58c","line":73,"updated":"2014-07-24 10:13:58.000000000","message":"ditto","commit_id":"0dc7804870738b27cf2838b07c2d2aa25d091f3b"},{"author":{"_account_id":8988,"name":"Rikimaru Honjo","email":"honjo.rikimaru@ntt-tx.co.jp","username":"rikimaru.honjo","inactive":true},"change_message_id":"e70ef41f5fe6589f17593e18d25f16cc662001ca","unresolved":false,"context_lines":[{"line_number":70,"context_line":"                               **kwargs),"},{"line_number":71,"context_line":"            # TODO(eglynn): extend glance API with all_tenants logic to"},{"line_number":72,"context_line":"            #              avoid second call to retrieve private images"},{"line_number":73,"context_line":"            client.images.list(filters\u003d{\"is_public\": False},"},{"line_number":74,"context_line":"                               **kwargs)))"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"        # When retrieving images from glance, glance will check"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_667034a5","line":73,"in_reply_to":"baada198_280ec58c","updated":"2014-07-30 00:57:58.000000000","message":"Done.","commit_id":"0dc7804870738b27cf2838b07c2d2aa25d091f3b"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"903750715a9884e83e127974e3be235696a5518f","unresolved":false,"context_lines":[{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    def _get_images(self, ksclient):"},{"line_number":61,"context_line":"        client \u003d self.get_glance_client(ksclient)"},{"line_number":62,"context_line":"        # TODO(eglynn): use pagination to protect against unbounded"},{"line_number":63,"context_line":"        #              memory usage"},{"line_number":64,"context_line":"        page_size \u003d cfg.CONF.glance_page_size"},{"line_number":65,"context_line":"        kwargs \u003d {}"}],"source_content_type":"text/x-python","patch_set":7,"id":"baada198_fc27451c","line":62,"updated":"2014-08-07 20:13:16.000000000","message":"safe to remove TODO now?","commit_id":"3ddd211bcfcac45f9389a734539db715e56f6937"},{"author":{"_account_id":8988,"name":"Rikimaru Honjo","email":"honjo.rikimaru@ntt-tx.co.jp","username":"rikimaru.honjo","inactive":true},"change_message_id":"6412635079012ffb848a14734aa5b94f37c78a2c","unresolved":false,"context_lines":[{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    def _get_images(self, ksclient):"},{"line_number":61,"context_line":"        client \u003d self.get_glance_client(ksclient)"},{"line_number":62,"context_line":"        # TODO(eglynn): use pagination to protect against unbounded"},{"line_number":63,"context_line":"        #              memory usage"},{"line_number":64,"context_line":"        page_size \u003d cfg.CONF.glance_page_size"},{"line_number":65,"context_line":"        kwargs \u003d {}"}],"source_content_type":"text/x-python","patch_set":7,"id":"baada198_04919e45","line":62,"in_reply_to":"baada198_73c30239","updated":"2014-08-11 13:02:04.000000000","message":"Done","commit_id":"3ddd211bcfcac45f9389a734539db715e56f6937"},{"author":{"_account_id":3012,"name":"Dina Belova","email":"dbelova@mirantis.com","username":"dbelova"},"change_message_id":"657531b1679a3e22ee6bfb211b98566e8bcee911","unresolved":false,"context_lines":[{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    def _get_images(self, ksclient):"},{"line_number":61,"context_line":"        client \u003d self.get_glance_client(ksclient)"},{"line_number":62,"context_line":"        # TODO(eglynn): use pagination to protect against unbounded"},{"line_number":63,"context_line":"        #              memory usage"},{"line_number":64,"context_line":"        page_size \u003d cfg.CONF.glance_page_size"},{"line_number":65,"context_line":"        kwargs \u003d {}"}],"source_content_type":"text/x-python","patch_set":7,"id":"baada198_73c30239","line":62,"in_reply_to":"baada198_fc27451c","updated":"2014-08-11 11:40:35.000000000","message":"a-ha, yes, that needs to be removed here for sure","commit_id":"3ddd211bcfcac45f9389a734539db715e56f6937"}],"ceilometer/tests/image/test_glance.py":[{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"0ac5f2b523dcfe6b9c45ef06fe83beaee469d087","unresolved":false,"context_lines":[{"line_number":138,"context_line":"            side_effect\u003dself.fake_get_glance_client))"},{"line_number":139,"context_line":"        self.CONF \u003d self.useFixture(config.Config()).conf"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"    def test_page_size(self):"},{"line_number":142,"context_line":"        self.CONF.set_override(\"glance_page_size\", 100)"},{"line_number":143,"context_line":"        images \u003d list(glance.ImagePollster()."},{"line_number":144,"context_line":"                      _iter_images(self.manager.keystone, {}))"}],"source_content_type":"text/x-python","patch_set":5,"id":"baada198_320a9d27","line":141,"updated":"2014-08-01 02:28:10.000000000","message":"forgive my nitpicking. Seems the following 3 test cases have quite some common code, could you please move the common code into one internal function?","commit_id":"bd70540b1911cbd05b695a6fa53e111ae5ff8933"},{"author":{"_account_id":8988,"name":"Rikimaru Honjo","email":"honjo.rikimaru@ntt-tx.co.jp","username":"rikimaru.honjo","inactive":true},"change_message_id":"5f39e254e8a1b6e17a7880a44450b855cd1cdf1d","unresolved":false,"context_lines":[{"line_number":138,"context_line":"            side_effect\u003dself.fake_get_glance_client))"},{"line_number":139,"context_line":"        self.CONF \u003d self.useFixture(config.Config()).conf"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"    def test_page_size(self):"},{"line_number":142,"context_line":"        self.CONF.set_override(\"glance_page_size\", 100)"},{"line_number":143,"context_line":"        images \u003d list(glance.ImagePollster()."},{"line_number":144,"context_line":"                      _iter_images(self.manager.keystone, {}))"}],"source_content_type":"text/x-python","patch_set":5,"id":"baada198_41e3b39f","line":141,"in_reply_to":"baada198_320a9d27","updated":"2014-08-01 11:31:41.000000000","message":"Done.","commit_id":"bd70540b1911cbd05b695a6fa53e111ae5ff8933"}],"doc/source/configuration.rst":[{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"cf54e5b41f5e76ddb394d6c06a25eddba45888ab","unresolved":false,"context_lines":[{"line_number":47,"context_line":"                                                                       request (parameter used by glancecelient). If this is less "},{"line_number":48,"context_line":"                                                                       than or equal to 0, page size is not specified (default value "},{"line_number":49,"context_line":"                                                                       in glanceclient is used). It is better to check and set "},{"line_number":50,"context_line":"                                                                       appropriate value in line with each environment when calling "},{"line_number":51,"context_line":"                                                                       glanceclient, than to define higher default value."},{"line_number":52,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d  \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d  \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":53,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"baada198_43df973a","line":50,"updated":"2014-07-30 08:54:08.000000000","message":"Lines 46-50 end in whitespace and shouldn\u0027t.","commit_id":"714d95c3c657232ef7852799b1d169429f5a493e"},{"author":{"_account_id":8988,"name":"Rikimaru Honjo","email":"honjo.rikimaru@ntt-tx.co.jp","username":"rikimaru.honjo","inactive":true},"change_message_id":"5d8d8b755eecba11f3095ce7b46cbaa940d71544","unresolved":false,"context_lines":[{"line_number":47,"context_line":"                                                                       request (parameter used by glancecelient). If this is less "},{"line_number":48,"context_line":"                                                                       than or equal to 0, page size is not specified (default value "},{"line_number":49,"context_line":"                                                                       in glanceclient is used). It is better to check and set "},{"line_number":50,"context_line":"                                                                       appropriate value in line with each environment when calling "},{"line_number":51,"context_line":"                                                                       glanceclient, than to define higher default value."},{"line_number":52,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d  \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d  \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":53,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"baada198_5c6ae61b","line":50,"in_reply_to":"baada198_43df973a","updated":"2014-07-31 11:07:10.000000000","message":"Done.","commit_id":"714d95c3c657232ef7852799b1d169429f5a493e"}]}