)]}'
{"ceilometer/transformer/conversions.py":[{"author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"change_message_id":"0d932eed019fd2d217489bedcbfad1edafbb2225","unresolved":false,"context_lines":[{"line_number":188,"context_line":"                 **kwargs):"},{"line_number":189,"context_line":"        super(AggregatorTransformer, self).__init__(**kwargs)"},{"line_number":190,"context_line":"        self.samples \u003d {}"},{"line_number":191,"context_line":"        self.size \u003d int(size) if size else None"},{"line_number":192,"context_line":"        self.retention_time \u003d float(retention_time) if retention_time else None"},{"line_number":193,"context_line":"        self.initial_timestamp \u003d None"},{"line_number":194,"context_line":"        self.aggregated_samples \u003d 0"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_9846637a","line":191,"updated":"2014-07-17 09:37:11.000000000","message":"Did you intend this to include the size\u003d0 case?\n\nOr should it be:\n\n  self.size \u003d int(size) if size is not None else size\n\nto avoid setting self.size\u003dNone when size\u003d0?\n\n(I\u0027m not sure that it\u0027s even possible for size to have value 0 as opposed to \u00270\u0027 BTW, so may not be a real concern at all)","commit_id":"2a0f1e87891ea334358cb46c6b16d2f99cf0aee3"},{"author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"change_message_id":"be6451583b1fdbb9a9b403609a8963e450514f3d","unresolved":false,"context_lines":[{"line_number":188,"context_line":"                 **kwargs):"},{"line_number":189,"context_line":"        super(AggregatorTransformer, self).__init__(**kwargs)"},{"line_number":190,"context_line":"        self.samples \u003d {}"},{"line_number":191,"context_line":"        self.size \u003d int(size) if size else None"},{"line_number":192,"context_line":"        self.retention_time \u003d float(retention_time) if retention_time else None"},{"line_number":193,"context_line":"        self.initial_timestamp \u003d None"},{"line_number":194,"context_line":"        self.aggregated_samples \u003d 0"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_07c2ee52","line":191,"in_reply_to":"baada198_7b43496c","updated":"2014-07-17 11:26:16.000000000","message":"Cool enough.","commit_id":"2a0f1e87891ea334358cb46c6b16d2f99cf0aee3"},{"author":{"_account_id":8052,"name":"Nejc Saje","email":"nejc@saje.info","username":"nsaje"},"change_message_id":"1fff676cb4ec5ffe1a6348008a96b786f57bdde9","unresolved":false,"context_lines":[{"line_number":188,"context_line":"                 **kwargs):"},{"line_number":189,"context_line":"        super(AggregatorTransformer, self).__init__(**kwargs)"},{"line_number":190,"context_line":"        self.samples \u003d {}"},{"line_number":191,"context_line":"        self.size \u003d int(size) if size else None"},{"line_number":192,"context_line":"        self.retention_time \u003d float(retention_time) if retention_time else None"},{"line_number":193,"context_line":"        self.initial_timestamp \u003d None"},{"line_number":194,"context_line":"        self.aggregated_samples \u003d 0"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_7b43496c","line":191,"in_reply_to":"baada198_9846637a","updated":"2014-07-17 09:56:38.000000000","message":"Good catch, but since it\u0027s always compared to a positive value, it doesn\u0027t matter.\n\n \u003e\u003e\u003e 5 \u003e\u003d 0\n True\n \u003e\u003e\u003e 5 \u003e\u003d None\n True","commit_id":"2a0f1e87891ea334358cb46c6b16d2f99cf0aee3"}]}