)]}'
{"ceilometer/hardware/inspector/snmp.py":[{"author":{"_account_id":8052,"name":"Nejc Saje","email":"nejc@saje.info","username":"nsaje"},"change_message_id":"15445e45e04d5ef447963c265830d54208e1e4eb","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    return (err, data)"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"TYPE_EXACT, TYPE_PREFIX \u003d range(2)"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"class SNMPInspector(base.Inspector):"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_b1ea670c","line":55,"updated":"2014-07-23 12:13:51.000000000","message":"Why not make these two be (\"exact\", \"prefix\"). I think it hardly makes a performance difference, but it does make a difference when debugging.","commit_id":"c4ebed4f3d01fde9167d26bb476f1d622fcd7ee2"},{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"e982dbe98080e7da9af6e15ace8a79b587d55bf4","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    return (err, data)"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"TYPE_EXACT, TYPE_PREFIX \u003d range(2)"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"class SNMPInspector(base.Inspector):"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_46adb79a","line":55,"in_reply_to":"baada198_b1ea670c","updated":"2014-07-24 01:40:43.000000000","message":"Done","commit_id":"c4ebed4f3d01fde9167d26bb476f1d622fcd7ee2"},{"author":{"_account_id":8052,"name":"Nejc Saje","email":"nejc@saje.info","username":"nsaje"},"change_message_id":"15445e45e04d5ef447963c265830d54208e1e4eb","unresolved":false,"context_lines":[{"line_number":242,"context_line":"                                     err\u003ddata))"},{"line_number":243,"context_line":"        # save result into cache"},{"line_number":244,"context_line":"        if type_prefix:"},{"line_number":245,"context_line":"            for varBindTableRow in data:"},{"line_number":246,"context_line":"                for name, val in varBindTableRow:"},{"line_number":247,"context_line":"                    cached_oids[name.prettyPrint()] \u003d val"},{"line_number":248,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_71160f4b","line":245,"updated":"2014-07-23 12:13:51.000000000","message":"How about var_bind_table_row to be consistent regarding camelcase?","commit_id":"c4ebed4f3d01fde9167d26bb476f1d622fcd7ee2"},{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"e982dbe98080e7da9af6e15ace8a79b587d55bf4","unresolved":false,"context_lines":[{"line_number":242,"context_line":"                                     err\u003ddata))"},{"line_number":243,"context_line":"        # save result into cache"},{"line_number":244,"context_line":"        if type_prefix:"},{"line_number":245,"context_line":"            for varBindTableRow in data:"},{"line_number":246,"context_line":"                for name, val in varBindTableRow:"},{"line_number":247,"context_line":"                    cached_oids[name.prettyPrint()] \u003d val"},{"line_number":248,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_869c2f5d","line":245,"in_reply_to":"baada198_71160f4b","updated":"2014-07-24 01:40:43.000000000","message":"Done","commit_id":"c4ebed4f3d01fde9167d26bb476f1d622fcd7ee2"},{"author":{"_account_id":8052,"name":"Nejc Saje","email":"nejc@saje.info","username":"nsaje"},"change_message_id":"15445e45e04d5ef447963c265830d54208e1e4eb","unresolved":false,"context_lines":[{"line_number":278,"context_line":"            metadata[key] \u003d self.get_oid_value(cache, oid_def, suffix)"},{"line_number":279,"context_line":"        return metadata"},{"line_number":280,"context_line":""},{"line_number":281,"context_line":"    def _collect_oids(self, smap, cache):"},{"line_number":282,"context_line":"        # find oids have not been queried and cached"},{"line_number":283,"context_line":"        new_oids \u003d []"},{"line_number":284,"context_line":"        cached_oids \u003d cache.setdefault(self._CACHE_KEY_OID, {})"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_51c2eb34","line":281,"updated":"2014-07-23 12:13:51.000000000","message":"_find_missing_oids() perhaps?","commit_id":"c4ebed4f3d01fde9167d26bb476f1d622fcd7ee2"},{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"e982dbe98080e7da9af6e15ace8a79b587d55bf4","unresolved":false,"context_lines":[{"line_number":278,"context_line":"            metadata[key] \u003d self.get_oid_value(cache, oid_def, suffix)"},{"line_number":279,"context_line":"        return metadata"},{"line_number":280,"context_line":""},{"line_number":281,"context_line":"    def _collect_oids(self, smap, cache):"},{"line_number":282,"context_line":"        # find oids have not been queried and cached"},{"line_number":283,"context_line":"        new_oids \u003d []"},{"line_number":284,"context_line":"        cached_oids \u003d cache.setdefault(self._CACHE_KEY_OID, {})"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_86f18f98","line":281,"in_reply_to":"baada198_51c2eb34","updated":"2014-07-24 01:40:43.000000000","message":"Done","commit_id":"c4ebed4f3d01fde9167d26bb476f1d622fcd7ee2"},{"author":{"_account_id":8052,"name":"Nejc Saje","email":"nejc@saje.info","username":"nsaje"},"change_message_id":"15445e45e04d5ef447963c265830d54208e1e4eb","unresolved":false,"context_lines":[{"line_number":295,"context_line":"        return new_oids"},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"    def inspect_generic(self, host, identifier, cache):"},{"line_number":298,"context_line":"        smap \u003d self.MAPPING[identifier]"},{"line_number":299,"context_line":"        # collect oids that needs to be queried"},{"line_number":300,"context_line":"        oids \u003d self._collect_oids(smap, cache)"},{"line_number":301,"context_line":"        # query oids and populate into caches"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_b1750799","line":298,"updated":"2014-07-23 12:13:51.000000000","message":"Something more descriptive perhaps, like meter_definition?","commit_id":"c4ebed4f3d01fde9167d26bb476f1d622fcd7ee2"},{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"e982dbe98080e7da9af6e15ace8a79b587d55bf4","unresolved":false,"context_lines":[{"line_number":295,"context_line":"        return new_oids"},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"    def inspect_generic(self, host, identifier, cache):"},{"line_number":298,"context_line":"        smap \u003d self.MAPPING[identifier]"},{"line_number":299,"context_line":"        # collect oids that needs to be queried"},{"line_number":300,"context_line":"        oids \u003d self._collect_oids(smap, cache)"},{"line_number":301,"context_line":"        # query oids and populate into caches"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_790c1c3a","line":298,"in_reply_to":"baada198_b1750799","updated":"2014-07-24 01:40:43.000000000","message":"Done","commit_id":"c4ebed4f3d01fde9167d26bb476f1d622fcd7ee2"},{"author":{"_account_id":8052,"name":"Nejc Saje","email":"nejc@saje.info","username":"nsaje"},"change_message_id":"15445e45e04d5ef447963c265830d54208e1e4eb","unresolved":false,"context_lines":[{"line_number":297,"context_line":"    def inspect_generic(self, host, identifier, cache):"},{"line_number":298,"context_line":"        smap \u003d self.MAPPING[identifier]"},{"line_number":299,"context_line":"        # collect oids that needs to be queried"},{"line_number":300,"context_line":"        oids \u003d self._collect_oids(smap, cache)"},{"line_number":301,"context_line":"        # query oids and populate into caches"},{"line_number":302,"context_line":"        if oids:"},{"line_number":303,"context_line":"            self._query_oids(host, oids, cache,"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_6cc1d84d","line":300,"updated":"2014-07-23 12:13:51.000000000","message":"oids_to_query","commit_id":"c4ebed4f3d01fde9167d26bb476f1d622fcd7ee2"},{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"e982dbe98080e7da9af6e15ace8a79b587d55bf4","unresolved":false,"context_lines":[{"line_number":297,"context_line":"    def inspect_generic(self, host, identifier, cache):"},{"line_number":298,"context_line":"        smap \u003d self.MAPPING[identifier]"},{"line_number":299,"context_line":"        # collect oids that needs to be queried"},{"line_number":300,"context_line":"        oids \u003d self._collect_oids(smap, cache)"},{"line_number":301,"context_line":"        # query oids and populate into caches"},{"line_number":302,"context_line":"        if oids:"},{"line_number":303,"context_line":"            self._query_oids(host, oids, cache,"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_26344349","line":300,"in_reply_to":"baada198_6cc1d84d","updated":"2014-07-24 01:40:43.000000000","message":"Done","commit_id":"c4ebed4f3d01fde9167d26bb476f1d622fcd7ee2"},{"author":{"_account_id":8052,"name":"Nejc Saje","email":"nejc@saje.info","username":"nsaje"},"change_message_id":"15445e45e04d5ef447963c265830d54208e1e4eb","unresolved":false,"context_lines":[{"line_number":303,"context_line":"            self._query_oids(host, oids, cache,"},{"line_number":304,"context_line":"                             smap[\u0027matching_type\u0027] \u003d\u003d TYPE_PREFIX)"},{"line_number":305,"context_line":"        # construct (value, metadata, extra)"},{"line_number":306,"context_line":"        cache_oid \u003d cache[self._CACHE_KEY_OID]"},{"line_number":307,"context_line":"        func \u003d self.find_matching_oids"},{"line_number":308,"context_line":"        construct_oids \u003d func(cache_oid,"},{"line_number":309,"context_line":"                              smap[\u0027metric_oid\u0027][0],"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_0c93fc5c","line":306,"updated":"2014-07-23 12:13:51.000000000","message":"cached_oids perhaps?","commit_id":"c4ebed4f3d01fde9167d26bb476f1d622fcd7ee2"},{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"e982dbe98080e7da9af6e15ace8a79b587d55bf4","unresolved":false,"context_lines":[{"line_number":303,"context_line":"            self._query_oids(host, oids, cache,"},{"line_number":304,"context_line":"                             smap[\u0027matching_type\u0027] \u003d\u003d TYPE_PREFIX)"},{"line_number":305,"context_line":"        # construct (value, metadata, extra)"},{"line_number":306,"context_line":"        cache_oid \u003d cache[self._CACHE_KEY_OID]"},{"line_number":307,"context_line":"        func \u003d self.find_matching_oids"},{"line_number":308,"context_line":"        construct_oids \u003d func(cache_oid,"},{"line_number":309,"context_line":"                              smap[\u0027metric_oid\u0027][0],"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_86a98f27","line":306,"in_reply_to":"baada198_0c93fc5c","updated":"2014-07-24 01:40:43.000000000","message":"I\u0027ll change it to oid_cache, which is more descriptive.","commit_id":"c4ebed4f3d01fde9167d26bb476f1d622fcd7ee2"},{"author":{"_account_id":8052,"name":"Nejc Saje","email":"nejc@saje.info","username":"nsaje"},"change_message_id":"15445e45e04d5ef447963c265830d54208e1e4eb","unresolved":false,"context_lines":[{"line_number":304,"context_line":"                             smap[\u0027matching_type\u0027] \u003d\u003d TYPE_PREFIX)"},{"line_number":305,"context_line":"        # construct (value, metadata, extra)"},{"line_number":306,"context_line":"        cache_oid \u003d cache[self._CACHE_KEY_OID]"},{"line_number":307,"context_line":"        func \u003d self.find_matching_oids"},{"line_number":308,"context_line":"        construct_oids \u003d func(cache_oid,"},{"line_number":309,"context_line":"                              smap[\u0027metric_oid\u0027][0],"},{"line_number":310,"context_line":"                              smap[\u0027matching_type\u0027] \u003d\u003d TYPE_PREFIX,"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_31f2d7e3","line":307,"updated":"2014-07-23 12:13:51.000000000","message":"Even if you use the function name directly in the function call, you can still comply with PEP8 by putting the parameters in a new line and indent them by one block. I think it would greatly improve readability.","commit_id":"c4ebed4f3d01fde9167d26bb476f1d622fcd7ee2"},{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"e982dbe98080e7da9af6e15ace8a79b587d55bf4","unresolved":false,"context_lines":[{"line_number":304,"context_line":"                             smap[\u0027matching_type\u0027] \u003d\u003d TYPE_PREFIX)"},{"line_number":305,"context_line":"        # construct (value, metadata, extra)"},{"line_number":306,"context_line":"        cache_oid \u003d cache[self._CACHE_KEY_OID]"},{"line_number":307,"context_line":"        func \u003d self.find_matching_oids"},{"line_number":308,"context_line":"        construct_oids \u003d func(cache_oid,"},{"line_number":309,"context_line":"                              smap[\u0027metric_oid\u0027][0],"},{"line_number":310,"context_line":"                              smap[\u0027matching_type\u0027] \u003d\u003d TYPE_PREFIX,"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_c642a7aa","line":307,"in_reply_to":"baada198_31f2d7e3","updated":"2014-07-24 01:40:43.000000000","message":"Done","commit_id":"c4ebed4f3d01fde9167d26bb476f1d622fcd7ee2"},{"author":{"_account_id":8052,"name":"Nejc Saje","email":"nejc@saje.info","username":"nsaje"},"change_message_id":"15445e45e04d5ef447963c265830d54208e1e4eb","unresolved":false,"context_lines":[{"line_number":305,"context_line":"        # construct (value, metadata, extra)"},{"line_number":306,"context_line":"        cache_oid \u003d cache[self._CACHE_KEY_OID]"},{"line_number":307,"context_line":"        func \u003d self.find_matching_oids"},{"line_number":308,"context_line":"        construct_oids \u003d func(cache_oid,"},{"line_number":309,"context_line":"                              smap[\u0027metric_oid\u0027][0],"},{"line_number":310,"context_line":"                              smap[\u0027matching_type\u0027] \u003d\u003d TYPE_PREFIX,"},{"line_number":311,"context_line":"                              False)"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_acbbf0e2","line":308,"updated":"2014-07-23 12:13:51.000000000","message":"It would be extremely helpful for the reviewers if you added more comments about what is going on, and perhaps use a bit more descriptive names. All I see is \u0027oids\u0027 here, \u0027oids\u0027 there, \u0027cache\u0027 here, \u0027cache\u0027 there, and I feel like my head is going to explode :-)","commit_id":"c4ebed4f3d01fde9167d26bb476f1d622fcd7ee2"},{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"e982dbe98080e7da9af6e15ace8a79b587d55bf4","unresolved":false,"context_lines":[{"line_number":305,"context_line":"        # construct (value, metadata, extra)"},{"line_number":306,"context_line":"        cache_oid \u003d cache[self._CACHE_KEY_OID]"},{"line_number":307,"context_line":"        func \u003d self.find_matching_oids"},{"line_number":308,"context_line":"        construct_oids \u003d func(cache_oid,"},{"line_number":309,"context_line":"                              smap[\u0027metric_oid\u0027][0],"},{"line_number":310,"context_line":"                              smap[\u0027matching_type\u0027] \u003d\u003d TYPE_PREFIX,"},{"line_number":311,"context_line":"                              False)"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_8670afdb","line":308,"in_reply_to":"baada198_acbbf0e2","updated":"2014-07-24 01:40:43.000000000","message":"Done","commit_id":"c4ebed4f3d01fde9167d26bb476f1d622fcd7ee2"},{"author":{"_account_id":8052,"name":"Nejc Saje","email":"nejc@saje.info","username":"nsaje"},"change_message_id":"15445e45e04d5ef447963c265830d54208e1e4eb","unresolved":false,"context_lines":[{"line_number":307,"context_line":"        func \u003d self.find_matching_oids"},{"line_number":308,"context_line":"        construct_oids \u003d func(cache_oid,"},{"line_number":309,"context_line":"                              smap[\u0027metric_oid\u0027][0],"},{"line_number":310,"context_line":"                              smap[\u0027matching_type\u0027] \u003d\u003d TYPE_PREFIX,"},{"line_number":311,"context_line":"                              False)"},{"line_number":312,"context_line":"        for oid in construct_oids:"},{"line_number":313,"context_line":"            suffix \u003d oid[len(smap[\u0027metric_oid\u0027][0]):]"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_9102c370","line":310,"updated":"2014-07-23 12:13:51.000000000","message":"Just put this check in the find_matching_oids function.","commit_id":"c4ebed4f3d01fde9167d26bb476f1d622fcd7ee2"},{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"e982dbe98080e7da9af6e15ace8a79b587d55bf4","unresolved":false,"context_lines":[{"line_number":307,"context_line":"        func \u003d self.find_matching_oids"},{"line_number":308,"context_line":"        construct_oids \u003d func(cache_oid,"},{"line_number":309,"context_line":"                              smap[\u0027metric_oid\u0027][0],"},{"line_number":310,"context_line":"                              smap[\u0027matching_type\u0027] \u003d\u003d TYPE_PREFIX,"},{"line_number":311,"context_line":"                              False)"},{"line_number":312,"context_line":"        for oid in construct_oids:"},{"line_number":313,"context_line":"            suffix \u003d oid[len(smap[\u0027metric_oid\u0027][0]):]"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_46a13745","line":310,"in_reply_to":"baada198_9102c370","updated":"2014-07-24 01:40:43.000000000","message":"Done","commit_id":"c4ebed4f3d01fde9167d26bb476f1d622fcd7ee2"},{"author":{"_account_id":8052,"name":"Nejc Saje","email":"nejc@saje.info","username":"nsaje"},"change_message_id":"15445e45e04d5ef447963c265830d54208e1e4eb","unresolved":false,"context_lines":[{"line_number":309,"context_line":"                              smap[\u0027metric_oid\u0027][0],"},{"line_number":310,"context_line":"                              smap[\u0027matching_type\u0027] \u003d\u003d TYPE_PREFIX,"},{"line_number":311,"context_line":"                              False)"},{"line_number":312,"context_line":"        for oid in construct_oids:"},{"line_number":313,"context_line":"            suffix \u003d oid[len(smap[\u0027metric_oid\u0027][0]):]"},{"line_number":314,"context_line":"            value \u003d self.get_oid_value(cache_oid,"},{"line_number":315,"context_line":"                                       smap[\u0027metric_oid\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_ec9a4861","line":312,"updated":"2014-07-23 12:13:51.000000000","message":"for oid in meters_to_construct perhaps?","commit_id":"c4ebed4f3d01fde9167d26bb476f1d622fcd7ee2"},{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"e982dbe98080e7da9af6e15ace8a79b587d55bf4","unresolved":false,"context_lines":[{"line_number":309,"context_line":"                              smap[\u0027metric_oid\u0027][0],"},{"line_number":310,"context_line":"                              smap[\u0027matching_type\u0027] \u003d\u003d TYPE_PREFIX,"},{"line_number":311,"context_line":"                              False)"},{"line_number":312,"context_line":"        for oid in construct_oids:"},{"line_number":313,"context_line":"            suffix \u003d oid[len(smap[\u0027metric_oid\u0027][0]):]"},{"line_number":314,"context_line":"            value \u003d self.get_oid_value(cache_oid,"},{"line_number":315,"context_line":"                                       smap[\u0027metric_oid\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_e6ba4b70","line":312,"in_reply_to":"baada198_ec9a4861","updated":"2014-07-24 01:40:43.000000000","message":"Done","commit_id":"c4ebed4f3d01fde9167d26bb476f1d622fcd7ee2"},{"author":{"_account_id":8052,"name":"Nejc Saje","email":"nejc@saje.info","username":"nsaje"},"change_message_id":"15445e45e04d5ef447963c265830d54208e1e4eb","unresolved":false,"context_lines":[{"line_number":329,"context_line":"    def _post_op_net(self, host, cache, smap,"},{"line_number":330,"context_line":"                     value, metadata, extra, suffix):"},{"line_number":331,"context_line":"        # add ip address into metadata"},{"line_number":332,"context_line":"        _int_ip_oid \u003d self._interface_ip_oid"},{"line_number":333,"context_line":"        cached_oids \u003d cache.setdefault(self._CACHE_KEY_OID, {})"},{"line_number":334,"context_line":"        if not self.find_matching_oids(cached_oids,"},{"line_number":335,"context_line":"                                       _int_ip_oid,"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_d1399bf3","line":332,"updated":"2014-07-23 12:13:51.000000000","message":"This reassignment confuses the person reading the code (adds another thing they need to track mentally), do you think you could just use the original name?","commit_id":"c4ebed4f3d01fde9167d26bb476f1d622fcd7ee2"},{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"e982dbe98080e7da9af6e15ace8a79b587d55bf4","unresolved":false,"context_lines":[{"line_number":329,"context_line":"    def _post_op_net(self, host, cache, smap,"},{"line_number":330,"context_line":"                     value, metadata, extra, suffix):"},{"line_number":331,"context_line":"        # add ip address into metadata"},{"line_number":332,"context_line":"        _int_ip_oid \u003d self._interface_ip_oid"},{"line_number":333,"context_line":"        cached_oids \u003d cache.setdefault(self._CACHE_KEY_OID, {})"},{"line_number":334,"context_line":"        if not self.find_matching_oids(cached_oids,"},{"line_number":335,"context_line":"                                       _int_ip_oid,"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_99bc9008","line":332,"in_reply_to":"baada198_d1399bf3","updated":"2014-07-24 01:40:43.000000000","message":"Done","commit_id":"c4ebed4f3d01fde9167d26bb476f1d622fcd7ee2"},{"author":{"_account_id":8052,"name":"Nejc Saje","email":"nejc@saje.info","username":"nsaje"},"change_message_id":"4bf0dec2fab60bd6f542b2a06d06cabb4f714fd9","unresolved":false,"context_lines":[{"line_number":54,"context_line":"    return (err, data)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"EXACT, PREFIX \u003d range(2)"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"class SNMPInspector(base.Inspector):"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_151d7173","line":57,"updated":"2014-07-25 06:34:02.000000000","message":"I apologize for not being clearer! I meant TYPE_EXACT\u003d\u0027exact\u0027 and TYPE_PREFIX\u003d\u0027prefix\u0027. When you step through the code and see a dict that has {type: 0} it is far less helpful than {type: \u0027exact\u0027}.","commit_id":"0042a2a973b9e87a25019c3f385c205d804bad80"},{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"fe7f404dee06d32638b2ad21c3257a8417fd8214","unresolved":false,"context_lines":[{"line_number":54,"context_line":"    return (err, data)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"EXACT, PREFIX \u003d range(2)"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"class SNMPInspector(base.Inspector):"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_b0713347","line":57,"in_reply_to":"baada198_151d7173","updated":"2014-07-25 06:45:48.000000000","message":"Done","commit_id":"0042a2a973b9e87a25019c3f385c205d804bad80"},{"author":{"_account_id":8052,"name":"Nejc Saje","email":"nejc@saje.info","username":"nsaje"},"change_message_id":"4bf0dec2fab60bd6f542b2a06d06cabb4f714fd9","unresolved":false,"context_lines":[{"line_number":280,"context_line":"            value \u003d converter(value)"},{"line_number":281,"context_line":"        return value"},{"line_number":282,"context_line":""},{"line_number":283,"context_line":"    def construct_metadata(self, oid_cache, meta_defs, suffix\u003d\u0027\u0027):"},{"line_number":284,"context_line":"        metadata \u003d {}"},{"line_number":285,"context_line":"        for key, oid_def in meta_defs.iteritems():"},{"line_number":286,"context_line":"            metadata[key] \u003d self.get_oid_value(oid_cache, oid_def, suffix)"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_f09acbc3","line":283,"updated":"2014-07-25 06:34:02.000000000","message":"@classmethod","commit_id":"0042a2a973b9e87a25019c3f385c205d804bad80"},{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"fe7f404dee06d32638b2ad21c3257a8417fd8214","unresolved":false,"context_lines":[{"line_number":280,"context_line":"            value \u003d converter(value)"},{"line_number":281,"context_line":"        return value"},{"line_number":282,"context_line":""},{"line_number":283,"context_line":"    def construct_metadata(self, oid_cache, meta_defs, suffix\u003d\u0027\u0027):"},{"line_number":284,"context_line":"        metadata \u003d {}"},{"line_number":285,"context_line":"        for key, oid_def in meta_defs.iteritems():"},{"line_number":286,"context_line":"            metadata[key] \u003d self.get_oid_value(oid_cache, oid_def, suffix)"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_90c6ef47","line":283,"in_reply_to":"baada198_f09acbc3","updated":"2014-07-25 06:45:48.000000000","message":"Done","commit_id":"0042a2a973b9e87a25019c3f385c205d804bad80"},{"author":{"_account_id":8052,"name":"Nejc Saje","email":"nejc@saje.info","username":"nsaje"},"change_message_id":"4bf0dec2fab60bd6f542b2a06d06cabb4f714fd9","unresolved":false,"context_lines":[{"line_number":286,"context_line":"            metadata[key] \u003d self.get_oid_value(oid_cache, oid_def, suffix)"},{"line_number":287,"context_line":"        return metadata"},{"line_number":288,"context_line":""},{"line_number":289,"context_line":"    def _find_missing_oids(self, meter_def, cache):"},{"line_number":290,"context_line":"        # find oids have not been queried and cached"},{"line_number":291,"context_line":"        new_oids \u003d []"},{"line_number":292,"context_line":"        oid_cache \u003d cache.setdefault(self._CACHE_KEY_OID, {})"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_30a1a3f7","line":289,"updated":"2014-07-25 06:34:02.000000000","message":"@classmethod","commit_id":"0042a2a973b9e87a25019c3f385c205d804bad80"},{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"fe7f404dee06d32638b2ad21c3257a8417fd8214","unresolved":false,"context_lines":[{"line_number":286,"context_line":"            metadata[key] \u003d self.get_oid_value(oid_cache, oid_def, suffix)"},{"line_number":287,"context_line":"        return metadata"},{"line_number":288,"context_line":""},{"line_number":289,"context_line":"    def _find_missing_oids(self, meter_def, cache):"},{"line_number":290,"context_line":"        # find oids have not been queried and cached"},{"line_number":291,"context_line":"        new_oids \u003d []"},{"line_number":292,"context_line":"        oid_cache \u003d cache.setdefault(self._CACHE_KEY_OID, {})"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_b0bf73aa","line":289,"in_reply_to":"baada198_30a1a3f7","updated":"2014-07-25 06:45:48.000000000","message":"Done","commit_id":"0042a2a973b9e87a25019c3f385c205d804bad80"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"1649729108866808a3dd90690c567558c3d505bb","unresolved":false,"context_lines":[{"line_number":102,"context_line":"    \u0027\u0027\u0027"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"     The following mapping define how to construct"},{"line_number":105,"context_line":"     (value, metadata, extra) returned by insepct_generic"},{"line_number":106,"context_line":"     MAPPING \u003d {"},{"line_number":107,"context_line":"         \u0027identifier: {"},{"line_number":108,"context_line":"             \u0027matching_type\u0027: EXACT or PREFIX,"}],"source_content_type":"text/x-python","patch_set":4,"id":"baada198_2ea08a90","line":105,"updated":"2014-07-31 18:22:29.000000000","message":"(nit) s/insepct_generic/inspect_generic/","commit_id":"d8a2064e56e0a5337177d0adbaee3e5735ddc9fc"},{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"d344fb99f290d97a9ed4b664f505cad2feee6a18","unresolved":false,"context_lines":[{"line_number":102,"context_line":"    \u0027\u0027\u0027"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"     The following mapping define how to construct"},{"line_number":105,"context_line":"     (value, metadata, extra) returned by insepct_generic"},{"line_number":106,"context_line":"     MAPPING \u003d {"},{"line_number":107,"context_line":"         \u0027identifier: {"},{"line_number":108,"context_line":"             \u0027matching_type\u0027: EXACT or PREFIX,"}],"source_content_type":"text/x-python","patch_set":4,"id":"baada198_4f9e8e55","line":105,"in_reply_to":"baada198_2ea08a90","updated":"2014-08-01 02:53:57.000000000","message":"Done","commit_id":"d8a2064e56e0a5337177d0adbaee3e5735ddc9fc"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"1649729108866808a3dd90690c567558c3d505bb","unresolved":false,"context_lines":[{"line_number":306,"context_line":"        return new_oids"},{"line_number":307,"context_line":""},{"line_number":308,"context_line":"    def inspect_generic(self, host, identifier, cache):"},{"line_number":309,"context_line":"        # the snmp definition for the correspdoning meter"},{"line_number":310,"context_line":"        meter_def \u003d self.MAPPING[identifier]"},{"line_number":311,"context_line":"        # collect oids that needs to be queried"},{"line_number":312,"context_line":"        oids_to_query \u003d self._find_missing_oids(meter_def, cache)"}],"source_content_type":"text/x-python","patch_set":4,"id":"baada198_ae92daf9","line":309,"updated":"2014-07-31 18:22:29.000000000","message":"(nit) s/correspdoning/corresponding/","commit_id":"d8a2064e56e0a5337177d0adbaee3e5735ddc9fc"},{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"d344fb99f290d97a9ed4b664f505cad2feee6a18","unresolved":false,"context_lines":[{"line_number":306,"context_line":"        return new_oids"},{"line_number":307,"context_line":""},{"line_number":308,"context_line":"    def inspect_generic(self, host, identifier, cache):"},{"line_number":309,"context_line":"        # the snmp definition for the correspdoning meter"},{"line_number":310,"context_line":"        meter_def \u003d self.MAPPING[identifier]"},{"line_number":311,"context_line":"        # collect oids that needs to be queried"},{"line_number":312,"context_line":"        oids_to_query \u003d self._find_missing_oids(meter_def, cache)"}],"source_content_type":"text/x-python","patch_set":4,"id":"baada198_cfb9becc","line":309,"in_reply_to":"baada198_ae92daf9","updated":"2014-08-01 02:53:57.000000000","message":"Done","commit_id":"d8a2064e56e0a5337177d0adbaee3e5735ddc9fc"},{"author":{"_account_id":7478,"name":"Nadya Shakhat","email":"nadmi4@gmail.com","username":"nprivalova"},"change_message_id":"54f81b688b607f4a3727106aa4bee5909a693853","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"def parse_snmp_return(ret, is_bulk\u003dFalse):"},{"line_number":32,"context_line":"    \"\"\"Check the return value of snmp operations"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    :param ret: a tuple of (errorIndication, errorStatus, errorIndex, data)"},{"line_number":35,"context_line":"                returned by pysnmp"},{"line_number":36,"context_line":"    :return: a tuple of (err, data)"}],"source_content_type":"text/x-python","patch_set":6,"id":"1abeadc6_b542580e","line":33,"updated":"2014-08-19 11:19:53.000000000","message":"Could you please add a description about new \u0027is_bulk\u0027 param?","commit_id":"73085a47dfcb71ec01eace3f2700ac605f6ee519"},{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"a479c5d85d27628f80b3f8e1cc65a5533efcddb7","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"def parse_snmp_return(ret, is_bulk\u003dFalse):"},{"line_number":32,"context_line":"    \"\"\"Check the return value of snmp operations"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    :param ret: a tuple of (errorIndication, errorStatus, errorIndex, data)"},{"line_number":35,"context_line":"                returned by pysnmp"},{"line_number":36,"context_line":"    :return: a tuple of (err, data)"}],"source_content_type":"text/x-python","patch_set":6,"id":"1abeadc6_fa09efdd","line":33,"in_reply_to":"1abeadc6_b542580e","updated":"2014-08-20 06:02:54.000000000","message":"Done","commit_id":"73085a47dfcb71ec01eace3f2700ac605f6ee519"},{"author":{"_account_id":7585,"name":"Ladislav Smola","email":"lsmola@redhat.com","username":"lsmola"},"change_message_id":"5139d08867a621de5ac657b38f3e62be69e379bd","unresolved":false,"context_lines":[{"line_number":154,"context_line":"         extra.update(\u0027project_id\u0027: xy, \u0027user_id\u0027: zw)"},{"line_number":155,"context_line":"    \u0027\u0027\u0027"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"    MAPPING \u003d {"},{"line_number":158,"context_line":"        \u0027cpu.load.1min\u0027: {"},{"line_number":159,"context_line":"            \u0027matching_type\u0027: EXACT,"},{"line_number":160,"context_line":"            \u0027metric_oid\u0027: (_cpu_1_min_load_oid, lambda x: float(str(x))),"}],"source_content_type":"text/x-python","patch_set":6,"id":"7ac7a964_07d92483","line":157,"updated":"2014-08-15 07:10:33.000000000","message":"At some point we will need to separate it into multiple files, if somebody is planning to add hundreds of OIDs.\n\nBut it is acceptable for now.","commit_id":"73085a47dfcb71ec01eace3f2700ac605f6ee519"}],"ceilometer/tests/hardware/inspector/test_snmp.py":[{"author":{"_account_id":8052,"name":"Nejc Saje","email":"nejc@saje.info","username":"nsaje"},"change_message_id":"4bf0dec2fab60bd6f542b2a06d06cabb4f714fd9","unresolved":false,"context_lines":[{"line_number":215,"context_line":"def faux_getCmd_new(authData, transportTarget, *oids, **kwargs):"},{"line_number":216,"context_line":"    varBinds \u003d []"},{"line_number":217,"context_line":"    for oid in oids:"},{"line_number":218,"context_line":"        varBinds.append((FakeObjectName(oid), int(oid.split(\u0027.\u0027)[-1])))"},{"line_number":219,"context_line":"    return (None, None, 0, varBinds)"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_704a3b28","line":218,"updated":"2014-07-25 06:34:02.000000000","message":"varBinds \u003d [(FakeObjectName(oid), int(oid.split(\u0027.\u0027)[-1])) for oid in oids]","commit_id":"0042a2a973b9e87a25019c3f385c205d804bad80"},{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"fe7f404dee06d32638b2ad21c3257a8417fd8214","unresolved":false,"context_lines":[{"line_number":215,"context_line":"def faux_getCmd_new(authData, transportTarget, *oids, **kwargs):"},{"line_number":216,"context_line":"    varBinds \u003d []"},{"line_number":217,"context_line":"    for oid in oids:"},{"line_number":218,"context_line":"        varBinds.append((FakeObjectName(oid), int(oid.split(\u0027.\u0027)[-1])))"},{"line_number":219,"context_line":"    return (None, None, 0, varBinds)"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_70f79b8c","line":218,"in_reply_to":"baada198_704a3b28","updated":"2014-07-25 06:45:48.000000000","message":"Done","commit_id":"0042a2a973b9e87a25019c3f385c205d804bad80"},{"author":{"_account_id":8052,"name":"Nejc Saje","email":"nejc@saje.info","username":"nsaje"},"change_message_id":"4bf0dec2fab60bd6f542b2a06d06cabb4f714fd9","unresolved":false,"context_lines":[{"line_number":226,"context_line":"        varBindTableRow \u003d []"},{"line_number":227,"context_line":"        varBindTableRow.append((FakeObjectName(oid + \".1\"), 1))"},{"line_number":228,"context_line":"        varBindTableRow.append((FakeObjectName(oid + \".2\"), 2))"},{"line_number":229,"context_line":"        varBindTable.append(varBindTableRow)"},{"line_number":230,"context_line":"    return (None, None, 0, varBindTable)"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_305443c5","line":229,"updated":"2014-07-25 06:34:02.000000000","message":"varBindTable \u003d [\n    [(FakeObjectName(oid + \".%d\" % i), i) for i in range(1, 3)]\n    for oid in oids\n]","commit_id":"0042a2a973b9e87a25019c3f385c205d804bad80"},{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"fe7f404dee06d32638b2ad21c3257a8417fd8214","unresolved":false,"context_lines":[{"line_number":226,"context_line":"        varBindTableRow \u003d []"},{"line_number":227,"context_line":"        varBindTableRow.append((FakeObjectName(oid + \".1\"), 1))"},{"line_number":228,"context_line":"        varBindTableRow.append((FakeObjectName(oid + \".2\"), 2))"},{"line_number":229,"context_line":"        varBindTable.append(varBindTableRow)"},{"line_number":230,"context_line":"    return (None, None, 0, varBindTable)"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_d06f8726","line":229,"in_reply_to":"baada198_305443c5","updated":"2014-07-25 06:45:48.000000000","message":"Done","commit_id":"0042a2a973b9e87a25019c3f385c205d804bad80"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"1649729108866808a3dd90690c567558c3d505bb","unresolved":false,"context_lines":[{"line_number":235,"context_line":"            \u0027metadata\u0027: {"},{"line_number":236,"context_line":"                \u0027meta\u0027: (\u00271.3.6.1.4.1.2021.10.1.3.8\u0027, int)"},{"line_number":237,"context_line":"            },"},{"line_number":238,"context_line":"            \u0027post_op\u0027: None,"},{"line_number":239,"context_line":"        },"},{"line_number":240,"context_line":"        \u0027test_prefix\u0027: {"},{"line_number":241,"context_line":"            \u0027matching_type\u0027: snmp.PREFIX,"}],"source_content_type":"text/x-python","patch_set":4,"id":"baada198_2986c4ba","line":238,"updated":"2014-07-31 18:22:29.000000000","message":"be good to have a test against post_op functionality","commit_id":"d8a2064e56e0a5337177d0adbaee3e5735ddc9fc"},{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"d344fb99f290d97a9ed4b664f505cad2feee6a18","unresolved":false,"context_lines":[{"line_number":235,"context_line":"            \u0027metadata\u0027: {"},{"line_number":236,"context_line":"                \u0027meta\u0027: (\u00271.3.6.1.4.1.2021.10.1.3.8\u0027, int)"},{"line_number":237,"context_line":"            },"},{"line_number":238,"context_line":"            \u0027post_op\u0027: None,"},{"line_number":239,"context_line":"        },"},{"line_number":240,"context_line":"        \u0027test_prefix\u0027: {"},{"line_number":241,"context_line":"            \u0027matching_type\u0027: snmp.PREFIX,"}],"source_content_type":"text/x-python","patch_set":4,"id":"baada198_05571502","line":238,"in_reply_to":"baada198_2986c4ba","updated":"2014-08-01 02:53:57.000000000","message":"Done","commit_id":"d8a2064e56e0a5337177d0adbaee3e5735ddc9fc"}]}