)]}'
{"ceilometer/hardware/plugin.py":[{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"11da95324709a5729a990fea26d6f8ff4d6a3dc6","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    \"\"\"Base class for plugins that support the polling API.\"\"\""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    CACHE_KEY \u003d None"},{"line_number":40,"context_line":"    IDENDIFIER \u003d None"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    def __init__(self):"},{"line_number":43,"context_line":"        super(HardwarePollster, self).__init__()"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_20efa01e","line":40,"updated":"2014-07-24 21:22:11.000000000","message":"s/IDENDIFIER/IDENTIFIER","commit_id":"f6be3a40028981d6f813b1af4a45fe9eb4ef039f"},{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"634e2ec71f420c3ac2af6338fde259e80f57dce7","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    \"\"\"Base class for plugins that support the polling API.\"\"\""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    CACHE_KEY \u003d None"},{"line_number":40,"context_line":"    IDENDIFIER \u003d None"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    def __init__(self):"},{"line_number":43,"context_line":"        super(HardwarePollster, self).__init__()"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_012c5b49","line":40,"in_reply_to":"baada198_20efa01e","updated":"2014-07-25 01:19:55.000000000","message":"my stupidity, will correct soon :(","commit_id":"f6be3a40028981d6f813b1af4a45fe9eb4ef039f"},{"author":{"_account_id":10987,"name":"Igor Degtiarov","username":"tovstun","inactive":true},"change_message_id":"14daf290f5a1b613145511952377d2e831be05ec","unresolved":false,"context_lines":[{"line_number":70,"context_line":"                        parsed_url,"},{"line_number":71,"context_line":"                        i_cache[self.IDENTIFIER]))"},{"line_number":72,"context_line":"            except Exception as err:"},{"line_number":73,"context_line":"                LOG.exception(_(\u0027inspector call failed for %(ident)s\u0027"},{"line_number":74,"context_line":"                                \u0027host %(host)s: %(err)s\u0027),"},{"line_number":75,"context_line":"                              dict(ident\u003dself.IDENTIFIER,"},{"line_number":76,"context_line":"                                   host\u003dparsed_url.hostname,"}],"source_content_type":"text/x-python","patch_set":4,"id":"baada198_26963cf0","line":73,"updated":"2014-08-06 10:51:08.000000000","message":"Probably we need to finish this Log line with additional whitespace s/%(ident)s\u0027/%(ident)s \u0027?","commit_id":"7ddae428990dde629b30546f9aa7d98b167f30a0"},{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"58e47781b34e2e8997c21d9af5ec68238d88dddf","unresolved":false,"context_lines":[{"line_number":70,"context_line":"                        parsed_url,"},{"line_number":71,"context_line":"                        i_cache[self.IDENTIFIER]))"},{"line_number":72,"context_line":"            except Exception as err:"},{"line_number":73,"context_line":"                LOG.exception(_(\u0027inspector call failed for %(ident)s\u0027"},{"line_number":74,"context_line":"                                \u0027host %(host)s: %(err)s\u0027),"},{"line_number":75,"context_line":"                              dict(ident\u003dself.IDENTIFIER,"},{"line_number":76,"context_line":"                                   host\u003dparsed_url.hostname,"}],"source_content_type":"text/x-python","patch_set":4,"id":"7ac7a964_60c11be4","line":73,"in_reply_to":"baada198_26963cf0","updated":"2014-08-14 02:19:32.000000000","message":"Done","commit_id":"7ddae428990dde629b30546f9aa7d98b167f30a0"},{"author":{"_account_id":10987,"name":"Igor Degtiarov","username":"tovstun","inactive":true},"change_message_id":"6ac56d2960679c4d1c27951700fba2b4590fd82a","unresolved":false,"context_lines":[{"line_number":93,"context_line":"        :param host_url: host url of the endpoint"},{"line_number":94,"context_line":"        :param c_data: data returned by the inspector.inspect_generic,"},{"line_number":95,"context_line":"                       tuple of (value, metadata, extra)"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"        \"\"\""},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    def _get_inspector(self, parsed_url):"}],"source_content_type":"text/x-python","patch_set":6,"id":"1abeadc6_05cc90bb","line":96,"updated":"2014-08-20 07:01:58.000000000","message":"Extra empty line is not needed here.","commit_id":"a481326daf79e0a95b087485325d62fa1b84d951"},{"author":{"_account_id":6763,"name":"jingliuqing","email":"jing.liuqing@99cloud.net","username":"jing"},"change_message_id":"8c76bd1d22a2026f30a05033420b8b618ca62d32","unresolved":false,"context_lines":[{"line_number":93,"context_line":"        :param host_url: host url of the endpoint"},{"line_number":94,"context_line":"        :param c_data: data returned by the inspector.inspect_generic,"},{"line_number":95,"context_line":"                       tuple of (value, metadata, extra)"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"        \"\"\""},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    def _get_inspector(self, parsed_url):"}],"source_content_type":"text/x-python","patch_set":6,"id":"1abeadc6_c6137eb6","line":96,"in_reply_to":"1abeadc6_05cc90bb","updated":"2014-08-20 08:50:50.000000000","message":"+1","commit_id":"a481326daf79e0a95b087485325d62fa1b84d951"},{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"ec25b3d697b23259bbfe5ec546897c2109ea4bcf","unresolved":false,"context_lines":[{"line_number":93,"context_line":"        :param host_url: host url of the endpoint"},{"line_number":94,"context_line":"        :param c_data: data returned by the inspector.inspect_generic,"},{"line_number":95,"context_line":"                       tuple of (value, metadata, extra)"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"        \"\"\""},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    def _get_inspector(self, parsed_url):"}],"source_content_type":"text/x-python","patch_set":6,"id":"1abeadc6_61f7d3f5","line":96,"in_reply_to":"1abeadc6_c6137eb6","updated":"2014-08-21 00:26:39.000000000","message":"Done","commit_id":"a481326daf79e0a95b087485325d62fa1b84d951"}],"ceilometer/hardware/pollsters/cpu.py":[{"author":{"_account_id":10987,"name":"Igor Degtiarov","username":"tovstun","inactive":true},"change_message_id":"14daf290f5a1b613145511952377d2e831be05ec","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    CACHE_KEY \u003d \u0027cpu\u0027"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    def generate_one_sample(self, host, c_data):"},{"line_number":31,"context_line":"        (value, metadata, extra) \u003d c_data"},{"line_number":32,"context_line":"        return util.make_sample_from_host(host,"},{"line_number":33,"context_line":"                                          name\u003dself.IDENTIFIER,"},{"line_number":34,"context_line":"                                          sample_type\u003dsample.TYPE_GAUGE,"}],"source_content_type":"text/x-python","patch_set":4,"id":"baada198_a656cc29","line":31,"updated":"2014-08-06 10:51:08.000000000","message":"Just a nitpicking: we don\u0027t really need parentheses in that line, but of course it up to your style of coding.","commit_id":"7ddae428990dde629b30546f9aa7d98b167f30a0"},{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"58e47781b34e2e8997c21d9af5ec68238d88dddf","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    CACHE_KEY \u003d \u0027cpu\u0027"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    def generate_one_sample(self, host, c_data):"},{"line_number":31,"context_line":"        (value, metadata, extra) \u003d c_data"},{"line_number":32,"context_line":"        return util.make_sample_from_host(host,"},{"line_number":33,"context_line":"                                          name\u003dself.IDENTIFIER,"},{"line_number":34,"context_line":"                                          sample_type\u003dsample.TYPE_GAUGE,"}],"source_content_type":"text/x-python","patch_set":4,"id":"7ac7a964_80447775","line":31,"in_reply_to":"baada198_a656cc29","updated":"2014-08-14 02:19:32.000000000","message":"I just want to remind myself it\u0027s a tuple :)","commit_id":"7ddae428990dde629b30546f9aa7d98b167f30a0"},{"author":{"_account_id":6763,"name":"jingliuqing","email":"jing.liuqing@99cloud.net","username":"jing"},"change_message_id":"8c76bd1d22a2026f30a05033420b8b618ca62d32","unresolved":false,"context_lines":[{"line_number":35,"context_line":"                                          unit\u003d\u0027process\u0027,"},{"line_number":36,"context_line":"                                          volume\u003dvalue,"},{"line_number":37,"context_line":"                                          res_metadata\u003dmetadata,"},{"line_number":38,"context_line":"                                          extra\u003dextra)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"class CPULoad1MinPollster(_Base):"}],"source_content_type":"text/x-python","patch_set":6,"id":"1abeadc6_265fd273","line":38,"updated":"2014-08-20 08:50:50.000000000","message":"Nice refactor","commit_id":"a481326daf79e0a95b087485325d62fa1b84d951"},{"author":{"_account_id":10987,"name":"Igor Degtiarov","username":"tovstun","inactive":true},"change_message_id":"438da6c374777582d13c2fa16ed0919b12c04402","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    CACHE_KEY \u003d \u0027cpu\u0027"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    def generate_one_sample(self, host, c_data):"},{"line_number":31,"context_line":"        (value, metadata, extra) \u003d c_data"},{"line_number":32,"context_line":"        return util.make_sample_from_host(host,"},{"line_number":33,"context_line":"                                          name\u003dself.IDENTIFIER,"},{"line_number":34,"context_line":"                                          sample_type\u003dsample.TYPE_GAUGE,"}],"source_content_type":"text/x-python","patch_set":7,"id":"1abeadc6_08e55cdc","line":31,"updated":"2014-08-21 05:07:56.000000000","message":"Parentheses is not needed here \ns/(value, metadata, extra)/value, metadata, extra/ \nwould be better","commit_id":"79121d61bf346b8f9b3c50daf913f40b83cf0e96"},{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"e456cba2615a4fa5c10df3362bbd11e422bbcfe3","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    CACHE_KEY \u003d \u0027cpu\u0027"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    def generate_one_sample(self, host, c_data):"},{"line_number":31,"context_line":"        (value, metadata, extra) \u003d c_data"},{"line_number":32,"context_line":"        return util.make_sample_from_host(host,"},{"line_number":33,"context_line":"                                          name\u003dself.IDENTIFIER,"},{"line_number":34,"context_line":"                                          sample_type\u003dsample.TYPE_GAUGE,"}],"source_content_type":"text/x-python","patch_set":7,"id":"1abeadc6_07446ab5","line":31,"in_reply_to":"1abeadc6_08e55cdc","updated":"2014-08-21 06:40:20.000000000","message":"Done","commit_id":"79121d61bf346b8f9b3c50daf913f40b83cf0e96"}],"ceilometer/hardware/pollsters/disk.py":[{"author":{"_account_id":10987,"name":"Igor Degtiarov","username":"tovstun","inactive":true},"change_message_id":"14daf290f5a1b613145511952377d2e831be05ec","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    CACHE_KEY \u003d \u0027disk\u0027"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    def generate_one_sample(self, host, c_data):"},{"line_number":31,"context_line":"        (value, metadata, extra) \u003d c_data"},{"line_number":32,"context_line":"        res_id \u003d host.hostname"},{"line_number":33,"context_line":"        if metadata.get(\u0027device\u0027):"},{"line_number":34,"context_line":"            res_id \u003d res_id + \".%s\" % metadata.get(\u0027device\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"baada198_6613d465","line":31,"updated":"2014-08-06 10:51:08.000000000","message":"ditto","commit_id":"7ddae428990dde629b30546f9aa7d98b167f30a0"},{"author":{"_account_id":7585,"name":"Ladislav Smola","email":"lsmola@redhat.com","username":"lsmola"},"change_message_id":"667f1e69e1e43fcd6476ef7937ba38aaf572c55d","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        res_id \u003d host.hostname"},{"line_number":33,"context_line":"        if metadata.get(\u0027device\u0027):"},{"line_number":34,"context_line":"            res_id \u003d res_id + \".%s\" % metadata.get(\u0027device\u0027)"},{"line_number":35,"context_line":"        return util.make_sample_from_host(host,"},{"line_number":36,"context_line":"                                          name\u003dself.IDENTIFIER,"},{"line_number":37,"context_line":"                                          sample_type\u003dsample.TYPE_GAUGE,"},{"line_number":38,"context_line":"                                          unit\u003d\u0027B\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"7ac7a964_47195c78","line":35,"updated":"2014-08-15 07:08:26.000000000","message":"I wonder if we can get even further and just have 1 generic pollster.\n\nSo we would just move everything to the inspector mapping. So unit is easy. And res_id would be done similar as post_op which would be called in generic pollster.\n\nOtherwise it\u0027s still dull to have to add these pollsters.\n\nDoes it make sense?","commit_id":"02d2aa0fa95fd67f770a46860293e5e1af324536"},{"author":{"_account_id":7585,"name":"Ladislav Smola","email":"lsmola@redhat.com","username":"lsmola"},"change_message_id":"7531932fe40d3ccb9a531d06c63e759f6cf00519","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        res_id \u003d host.hostname"},{"line_number":33,"context_line":"        if metadata.get(\u0027device\u0027):"},{"line_number":34,"context_line":"            res_id \u003d res_id + \".%s\" % metadata.get(\u0027device\u0027)"},{"line_number":35,"context_line":"        return util.make_sample_from_host(host,"},{"line_number":36,"context_line":"                                          name\u003dself.IDENTIFIER,"},{"line_number":37,"context_line":"                                          sample_type\u003dsample.TYPE_GAUGE,"},{"line_number":38,"context_line":"                                          unit\u003d\u0027B\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"1abeadc6_f62c7aae","line":35,"in_reply_to":"1abeadc6_c85f480d","updated":"2014-08-21 09:59:08.000000000","message":"You still can control what to meter by pipeline.\n\nNevertheless,  more and more I am starting to think that this pollster/inspector architecture is not the best we can get for SNMP. I believe that all of this could be rewritten to some YAML config with logic similar to arithmetic transformer.\n\nWe are expecting to have a lot of Vendor specific OIDs, so best if we can just change one YAML in /etc and we have it configured. Or to add one plugin file for metering extra set of OIDs, if the yaml way will be too hard or limited\n\nFor Production and Enterprise use, this needs to be configurable much easier, otherwise we will have hard time monitoring different hardware. This is good enough for J, but I believe we can push this further in K. :-)","commit_id":"02d2aa0fa95fd67f770a46860293e5e1af324536"},{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"212e0d5fee01d9c00ee61f1dcf870cbd156bf754","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        res_id \u003d host.hostname"},{"line_number":33,"context_line":"        if metadata.get(\u0027device\u0027):"},{"line_number":34,"context_line":"            res_id \u003d res_id + \".%s\" % metadata.get(\u0027device\u0027)"},{"line_number":35,"context_line":"        return util.make_sample_from_host(host,"},{"line_number":36,"context_line":"                                          name\u003dself.IDENTIFIER,"},{"line_number":37,"context_line":"                                          sample_type\u003dsample.TYPE_GAUGE,"},{"line_number":38,"context_line":"                                          unit\u003d\u0027B\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"1abeadc6_c85f480d","line":35,"in_reply_to":"7ac7a964_47195c78","updated":"2014-08-19 01:24:06.000000000","message":"The reason that we still have separate pollsters and inspector is that this gives us the possibility to add another type of inspector in the future in framework perspective.\n\nAnd all these sample_type \u0026 sample_unit things are independant of specific inspectors, So I think it would be better to leave these in pollster instead of putting them into specific pollster.\n\nBesides, 1 generic pollster doesn\u0027t give the admin the opportunity to fine-grain control what metrics to poll and what not, it\u0027s either all or none.\n\nAny comment?","commit_id":"02d2aa0fa95fd67f770a46860293e5e1af324536"},{"author":{"_account_id":10987,"name":"Igor Degtiarov","username":"tovstun","inactive":true},"change_message_id":"438da6c374777582d13c2fa16ed0919b12c04402","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    CACHE_KEY \u003d \u0027disk\u0027"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    def generate_one_sample(self, host, c_data):"},{"line_number":31,"context_line":"        (value, metadata, extra) \u003d c_data"},{"line_number":32,"context_line":"        res_id \u003d host.hostname"},{"line_number":33,"context_line":"        if metadata.get(\u0027device\u0027):"},{"line_number":34,"context_line":"            res_id \u003d res_id + \".%s\" % metadata.get(\u0027device\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"1abeadc6_88d08cf7","line":31,"updated":"2014-08-21 05:07:56.000000000","message":"ditto parentheses is useless","commit_id":"79121d61bf346b8f9b3c50daf913f40b83cf0e96"},{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"e456cba2615a4fa5c10df3362bbd11e422bbcfe3","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    CACHE_KEY \u003d \u0027disk\u0027"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    def generate_one_sample(self, host, c_data):"},{"line_number":31,"context_line":"        (value, metadata, extra) \u003d c_data"},{"line_number":32,"context_line":"        res_id \u003d host.hostname"},{"line_number":33,"context_line":"        if metadata.get(\u0027device\u0027):"},{"line_number":34,"context_line":"            res_id \u003d res_id + \".%s\" % metadata.get(\u0027device\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"1abeadc6_670a7e7a","line":31,"in_reply_to":"1abeadc6_88d08cf7","updated":"2014-08-21 06:40:20.000000000","message":"Done","commit_id":"79121d61bf346b8f9b3c50daf913f40b83cf0e96"}],"ceilometer/hardware/pollsters/memory.py":[{"author":{"_account_id":10987,"name":"Igor Degtiarov","username":"tovstun","inactive":true},"change_message_id":"14daf290f5a1b613145511952377d2e831be05ec","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    CACHE_KEY \u003d \u0027memory\u0027"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    def generate_one_sample(self, host, c_data):"},{"line_number":31,"context_line":"        (value, metadata, extra) \u003d c_data"},{"line_number":32,"context_line":"        return util.make_sample_from_host(host,"},{"line_number":33,"context_line":"                                          name\u003dself.IDENTIFIER,"},{"line_number":34,"context_line":"                                          sample_type\u003dsample.TYPE_GAUGE,"}],"source_content_type":"text/x-python","patch_set":4,"id":"baada198_2900cfff","line":31,"updated":"2014-08-06 10:51:08.000000000","message":"ditto","commit_id":"7ddae428990dde629b30546f9aa7d98b167f30a0"},{"author":{"_account_id":10987,"name":"Igor Degtiarov","username":"tovstun","inactive":true},"change_message_id":"438da6c374777582d13c2fa16ed0919b12c04402","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    CACHE_KEY \u003d \u0027memory\u0027"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    def generate_one_sample(self, host, c_data):"},{"line_number":31,"context_line":"        (value, metadata, extra) \u003d c_data"},{"line_number":32,"context_line":"        return util.make_sample_from_host(host,"},{"line_number":33,"context_line":"                                          name\u003dself.IDENTIFIER,"},{"line_number":34,"context_line":"                                          sample_type\u003dsample.TYPE_GAUGE,"}],"source_content_type":"text/x-python","patch_set":7,"id":"1abeadc6_c8d604f1","line":31,"updated":"2014-08-21 05:07:56.000000000","message":"ditto","commit_id":"79121d61bf346b8f9b3c50daf913f40b83cf0e96"},{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"e456cba2615a4fa5c10df3362bbd11e422bbcfe3","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    CACHE_KEY \u003d \u0027memory\u0027"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    def generate_one_sample(self, host, c_data):"},{"line_number":31,"context_line":"        (value, metadata, extra) \u003d c_data"},{"line_number":32,"context_line":"        return util.make_sample_from_host(host,"},{"line_number":33,"context_line":"                                          name\u003dself.IDENTIFIER,"},{"line_number":34,"context_line":"                                          sample_type\u003dsample.TYPE_GAUGE,"}],"source_content_type":"text/x-python","patch_set":7,"id":"1abeadc6_c76b521c","line":31,"in_reply_to":"1abeadc6_c8d604f1","updated":"2014-08-21 06:40:20.000000000","message":"Done","commit_id":"79121d61bf346b8f9b3c50daf913f40b83cf0e96"}],"ceilometer/hardware/pollsters/net.py":[{"author":{"_account_id":10987,"name":"Igor Degtiarov","username":"tovstun","inactive":true},"change_message_id":"14daf290f5a1b613145511952377d2e831be05ec","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    CACHE_KEY \u003d \u0027nic\u0027"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    def generate_one_sample(self, host, c_data):"},{"line_number":31,"context_line":"        (value, metadata, extra) \u003d c_data"},{"line_number":32,"context_line":"        res_id \u003d host.hostname"},{"line_number":33,"context_line":"        if metadata.get(\u0027name\u0027):"},{"line_number":34,"context_line":"            res_id \u003d res_id + \".%s\" % metadata.get(\u0027name\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"baada198_4905030f","line":31,"updated":"2014-08-06 10:51:08.000000000","message":"ditto","commit_id":"7ddae428990dde629b30546f9aa7d98b167f30a0"}],"ceilometer/tests/hardware/inspector/test_snmp.py":[{"author":{"_account_id":10987,"name":"Igor Degtiarov","username":"tovstun","inactive":true},"change_message_id":"438da6c374777582d13c2fa16ed0919b12c04402","unresolved":false,"context_lines":[{"line_number":83,"context_line":"            return list(func(*args, **kwargs))"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"        def faux_parse(ret, is_bulk):"},{"line_number":86,"context_line":"            return (True, \u0027forced error\u0027)"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"        self.useFixture(mockpatch.PatchObject("},{"line_number":89,"context_line":"            snmp, \u0027parse_snmp_return\u0027, new\u003dfaux_parse))"}],"source_content_type":"text/x-python","patch_set":7,"id":"1abeadc6_883ecc26","line":86,"updated":"2014-08-21 05:07:56.000000000","message":"ditto, but here it up to you.","commit_id":"79121d61bf346b8f9b3c50daf913f40b83cf0e96"},{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"e456cba2615a4fa5c10df3362bbd11e422bbcfe3","unresolved":false,"context_lines":[{"line_number":83,"context_line":"            return list(func(*args, **kwargs))"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"        def faux_parse(ret, is_bulk):"},{"line_number":86,"context_line":"            return (True, \u0027forced error\u0027)"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"        self.useFixture(mockpatch.PatchObject("},{"line_number":89,"context_line":"            snmp, \u0027parse_snmp_return\u0027, new\u003dfaux_parse))"}],"source_content_type":"text/x-python","patch_set":7,"id":"1abeadc6_875dda7b","line":86,"in_reply_to":"1abeadc6_883ecc26","updated":"2014-08-21 06:40:20.000000000","message":"Here I think it\u0027s better to follow the original function\u0027s(which is to be mocked) return type, as a tuple.","commit_id":"79121d61bf346b8f9b3c50daf913f40b83cf0e96"}]}