)]}'
{"ceilometer/hardware/pollsters/util.py":[{"author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"change_message_id":"dc73a95fcae0e0a43007dae24302f2ec6aa67667","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    return {\u0027resource_url\u0027: urlparse.urlunsplit(host_url)}"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"def make_metadata(res_metadata\u003dNone, host_url\u003dNone):"},{"line_number":34,"context_line":"    resource_metadata \u003d dict()"},{"line_number":35,"context_line":"    if res_metadata is not None:"},{"line_number":36,"context_line":"        metadata \u003d copy.copy(res_metadata)"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_0f3a7d33","line":33,"updated":"2014-07-28 12:18:43.000000000","message":"nit: it is better to name this method as \"make_resource_metadata\"","commit_id":"1e89f6c8cb6d4bbec7e5fd41b8a4da3f910b0c43"},{"author":{"_account_id":7585,"name":"Ladislav Smola","email":"lsmola@redhat.com","username":"lsmola"},"change_message_id":"c992281a8bf60042a392ec5dd04a6f5202af146e","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    return {\u0027resource_url\u0027: urlparse.urlunsplit(host_url)}"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"def make_metadata(res_metadata\u003dNone, host_url\u003dNone):"},{"line_number":34,"context_line":"    resource_metadata \u003d dict()"},{"line_number":35,"context_line":"    if res_metadata is not None:"},{"line_number":36,"context_line":"        metadata \u003d copy.copy(res_metadata)"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_cd9b0963","line":33,"in_reply_to":"baada198_0f3a7d33","updated":"2014-07-29 07:47:51.000000000","message":"The function above is also called only get_metadata so I guess it is fine.\n\nIt is combining resource and host metadata.","commit_id":"1e89f6c8cb6d4bbec7e5fd41b8a4da3f910b0c43"},{"author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"change_message_id":"d645d982e901a9a70b24aa12b52d980c083efd2c","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    return {\u0027resource_url\u0027: urlparse.urlunsplit(host_url)}"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"def make_metadata(res_metadata\u003dNone, host_url\u003dNone):"},{"line_number":34,"context_line":"    resource_metadata \u003d dict()"},{"line_number":35,"context_line":"    if res_metadata is not None:"},{"line_number":36,"context_line":"        metadata \u003d copy.copy(res_metadata)"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_fff79058","line":33,"in_reply_to":"baada198_cd9b0963","updated":"2014-07-29 08:15:25.000000000","message":"the definition and return of this method is about metadata of resource, so I think \"make_resource_metadata\"  is better. \"make_metadata\" is unexplained.\n\nthe above is different with this, and it is fine. the name is meaningful","commit_id":"1e89f6c8cb6d4bbec7e5fd41b8a4da3f910b0c43"},{"author":{"_account_id":7585,"name":"Ladislav Smola","email":"lsmola@redhat.com","username":"lsmola"},"change_message_id":"0625a4b2a4f71c94d5dfb62cb13a396f3a6125cc","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    return {\u0027resource_url\u0027: urlparse.urlunsplit(host_url)}"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"def make_metadata(res_metadata\u003dNone, host_url\u003dNone):"},{"line_number":34,"context_line":"    resource_metadata \u003d dict()"},{"line_number":35,"context_line":"    if res_metadata is not None:"},{"line_number":36,"context_line":"        metadata \u003d copy.copy(res_metadata)"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_422d03ae","line":33,"in_reply_to":"baada198_fff79058","updated":"2014-07-29 08:38:29.000000000","message":"Done","commit_id":"1e89f6c8cb6d4bbec7e5fd41b8a4da3f910b0c43"}]}