)]}'
{"ceilometer/hardware/inspector/base.py":[{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"52fb8e041c041654fb59b91abccca2ff24183b89","unresolved":false,"context_lines":[{"line_number":78,"context_line":"#"},{"line_number":79,"context_line":"# name: name of the sensor"},{"line_number":80,"context_line":"#"},{"line_number":81,"context_line":"Sensor \u003d collections.namedtuple(\u0027Sensor\u0027, [\u0027name\u0027])"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"@six.add_metaclass(abc.ABCMeta)"}],"source_content_type":"text/x-python","patch_set":5,"id":"baada198_cc082483","line":81,"updated":"2014-08-07 02:17:46.000000000","message":"why add this?\nMaybe we should leverage the snmp-improvement bp https://review.openstack.org/#/c/108938/","commit_id":"7f4a79b61073b1a6770a60cd8dd06f23b54812bf"},{"author":{"_account_id":7585,"name":"Ladislav Smola","email":"lsmola@redhat.com","username":"lsmola"},"change_message_id":"51b05f7f627440cef439f2ffa79fcc5778631ede","unresolved":false,"context_lines":[{"line_number":78,"context_line":"#"},{"line_number":79,"context_line":"# name: name of the sensor"},{"line_number":80,"context_line":"#"},{"line_number":81,"context_line":"Sensor \u003d collections.namedtuple(\u0027Sensor\u0027, [\u0027name\u0027])"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"@six.add_metaclass(abc.ABCMeta)"}],"source_content_type":"text/x-python","patch_set":5,"id":"baada198_2127e21f","line":81,"in_reply_to":"baada198_cc082483","updated":"2014-08-07 07:37:47.000000000","message":"yes that was plan plan, it wasn\u0027t ready when I wrote this\n\nwill do","commit_id":"7f4a79b61073b1a6770a60cd8dd06f23b54812bf"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"89e79a2313a30225f37da45a1507d13832a0f638","unresolved":false,"context_lines":[{"line_number":78,"context_line":"#"},{"line_number":79,"context_line":"# name: name of the sensor"},{"line_number":80,"context_line":"#"},{"line_number":81,"context_line":"Sensor \u003d collections.namedtuple(\u0027Sensor\u0027, [\u0027name\u0027])"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"@six.add_metaclass(abc.ABCMeta)"}],"source_content_type":"text/x-python","patch_set":6,"id":"baada198_c0c2c053","line":81,"updated":"2014-08-13 16:14:51.000000000","message":"how is this part of bug?","commit_id":"539dfc29f697fa4a656c93ae9de48c7fd90de2a6"},{"author":{"_account_id":7585,"name":"Ladislav Smola","email":"lsmola@redhat.com","username":"lsmola"},"change_message_id":"054258d73b82d6a928317dc9282f32e45d796c3c","unresolved":false,"context_lines":[{"line_number":78,"context_line":"#"},{"line_number":79,"context_line":"# name: name of the sensor"},{"line_number":80,"context_line":"#"},{"line_number":81,"context_line":"Sensor \u003d collections.namedtuple(\u0027Sensor\u0027, [\u0027name\u0027])"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"@six.add_metaclass(abc.ABCMeta)"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a8c0949_c44ffebb","line":81,"in_reply_to":"baada198_c0c2c053","updated":"2014-11-06 10:06:44.000000000","message":"will remove","commit_id":"539dfc29f697fa4a656c93ae9de48c7fd90de2a6"}],"tools/tripleo_ui_ceilometer_test_data.py":[{"author":{"_account_id":3012,"name":"Dina Belova","email":"dbelova@mirantis.com","username":"dbelova"},"change_message_id":"16d553b2aaa5d928c82a691a19e9f2cee7d1763e","unresolved":false,"context_lines":[{"line_number":49,"context_line":"from ceilometer import nova_client"},{"line_number":50,"context_line":"from ceilometer import storage"},{"line_number":51,"context_line":"from ceilometer.hardware.pollsters import util"},{"line_number":52,"context_line":"from ceilometer.hardware.inspector import base"},{"line_number":53,"context_line":"from ceilometer.openstack.common import log"},{"line_number":54,"context_line":"from ceilometer.openstack.common import network_utils"},{"line_number":55,"context_line":"from tools.make_test_data import make_test_data"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_731685f3","line":52,"updated":"2014-07-28 10:38:27.000000000","message":"wrong alphabetical order:\n\nfrom ceilometer.hardware.inspector import base\nfrom ceilometer.hardware.pollsters import util\nfrom ceilometer import nova_client\nfrom ceilometer.openstack.common import log\nfrom ceilometer.openstack.common import network_utils\nfrom ceilometer import storage\nfrom tools.make_test_data import make_test_data","commit_id":"7e364ceadd32b960ca887c159ec77c31698bc6bb"},{"author":{"_account_id":7585,"name":"Ladislav Smola","email":"lsmola@redhat.com","username":"lsmola"},"change_message_id":"2bd740bdc93b38dd16ef64dd3e11d745cac8ba46","unresolved":false,"context_lines":[{"line_number":49,"context_line":"from ceilometer import nova_client"},{"line_number":50,"context_line":"from ceilometer import storage"},{"line_number":51,"context_line":"from ceilometer.hardware.pollsters import util"},{"line_number":52,"context_line":"from ceilometer.hardware.inspector import base"},{"line_number":53,"context_line":"from ceilometer.openstack.common import log"},{"line_number":54,"context_line":"from ceilometer.openstack.common import network_utils"},{"line_number":55,"context_line":"from tools.make_test_data import make_test_data"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_cdf06995","line":52,"in_reply_to":"baada198_731685f3","updated":"2014-07-29 07:53:16.000000000","message":"ah, there is not pep8 check for this? ok i will fix it.","commit_id":"7e364ceadd32b960ca887c159ec77c31698bc6bb"},{"author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"change_message_id":"9e91785a14228b25ffa65478e22b6a0bcd229087","unresolved":false,"context_lines":[{"line_number":60,"context_line":"DEFAULT_METERS \u003d {"},{"line_number":61,"context_line":"    \"hardware.cpu.load.1min\": {"},{"line_number":62,"context_line":"        \"type\": \"gauge\","},{"line_number":63,"context_line":"        \"unit\": \"process\","},{"line_number":64,"context_line":"        \"random_min\": 0,"},{"line_number":65,"context_line":"        \"random_max\": 1.0,"},{"line_number":66,"context_line":"    },"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_4f11d5f6","line":63,"updated":"2014-07-28 12:09:02.000000000","message":"maybe the unit should be \"%\" for this metric is a percentage, please see:\n*cpu_util*  in https://github.com/openstack/ceilometer/blob/master/doc/source/measurements.rst#compute-nova","commit_id":"7e364ceadd32b960ca887c159ec77c31698bc6bb"},{"author":{"_account_id":7585,"name":"Ladislav Smola","email":"lsmola@redhat.com","username":"lsmola"},"change_message_id":"2bd740bdc93b38dd16ef64dd3e11d745cac8ba46","unresolved":false,"context_lines":[{"line_number":60,"context_line":"DEFAULT_METERS \u003d {"},{"line_number":61,"context_line":"    \"hardware.cpu.load.1min\": {"},{"line_number":62,"context_line":"        \"type\": \"gauge\","},{"line_number":63,"context_line":"        \"unit\": \"process\","},{"line_number":64,"context_line":"        \"random_min\": 0,"},{"line_number":65,"context_line":"        \"random_max\": 1.0,"},{"line_number":66,"context_line":"    },"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_8dff5166","line":63,"in_reply_to":"baada198_4f11d5f6","updated":"2014-07-29 07:53:16.000000000","message":"this is actually cpu_load not cpu_util from nova. These are hardware metrics related to baremetal host, not hyper-visor.","commit_id":"7e364ceadd32b960ca887c159ec77c31698bc6bb"},{"author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"change_message_id":"d62efda49dfb6c0fe396bc60b780d301cca8971f","unresolved":false,"context_lines":[{"line_number":60,"context_line":"DEFAULT_METERS \u003d {"},{"line_number":61,"context_line":"    \"hardware.cpu.load.1min\": {"},{"line_number":62,"context_line":"        \"type\": \"gauge\","},{"line_number":63,"context_line":"        \"unit\": \"process\","},{"line_number":64,"context_line":"        \"random_min\": 0,"},{"line_number":65,"context_line":"        \"random_max\": 1.0,"},{"line_number":66,"context_line":"    },"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_bf90b850","line":63,"in_reply_to":"baada198_8dff5166","updated":"2014-07-29 08:16:03.000000000","message":"did the random_min and random_max means this metric is a percentage? if so the unit should be \"%\", personally","commit_id":"7e364ceadd32b960ca887c159ec77c31698bc6bb"},{"author":{"_account_id":7585,"name":"Ladislav Smola","email":"lsmola@redhat.com","username":"lsmola"},"change_message_id":"d86e8b207e3cfee5d32f2439317c21b1eedd04f2","unresolved":false,"context_lines":[{"line_number":60,"context_line":"DEFAULT_METERS \u003d {"},{"line_number":61,"context_line":"    \"hardware.cpu.load.1min\": {"},{"line_number":62,"context_line":"        \"type\": \"gauge\","},{"line_number":63,"context_line":"        \"unit\": \"process\","},{"line_number":64,"context_line":"        \"random_min\": 0,"},{"line_number":65,"context_line":"        \"random_max\": 1.0,"},{"line_number":66,"context_line":"    },"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_1570a307","line":63,"in_reply_to":"baada198_bf90b850","updated":"2014-07-29 08:55:57.000000000","message":"The docs state the value is float between [0..1.0], it will give you random number like that.\ne.g. http://www.dd-wrt.com/wiki/index.php/Simple_Network_Management_Protocol\n\nBut the unit is probably wrong here, there should be no unit according to docs.","commit_id":"7e364ceadd32b960ca887c159ec77c31698bc6bb"},{"author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"change_message_id":"9e91785a14228b25ffa65478e22b6a0bcd229087","unresolved":false,"context_lines":[{"line_number":66,"context_line":"    },"},{"line_number":67,"context_line":"    \"hardware.cpu.load.5min\": {"},{"line_number":68,"context_line":"        \"type\": \"gauge\","},{"line_number":69,"context_line":"        \"unit\": \"process\","},{"line_number":70,"context_line":"        \"random_min\": 0,"},{"line_number":71,"context_line":"        \"random_max\": 1.0,"},{"line_number":72,"context_line":"    },"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_afb0b1fd","line":69,"updated":"2014-07-28 12:09:02.000000000","message":"ditto","commit_id":"7e364ceadd32b960ca887c159ec77c31698bc6bb"},{"author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"change_message_id":"9e91785a14228b25ffa65478e22b6a0bcd229087","unresolved":false,"context_lines":[{"line_number":72,"context_line":"    },"},{"line_number":73,"context_line":"    \"hardware.cpu.load.15min\": {"},{"line_number":74,"context_line":"        \"type\": \"gauge\","},{"line_number":75,"context_line":"        \"unit\": \"process\","},{"line_number":76,"context_line":"        \"random_min\": 0,"},{"line_number":77,"context_line":"        \"random_max\": 1.0,"},{"line_number":78,"context_line":"    },"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_2fc4a15e","line":75,"updated":"2014-07-28 12:09:02.000000000","message":"ditto","commit_id":"7e364ceadd32b960ca887c159ec77c31698bc6bb"},{"author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"change_message_id":"9e91785a14228b25ffa65478e22b6a0bcd229087","unresolved":false,"context_lines":[{"line_number":78,"context_line":"    },"},{"line_number":79,"context_line":"    \"hardware.disk.size.total\": {"},{"line_number":80,"context_line":"        \"type\": \"gauge\","},{"line_number":81,"context_line":"        \"unit\": \"B\","},{"line_number":82,"context_line":"        \"volume\": 64420000000,"},{"line_number":83,"context_line":"        \"devices\": ["},{"line_number":84,"context_line":"            base.Disk(device\u003d\u0027/dev/sda3\u0027, path\u003d\u0027/\u0027),"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_8f8bed1c","line":81,"updated":"2014-07-28 12:09:02.000000000","message":"generally, the unit of disk\u0027s size should be GB, please see above link","commit_id":"7e364ceadd32b960ca887c159ec77c31698bc6bb"},{"author":{"_account_id":7585,"name":"Ladislav Smola","email":"lsmola@redhat.com","username":"lsmola"},"change_message_id":"2bd740bdc93b38dd16ef64dd3e11d745cac8ba46","unresolved":false,"context_lines":[{"line_number":78,"context_line":"    },"},{"line_number":79,"context_line":"    \"hardware.disk.size.total\": {"},{"line_number":80,"context_line":"        \"type\": \"gauge\","},{"line_number":81,"context_line":"        \"unit\": \"B\","},{"line_number":82,"context_line":"        \"volume\": 64420000000,"},{"line_number":83,"context_line":"        \"devices\": ["},{"line_number":84,"context_line":"            base.Disk(device\u003d\u0027/dev/sda3\u0027, path\u003d\u0027/\u0027),"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_eded2dba","line":81,"in_reply_to":"baada198_8f8bed1c","updated":"2014-07-29 07:53:16.000000000","message":"this is from SNMP documentation","commit_id":"7e364ceadd32b960ca887c159ec77c31698bc6bb"},{"author":{"_account_id":9317,"name":"Ana Krivokapic","email":"akrivoka@redhat.com","username":"akrivoka"},"change_message_id":"b9c291d49488b1800506ec8f78e89e310919bdd3","unresolved":false,"context_lines":[{"line_number":35,"context_line":"#2. generate testing data for e.g. last 2 days"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"source .tox/py27/bin/activate"},{"line_number":38,"context_line":"./tools/tripleo_ui_ceilometer_test_data.py --time_period 2"},{"line_number":39,"context_line":"\"\"\""},{"line_number":40,"context_line":"from __future__ import print_function"},{"line_number":41,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"baada198_88c60a9b","line":38,"updated":"2014-08-07 12:00:10.000000000","message":"I\u0027m getting \"Unrecognized argument \u0027time_period\u0027\" when I run this.","commit_id":"7f4a79b61073b1a6770a60cd8dd06f23b54812bf"},{"author":{"_account_id":7729,"name":"Ilya Tyaptin","email":"ityaptin@mirantis.com","username":"ityaptin"},"change_message_id":"74044ed00d53c37d911022842b2b55c28f8e73ed","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/usr/bin/env python"},{"line_number":2,"context_line":"# -*- encoding: utf-8 -*-"},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# Copyright © 2012 New Dream Network, LLC (DreamHost)"}],"source_content_type":"text/x-python","patch_set":6,"id":"baada198_45c8894d","line":1,"updated":"2014-08-13 13:57:40.000000000","message":"Please, delete line with encoding, because that was already removed from all files of project","commit_id":"539dfc29f697fa4a656c93ae9de48c7fd90de2a6"},{"author":{"_account_id":7585,"name":"Ladislav Smola","email":"lsmola@redhat.com","username":"lsmola"},"change_message_id":"054258d73b82d6a928317dc9282f32e45d796c3c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/usr/bin/env python"},{"line_number":2,"context_line":"# -*- encoding: utf-8 -*-"},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# Copyright © 2012 New Dream Network, LLC (DreamHost)"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a8c0949_0462e63d","line":1,"in_reply_to":"baada198_45c8894d","updated":"2014-11-06 10:06:44.000000000","message":"will do","commit_id":"539dfc29f697fa4a656c93ae9de48c7fd90de2a6"},{"author":{"_account_id":7729,"name":"Ilya Tyaptin","email":"ityaptin@mirantis.com","username":"ityaptin"},"change_message_id":"74044ed00d53c37d911022842b2b55c28f8e73ed","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/usr/bin/env python"},{"line_number":2,"context_line":"# -*- encoding: utf-8 -*-"},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# Copyright © 2012 New Dream Network, LLC (DreamHost)"},{"line_number":5,"context_line":"#"},{"line_number":6,"context_line":"# Author: Doug Hellmann \u003cdoug.hellmann@dreamhost.com\u003e"},{"line_number":7,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":6,"id":"baada198_a5b085e0","line":4,"updated":"2014-08-13 13:57:40.000000000","message":"Please, change year in licence copyright to 2014","commit_id":"539dfc29f697fa4a656c93ae9de48c7fd90de2a6"},{"author":{"_account_id":7585,"name":"Ladislav Smola","email":"lsmola@redhat.com","username":"lsmola"},"change_message_id":"054258d73b82d6a928317dc9282f32e45d796c3c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/usr/bin/env python"},{"line_number":2,"context_line":"# -*- encoding: utf-8 -*-"},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# Copyright © 2012 New Dream Network, LLC (DreamHost)"},{"line_number":5,"context_line":"#"},{"line_number":6,"context_line":"# Author: Doug Hellmann \u003cdoug.hellmann@dreamhost.com\u003e"},{"line_number":7,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a8c0949_445cee7e","line":4,"in_reply_to":"baada198_a5b085e0","updated":"2014-11-06 10:06:44.000000000","message":"will do","commit_id":"539dfc29f697fa4a656c93ae9de48c7fd90de2a6"},{"author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"change_message_id":"26510d8fb2fc74e95a012ea565f148250ab4121f","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"#1. you can clear you db first, for mysql use this:"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"db_pass\u003d$(os-apply-config --key db-password)"},{"line_number":30,"context_line":"echo \"drop database ceilometer\" | mysql"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"os-db-create ceilometer ceilometer $db_pass"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa98f980_d5738e4c","line":29,"range":{"start_line":29,"start_character":10,"end_line":29,"end_character":25},"updated":"2014-09-16 10:57:17.000000000","message":"Does the reference to os-apply-config assume that TripeO is in use here? Is there a more generic way of generating or referring to a DB password?","commit_id":"539dfc29f697fa4a656c93ae9de48c7fd90de2a6"},{"author":{"_account_id":7585,"name":"Ladislav Smola","email":"lsmola@redhat.com","username":"lsmola"},"change_message_id":"054258d73b82d6a928317dc9282f32e45d796c3c","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"#1. you can clear you db first, for mysql use this:"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"db_pass\u003d$(os-apply-config --key db-password)"},{"line_number":30,"context_line":"echo \"drop database ceilometer\" | mysql"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"os-db-create ceilometer ceilometer $db_pass"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a8c0949_643aca37","line":29,"in_reply_to":"fa98f980_d5738e4c","updated":"2014-11-06 10:06:44.000000000","message":"yes this whole script is tripleo related","commit_id":"539dfc29f697fa4a656c93ae9de48c7fd90de2a6"},{"author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"change_message_id":"26510d8fb2fc74e95a012ea565f148250ab4121f","unresolved":false,"context_lines":[{"line_number":29,"context_line":"db_pass\u003d$(os-apply-config --key db-password)"},{"line_number":30,"context_line":"echo \"drop database ceilometer\" | mysql"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"os-db-create ceilometer ceilometer $db_pass"},{"line_number":33,"context_line":"ceilometer-dbsync --config-file /etc/ceilometer/ceilometer.conf"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"#2. generate testing data for e.g. last 2 days"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa98f980_55979e3a","line":32,"updated":"2014-09-16 10:57:17.000000000","message":"Similarly, would it more direct to refer to the analogous mysql command directly here?","commit_id":"539dfc29f697fa4a656c93ae9de48c7fd90de2a6"},{"author":{"_account_id":7585,"name":"Ladislav Smola","email":"lsmola@redhat.com","username":"lsmola"},"change_message_id":"054258d73b82d6a928317dc9282f32e45d796c3c","unresolved":false,"context_lines":[{"line_number":29,"context_line":"db_pass\u003d$(os-apply-config --key db-password)"},{"line_number":30,"context_line":"echo \"drop database ceilometer\" | mysql"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"os-db-create ceilometer ceilometer $db_pass"},{"line_number":33,"context_line":"ceilometer-dbsync --config-file /etc/ceilometer/ceilometer.conf"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"#2. generate testing data for e.g. last 2 days"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a8c0949_a43bd236","line":32,"in_reply_to":"fa98f980_55979e3a","updated":"2014-11-06 10:06:44.000000000","message":"I think it should be enough to be tripleo specific here","commit_id":"539dfc29f697fa4a656c93ae9de48c7fd90de2a6"},{"author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"change_message_id":"26510d8fb2fc74e95a012ea565f148250ab4121f","unresolved":false,"context_lines":[{"line_number":321,"context_line":"        \u0027--interval\u0027,"},{"line_number":322,"context_line":"        help\u003d\u0027The period between events, in minutes.\u0027,"},{"line_number":323,"context_line":"        type\u003dint,"},{"line_number":324,"context_line":"        default\u003d10,"},{"line_number":325,"context_line":"    )"},{"line_number":326,"context_line":"    args \u003d parser.parse_args()"},{"line_number":327,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"fa98f980_f5eb32da","line":324,"updated":"2014-09-16 10:57:17.000000000","message":"Seconds as opposed to minutes seems like a much more natural granularity to use here, given that seconds are the unit for the pipeline source intervals.","commit_id":"539dfc29f697fa4a656c93ae9de48c7fd90de2a6"},{"author":{"_account_id":7585,"name":"Ladislav Smola","email":"lsmola@redhat.com","username":"lsmola"},"change_message_id":"054258d73b82d6a928317dc9282f32e45d796c3c","unresolved":false,"context_lines":[{"line_number":321,"context_line":"        \u0027--interval\u0027,"},{"line_number":322,"context_line":"        help\u003d\u0027The period between events, in minutes.\u0027,"},{"line_number":323,"context_line":"        type\u003dint,"},{"line_number":324,"context_line":"        default\u003d10,"},{"line_number":325,"context_line":"    )"},{"line_number":326,"context_line":"    args \u003d parser.parse_args()"},{"line_number":327,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"7a8c0949_042d86fe","line":324,"in_reply_to":"fa98f980_f5eb32da","updated":"2014-11-06 10:06:44.000000000","message":"will do","commit_id":"539dfc29f697fa4a656c93ae9de48c7fd90de2a6"},{"author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"change_message_id":"26510d8fb2fc74e95a012ea565f148250ab4121f","unresolved":false,"context_lines":[{"line_number":342,"context_line":"    ip_addresses \u003d []"},{"line_number":343,"context_line":"    for instance in instances:"},{"line_number":344,"context_line":"        try:"},{"line_number":345,"context_line":"            ip_address \u003d instance.addresses[\u0027ctlplane\u0027][0][\u0027addr\u0027]"},{"line_number":346,"context_line":"            ip_addresses.append(ip_address)"},{"line_number":347,"context_line":"        except KeyError:"},{"line_number":348,"context_line":"            print(\"Couldn\u0027t obtain IP address of\""}],"source_content_type":"text/x-python","patch_set":6,"id":"fa98f980_55a95e8f","line":345,"updated":"2014-09-16 10:57:17.000000000","message":"Is the \u0027ctlplane\u0027 field always set, regardless of how the instance is spun up?","commit_id":"539dfc29f697fa4a656c93ae9de48c7fd90de2a6"},{"author":{"_account_id":7585,"name":"Ladislav Smola","email":"lsmola@redhat.com","username":"lsmola"},"change_message_id":"054258d73b82d6a928317dc9282f32e45d796c3c","unresolved":false,"context_lines":[{"line_number":342,"context_line":"    ip_addresses \u003d []"},{"line_number":343,"context_line":"    for instance in instances:"},{"line_number":344,"context_line":"        try:"},{"line_number":345,"context_line":"            ip_address \u003d instance.addresses[\u0027ctlplane\u0027][0][\u0027addr\u0027]"},{"line_number":346,"context_line":"            ip_addresses.append(ip_address)"},{"line_number":347,"context_line":"        except KeyError:"},{"line_number":348,"context_line":"            print(\"Couldn\u0027t obtain IP address of\""}],"source_content_type":"text/x-python","patch_set":6,"id":"7a8c0949_6411eaab","line":345,"in_reply_to":"fa98f980_55a95e8f","updated":"2014-11-06 10:06:44.000000000","message":"only when done via triple AFAIK","commit_id":"539dfc29f697fa4a656c93ae9de48c7fd90de2a6"},{"author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"change_message_id":"26510d8fb2fc74e95a012ea565f148250ab4121f","unresolved":false,"context_lines":[{"line_number":346,"context_line":"            ip_addresses.append(ip_address)"},{"line_number":347,"context_line":"        except KeyError:"},{"line_number":348,"context_line":"            print(\"Couldn\u0027t obtain IP address of\""},{"line_number":349,"context_line":"                  \"instance %s\" % instance.id)"},{"line_number":350,"context_line":""},{"line_number":351,"context_line":"    # Connect to the metering database"},{"line_number":352,"context_line":"    conn \u003d storage.get_connection_from_config(cfg.CONF)"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa98f980_f5c25252","line":349,"updated":"2014-09-16 10:57:17.000000000","message":"I\u0027m not loving the mixture of real and fake here. Would it more direct to allow a list of fake addresses to be specified, instead of requiring that real instances are spun up before any metering data can be generated?","commit_id":"539dfc29f697fa4a656c93ae9de48c7fd90de2a6"},{"author":{"_account_id":7585,"name":"Ladislav Smola","email":"lsmola@redhat.com","username":"lsmola"},"change_message_id":"054258d73b82d6a928317dc9282f32e45d796c3c","unresolved":false,"context_lines":[{"line_number":346,"context_line":"            ip_addresses.append(ip_address)"},{"line_number":347,"context_line":"        except KeyError:"},{"line_number":348,"context_line":"            print(\"Couldn\u0027t obtain IP address of\""},{"line_number":349,"context_line":"                  \"instance %s\" % instance.id)"},{"line_number":350,"context_line":""},{"line_number":351,"context_line":"    # Connect to the metering database"},{"line_number":352,"context_line":"    conn \u003d storage.get_connection_from_config(cfg.CONF)"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a8c0949_c478def4","line":349,"in_reply_to":"fa98f980_f5c25252","updated":"2014-11-06 10:06:44.000000000","message":"this script is mainly for testing TripleO-UI stats. We don\u0027t have scripts for mocking nova/ironic and I don\u0027t think we will ever create them.\n\nSo the main purpose of this script is that you will deploy your Openstack using TripleO-UI and then you will generate e.g. year of data to test the UI. We need to use real connection to deployed nodes, otherwise UI won\u0027t show the stats.","commit_id":"539dfc29f697fa4a656c93ae9de48c7fd90de2a6"}]}