)]}'
{"ceilometer/identity/notifications.py":[{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"b68a6f39312c8f13437d8dd5d28841e9f75a6dfe","unresolved":false,"context_lines":[{"line_number":123,"context_line":"        yield sample.Sample.from_notification("},{"line_number":124,"context_line":"            name\u003dmessage[\u0027event_type\u0027],"},{"line_number":125,"context_line":"            type\u003dsample.TYPE_DELTA,"},{"line_number":126,"context_line":"            unit\u003dmessage[\u0027payload\u0027][\u0027outcome\u0027],"},{"line_number":127,"context_line":"            volume\u003d1,"},{"line_number":128,"context_line":"            resource_id\u003dmessage[\u0027payload\u0027][\u0027initiator\u0027][\u0027name\u0027],"},{"line_number":129,"context_line":"            user_id\u003dmessage[\u0027payload\u0027][\u0027initiator\u0027][\u0027name\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_c71bd36d","line":126,"updated":"2014-08-05 20:08:51.000000000","message":"wondering if it\u0027s better to have this as part of meter name? ie. identity.authenticate.pending/sucess/failure?","commit_id":"820d66bd28f168601b179cf6f9d6d23f96de10d0"},{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"a9be47eeed36618103c0f8c6f550fc2eb1370d18","unresolved":false,"context_lines":[{"line_number":123,"context_line":"        yield sample.Sample.from_notification("},{"line_number":124,"context_line":"            name\u003dmessage[\u0027event_type\u0027],"},{"line_number":125,"context_line":"            type\u003dsample.TYPE_DELTA,"},{"line_number":126,"context_line":"            unit\u003dmessage[\u0027payload\u0027][\u0027outcome\u0027],"},{"line_number":127,"context_line":"            volume\u003d1,"},{"line_number":128,"context_line":"            resource_id\u003dmessage[\u0027payload\u0027][\u0027initiator\u0027][\u0027name\u0027],"},{"line_number":129,"context_line":"            user_id\u003dmessage[\u0027payload\u0027][\u0027initiator\u0027][\u0027name\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_f29a1e6e","line":126,"in_reply_to":"baada198_6172d3e5","updated":"2014-08-07 02:58:29.000000000","message":"+1 for including the result into the sample name","commit_id":"820d66bd28f168601b179cf6f9d6d23f96de10d0"},{"author":{"_account_id":7478,"name":"Nadya Shakhat","email":"nadmi4@gmail.com","username":"nprivalova"},"change_message_id":"4dafbc0d9ed4c10070d86cf94073889a3ccc7e37","unresolved":false,"context_lines":[{"line_number":123,"context_line":"        yield sample.Sample.from_notification("},{"line_number":124,"context_line":"            name\u003dmessage[\u0027event_type\u0027],"},{"line_number":125,"context_line":"            type\u003dsample.TYPE_DELTA,"},{"line_number":126,"context_line":"            unit\u003dmessage[\u0027payload\u0027][\u0027outcome\u0027],"},{"line_number":127,"context_line":"            volume\u003d1,"},{"line_number":128,"context_line":"            resource_id\u003dmessage[\u0027payload\u0027][\u0027initiator\u0027][\u0027name\u0027],"},{"line_number":129,"context_line":"            user_id\u003dmessage[\u0027payload\u0027][\u0027initiator\u0027][\u0027name\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_ecdd05df","line":126,"in_reply_to":"baada198_a74a5f80","updated":"2014-08-06 11:40:59.000000000","message":"+1 to Gordon, it will be more representative. I guess that \u0027unit\u0027 should be just \u0027user\u0027. \n1 \u0027user\u0027 with resource_id\u003d\u0027bla\u0027 and user_id\u003d\u0027bla-bla\u0027 was trying to ...\nAnd what he was trying to do and the result of this action is possible to see from meter name, e.g. \u0027identity.authenticate.sucess\u0027 \u003d to authenticate with status \u003d \"success\".\nI hope it\u0027s clear what I meant :)","commit_id":"820d66bd28f168601b179cf6f9d6d23f96de10d0"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"7f95f671a443d3499d2e551b9d95fbccd63979b9","unresolved":false,"context_lines":[{"line_number":123,"context_line":"        yield sample.Sample.from_notification("},{"line_number":124,"context_line":"            name\u003dmessage[\u0027event_type\u0027],"},{"line_number":125,"context_line":"            type\u003dsample.TYPE_DELTA,"},{"line_number":126,"context_line":"            unit\u003dmessage[\u0027payload\u0027][\u0027outcome\u0027],"},{"line_number":127,"context_line":"            volume\u003d1,"},{"line_number":128,"context_line":"            resource_id\u003dmessage[\u0027payload\u0027][\u0027initiator\u0027][\u0027name\u0027],"},{"line_number":129,"context_line":"            user_id\u003dmessage[\u0027payload\u0027][\u0027initiator\u0027][\u0027name\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_a74a5f80","line":126,"in_reply_to":"baada198_c71bd36d","updated":"2014-08-05 20:33:11.000000000","message":"so unit would be event_name+outcome?","commit_id":"820d66bd28f168601b179cf6f9d6d23f96de10d0"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"42db446df4b3ecd4b7e4f18d253fc2416d9c8c27","unresolved":false,"context_lines":[{"line_number":123,"context_line":"        yield sample.Sample.from_notification("},{"line_number":124,"context_line":"            name\u003dmessage[\u0027event_type\u0027],"},{"line_number":125,"context_line":"            type\u003dsample.TYPE_DELTA,"},{"line_number":126,"context_line":"            unit\u003dmessage[\u0027payload\u0027][\u0027outcome\u0027],"},{"line_number":127,"context_line":"            volume\u003d1,"},{"line_number":128,"context_line":"            resource_id\u003dmessage[\u0027payload\u0027][\u0027initiator\u0027][\u0027name\u0027],"},{"line_number":129,"context_line":"            user_id\u003dmessage[\u0027payload\u0027][\u0027initiator\u0027][\u0027name\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_6172d3e5","line":126,"in_reply_to":"baada198_ecdd05df","updated":"2014-08-06 15:59:08.000000000","message":"yeah, that\u0027s what i meant... i guess i\u0027m pretty open to current solutoin... depends on use case... only issue is that i don\u0027t believe we filter on unit.","commit_id":"820d66bd28f168601b179cf6f9d6d23f96de10d0"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"8d759fd6101947308f68bc5ff1ea7425739ce28c","unresolved":false,"context_lines":[{"line_number":123,"context_line":"        yield sample.Sample.from_notification("},{"line_number":124,"context_line":"            name\u003dmessage[\u0027event_type\u0027],"},{"line_number":125,"context_line":"            type\u003dsample.TYPE_DELTA,"},{"line_number":126,"context_line":"            unit\u003dmessage[\u0027payload\u0027][\u0027outcome\u0027],"},{"line_number":127,"context_line":"            volume\u003d1,"},{"line_number":128,"context_line":"            resource_id\u003dmessage[\u0027payload\u0027][\u0027initiator\u0027][\u0027name\u0027],"},{"line_number":129,"context_line":"            user_id\u003dmessage[\u0027payload\u0027][\u0027initiator\u0027][\u0027name\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_6de37606","line":126,"in_reply_to":"baada198_f29a1e6e","updated":"2014-08-07 20:32:13.000000000","message":"Done","commit_id":"820d66bd28f168601b179cf6f9d6d23f96de10d0"},{"author":{"_account_id":7478,"name":"Nadya Shakhat","email":"nadmi4@gmail.com","username":"nprivalova"},"change_message_id":"4dafbc0d9ed4c10070d86cf94073889a3ccc7e37","unresolved":false,"context_lines":[{"line_number":124,"context_line":"            name\u003dmessage[\u0027event_type\u0027],"},{"line_number":125,"context_line":"            type\u003dsample.TYPE_DELTA,"},{"line_number":126,"context_line":"            unit\u003dmessage[\u0027payload\u0027][\u0027outcome\u0027],"},{"line_number":127,"context_line":"            volume\u003d1,"},{"line_number":128,"context_line":"            resource_id\u003dmessage[\u0027payload\u0027][\u0027initiator\u0027][\u0027name\u0027],"},{"line_number":129,"context_line":"            user_id\u003dmessage[\u0027payload\u0027][\u0027initiator\u0027][\u0027name\u0027],"},{"line_number":130,"context_line":"            project_id\u003dNone,"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_8c63a9dd","line":127,"updated":"2014-08-06 11:40:59.000000000","message":"maybe resource_id should be message[\u0027payload\u0027][\u0027initiator\u0027][\u0027id\u0027]?","commit_id":"820d66bd28f168601b179cf6f9d6d23f96de10d0"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"8d759fd6101947308f68bc5ff1ea7425739ce28c","unresolved":false,"context_lines":[{"line_number":124,"context_line":"            name\u003dmessage[\u0027event_type\u0027],"},{"line_number":125,"context_line":"            type\u003dsample.TYPE_DELTA,"},{"line_number":126,"context_line":"            unit\u003dmessage[\u0027payload\u0027][\u0027outcome\u0027],"},{"line_number":127,"context_line":"            volume\u003d1,"},{"line_number":128,"context_line":"            resource_id\u003dmessage[\u0027payload\u0027][\u0027initiator\u0027][\u0027name\u0027],"},{"line_number":129,"context_line":"            user_id\u003dmessage[\u0027payload\u0027][\u0027initiator\u0027][\u0027name\u0027],"},{"line_number":130,"context_line":"            project_id\u003dNone,"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_adf78459","line":127,"in_reply_to":"baada198_8c63a9dd","updated":"2014-08-07 20:32:13.000000000","message":"++ good call","commit_id":"820d66bd28f168601b179cf6f9d6d23f96de10d0"},{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"a9be47eeed36618103c0f8c6f550fc2eb1370d18","unresolved":false,"context_lines":[{"line_number":124,"context_line":"            name\u003dmessage[\u0027event_type\u0027],"},{"line_number":125,"context_line":"            type\u003dsample.TYPE_DELTA,"},{"line_number":126,"context_line":"            unit\u003dmessage[\u0027payload\u0027][\u0027outcome\u0027],"},{"line_number":127,"context_line":"            volume\u003d1,"},{"line_number":128,"context_line":"            resource_id\u003dmessage[\u0027payload\u0027][\u0027initiator\u0027][\u0027name\u0027],"},{"line_number":129,"context_line":"            user_id\u003dmessage[\u0027payload\u0027][\u0027initiator\u0027][\u0027name\u0027],"},{"line_number":130,"context_line":"            project_id\u003dNone,"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_b2e26600","line":127,"in_reply_to":"baada198_8c63a9dd","updated":"2014-08-07 02:58:29.000000000","message":"I think [\u0027payload\u0027][\u0027initiator\u0027][\u0027id\u0027] is better. But i\u0027m not sure whether we need to remove the \"openstack: \" prefix from that. any comment?","commit_id":"820d66bd28f168601b179cf6f9d6d23f96de10d0"}],"ceilometer/tests/identity/test_notifications.py":[{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"b68a6f39312c8f13437d8dd5d28841e9f75a6dfe","unresolved":false,"context_lines":[{"line_number":47,"context_line":"def authn_notification_for(outcome):"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    return {"},{"line_number":50,"context_line":"        u\u0027event_type\u0027: u\u0027identity.authenticate\u0027,"},{"line_number":51,"context_line":"        u\u0027message_id\u0027: u\u00271371a590-d5fd-448f-b3bb-a14dead6f4cb\u0027,"},{"line_number":52,"context_line":"        u\u0027payload\u0027: {"},{"line_number":53,"context_line":"            u\u0027typeURI\u0027: u\u0027http://schemas.dmtf.org/cloud/audit/1.0/event\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_14cc1762","line":50,"updated":"2014-08-05 20:08:51.000000000","message":"do you guys use the same event_type for request and response? i vaguely remember there being two audit events per api call?","commit_id":"820d66bd28f168601b179cf6f9d6d23f96de10d0"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"42db446df4b3ecd4b7e4f18d253fc2416d9c8c27","unresolved":false,"context_lines":[{"line_number":47,"context_line":"def authn_notification_for(outcome):"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    return {"},{"line_number":50,"context_line":"        u\u0027event_type\u0027: u\u0027identity.authenticate\u0027,"},{"line_number":51,"context_line":"        u\u0027message_id\u0027: u\u00271371a590-d5fd-448f-b3bb-a14dead6f4cb\u0027,"},{"line_number":52,"context_line":"        u\u0027payload\u0027: {"},{"line_number":53,"context_line":"            u\u0027typeURI\u0027: u\u0027http://schemas.dmtf.org/cloud/audit/1.0/event\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_413cefe1","line":50,"in_reply_to":"baada198_07206bb0","updated":"2014-08-06 15:59:08.000000000","message":"i see... it might be easier for you guys to separate uniquenes of data if you create different event types... maybe a identity.authenticate.start, identity.authenticate.end?\n\nthat said, if this is what you guys emit, that\u0027s cool.","commit_id":"820d66bd28f168601b179cf6f9d6d23f96de10d0"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"7f95f671a443d3499d2e551b9d95fbccd63979b9","unresolved":false,"context_lines":[{"line_number":47,"context_line":"def authn_notification_for(outcome):"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    return {"},{"line_number":50,"context_line":"        u\u0027event_type\u0027: u\u0027identity.authenticate\u0027,"},{"line_number":51,"context_line":"        u\u0027message_id\u0027: u\u00271371a590-d5fd-448f-b3bb-a14dead6f4cb\u0027,"},{"line_number":52,"context_line":"        u\u0027payload\u0027: {"},{"line_number":53,"context_line":"            u\u0027typeURI\u0027: u\u0027http://schemas.dmtf.org/cloud/audit/1.0/event\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_07206bb0","line":50,"in_reply_to":"baada198_14cc1762","updated":"2014-08-05 20:33:11.000000000","message":"For request and response of an authenticate call?\nI think it\u0027s always identity.authenticate, and the \u0027outcome\u0027 changes from pending/success/failure, thats all the differences.","commit_id":"820d66bd28f168601b179cf6f9d6d23f96de10d0"}]}