)]}'
{"ceilometer/collector.py":[{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"fcb6dd3873d996f0dfe3af99adba400ac34ebb58","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    cfg.BoolOpt(\u0027requeue_notification_on_dispatcher_error\u0027,"},{"line_number":40,"context_line":"                default\u003dFalse,"},{"line_number":41,"context_line":"                help\u003d\u0027Requeue the sample on the collector sample queue \u0027"},{"line_number":42,"context_line":"                \u0027when the collector failt to dispath it.\u0027),"},{"line_number":43,"context_line":"]"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"cfg.CONF.register_opts(OPTS, group\u003d\"collector\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_917d8773","line":42,"updated":"2014-08-06 07:23:30.000000000","message":"s/failt/failed/\n\ns/dispath/dispatch/","commit_id":"6b32b71164f7392c544fb519e98ed5f498ede716"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"fcb6dd3873d996f0dfe3af99adba400ac34ebb58","unresolved":false,"context_lines":[{"line_number":125,"context_line":"                                               data\u003dpayload)"},{"line_number":126,"context_line":"        except Exception:"},{"line_number":127,"context_line":"            if cfg.CONF.requeue_notification_on_dispatcher_error:"},{"line_number":128,"context_line":"                LOG.exception(_(\"Dispatcher fail to handle the sample, \""},{"line_number":129,"context_line":"                                \"requeue it.\"))"},{"line_number":130,"context_line":"                return oslo.messaging.NotificationResult.REQUEUE"},{"line_number":131,"context_line":"            raise"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_f1f32307","line":128,"updated":"2014-08-06 07:23:30.000000000","message":"s/fail/failed/","commit_id":"6b32b71164f7392c544fb519e98ed5f498ede716"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"9151aba7e34b2e1377a916667fabc3ab6573dbda","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    cfg.BoolOpt(\u0027requeue_notification_on_dispatcher_error\u0027,"},{"line_number":40,"context_line":"                default\u003dFalse,"},{"line_number":41,"context_line":"                help\u003d\u0027Requeue the sample on the collector sample queue \u0027"},{"line_number":42,"context_line":"                \u0027when the collector failt to dispath it.\u0027),"},{"line_number":43,"context_line":"]"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"cfg.CONF.register_opts(OPTS, group\u003d\"collector\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"1abeadc6_59609135","line":42,"updated":"2014-08-18 09:44:54.000000000","message":"s/failt/fails/","commit_id":"5b2a1e48519a16b37cf5860f913b030cc56dadf9"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"f6bef608a6da06b0c3aced60a312b89a9e5bc623","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    cfg.BoolOpt(\u0027requeue_notification_on_dispatcher_error\u0027,"},{"line_number":40,"context_line":"                default\u003dFalse,"},{"line_number":41,"context_line":"                help\u003d\u0027Requeue the sample on the collector sample queue \u0027"},{"line_number":42,"context_line":"                \u0027when the collector failt to dispath it.\u0027),"},{"line_number":43,"context_line":"]"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"cfg.CONF.register_opts(OPTS, group\u003d\"collector\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"1abeadc6_c921f8a0","line":42,"in_reply_to":"1abeadc6_59609135","updated":"2014-08-19 12:57:56.000000000","message":"Done","commit_id":"5b2a1e48519a16b37cf5860f913b030cc56dadf9"},{"author":{"_account_id":8052,"name":"Nejc Saje","email":"nejc@saje.info","username":"nsaje"},"change_message_id":"9cc19a6902ceeb9edf61d15291278180704041da","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    cfg.BoolOpt(\u0027requeue_notification_on_dispatcher_error\u0027,"},{"line_number":40,"context_line":"                default\u003dFalse,"},{"line_number":41,"context_line":"                help\u003d\u0027Requeue the sample on the collector sample queue \u0027"},{"line_number":42,"context_line":"                \u0027when the collector failt to dispath it.\u0027),"},{"line_number":43,"context_line":"]"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"cfg.CONF.register_opts(OPTS, group\u003d\"collector\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"1abeadc6_94575002","line":42,"in_reply_to":"1abeadc6_59609135","updated":"2014-08-18 09:57:00.000000000","message":"s/dispath/dispatch/","commit_id":"5b2a1e48519a16b37cf5860f913b030cc56dadf9"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"f6bef608a6da06b0c3aced60a312b89a9e5bc623","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    cfg.BoolOpt(\u0027requeue_notification_on_dispatcher_error\u0027,"},{"line_number":40,"context_line":"                default\u003dFalse,"},{"line_number":41,"context_line":"                help\u003d\u0027Requeue the sample on the collector sample queue \u0027"},{"line_number":42,"context_line":"                \u0027when the collector failt to dispath it.\u0027),"},{"line_number":43,"context_line":"]"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"cfg.CONF.register_opts(OPTS, group\u003d\"collector\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"1abeadc6_a92afc7b","line":42,"in_reply_to":"1abeadc6_94575002","updated":"2014-08-19 12:57:56.000000000","message":"Done","commit_id":"5b2a1e48519a16b37cf5860f913b030cc56dadf9"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"9151aba7e34b2e1377a916667fabc3ab6573dbda","unresolved":false,"context_lines":[{"line_number":127,"context_line":"            if cfg.CONF.requeue_notification_on_dispatcher_error:"},{"line_number":128,"context_line":"                LOG.exception(_(\"Dispatcher fail to handle the sample, \""},{"line_number":129,"context_line":"                                \"requeue it.\"))"},{"line_number":130,"context_line":"                return oslo.messaging.NotificationResult.REQUEUE"},{"line_number":131,"context_line":"            raise"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"    def record_metering_data(self, context, data):"}],"source_content_type":"text/x-python","patch_set":3,"id":"1abeadc6_79654d44","line":130,"updated":"2014-08-18 09:44:54.000000000","message":"If there\u0027s a catastrophic failure of some kind, on the dispatcher side, does this mean the sample could go on being requeued forever? Is that desirable? When the dispatcher comes back to health with there be a giant flush?","commit_id":"5b2a1e48519a16b37cf5860f913b030cc56dadf9"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"f6bef608a6da06b0c3aced60a312b89a9e5bc623","unresolved":false,"context_lines":[{"line_number":127,"context_line":"            if cfg.CONF.requeue_notification_on_dispatcher_error:"},{"line_number":128,"context_line":"                LOG.exception(_(\"Dispatcher fail to handle the sample, \""},{"line_number":129,"context_line":"                                \"requeue it.\"))"},{"line_number":130,"context_line":"                return oslo.messaging.NotificationResult.REQUEUE"},{"line_number":131,"context_line":"            raise"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"    def record_metering_data(self, context, data):"}],"source_content_type":"text/x-python","patch_set":3,"id":"1abeadc6_0914d042","line":130,"in_reply_to":"1abeadc6_79654d44","updated":"2014-08-19 12:57:56.000000000","message":"I\u0027m afraid that yes, it will retry until the dispatcher rework. And yes we will get a giant flush is the dispatcher come back.\n\nThis is why this is disable by default, the event dispatcher already have the same behavior.","commit_id":"5b2a1e48519a16b37cf5860f913b030cc56dadf9"},{"author":{"_account_id":3012,"name":"Dina Belova","email":"dbelova@mirantis.com","username":"dbelova"},"change_message_id":"d7e27f510067fc68b4929c8256488a9b22119346","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    cfg.BoolOpt(\u0027requeue_notification_on_dispatcher_error\u0027,"},{"line_number":40,"context_line":"                default\u003dFalse,"},{"line_number":41,"context_line":"                help\u003d\u0027Requeue the sample on the collector sample queue \u0027"},{"line_number":42,"context_line":"                \u0027when the collector failt to dispath it.\u0027),"},{"line_number":43,"context_line":"]"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"cfg.CONF.register_opts(OPTS, group\u003d\"collector\")"}],"source_content_type":"text/x-python","patch_set":4,"id":"1abeadc6_bdb6e3da","line":42,"range":{"start_line":42,"start_character":36,"end_line":42,"end_character":41},"updated":"2014-08-18 14:56:12.000000000","message":"failed\ndispatch","commit_id":"35902d5232e1a9f020d8d7444df68721ce8ab7eb"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"1cff5bc9a2b7b6724def88d3205303d46aa7fd3c","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    cfg.BoolOpt(\u0027requeue_notification_on_dispatcher_error\u0027,"},{"line_number":40,"context_line":"                default\u003dFalse,"},{"line_number":41,"context_line":"                help\u003d\u0027Requeue the sample on the collector sample queue \u0027"},{"line_number":42,"context_line":"                \u0027when the collector failt to dispath it.\u0027),"},{"line_number":43,"context_line":"]"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"cfg.CONF.register_opts(OPTS, group\u003d\"collector\")"}],"source_content_type":"text/x-python","patch_set":4,"id":"1abeadc6_6eee2ab6","line":42,"in_reply_to":"1abeadc6_bdb6e3da","updated":"2014-08-19 12:57:27.000000000","message":"Done","commit_id":"35902d5232e1a9f020d8d7444df68721ce8ab7eb"},{"author":{"_account_id":3012,"name":"Dina Belova","email":"dbelova@mirantis.com","username":"dbelova"},"change_message_id":"d7e27f510067fc68b4929c8256488a9b22119346","unresolved":false,"context_lines":[{"line_number":125,"context_line":"                                               data\u003dpayload)"},{"line_number":126,"context_line":"        except Exception:"},{"line_number":127,"context_line":"            if cfg.CONF.requeue_notification_on_dispatcher_error:"},{"line_number":128,"context_line":"                LOG.exception(_(\"Dispatcher fail to handle the sample, \""},{"line_number":129,"context_line":"                                \"requeue it.\"))"},{"line_number":130,"context_line":"                return oslo.messaging.NotificationResult.REQUEUE"},{"line_number":131,"context_line":"            raise"}],"source_content_type":"text/x-python","patch_set":4,"id":"1abeadc6_fdb05bdf","line":128,"range":{"start_line":128,"start_character":44,"end_line":128,"end_character":48},"updated":"2014-08-18 14:56:12.000000000","message":"failed","commit_id":"35902d5232e1a9f020d8d7444df68721ce8ab7eb"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"00a5313c6adf65b29d3bf9245b5f39ba9d2aa6b1","unresolved":false,"context_lines":[{"line_number":125,"context_line":"                                               data\u003dpayload)"},{"line_number":126,"context_line":"        except Exception:"},{"line_number":127,"context_line":"            if cfg.CONF.requeue_notification_on_dispatcher_error:"},{"line_number":128,"context_line":"                LOG.exception(_(\"Dispatcher fail to handle the sample, \""},{"line_number":129,"context_line":"                                \"requeue it.\"))"},{"line_number":130,"context_line":"                return oslo.messaging.NotificationResult.REQUEUE"},{"line_number":131,"context_line":"            raise"}],"source_content_type":"text/x-python","patch_set":4,"id":"1abeadc6_51b0588b","line":128,"updated":"2014-08-18 16:04:45.000000000","message":"sould be _LE","commit_id":"35902d5232e1a9f020d8d7444df68721ce8ab7eb"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"1cff5bc9a2b7b6724def88d3205303d46aa7fd3c","unresolved":false,"context_lines":[{"line_number":125,"context_line":"                                               data\u003dpayload)"},{"line_number":126,"context_line":"        except Exception:"},{"line_number":127,"context_line":"            if cfg.CONF.requeue_notification_on_dispatcher_error:"},{"line_number":128,"context_line":"                LOG.exception(_(\"Dispatcher fail to handle the sample, \""},{"line_number":129,"context_line":"                                \"requeue it.\"))"},{"line_number":130,"context_line":"                return oslo.messaging.NotificationResult.REQUEUE"},{"line_number":131,"context_line":"            raise"}],"source_content_type":"text/x-python","patch_set":4,"id":"1abeadc6_ce365e52","line":128,"in_reply_to":"1abeadc6_51b0588b","updated":"2014-08-19 12:57:27.000000000","message":"Done","commit_id":"35902d5232e1a9f020d8d7444df68721ce8ab7eb"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"1cff5bc9a2b7b6724def88d3205303d46aa7fd3c","unresolved":false,"context_lines":[{"line_number":125,"context_line":"                                               data\u003dpayload)"},{"line_number":126,"context_line":"        except Exception:"},{"line_number":127,"context_line":"            if cfg.CONF.requeue_notification_on_dispatcher_error:"},{"line_number":128,"context_line":"                LOG.exception(_(\"Dispatcher fail to handle the sample, \""},{"line_number":129,"context_line":"                                \"requeue it.\"))"},{"line_number":130,"context_line":"                return oslo.messaging.NotificationResult.REQUEUE"},{"line_number":131,"context_line":"            raise"}],"source_content_type":"text/x-python","patch_set":4,"id":"1abeadc6_ae2f62f5","line":128,"in_reply_to":"1abeadc6_fdb05bdf","updated":"2014-08-19 12:57:27.000000000","message":"Done","commit_id":"35902d5232e1a9f020d8d7444df68721ce8ab7eb"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"86c511eadccb470082ae34d996b0cdd3c8554261","unresolved":false,"context_lines":[{"line_number":126,"context_line":"                                               data\u003dpayload)"},{"line_number":127,"context_line":"        except Exception:"},{"line_number":128,"context_line":"            if cfg.CONF.requeue_notification_on_dispatcher_error:"},{"line_number":129,"context_line":"                LOG.exception(_LE(\"Dispatcher fails to handle the sample, \""},{"line_number":130,"context_line":"                                  \"requeue it.\"))"},{"line_number":131,"context_line":"                return oslo.messaging.NotificationResult.REQUEUE"},{"line_number":132,"context_line":"            raise"}],"source_content_type":"text/x-python","patch_set":5,"id":"1abeadc6_492168fa","line":129,"updated":"2014-08-19 13:16:33.000000000","message":"(nit) s/fails/failed/","commit_id":"911f970f3710e272a97974e8b610d4250dad29a8"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"f692cae36e458bd76e5b46c3d797d28a5c6d1f70","unresolved":false,"context_lines":[{"line_number":126,"context_line":"                                               data\u003dpayload)"},{"line_number":127,"context_line":"        except Exception:"},{"line_number":128,"context_line":"            if cfg.CONF.requeue_notification_on_dispatcher_error:"},{"line_number":129,"context_line":"                LOG.exception(_LE(\"Dispatcher fails to handle the sample, \""},{"line_number":130,"context_line":"                                  \"requeue it.\"))"},{"line_number":131,"context_line":"                return oslo.messaging.NotificationResult.REQUEUE"},{"line_number":132,"context_line":"            raise"}],"source_content_type":"text/x-python","patch_set":5,"id":"1abeadc6_0d169bf1","line":129,"in_reply_to":"1abeadc6_492168fa","updated":"2014-08-19 13:28:53.000000000","message":"Done","commit_id":"911f970f3710e272a97974e8b610d4250dad29a8"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"893bde1554dbaa7284ac27807add438bf8a1fbf2","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    cfg.IntOpt(\u0027udp_port\u0027,"},{"line_number":38,"context_line":"               default\u003d4952,"},{"line_number":39,"context_line":"               help\u003d\u0027Port to which the UDP socket is bound.\u0027),"},{"line_number":40,"context_line":"    cfg.BoolOpt(\u0027requeue_notification_on_dispatcher_error\u0027,"},{"line_number":41,"context_line":"                default\u003dFalse,"},{"line_number":42,"context_line":"                help\u003d\u0027Requeue the sample on the collector sample queue \u0027"},{"line_number":43,"context_line":"                \u0027when the collector fails to dispatch it.\u0027),"}],"source_content_type":"text/x-python","patch_set":9,"id":"1abeadc6_ffccdd63","line":40,"updated":"2014-08-25 14:14:20.000000000","message":"only complaint is this is a really long option name.","commit_id":"aa8c184164348461717dd3b6312e21739e27e030"},{"author":{"_account_id":7478,"name":"Nadya Shakhat","email":"nadmi4@gmail.com","username":"nprivalova"},"change_message_id":"1df24b0d5aff61015a895394c0399d403801d185","unresolved":false,"context_lines":[{"line_number":36,"context_line":"               \u0027an empty string to disable.\u0027),"},{"line_number":37,"context_line":"    cfg.IntOpt(\u0027udp_port\u0027,"},{"line_number":38,"context_line":"               default\u003d4952,"},{"line_number":39,"context_line":"               help\u003d\u0027Port to which the UDP socket is bound.\u0027),"},{"line_number":40,"context_line":"    cfg.BoolOpt(\u0027requeue_notification_on_dispatcher_error\u0027,"},{"line_number":41,"context_line":"                default\u003dFalse,"},{"line_number":42,"context_line":"                help\u003d\u0027Requeue the sample on the collector sample queue \u0027"}],"source_content_type":"text/x-python","patch_set":12,"id":"1abeadc6_97934d5a","line":39,"updated":"2014-08-28 10:05:39.000000000","message":"Maybe it\u0027s better to rename to requeue_sample_on_dispatcher_error? This opt will be used not only for notifications processing but for pollsters too. What do you think? Of course the message from pollster may be called \u0027notification\u0027 too but it may confuse imho","commit_id":"7373634a331161b53b6ba2e3f56576ff317270fe"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"b4fe26df18092d03a0921d7779f71e845074a21b","unresolved":false,"context_lines":[{"line_number":36,"context_line":"               \u0027an empty string to disable.\u0027),"},{"line_number":37,"context_line":"    cfg.IntOpt(\u0027udp_port\u0027,"},{"line_number":38,"context_line":"               default\u003d4952,"},{"line_number":39,"context_line":"               help\u003d\u0027Port to which the UDP socket is bound.\u0027),"},{"line_number":40,"context_line":"    cfg.BoolOpt(\u0027requeue_notification_on_dispatcher_error\u0027,"},{"line_number":41,"context_line":"                default\u003dFalse,"},{"line_number":42,"context_line":"                help\u003d\u0027Requeue the sample on the collector sample queue \u0027"}],"source_content_type":"text/x-python","patch_set":12,"id":"1abeadc6_927a7b22","line":39,"in_reply_to":"1abeadc6_97934d5a","updated":"2014-08-28 10:42:55.000000000","message":"Hum, I agree the name can be confusing, so we need an other one :)\n\nThe fact is this other is only valid for sample that come from the notifier publisher but not for the udp or the rpc publushers. This is why the work notification appear.\n\nPerhaps requeue_sample_from_notifier_on_dispatcher_error ? but this is a bit long.\n\nSo I will keep your proposal \u0027requeue_sample_on_dispatcher_error\u0027 and I just complete the help sentence with the fact that only useful for samples that come from the notifier publisher.","commit_id":"7373634a331161b53b6ba2e3f56576ff317270fe"},{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"c9e29e1d49e27dc90410e4953c1041d95bc4cedc","unresolved":false,"context_lines":[{"line_number":74,"context_line":""},{"line_number":75,"context_line":"            target \u003d oslo.messaging.Target("},{"line_number":76,"context_line":"                topic\u003dcfg.CONF.publisher_notifier.metering_topic)"},{"line_number":77,"context_line":"            self.notification_server \u003d messaging.get_notification_listener("},{"line_number":78,"context_line":"                transport, [target], [self])"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"            self.rpc_server.start()"}],"source_content_type":"text/x-python","patch_set":13,"id":"1abeadc6_9b11af06","line":77,"updated":"2014-08-28 13:52:50.000000000","message":"according to http://docs.openstack.org/developer/oslo.messaging/notification_listener.html, I think in order to support requeue, the messaging.get_notification_listener() should pass allow_requeue\u003dTrue when calling oslo.messaging.get_notification_listener(). I\u0027m not sure the current messaging.get_notification_listener() implementation can support requeue or not.","commit_id":"5e4460276a127743f98273867b0803af97c59905"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"a33c2a3af07d5d76bedd81f1c028d597ac8bc282","unresolved":false,"context_lines":[{"line_number":74,"context_line":""},{"line_number":75,"context_line":"            target \u003d oslo.messaging.Target("},{"line_number":76,"context_line":"                topic\u003dcfg.CONF.publisher_notifier.metering_topic)"},{"line_number":77,"context_line":"            self.notification_server \u003d messaging.get_notification_listener("},{"line_number":78,"context_line":"                transport, [target], [self])"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"            self.rpc_server.start()"}],"source_content_type":"text/x-python","patch_set":13,"id":"1abeadc6_f69b9a70","line":77,"in_reply_to":"1abeadc6_9b11af06","updated":"2014-08-28 14:17:30.000000000","message":"oh damn, thank a lot, I have missed that one. \n\nThis flags is just to check if the oslo.messaging driver support requeue, it doesn\u0027t do any initialization.\nIf the deployer use a driver that doesn\u0027t support requeue (ie: zmq), ceilometer stop here, and the appropriate message is logged into the log file.\n\nThis flags have been made to make the app fail on startup instead of just a warning/error message during notification handling.","commit_id":"5e4460276a127743f98273867b0803af97c59905"},{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"09da67fb0b4281946205abdf16e4cbecdb8ce9d8","unresolved":false,"context_lines":[{"line_number":76,"context_line":"                topic\u003dcfg.CONF.publisher_notifier.metering_topic)"},{"line_number":77,"context_line":"            self.notification_server \u003d messaging.get_notification_listener("},{"line_number":78,"context_line":"                transport, [target], [self],"},{"line_number":79,"context_line":"                allow_requeue\u003dcfg.CONF.requeue_sample_on_dispatcher_error)"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"            self.rpc_server.start()"},{"line_number":82,"context_line":"            self.notification_server.start()"}],"source_content_type":"text/x-python","patch_set":14,"id":"1abeadc6_a7463779","line":79,"updated":"2014-08-29 02:38:40.000000000","message":"requeue_sample_on_dispatcher_error is registered under collector group.\n\nBesides, messaging.get_notification_listener() doesn\u0027t support **kwargs, so passing the 4th parameter allow_requeue would cause failure.","commit_id":"dfcd6e748f3ff007e421b2a1722e7b8db41b46eb"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"25fca785356751fc59ade250473292ebccfc4960","unresolved":false,"context_lines":[{"line_number":76,"context_line":"                topic\u003dcfg.CONF.publisher_notifier.metering_topic)"},{"line_number":77,"context_line":"            self.notification_server \u003d messaging.get_notification_listener("},{"line_number":78,"context_line":"                transport, [target], [self],"},{"line_number":79,"context_line":"                allow_requeue\u003dcfg.CONF.requeue_sample_on_dispatcher_error)"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"            self.rpc_server.start()"},{"line_number":82,"context_line":"            self.notification_server.start()"}],"source_content_type":"text/x-python","patch_set":14,"id":"1abeadc6_bd3c7594","line":79,"in_reply_to":"1abeadc6_a7463779","updated":"2014-08-29 11:20:56.000000000","message":"Done","commit_id":"dfcd6e748f3ff007e421b2a1722e7b8db41b46eb"},{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"09da67fb0b4281946205abdf16e4cbecdb8ce9d8","unresolved":false,"context_lines":[{"line_number":127,"context_line":"            self.dispatcher_manager.map_method(\u0027record_metering_data\u0027,"},{"line_number":128,"context_line":"                                               data\u003dpayload)"},{"line_number":129,"context_line":"        except Exception:"},{"line_number":130,"context_line":"            if cfg.CONF.requeue_sample_on_dispatcher_error:"},{"line_number":131,"context_line":"                LOG.exception(_LE(\"Dispatcher failed to handle the sample, \""},{"line_number":132,"context_line":"                                  \"requeue it.\"))"},{"line_number":133,"context_line":"                return oslo.messaging.NotificationResult.REQUEUE"}],"source_content_type":"text/x-python","patch_set":14,"id":"1abeadc6_27522735","line":130,"updated":"2014-08-29 02:38:40.000000000","message":"ditto, conf group","commit_id":"dfcd6e748f3ff007e421b2a1722e7b8db41b46eb"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"25fca785356751fc59ade250473292ebccfc4960","unresolved":false,"context_lines":[{"line_number":127,"context_line":"            self.dispatcher_manager.map_method(\u0027record_metering_data\u0027,"},{"line_number":128,"context_line":"                                               data\u003dpayload)"},{"line_number":129,"context_line":"        except Exception:"},{"line_number":130,"context_line":"            if cfg.CONF.requeue_sample_on_dispatcher_error:"},{"line_number":131,"context_line":"                LOG.exception(_LE(\"Dispatcher failed to handle the sample, \""},{"line_number":132,"context_line":"                                  \"requeue it.\"))"},{"line_number":133,"context_line":"                return oslo.messaging.NotificationResult.REQUEUE"}],"source_content_type":"text/x-python","patch_set":14,"id":"1abeadc6_7d4e5d39","line":130,"in_reply_to":"1abeadc6_27522735","updated":"2014-08-29 11:20:56.000000000","message":"Done, I have added a test case in case of this flags is true.","commit_id":"dfcd6e748f3ff007e421b2a1722e7b8db41b46eb"},{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"53e69cb993e3fd7d799b62c44ed5d36f4ccc732d","unresolved":false,"context_lines":[{"line_number":77,"context_line":"                topic\u003dcfg.CONF.publisher_notifier.metering_topic)"},{"line_number":78,"context_line":"            self.notification_server \u003d messaging.get_notification_listener("},{"line_number":79,"context_line":"                transport, [target], [self],"},{"line_number":80,"context_line":"                allow_requeue\u003dallow_requeue)"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"            self.rpc_server.start()"},{"line_number":83,"context_line":"            self.notification_server.start()"}],"source_content_type":"text/x-python","patch_set":15,"id":"1abeadc6_6c194dd0","line":80,"updated":"2014-08-29 10:08:17.000000000","message":"allow_requeue\u003dTrue","commit_id":"6dd02d7bbc30fd4622f2b673437e8ad20e37f513"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"4b59133c0e9e5427b66309b05551c5b4ddd883cd","unresolved":false,"context_lines":[{"line_number":77,"context_line":"                topic\u003dcfg.CONF.publisher_notifier.metering_topic)"},{"line_number":78,"context_line":"            self.notification_server \u003d messaging.get_notification_listener("},{"line_number":79,"context_line":"                transport, [target], [self],"},{"line_number":80,"context_line":"                allow_requeue\u003dallow_requeue)"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"            self.rpc_server.start()"},{"line_number":83,"context_line":"            self.notification_server.start()"}],"source_content_type":"text/x-python","patch_set":15,"id":"1abeadc6_46438d41","line":80,"in_reply_to":"1abeadc6_6c194dd0","updated":"2014-08-29 11:48:36.000000000","message":"If the deployer doesn\u0027t enable requeue_sample_on_dispatcher_error we don\u0027t need to enforce this feature.","commit_id":"6dd02d7bbc30fd4622f2b673437e8ad20e37f513"}],"doc/source/configuration.rst":[{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"86be72a0c111df5ebe392a886f0b9c90122442f8","unresolved":false,"context_lines":[{"line_number":203,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d  \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d  \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":204,"context_line":"requeue_sample_on_dispatcher_error     False                                   Requeue the sample on the collector sample queue when the"},{"line_number":205,"context_line":"                                                                               collector fails to dispatch it. This is only valid if the"},{"line_number":206,"context_line":"                                                                               sample come from the notifier publisher"},{"line_number":207,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d  \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d  \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":""}],"source_content_type":"text/x-rst","patch_set":16,"id":"1abeadc6_5a799a2d","line":206,"updated":"2014-08-29 13:46:51.000000000","message":"s/this is only valid if the sample come from/this option is only valid if the sample comes from/","commit_id":"b79180937f0851cb4290a4efc1d30accc1b05811"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"085beef3090a17e8bd39e888d7166264c8fc4664","unresolved":false,"context_lines":[{"line_number":203,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d  \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d  \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":204,"context_line":"requeue_sample_on_dispatcher_error     False                                   Requeue the sample on the collector sample queue when the"},{"line_number":205,"context_line":"                                                                               collector fails to dispatch it. This is only valid if the"},{"line_number":206,"context_line":"                                                                               sample come from the notifier publisher"},{"line_number":207,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d  \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d  \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":""}],"source_content_type":"text/x-rst","patch_set":16,"id":"fa98f980_47db5b1b","line":206,"in_reply_to":"1abeadc6_5a799a2d","updated":"2014-09-01 07:05:26.000000000","message":"Done","commit_id":"b79180937f0851cb4290a4efc1d30accc1b05811"}]}