)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10987,"name":"Igor Degtiarov","username":"tovstun","inactive":true},"change_message_id":"e887f6b3b65b32bb883e55e376c2bbad053e62d6","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"XenAPI support: Memory Usage"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Implemented inspect_memory_usage() to inspect the memory usage statistics"},{"line_number":10,"context_line":"for an instance."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I0a8549e9e80ffeab18acc3b236c8fdc63d970783"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1abeadc6_d8426967","line":9,"updated":"2014-08-20 16:01:15.000000000","message":"Would be better s/Implemented/implements\n\nJust a nit, not blocking of course :)","commit_id":"4c521892e73ef44927e7573ce8f3977c94e9efa1"},{"author":{"_account_id":9581,"name":"Ren Qiaowei","email":"qiaowei.ren@intel.com","username":"qiaowei"},"change_message_id":"974c016f25b54b14bc259bdd0064c132342a1be8","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"XenAPI support: Memory Usage"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Implemented inspect_memory_usage() to inspect the memory usage statistics"},{"line_number":10,"context_line":"for an instance."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I0a8549e9e80ffeab18acc3b236c8fdc63d970783"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1abeadc6_593cbfe2","line":9,"in_reply_to":"1abeadc6_d8426967","updated":"2014-08-27 06:44:09.000000000","message":"Hmm, just refer to vmware inspector patches. :)","commit_id":"4c521892e73ef44927e7573ce8f3977c94e9efa1"}],"ceilometer/compute/virt/xenapi/inspector.py":[{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"273c245ef02094795f0656fde13d195e9e54599c","unresolved":false,"context_lines":[{"line_number":142,"context_line":"        metrics_rec \u003d self._call_xenapi(\"VM_metrics.get_record\","},{"line_number":143,"context_line":"                                        metrics_ref)"},{"line_number":144,"context_line":"        memory \u003d metrics_rec[\u0027memory_actual\u0027]"},{"line_number":145,"context_line":"        # Stat provided from vSphere is in B, converting it to MB."},{"line_number":146,"context_line":"        memory \u003d long(metrics_rec[\u0027memory_actual\u0027]) / units.Mi"},{"line_number":147,"context_line":"        return virt_inspector.MemoryUsageStats(usage\u003dmemory)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1abeadc6_c7f39c9d","line":145,"updated":"2014-08-19 15:16:43.000000000","message":"s/vsphere/xenserver?/","commit_id":"66e1c436d98f65838f618142ad4dfac24c355f25"},{"author":{"_account_id":9581,"name":"Ren Qiaowei","email":"qiaowei.ren@intel.com","username":"qiaowei"},"change_message_id":"6a29b607f60169ddfec30c612a4dcd860381bd0f","unresolved":false,"context_lines":[{"line_number":142,"context_line":"        metrics_rec \u003d self._call_xenapi(\"VM_metrics.get_record\","},{"line_number":143,"context_line":"                                        metrics_ref)"},{"line_number":144,"context_line":"        memory \u003d metrics_rec[\u0027memory_actual\u0027]"},{"line_number":145,"context_line":"        # Stat provided from vSphere is in B, converting it to MB."},{"line_number":146,"context_line":"        memory \u003d long(metrics_rec[\u0027memory_actual\u0027]) / units.Mi"},{"line_number":147,"context_line":"        return virt_inspector.MemoryUsageStats(usage\u003dmemory)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1abeadc6_cd8c8482","line":145,"in_reply_to":"1abeadc6_c7f39c9d","updated":"2014-08-20 02:03:49.000000000","message":"Hmm. Sorry, I refered to vmware implementation. :)","commit_id":"66e1c436d98f65838f618142ad4dfac24c355f25"},{"author":{"_account_id":10106,"name":"Piyush Masrani","email":"pmasrani@vmware.com","username":"piyushmasrani"},"change_message_id":"6fba0180b1192ce29d6d0efc22727280ed5d2307","unresolved":false,"context_lines":[{"line_number":142,"context_line":"        metrics_ref \u003d self._call_xenapi(\"VM.get_metrics\", vm_ref)"},{"line_number":143,"context_line":"        metrics_rec \u003d self._call_xenapi(\"VM_metrics.get_record\","},{"line_number":144,"context_line":"                                        metrics_ref)"},{"line_number":145,"context_line":"        memory \u003d metrics_rec[\u0027memory_actual\u0027]"},{"line_number":146,"context_line":"        # Stat provided from XenServer is in B, converting it to MB."},{"line_number":147,"context_line":"        memory \u003d long(metrics_rec[\u0027memory_actual\u0027]) / units.Mi"},{"line_number":148,"context_line":"        return virt_inspector.MemoryUsageStats(usage\u003dmemory)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1abeadc6_10bd1503","line":145,"updated":"2014-08-25 08:39:55.000000000","message":"I believe this is unnecessary as the immediate next instruction is overwriting the variable.","commit_id":"4c521892e73ef44927e7573ce8f3977c94e9efa1"},{"author":{"_account_id":9581,"name":"Ren Qiaowei","email":"qiaowei.ren@intel.com","username":"qiaowei"},"change_message_id":"974c016f25b54b14bc259bdd0064c132342a1be8","unresolved":false,"context_lines":[{"line_number":142,"context_line":"        metrics_ref \u003d self._call_xenapi(\"VM.get_metrics\", vm_ref)"},{"line_number":143,"context_line":"        metrics_rec \u003d self._call_xenapi(\"VM_metrics.get_record\","},{"line_number":144,"context_line":"                                        metrics_ref)"},{"line_number":145,"context_line":"        memory \u003d metrics_rec[\u0027memory_actual\u0027]"},{"line_number":146,"context_line":"        # Stat provided from XenServer is in B, converting it to MB."},{"line_number":147,"context_line":"        memory \u003d long(metrics_rec[\u0027memory_actual\u0027]) / units.Mi"},{"line_number":148,"context_line":"        return virt_inspector.MemoryUsageStats(usage\u003dmemory)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1abeadc6_990c9744","line":145,"in_reply_to":"1abeadc6_10bd1503","updated":"2014-08-27 06:44:09.000000000","message":"Yes. I will remove it.","commit_id":"4c521892e73ef44927e7573ce8f3977c94e9efa1"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"cfd337d04ca92039aaa133b4aa426809e0c46669","unresolved":false,"context_lines":[{"line_number":142,"context_line":"        metrics_ref \u003d self._call_xenapi(\"VM.get_metrics\", vm_ref)"},{"line_number":143,"context_line":"        metrics_rec \u003d self._call_xenapi(\"VM_metrics.get_record\","},{"line_number":144,"context_line":"                                        metrics_ref)"},{"line_number":145,"context_line":"        memory \u003d metrics_rec[\u0027memory_actual\u0027]"},{"line_number":146,"context_line":"        # Stat provided from XenServer is in B, converting it to MB."},{"line_number":147,"context_line":"        memory \u003d long(metrics_rec[\u0027memory_actual\u0027]) / units.Mi"},{"line_number":148,"context_line":"        return virt_inspector.MemoryUsageStats(usage\u003dmemory)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1abeadc6_715e4114","line":145,"in_reply_to":"1abeadc6_10bd1503","updated":"2014-08-25 15:01:05.000000000","message":"agreed","commit_id":"4c521892e73ef44927e7573ce8f3977c94e9efa1"}],"ceilometer/tests/compute/virt/xenapi/test_inspector.py":[{"author":{"_account_id":3012,"name":"Dina Belova","email":"dbelova@mirantis.com","username":"dbelova"},"change_message_id":"09516f1a46679722cf262b7ba0cc591c6677faad","unresolved":false,"context_lines":[{"line_number":92,"context_line":"            elif method \u003d\u003d \u0027VM_metrics.get_record\u0027:"},{"line_number":93,"context_line":"                return metrics_rec"},{"line_number":94,"context_line":"            else:"},{"line_number":95,"context_line":"                return None"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"        session \u003d self.inspector.session"},{"line_number":98,"context_line":"        with mock.patch.object(session, \u0027xenapi_request\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"1abeadc6_2688b2e6","line":95,"updated":"2014-08-20 08:49:52.000000000","message":"here as well - do you need that explicit None being returned? Personally I love more just \u0027return\u0027, but that\u0027s question of personal taste and the meaning you\u0027re setting for every case separately","commit_id":"4c521892e73ef44927e7573ce8f3977c94e9efa1"}]}