)]}'
{"ceilometer/hardware/inspector/snmp.py":[{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"bdfabd7d404f226ad1078d4874d0769fc3e94a4b","unresolved":false,"context_lines":[{"line_number":237,"context_line":"            \u0027metadata\u0027: _net_metadata,"},{"line_number":238,"context_line":"            \u0027post_op\u0027: \"_post_op_net\","},{"line_number":239,"context_line":"        },"},{"line_number":240,"context_line":"        \u0027network.ip.out_requests\u0027: {"},{"line_number":241,"context_line":"            \u0027matching_type\u0027: EXACT,"},{"line_number":242,"context_line":"            \u0027metric_oid\u0027: (_network_ip_out_requests_oid, int),"},{"line_number":243,"context_line":"            \u0027metadata\u0027: {},"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa98f980_250ccf3a","line":240,"updated":"2014-09-05 02:34:07.000000000","message":"this should match the pollster\u0027s IDENTIFIER network.ip.outgoing.datagrams","commit_id":"f58f79bc0b9c55c32b993517958bdebea052d748"},{"author":{"_account_id":7585,"name":"Ladislav Smola","email":"lsmola@redhat.com","username":"lsmola"},"change_message_id":"0da927b236d1bf06e4e13a0fcee0a1ab42fba7b8","unresolved":false,"context_lines":[{"line_number":237,"context_line":"            \u0027metadata\u0027: _net_metadata,"},{"line_number":238,"context_line":"            \u0027post_op\u0027: \"_post_op_net\","},{"line_number":239,"context_line":"        },"},{"line_number":240,"context_line":"        \u0027network.ip.out_requests\u0027: {"},{"line_number":241,"context_line":"            \u0027matching_type\u0027: EXACT,"},{"line_number":242,"context_line":"            \u0027metric_oid\u0027: (_network_ip_out_requests_oid, int),"},{"line_number":243,"context_line":"            \u0027metadata\u0027: {},"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa98f980_94176b44","line":240,"in_reply_to":"fa98f980_250ccf3a","updated":"2014-09-05 06:50:20.000000000","message":"oh, thanks","commit_id":"f58f79bc0b9c55c32b993517958bdebea052d748"},{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"bdfabd7d404f226ad1078d4874d0769fc3e94a4b","unresolved":false,"context_lines":[{"line_number":243,"context_line":"            \u0027metadata\u0027: {},"},{"line_number":244,"context_line":"            \u0027post_op\u0027: None,"},{"line_number":245,"context_line":"        },"},{"line_number":246,"context_line":"        \u0027network.ip.in_receives\u0027: {"},{"line_number":247,"context_line":"            \u0027matching_type\u0027: EXACT,"},{"line_number":248,"context_line":"            \u0027metric_oid\u0027: (_network_ip_in_receives_oid, int),"},{"line_number":249,"context_line":"            \u0027metadata\u0027: {},"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa98f980_4516334d","line":246,"updated":"2014-09-05 02:34:07.000000000","message":"ditto","commit_id":"f58f79bc0b9c55c32b993517958bdebea052d748"},{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"bdfabd7d404f226ad1078d4874d0769fc3e94a4b","unresolved":false,"context_lines":[{"line_number":255,"context_line":"            \u0027metadata\u0027: {},"},{"line_number":256,"context_line":"            \u0027post_op\u0027: None,"},{"line_number":257,"context_line":"        },"},{"line_number":258,"context_line":"        \u0027system_stats.io.raw_sent\u0027: {"},{"line_number":259,"context_line":"            \u0027matching_type\u0027: EXACT,"},{"line_number":260,"context_line":"            \u0027metric_oid\u0027: (_system_stats_io_raw_sent_oid, int),"},{"line_number":261,"context_line":"            \u0027metadata\u0027: {},"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa98f980_e52c879b","line":258,"updated":"2014-09-05 02:34:07.000000000","message":"ditto","commit_id":"f58f79bc0b9c55c32b993517958bdebea052d748"},{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"bdfabd7d404f226ad1078d4874d0769fc3e94a4b","unresolved":false,"context_lines":[{"line_number":261,"context_line":"            \u0027metadata\u0027: {},"},{"line_number":262,"context_line":"            \u0027post_op\u0027: None,"},{"line_number":263,"context_line":"        },"},{"line_number":264,"context_line":"        \u0027system_stats.io.raw_received\u0027: {"},{"line_number":265,"context_line":"            \u0027matching_type\u0027: EXACT,"},{"line_number":266,"context_line":"            \u0027metric_oid\u0027: (_system_stats_io_raw_received_oid, int),"},{"line_number":267,"context_line":"            \u0027metadata\u0027: {},"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa98f980_0520ab99","line":264,"updated":"2014-09-05 02:34:07.000000000","message":"ditto","commit_id":"f58f79bc0b9c55c32b993517958bdebea052d748"}],"ceilometer/hardware/pollsters/network_aggregated.py":[{"author":{"_account_id":3012,"name":"Dina Belova","email":"dbelova@mirantis.com","username":"dbelova"},"change_message_id":"53c7b6f6dd9625259753fadcb26370e940049391","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#"},{"line_number":2,"context_line":"# Copyright 2013 ZHAW SoE"},{"line_number":3,"context_line":"# Copyright 2014 Intel Corp."},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":3,"id":"1abeadc6_816b02f0","line":1,"updated":"2014-08-21 10:24:03.000000000","message":"Empty line?","commit_id":"d0250ecc7498e958b2ee6bf1d2f8f0f6b827e9bd"},{"author":{"_account_id":7585,"name":"Ladislav Smola","email":"lsmola@redhat.com","username":"lsmola"},"change_message_id":"e6f59dd76828b3d2e977aea0ca5644b0bca1cc0d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#"},{"line_number":2,"context_line":"# Copyright 2013 ZHAW SoE"},{"line_number":3,"context_line":"# Copyright 2014 Intel Corp."},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":3,"id":"1abeadc6_5fcffa28","line":1,"in_reply_to":"1abeadc6_816b02f0","updated":"2014-08-21 13:30:43.000000000","message":"Done","commit_id":"d0250ecc7498e958b2ee6bf1d2f8f0f6b827e9bd"},{"author":{"_account_id":10987,"name":"Igor Degtiarov","username":"tovstun","inactive":true},"change_message_id":"2c3982615377323786f5aae2e8895be373e98a75","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    CACHE_KEY \u003d \u0027network\u0027"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    def generate_one_sample(self, host, c_data):"},{"line_number":31,"context_line":"        (value, metadata, extra) \u003d c_data"},{"line_number":32,"context_line":"        return util.make_sample_from_host(host,"},{"line_number":33,"context_line":"                                          name\u003dself.IDENTIFIER,"},{"line_number":34,"context_line":"                                          sample_type\u003dsample.TYPE_CUMULATIVE,"}],"source_content_type":"text/x-python","patch_set":3,"id":"1abeadc6_81b22204","line":31,"updated":"2014-08-21 10:14:05.000000000","message":"We really don\u0027t need parentheses here.","commit_id":"d0250ecc7498e958b2ee6bf1d2f8f0f6b827e9bd"},{"author":{"_account_id":7585,"name":"Ladislav Smola","email":"lsmola@redhat.com","username":"lsmola"},"change_message_id":"e6f59dd76828b3d2e977aea0ca5644b0bca1cc0d","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    CACHE_KEY \u003d \u0027network\u0027"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    def generate_one_sample(self, host, c_data):"},{"line_number":31,"context_line":"        (value, metadata, extra) \u003d c_data"},{"line_number":32,"context_line":"        return util.make_sample_from_host(host,"},{"line_number":33,"context_line":"                                          name\u003dself.IDENTIFIER,"},{"line_number":34,"context_line":"                                          sample_type\u003dsample.TYPE_CUMULATIVE,"}],"source_content_type":"text/x-python","patch_set":3,"id":"1abeadc6_7fd4b6bc","line":31,"in_reply_to":"1abeadc6_21a5ce46","updated":"2014-08-21 13:30:43.000000000","message":"Done","commit_id":"d0250ecc7498e958b2ee6bf1d2f8f0f6b827e9bd"},{"author":{"_account_id":3012,"name":"Dina Belova","email":"dbelova@mirantis.com","username":"dbelova"},"change_message_id":"53c7b6f6dd9625259753fadcb26370e940049391","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    CACHE_KEY \u003d \u0027network\u0027"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    def generate_one_sample(self, host, c_data):"},{"line_number":31,"context_line":"        (value, metadata, extra) \u003d c_data"},{"line_number":32,"context_line":"        return util.make_sample_from_host(host,"},{"line_number":33,"context_line":"                                          name\u003dself.IDENTIFIER,"},{"line_number":34,"context_line":"                                          sample_type\u003dsample.TYPE_CUMULATIVE,"}],"source_content_type":"text/x-python","patch_set":3,"id":"1abeadc6_21a5ce46","line":31,"in_reply_to":"1abeadc6_81b22204","updated":"2014-08-21 10:24:03.000000000","message":"++, that is the obsolete practice","commit_id":"d0250ecc7498e958b2ee6bf1d2f8f0f6b827e9bd"},{"author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"change_message_id":"2d0c9e6ba6572b58bd2be6fe030e7104abd43ffe","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"class NetworkAggregatedIPInReceives(_Base):"},{"line_number":38,"context_line":"    IDENTIFIER \u003d \u0027network.ip.in_receives\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa98f980_8060c936","line":38,"updated":"2014-09-01 08:35:11.000000000","message":"Not sure about the \"receives\" in the meter name, from a clarity/consistency PoV.\n\nHow about something like:\n\n* hardware.network.ip.incoming.packets\n* hardware.network.ip.outgoing.packets\n\ninstead of:\n\n* hardware.network.ip.in_requests\n* hardware.network.ip.out_receives\n\nAlso is the \".ip.\" intended to convey that this meter is aggregated over all networks interfaces per-host?","commit_id":"4d1582e0749c823fe8a596cf011e93fea114049b"},{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"8c8b39228782ba50668763add0b4f0e5d62441b9","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"class NetworkAggregatedIPInReceives(_Base):"},{"line_number":38,"context_line":"    IDENTIFIER \u003d \u0027network.ip.in_receives\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa98f980_9e68f7bb","line":38,"in_reply_to":"fa98f980_17b6dad9","updated":"2014-09-02 03:59:36.000000000","message":"Yes, I think we should follow the pre-existing naming convention.","commit_id":"4d1582e0749c823fe8a596cf011e93fea114049b"},{"author":{"_account_id":7585,"name":"Ladislav Smola","email":"lsmola@redhat.com","username":"lsmola"},"change_message_id":"880f1716546e00383618f6ecbb87a8c0ac624153","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"class NetworkAggregatedIPInReceives(_Base):"},{"line_number":38,"context_line":"    IDENTIFIER \u003d \u0027network.ip.in_receives\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa98f980_17b6dad9","line":38,"in_reply_to":"fa98f980_8060c936","updated":"2014-09-01 11:55:43.000000000","message":"Will rename.\n\nYes it is aggregated across interfaces.","commit_id":"4d1582e0749c823fe8a596cf011e93fea114049b"}],"ceilometer/hardware/pollsters/system.py":[{"author":{"_account_id":3012,"name":"Dina Belova","email":"dbelova@mirantis.com","username":"dbelova"},"change_message_id":"53c7b6f6dd9625259753fadcb26370e940049391","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#"},{"line_number":2,"context_line":"# Copyright 2013 ZHAW SoE"},{"line_number":3,"context_line":"# Copyright 2014 Intel Corp."},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":3,"id":"1abeadc6_a170fedc","line":1,"updated":"2014-08-21 10:24:03.000000000","message":"ditto","commit_id":"d0250ecc7498e958b2ee6bf1d2f8f0f6b827e9bd"},{"author":{"_account_id":7585,"name":"Ladislav Smola","email":"lsmola@redhat.com","username":"lsmola"},"change_message_id":"e6f59dd76828b3d2e977aea0ca5644b0bca1cc0d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#"},{"line_number":2,"context_line":"# Copyright 2013 ZHAW SoE"},{"line_number":3,"context_line":"# Copyright 2014 Intel Corp."},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":3,"id":"1abeadc6_5fe61ab1","line":1,"in_reply_to":"1abeadc6_a170fedc","updated":"2014-08-21 13:30:43.000000000","message":"Done","commit_id":"d0250ecc7498e958b2ee6bf1d2f8f0f6b827e9bd"},{"author":{"_account_id":10987,"name":"Igor Degtiarov","username":"tovstun","inactive":true},"change_message_id":"2c3982615377323786f5aae2e8895be373e98a75","unresolved":false,"context_lines":[{"line_number":31,"context_line":"class _IOBase(_Base):"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    def generate_one_sample(self, host, c_data):"},{"line_number":34,"context_line":"        (value, metadata, extra) \u003d c_data"},{"line_number":35,"context_line":"        return util.make_sample_from_host(host,"},{"line_number":36,"context_line":"                                          name\u003dself.IDENTIFIER,"},{"line_number":37,"context_line":"                                          sample_type\u003dsample.TYPE_CUMULATIVE,"}],"source_content_type":"text/x-python","patch_set":3,"id":"1abeadc6_a1ae3e96","line":34,"updated":"2014-08-21 10:14:05.000000000","message":"ditto","commit_id":"d0250ecc7498e958b2ee6bf1d2f8f0f6b827e9bd"},{"author":{"_account_id":7585,"name":"Ladislav Smola","email":"lsmola@redhat.com","username":"lsmola"},"change_message_id":"e6f59dd76828b3d2e977aea0ca5644b0bca1cc0d","unresolved":false,"context_lines":[{"line_number":31,"context_line":"class _IOBase(_Base):"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    def generate_one_sample(self, host, c_data):"},{"line_number":34,"context_line":"        (value, metadata, extra) \u003d c_data"},{"line_number":35,"context_line":"        return util.make_sample_from_host(host,"},{"line_number":36,"context_line":"                                          name\u003dself.IDENTIFIER,"},{"line_number":37,"context_line":"                                          sample_type\u003dsample.TYPE_CUMULATIVE,"}],"source_content_type":"text/x-python","patch_set":3,"id":"1abeadc6_9f035241","line":34,"in_reply_to":"1abeadc6_a1ae3e96","updated":"2014-08-21 13:30:43.000000000","message":"Done","commit_id":"d0250ecc7498e958b2ee6bf1d2f8f0f6b827e9bd"},{"author":{"_account_id":10987,"name":"Igor Degtiarov","username":"tovstun","inactive":true},"change_message_id":"2c3982615377323786f5aae2e8895be373e98a75","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"class _CpuBase(_Base):"},{"line_number":45,"context_line":"    def generate_one_sample(self, host, c_data):"},{"line_number":46,"context_line":"        (value, metadata, extra) \u003d c_data"},{"line_number":47,"context_line":"        return util.make_sample_from_host(host,"},{"line_number":48,"context_line":"                                          name\u003dself.IDENTIFIER,"},{"line_number":49,"context_line":"                                          sample_type\u003dsample.TYPE_GAUGE,"}],"source_content_type":"text/x-python","patch_set":3,"id":"1abeadc6_e193d658","line":46,"updated":"2014-08-21 10:14:05.000000000","message":"ditto","commit_id":"d0250ecc7498e958b2ee6bf1d2f8f0f6b827e9bd"},{"author":{"_account_id":7585,"name":"Ladislav Smola","email":"lsmola@redhat.com","username":"lsmola"},"change_message_id":"e6f59dd76828b3d2e977aea0ca5644b0bca1cc0d","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"class _CpuBase(_Base):"},{"line_number":45,"context_line":"    def generate_one_sample(self, host, c_data):"},{"line_number":46,"context_line":"        (value, metadata, extra) \u003d c_data"},{"line_number":47,"context_line":"        return util.make_sample_from_host(host,"},{"line_number":48,"context_line":"                                          name\u003dself.IDENTIFIER,"},{"line_number":49,"context_line":"                                          sample_type\u003dsample.TYPE_GAUGE,"}],"source_content_type":"text/x-python","patch_set":3,"id":"1abeadc6_bf000e35","line":46,"in_reply_to":"1abeadc6_e193d658","updated":"2014-08-21 13:30:43.000000000","message":"Done","commit_id":"d0250ecc7498e958b2ee6bf1d2f8f0f6b827e9bd"},{"author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"change_message_id":"2d0c9e6ba6572b58bd2be6fe030e7104abd43ffe","unresolved":false,"context_lines":[{"line_number":42,"context_line":"                                          unit\u003d\u0027%\u0027,"},{"line_number":43,"context_line":"                                          volume\u003dvalue,"},{"line_number":44,"context_line":"                                          res_metadata\u003dmetadata,"},{"line_number":45,"context_line":"                                          extra\u003dextra)"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"class SystemCpuIdlePollster(_CpuBase):"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa98f980_40c8a174","line":45,"updated":"2014-09-01 08:35:11.000000000","message":"Hmmm, rather that having separate _IOBase \u0026 _CPUBase base class here, where the latter is one extended by a single sub-class and is not really very CPU-specific, how about instead using a pattern like:\n\n   class _SystemBase(_Base):\n      def generate_one_sample(self, host, c_data):\n          value, metadata, extra \u003d c_data\n          return util.make_sample_from_host(host,\n                                            name\u003dself.IDENTIFIER,\n                                            sample_type\u003dself.TYPE,\n                                            unit\u003dself.UNIT,\n                                            volume\u003dvalue,\n                                            res_metadata\u003dmetadata,\n                                            extra\u003dextra)\n\n  class SystemCpuIdlePollster(_SystemBase):\n      IDENTIFIER \u003d \u0027system_stats.cpu.idle\u0027\n      TYPE \u003d sample.TYPE_GAUGE\n      UNIT \u003d \u0027%\u0027\n\n  class SystemIORawSentPollster(_SystemBase):\n      IDENTIFIER \u003d \u0027system_stats.io.raw_sent\u0027\n      TYPE \u003d sample.TYPE_CUMULATIVE,\n      UNIT \u003d \u0027datagrams\u0027\n\n  ... etc","commit_id":"4d1582e0749c823fe8a596cf011e93fea114049b"},{"author":{"_account_id":7585,"name":"Ladislav Smola","email":"lsmola@redhat.com","username":"lsmola"},"change_message_id":"880f1716546e00383618f6ecbb87a8c0ac624153","unresolved":false,"context_lines":[{"line_number":42,"context_line":"                                          unit\u003d\u0027%\u0027,"},{"line_number":43,"context_line":"                                          volume\u003dvalue,"},{"line_number":44,"context_line":"                                          res_metadata\u003dmetadata,"},{"line_number":45,"context_line":"                                          extra\u003dextra)"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"class SystemCpuIdlePollster(_CpuBase):"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa98f980_f7e796e2","line":45,"in_reply_to":"fa98f980_40c8a174","updated":"2014-09-01 11:55:43.000000000","message":"will do","commit_id":"4d1582e0749c823fe8a596cf011e93fea114049b"},{"author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"change_message_id":"2d0c9e6ba6572b58bd2be6fe030e7104abd43ffe","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"class SystemIORawSentPollster(_IOBase):"},{"line_number":53,"context_line":"    IDENTIFIER \u003d \u0027system_stats.io.raw_sent\u0027"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"class SystemIORawReceivedPollster(_IOBase):"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa98f980_a0e22dd3","line":53,"updated":"2014-09-01 08:35:11.000000000","message":"The naming pattern for I/O related meters is usually to capture the thing been sent/received in the meter name, e.g.:\n\n* hardware.network.incoming.bytes\n* hardware.network.outgoing.bytes\n* network.incoming.packets\n* ... etc.\n\nWould it make sense to follow that pattern here also?","commit_id":"4d1582e0749c823fe8a596cf011e93fea114049b"},{"author":{"_account_id":7585,"name":"Ladislav Smola","email":"lsmola@redhat.com","username":"lsmola"},"change_message_id":"880f1716546e00383618f6ecbb87a8c0ac624153","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"class SystemIORawSentPollster(_IOBase):"},{"line_number":53,"context_line":"    IDENTIFIER \u003d \u0027system_stats.io.raw_sent\u0027"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"class SystemIORawReceivedPollster(_IOBase):"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa98f980_37cafe4f","line":53,"in_reply_to":"fa98f980_a0e22dd3","updated":"2014-09-01 11:55:43.000000000","message":"Yes, will rename","commit_id":"4d1582e0749c823fe8a596cf011e93fea114049b"}]}