)]}'
{"ceilometer/alarm/service.py":[{"author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"change_message_id":"91c95baa7c2ca29c53afa3a7957bf21d4466ceab","unresolved":false,"context_lines":[{"line_number":49,"context_line":"cfg.CONF.import_opt(\u0027partition_rpc_topic\u0027, \u0027ceilometer.alarm.rpc\u0027,"},{"line_number":50,"context_line":"                    group\u003d\u0027alarm\u0027)"},{"line_number":51,"context_line":"cfg.CONF.import_opt(\u0027heartbeat\u0027, \u0027ceilometer.coordination\u0027,"},{"line_number":52,"context_line":"                    group\u003d\u0027coordination\u0027)"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"LOG \u003d log.getLogger(__name__)"},{"line_number":55,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"1abeadc6_20c67e9a","line":52,"updated":"2014-08-29 08:59:38.000000000","message":"Should the default for this heartbeat be somehow related to the evaluation_interval? (i.e. some fraction thereof)","commit_id":"ab8e16218e7bc1917f6908cb03f6f4da5f5d9838"},{"author":{"_account_id":8052,"name":"Nejc Saje","email":"nejc@saje.info","username":"nsaje"},"change_message_id":"50d1ff9887750ec3a53a4870812f7c4201699eee","unresolved":false,"context_lines":[{"line_number":49,"context_line":"cfg.CONF.import_opt(\u0027partition_rpc_topic\u0027, \u0027ceilometer.alarm.rpc\u0027,"},{"line_number":50,"context_line":"                    group\u003d\u0027alarm\u0027)"},{"line_number":51,"context_line":"cfg.CONF.import_opt(\u0027heartbeat\u0027, \u0027ceilometer.coordination\u0027,"},{"line_number":52,"context_line":"                    group\u003d\u0027coordination\u0027)"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"LOG \u003d log.getLogger(__name__)"},{"line_number":55,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"1abeadc6_d7f10a02","line":52,"in_reply_to":"1abeadc6_20c67e9a","updated":"2014-08-29 10:25:44.000000000","message":"Yes, good point. Should we still make it configurable? Or perhaps take a minimum of the two, the configured one and the interval fraction?","commit_id":"ab8e16218e7bc1917f6908cb03f6f4da5f5d9838"}],"ceilometer/cmd/alarm.py":[{"author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"change_message_id":"91c95baa7c2ca29c53afa3a7957bf21d4466ceab","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    cfg.StrOpt(\u0027evaluation_service\u0027,"},{"line_number":27,"context_line":"               default\u003d\u0027ceilometer.alarm.service.SingletonAlarmService\u0027,"},{"line_number":28,"context_line":"               help\u003d\u0027Class to launch as alarm evaluation service.\u0027),"},{"line_number":29,"context_line":"]"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"cfg.CONF.register_opts(OPTS, group\u003d\u0027alarm\u0027)"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"1abeadc6_00ad029b","side":"PARENT","line":29,"updated":"2014-08-29 08:59:38.000000000","message":"Hmmm, just thinking about the unwritten policy on backward compatability of config.\n\nI wonder should we keep some sort of support around  for this config option for a transition period, by e.g. interpreting an *explicitly set* value of  ceilometer.alarm.service.SingletonAlarmService to mean \"disable partition coordination\"?","commit_id":"a1669d7746cd0db5f5ef80ba857cd5f2ae2b78ff"},{"author":{"_account_id":8052,"name":"Nejc Saje","email":"nejc@saje.info","username":"nsaje"},"change_message_id":"50d1ff9887750ec3a53a4870812f7c4201699eee","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    cfg.StrOpt(\u0027evaluation_service\u0027,"},{"line_number":27,"context_line":"               default\u003d\u0027ceilometer.alarm.service.SingletonAlarmService\u0027,"},{"line_number":28,"context_line":"               help\u003d\u0027Class to launch as alarm evaluation service.\u0027),"},{"line_number":29,"context_line":"]"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"cfg.CONF.register_opts(OPTS, group\u003d\u0027alarm\u0027)"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"1abeadc6_d77aea75","side":"PARENT","line":29,"in_reply_to":"1abeadc6_00ad029b","updated":"2014-08-29 10:25:44.000000000","message":"Good point, I\u0027ll fix it.","commit_id":"a1669d7746cd0db5f5ef80ba857cd5f2ae2b78ff"}]}