)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10987,"name":"Igor Degtiarov","username":"tovstun","inactive":true},"change_message_id":"80441b8cc40b39c6fa7c9815372396497d078216","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Ilya Tyaptin \u003cityaptin@mirantis.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-08-20 17:31:59 +0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[HBase] Improve speed of unit tests on real HBase backend"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently, unittests at real HBase are not usually used."},{"line_number":10,"context_line":"Jenkins jobs and a predominant amount of developer are uses"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1abeadc6_6f2d0ca8","line":7,"updated":"2014-08-21 10:05:53.000000000","message":"s/Improve/Improves","commit_id":"d6f02bebb3824153b5b081df3750bf02887528ef"},{"author":{"_account_id":7478,"name":"Nadya Shakhat","email":"nadmi4@gmail.com","username":"nprivalova"},"change_message_id":"18319ce9e8f5837bbd3f77e9c57ab5d8366a703f","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[HBase] Improve speed of unit tests on real HBase backend"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently, unittests at real HBase are not usually used."},{"line_number":10,"context_line":"Jenkins jobs and a predominant amount of developer are uses"},{"line_number":11,"context_line":"HBase mock. One of the reasons for this, unittests at real"},{"line_number":12,"context_line":"HBase are too slow. It\u0027s due to processing commands \"disable_table\""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1abeadc6_98063185","line":9,"updated":"2014-08-20 16:08:05.000000000","message":"of developer \u003d\u003e of developers, are uses \u003d\u003e use","commit_id":"d6f02bebb3824153b5b081df3750bf02887528ef"},{"author":{"_account_id":7729,"name":"Ilya Tyaptin","email":"ityaptin@mirantis.com","username":"ityaptin"},"change_message_id":"e8e9b4240ea1bd352bcb7afa450e6561ca93f4f3","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[HBase] Improve speed of unit tests on real HBase backend"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently, unittests at real HBase are not usually used."},{"line_number":10,"context_line":"Jenkins jobs and a predominant amount of developer are uses"},{"line_number":11,"context_line":"HBase mock. One of the reasons for this, unittests at real"},{"line_number":12,"context_line":"HBase are too slow. It\u0027s due to processing commands \"disable_table\""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1abeadc6_0dc3a957","line":9,"in_reply_to":"1abeadc6_98063185","updated":"2014-08-21 08:00:58.000000000","message":"Done","commit_id":"d6f02bebb3824153b5b081df3750bf02887528ef"},{"author":{"_account_id":7478,"name":"Nadya Shakhat","email":"nadmi4@gmail.com","username":"nprivalova"},"change_message_id":"18319ce9e8f5837bbd3f77e9c57ab5d8366a703f","unresolved":false,"context_lines":[{"line_number":7,"context_line":"[HBase] Improve speed of unit tests on real HBase backend"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently, unittests at real HBase are not usually used."},{"line_number":10,"context_line":"Jenkins jobs and a predominant amount of developer are uses"},{"line_number":11,"context_line":"HBase mock. One of the reasons for this, unittests at real"},{"line_number":12,"context_line":"HBase are too slow. It\u0027s due to processing commands \"disable_table\""},{"line_number":13,"context_line":"and \"delete_table\". In HBase these command running can spend time"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1abeadc6_d8334960","line":10,"updated":"2014-08-20 16:08:05.000000000","message":", \u003d\u003e is that","commit_id":"d6f02bebb3824153b5b081df3750bf02887528ef"},{"author":{"_account_id":7729,"name":"Ilya Tyaptin","email":"ityaptin@mirantis.com","username":"ityaptin"},"change_message_id":"e8e9b4240ea1bd352bcb7afa450e6561ca93f4f3","unresolved":false,"context_lines":[{"line_number":7,"context_line":"[HBase] Improve speed of unit tests on real HBase backend"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently, unittests at real HBase are not usually used."},{"line_number":10,"context_line":"Jenkins jobs and a predominant amount of developer are uses"},{"line_number":11,"context_line":"HBase mock. One of the reasons for this, unittests at real"},{"line_number":12,"context_line":"HBase are too slow. It\u0027s due to processing commands \"disable_table\""},{"line_number":13,"context_line":"and \"delete_table\". In HBase these command running can spend time"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1abeadc6_2da305b3","line":10,"in_reply_to":"1abeadc6_d8334960","updated":"2014-08-21 08:00:58.000000000","message":"Done","commit_id":"d6f02bebb3824153b5b081df3750bf02887528ef"},{"author":{"_account_id":7478,"name":"Nadya Shakhat","email":"nadmi4@gmail.com","username":"nprivalova"},"change_message_id":"18319ce9e8f5837bbd3f77e9c57ab5d8366a703f","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Currently, unittests at real HBase are not usually used."},{"line_number":10,"context_line":"Jenkins jobs and a predominant amount of developer are uses"},{"line_number":11,"context_line":"HBase mock. One of the reasons for this, unittests at real"},{"line_number":12,"context_line":"HBase are too slow. It\u0027s due to processing commands \"disable_table\""},{"line_number":13,"context_line":"and \"delete_table\". In HBase these command running can spend time"},{"line_number":14,"context_line":"to 1-2 seconds and for separation data of different tests for every test"},{"line_number":15,"context_line":"instance are created and deleted new tables set with unique prefix."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1abeadc6_386c3d35","line":12,"updated":"2014-08-20 16:08:05.000000000","message":"I don\u0027t understand the next sentence :) Please divide it to several ones","commit_id":"d6f02bebb3824153b5b081df3750bf02887528ef"},{"author":{"_account_id":3012,"name":"Dina Belova","email":"dbelova@mirantis.com","username":"dbelova"},"change_message_id":"f37d1f87a1124d7cc535ed827dcc3d3f7dc974f0","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Currently, unittests at real HBase are not usually used."},{"line_number":10,"context_line":"Jenkins jobs and a predominant amount of developer are uses"},{"line_number":11,"context_line":"HBase mock. One of the reasons for this, unittests at real"},{"line_number":12,"context_line":"HBase are too slow. It\u0027s due to processing commands \"disable_table\""},{"line_number":13,"context_line":"and \"delete_table\". In HBase these command running can spend time"},{"line_number":14,"context_line":"to 1-2 seconds and for separation data of different tests for every test"},{"line_number":15,"context_line":"instance are created and deleted new tables set with unique prefix."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1abeadc6_610c26ee","line":12,"range":{"start_line":12,"start_character":29,"end_line":12,"end_character":42},"updated":"2014-08-21 10:13:04.000000000","message":"to processing commands -\u003e to processing of the \"bla\" and \u0027foo\u0027 commands","commit_id":"d6f02bebb3824153b5b081df3750bf02887528ef"},{"author":{"_account_id":3012,"name":"Dina Belova","email":"dbelova@mirantis.com","username":"dbelova"},"change_message_id":"f37d1f87a1124d7cc535ed827dcc3d3f7dc974f0","unresolved":false,"context_lines":[{"line_number":10,"context_line":"Jenkins jobs and a predominant amount of developer are uses"},{"line_number":11,"context_line":"HBase mock. One of the reasons for this, unittests at real"},{"line_number":12,"context_line":"HBase are too slow. It\u0027s due to processing commands \"disable_table\""},{"line_number":13,"context_line":"and \"delete_table\". In HBase these command running can spend time"},{"line_number":14,"context_line":"to 1-2 seconds and for separation data of different tests for every test"},{"line_number":15,"context_line":"instance are created and deleted new tables set with unique prefix."},{"line_number":16,"context_line":"So, at real HBase backend unit tests may be executed several hours."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1abeadc6_81db024e","line":13,"range":{"start_line":13,"start_character":35,"end_line":13,"end_character":42},"updated":"2014-08-21 10:13:04.000000000","message":"commands\nspend time to 1-2 seconds -\u003e be running up to 1-2 seconds\nPlease end sentence here. The next one will start like this:\n\nTo prevent the described situation separation of the data for the different tests was implemented via creation and deletion of new tables with name containing the unique prefix.","commit_id":"d6f02bebb3824153b5b081df3750bf02887528ef"},{"author":{"_account_id":7478,"name":"Nadya Shakhat","email":"nadmi4@gmail.com","username":"nprivalova"},"change_message_id":"18319ce9e8f5837bbd3f77e9c57ab5d8366a703f","unresolved":false,"context_lines":[{"line_number":14,"context_line":"to 1-2 seconds and for separation data of different tests for every test"},{"line_number":15,"context_line":"instance are created and deleted new tables set with unique prefix."},{"line_number":16,"context_line":"So, at real HBase backend unit tests may be executed several hours."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"My CR speeds up this case. It implements using row prefix for"},{"line_number":19,"context_line":"separation tests data and allows to reduce table sets count to 1."},{"line_number":20,"context_line":"So unittests run several minutes instead several hours."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1abeadc6_98c9d128","line":17,"updated":"2014-08-20 16:08:05.000000000","message":"It implements using row prefix \u003d\u003e It uses row prefix (or maybe introduces)","commit_id":"d6f02bebb3824153b5b081df3750bf02887528ef"},{"author":{"_account_id":7729,"name":"Ilya Tyaptin","email":"ityaptin@mirantis.com","username":"ityaptin"},"change_message_id":"e8e9b4240ea1bd352bcb7afa450e6561ca93f4f3","unresolved":false,"context_lines":[{"line_number":14,"context_line":"to 1-2 seconds and for separation data of different tests for every test"},{"line_number":15,"context_line":"instance are created and deleted new tables set with unique prefix."},{"line_number":16,"context_line":"So, at real HBase backend unit tests may be executed several hours."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"My CR speeds up this case. It implements using row prefix for"},{"line_number":19,"context_line":"separation tests data and allows to reduce table sets count to 1."},{"line_number":20,"context_line":"So unittests run several minutes instead several hours."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1abeadc6_2d8a251b","line":17,"in_reply_to":"1abeadc6_98c9d128","updated":"2014-08-21 08:00:58.000000000","message":"Done","commit_id":"d6f02bebb3824153b5b081df3750bf02887528ef"},{"author":{"_account_id":7478,"name":"Nadya Shakhat","email":"nadmi4@gmail.com","username":"nprivalova"},"change_message_id":"18319ce9e8f5837bbd3f77e9c57ab5d8366a703f","unresolved":false,"context_lines":[{"line_number":15,"context_line":"instance are created and deleted new tables set with unique prefix."},{"line_number":16,"context_line":"So, at real HBase backend unit tests may be executed several hours."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"My CR speeds up this case. It implements using row prefix for"},{"line_number":19,"context_line":"separation tests data and allows to reduce table sets count to 1."},{"line_number":20,"context_line":"So unittests run several minutes instead several hours."},{"line_number":21,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1abeadc6_98f0f168","line":18,"updated":"2014-08-20 16:08:05.000000000","message":"table sets counts? What is this?","commit_id":"d6f02bebb3824153b5b081df3750bf02887528ef"},{"author":{"_account_id":7729,"name":"Ilya Tyaptin","email":"ityaptin@mirantis.com","username":"ityaptin"},"change_message_id":"736f17f2c06cae2a08847e9961a38a3d7d961a53","unresolved":false,"context_lines":[{"line_number":15,"context_line":"instance are created and deleted new tables set with unique prefix."},{"line_number":16,"context_line":"So, at real HBase backend unit tests may be executed several hours."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"My CR speeds up this case. It implements using row prefix for"},{"line_number":19,"context_line":"separation tests data and allows to reduce table sets count to 1."},{"line_number":20,"context_line":"So unittests run several minutes instead several hours."},{"line_number":21,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fa98f980_ae605b36","line":18,"in_reply_to":"1abeadc6_98f0f168","updated":"2014-09-01 10:38:39.000000000","message":"All HBase tables for one ceilometer instance. There are \u0027meter\u0027, \u0027resource\u0027, \u0027event\u0027, \u0027alarm\u0027, \u0027alarm_h\u0027 tables.","commit_id":"d6f02bebb3824153b5b081df3750bf02887528ef"},{"author":{"_account_id":7478,"name":"Nadya Shakhat","email":"nadmi4@gmail.com","username":"nprivalova"},"change_message_id":"18319ce9e8f5837bbd3f77e9c57ab5d8366a703f","unresolved":false,"context_lines":[{"line_number":18,"context_line":"My CR speeds up this case. It implements using row prefix for"},{"line_number":19,"context_line":"separation tests data and allows to reduce table sets count to 1."},{"line_number":20,"context_line":"So unittests run several minutes instead several hours."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Creating and deleting required table happens at setup-test-env.sh."},{"line_number":23,"context_line":"Separating data is implemented with mock.patchs which are transform"},{"line_number":24,"context_line":"row value in happybase.Table methods."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1abeadc6_d86b49ef","line":21,"updated":"2014-08-20 16:08:05.000000000","message":"Table creation and deleting are moved (?) to setup-test-env.sh.","commit_id":"d6f02bebb3824153b5b081df3750bf02887528ef"},{"author":{"_account_id":7729,"name":"Ilya Tyaptin","email":"ityaptin@mirantis.com","username":"ityaptin"},"change_message_id":"e8e9b4240ea1bd352bcb7afa450e6561ca93f4f3","unresolved":false,"context_lines":[{"line_number":18,"context_line":"My CR speeds up this case. It implements using row prefix for"},{"line_number":19,"context_line":"separation tests data and allows to reduce table sets count to 1."},{"line_number":20,"context_line":"So unittests run several minutes instead several hours."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Creating and deleting required table happens at setup-test-env.sh."},{"line_number":23,"context_line":"Separating data is implemented with mock.patchs which are transform"},{"line_number":24,"context_line":"row value in happybase.Table methods."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1abeadc6_4d8f612a","line":21,"in_reply_to":"1abeadc6_d86b49ef","updated":"2014-08-21 08:00:58.000000000","message":"Done","commit_id":"d6f02bebb3824153b5b081df3750bf02887528ef"},{"author":{"_account_id":7478,"name":"Nadya Shakhat","email":"nadmi4@gmail.com","username":"nprivalova"},"change_message_id":"18319ce9e8f5837bbd3f77e9c57ab5d8366a703f","unresolved":false,"context_lines":[{"line_number":19,"context_line":"separation tests data and allows to reduce table sets count to 1."},{"line_number":20,"context_line":"So unittests run several minutes instead several hours."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Creating and deleting required table happens at setup-test-env.sh."},{"line_number":23,"context_line":"Separating data is implemented with mock.patchs which are transform"},{"line_number":24,"context_line":"row value in happybase.Table methods."},{"line_number":25,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1abeadc6_5856592b","line":22,"updated":"2014-08-20 16:08:05.000000000","message":"which are transform \u003d\u003e which transforms","commit_id":"d6f02bebb3824153b5b081df3750bf02887528ef"},{"author":{"_account_id":7729,"name":"Ilya Tyaptin","email":"ityaptin@mirantis.com","username":"ityaptin"},"change_message_id":"e8e9b4240ea1bd352bcb7afa450e6561ca93f4f3","unresolved":false,"context_lines":[{"line_number":19,"context_line":"separation tests data and allows to reduce table sets count to 1."},{"line_number":20,"context_line":"So unittests run several minutes instead several hours."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Creating and deleting required table happens at setup-test-env.sh."},{"line_number":23,"context_line":"Separating data is implemented with mock.patchs which are transform"},{"line_number":24,"context_line":"row value in happybase.Table methods."},{"line_number":25,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1abeadc6_6d809df7","line":22,"in_reply_to":"1abeadc6_5856592b","updated":"2014-08-21 08:00:58.000000000","message":"Done","commit_id":"d6f02bebb3824153b5b081df3750bf02887528ef"},{"author":{"_account_id":7478,"name":"Nadya Shakhat","email":"nadmi4@gmail.com","username":"nprivalova"},"change_message_id":"4bb9e191ce8dc479feebd5c71bd78b4a754a12ee","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[HBase] Improves speed of unit tests on real HBase backend"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently, unittests at real HBase are not usually used."},{"line_number":10,"context_line":"Jenkins jobs and a predominant amount of developers are use"},{"line_number":11,"context_line":"HBase mock. One of the reasons for this is that unittests at real"},{"line_number":12,"context_line":"HBase are too slow. It\u0027s due to processing of \"disable_table\""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"fa98f980_9c6c3437","line":9,"updated":"2014-09-03 15:58:49.000000000","message":"are use \u003d\u003e use","commit_id":"58a56f48432d4fc8b9eeed42187c6a4905ca4b12"},{"author":{"_account_id":7729,"name":"Ilya Tyaptin","email":"ityaptin@mirantis.com","username":"ityaptin"},"change_message_id":"1bf3bd6f14a5818d50fd49e645e4abce6de7999b","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[HBase] Improves speed of unit tests on real HBase backend"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently, unittests at real HBase are not usually used."},{"line_number":10,"context_line":"Jenkins jobs and a predominant amount of developers are use"},{"line_number":11,"context_line":"HBase mock. One of the reasons for this is that unittests at real"},{"line_number":12,"context_line":"HBase are too slow. It\u0027s due to processing of \"disable_table\""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"fa98f980_fd37b4e0","line":9,"in_reply_to":"fa98f980_9c6c3437","updated":"2014-09-05 12:33:51.000000000","message":"Done","commit_id":"58a56f48432d4fc8b9eeed42187c6a4905ca4b12"},{"author":{"_account_id":7478,"name":"Nadya Shakhat","email":"nadmi4@gmail.com","username":"nprivalova"},"change_message_id":"4bb9e191ce8dc479feebd5c71bd78b4a754a12ee","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Currently, unittests at real HBase are not usually used."},{"line_number":10,"context_line":"Jenkins jobs and a predominant amount of developers are use"},{"line_number":11,"context_line":"HBase mock. One of the reasons for this is that unittests at real"},{"line_number":12,"context_line":"HBase are too slow. It\u0027s due to processing of \"disable_table\""},{"line_number":13,"context_line":"and \"delete_table\" commands. In HBase these command spend time"},{"line_number":14,"context_line":"to 1-2 seconds. To prevent the intersection of data "},{"line_number":15,"context_line":"for the different tests was implemented via creation and deletion of "}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"fa98f980_bc4c98c9","line":12,"updated":"2014-09-03 15:58:49.000000000","message":"spend time to \u003d\u003e take up to","commit_id":"58a56f48432d4fc8b9eeed42187c6a4905ca4b12"},{"author":{"_account_id":7729,"name":"Ilya Tyaptin","email":"ityaptin@mirantis.com","username":"ityaptin"},"change_message_id":"1bf3bd6f14a5818d50fd49e645e4abce6de7999b","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Currently, unittests at real HBase are not usually used."},{"line_number":10,"context_line":"Jenkins jobs and a predominant amount of developers are use"},{"line_number":11,"context_line":"HBase mock. One of the reasons for this is that unittests at real"},{"line_number":12,"context_line":"HBase are too slow. It\u0027s due to processing of \"disable_table\""},{"line_number":13,"context_line":"and \"delete_table\" commands. In HBase these command spend time"},{"line_number":14,"context_line":"to 1-2 seconds. To prevent the intersection of data "},{"line_number":15,"context_line":"for the different tests was implemented via creation and deletion of "}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"fa98f980_1d3398f6","line":12,"in_reply_to":"fa98f980_bc4c98c9","updated":"2014-09-05 12:33:51.000000000","message":"Done","commit_id":"58a56f48432d4fc8b9eeed42187c6a4905ca4b12"},{"author":{"_account_id":7478,"name":"Nadya Shakhat","email":"nadmi4@gmail.com","username":"nprivalova"},"change_message_id":"4bb9e191ce8dc479feebd5c71bd78b4a754a12ee","unresolved":false,"context_lines":[{"line_number":10,"context_line":"Jenkins jobs and a predominant amount of developers are use"},{"line_number":11,"context_line":"HBase mock. One of the reasons for this is that unittests at real"},{"line_number":12,"context_line":"HBase are too slow. It\u0027s due to processing of \"disable_table\""},{"line_number":13,"context_line":"and \"delete_table\" commands. In HBase these command spend time"},{"line_number":14,"context_line":"to 1-2 seconds. To prevent the intersection of data "},{"line_number":15,"context_line":"for the different tests was implemented via creation and deletion of "},{"line_number":16,"context_line":"new tables with name containing the unique prefix."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"fa98f980_5c3f2cd6","line":13,"updated":"2014-09-03 15:58:49.000000000","message":"To prevent the intersection of data for the different tests was implemented via creation and deletion of new tables with name containing the unique prefix. \u003d\u003e Now we create all table-set for each test that\u0027s why at real HBase unit tests may be executed several hours","commit_id":"58a56f48432d4fc8b9eeed42187c6a4905ca4b12"},{"author":{"_account_id":7729,"name":"Ilya Tyaptin","email":"ityaptin@mirantis.com","username":"ityaptin"},"change_message_id":"1bf3bd6f14a5818d50fd49e645e4abce6de7999b","unresolved":false,"context_lines":[{"line_number":10,"context_line":"Jenkins jobs and a predominant amount of developers are use"},{"line_number":11,"context_line":"HBase mock. One of the reasons for this is that unittests at real"},{"line_number":12,"context_line":"HBase are too slow. It\u0027s due to processing of \"disable_table\""},{"line_number":13,"context_line":"and \"delete_table\" commands. In HBase these command spend time"},{"line_number":14,"context_line":"to 1-2 seconds. To prevent the intersection of data "},{"line_number":15,"context_line":"for the different tests was implemented via creation and deletion of "},{"line_number":16,"context_line":"new tables with name containing the unique prefix."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"fa98f980_3d2e9c8c","line":13,"in_reply_to":"fa98f980_5c3f2cd6","updated":"2014-09-05 12:33:51.000000000","message":"Done","commit_id":"58a56f48432d4fc8b9eeed42187c6a4905ca4b12"},{"author":{"_account_id":7478,"name":"Nadya Shakhat","email":"nadmi4@gmail.com","username":"nprivalova"},"change_message_id":"4bb9e191ce8dc479feebd5c71bd78b4a754a12ee","unresolved":false,"context_lines":[{"line_number":15,"context_line":"for the different tests was implemented via creation and deletion of "},{"line_number":16,"context_line":"new tables with name containing the unique prefix."},{"line_number":17,"context_line":"So, at real HBase backend unit tests may be executed several hours."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"My CR speeds up this case. It uses row prefix for "},{"line_number":20,"context_line":"separation tests data and allows to reduce table sets count to 1."},{"line_number":21,"context_line":"So unittests run several minutes instead several hours."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"fa98f980_1e8bd968","line":18,"updated":"2014-09-03 15:58:49.000000000","message":"To solve this problem it was decided to keep all test data in one table. To provide a distinguishability of data from different tests unique row-prefix is used for each one.","commit_id":"58a56f48432d4fc8b9eeed42187c6a4905ca4b12"},{"author":{"_account_id":7729,"name":"Ilya Tyaptin","email":"ityaptin@mirantis.com","username":"ityaptin"},"change_message_id":"1bf3bd6f14a5818d50fd49e645e4abce6de7999b","unresolved":false,"context_lines":[{"line_number":15,"context_line":"for the different tests was implemented via creation and deletion of "},{"line_number":16,"context_line":"new tables with name containing the unique prefix."},{"line_number":17,"context_line":"So, at real HBase backend unit tests may be executed several hours."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"My CR speeds up this case. It uses row prefix for "},{"line_number":20,"context_line":"separation tests data and allows to reduce table sets count to 1."},{"line_number":21,"context_line":"So unittests run several minutes instead several hours."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"fa98f980_9d56a804","line":18,"in_reply_to":"fa98f980_1e8bd968","updated":"2014-09-05 12:33:51.000000000","message":"Done","commit_id":"58a56f48432d4fc8b9eeed42187c6a4905ca4b12"},{"author":{"_account_id":3012,"name":"Dina Belova","email":"dbelova@mirantis.com","username":"dbelova"},"change_message_id":"dafa95d2eb03a2457948730ff907143c86945e40","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[HBase] Improves speed of unit tests on real HBase backend"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently, unittests at real HBase are not usually use."},{"line_number":10,"context_line":"Jenkins jobs and a predominant amount of developers are use"},{"line_number":11,"context_line":"HBase mock. One of the reasons for this is that unittests at real"},{"line_number":12,"context_line":"HBase are too slow. It\u0027s due to processing of \"disable_table\""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"fa98f980_dd871ed6","line":9,"range":{"start_line":9,"start_character":51,"end_line":9,"end_character":54},"updated":"2014-09-08 10:34:02.000000000","message":"used\n\nNadya meant not this line, but 10th one","commit_id":"341ae81242bada723d828b2833529d0248af73c6"},{"author":{"_account_id":3012,"name":"Dina Belova","email":"dbelova@mirantis.com","username":"dbelova"},"change_message_id":"dafa95d2eb03a2457948730ff907143c86945e40","unresolved":false,"context_lines":[{"line_number":7,"context_line":"[HBase] Improves speed of unit tests on real HBase backend"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently, unittests at real HBase are not usually use."},{"line_number":10,"context_line":"Jenkins jobs and a predominant amount of developers are use"},{"line_number":11,"context_line":"HBase mock. One of the reasons for this is that unittests at real"},{"line_number":12,"context_line":"HBase are too slow. It\u0027s due to processing of \"disable_table\""},{"line_number":13,"context_line":"and \"delete_table\" commands. In HBase these command take up"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"fa98f980_fd6b021d","line":10,"range":{"start_line":10,"start_character":52,"end_line":10,"end_character":55},"updated":"2014-09-08 10:34:02.000000000","message":"remove \u0027are\u0027","commit_id":"341ae81242bada723d828b2833529d0248af73c6"}],"ceilometer/tests/db.py":[{"author":{"_account_id":10987,"name":"Igor Degtiarov","username":"tovstun","inactive":true},"change_message_id":"796c8be9446da6c26d8e3d9e10fe832c5d74991b","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"\"\"\"Base classes for API tests.\"\"\""},{"line_number":21,"context_line":"import fixtures"},{"line_number":22,"context_line":"import mock"},{"line_number":23,"context_line":"import os"},{"line_number":24,"context_line":"import uuid"},{"line_number":25,"context_line":"import warnings"}],"source_content_type":"text/x-python","patch_set":1,"id":"1abeadc6_f0585458","line":22,"updated":"2014-08-19 15:33:23.000000000","message":"\"mock\" should be in third-part of import blocks. we have it in requirements.txt","commit_id":"9f7b18fd5164ae8863f70ff8d1a9705f964a3406"},{"author":{"_account_id":10987,"name":"Igor Degtiarov","username":"tovstun","inactive":true},"change_message_id":"796c8be9446da6c26d8e3d9e10fe832c5d74991b","unresolved":false,"context_lines":[{"line_number":49,"context_line":"            \"%s_%s\" % (prefix, name),"},{"line_number":50,"context_line":"            connection)"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    def put(self, row, data, timestamp\u003dNone, wal\u003dTrue):"},{"line_number":53,"context_line":"        row \u003d self.data_prefix + row"},{"line_number":54,"context_line":"        return super(MockHBaseTable, self).put(row, data,"},{"line_number":55,"context_line":"                                               timestamp, wal)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1abeadc6_214b6088","line":52,"updated":"2014-08-19 15:33:23.000000000","message":"Could you clarify and probably add a description for param: wal?","commit_id":"9f7b18fd5164ae8863f70ff8d1a9705f964a3406"},{"author":{"_account_id":10987,"name":"Igor Degtiarov","username":"tovstun","inactive":true},"change_message_id":"796c8be9446da6c26d8e3d9e10fe832c5d74991b","unresolved":false,"context_lines":[{"line_number":66,"context_line":"        if row_prefix:"},{"line_number":67,"context_line":"            row_prefix \u003d self.data_prefix + row_prefix"},{"line_number":68,"context_line":"        if filter:"},{"line_number":69,"context_line":"            filter \u003d \"PrefixFilter(\u0027%s\u0027) AND %s\" % (self.data_prefix, filter)"},{"line_number":70,"context_line":"        else:"},{"line_number":71,"context_line":"            filter \u003d \"PrefixFilter(\u0027%s\u0027)\" % self.data_prefix"},{"line_number":72,"context_line":"        gen \u003d super(MockHBaseTable, self).scan(row_start, row_stop,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1abeadc6_9cc49793","line":69,"updated":"2014-08-19 15:33:23.000000000","message":"Do we really need to add \"PrefixFilter\" for all queries. For ex. if we have only \"SingleColumnValueFilter\" why do we need to add PrefixFilter?","commit_id":"9f7b18fd5164ae8863f70ff8d1a9705f964a3406"},{"author":{"_account_id":10987,"name":"Igor Degtiarov","username":"tovstun","inactive":true},"change_message_id":"796c8be9446da6c26d8e3d9e10fe832c5d74991b","unresolved":false,"context_lines":[{"line_number":134,"context_line":"        # separate test data"},{"line_number":135,"context_line":"        data_prefix \u003d str(uuid.uuid4().hex)"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"        def table(self, name, ignored\u003dFalse):"},{"line_number":138,"context_line":"            return MockHBaseTable(name, self, data_prefix)"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"        # Mock only real HBase connection, MConnection \"table\" method"}],"source_content_type":"text/x-python","patch_set":1,"id":"1abeadc6_6759e8fd","line":137,"updated":"2014-08-19 15:33:23.000000000","message":"I will appreciate if you use one more param in table function as:\ndef table(self, name, data_prefix\u003ddata_prefix, ignored\u003dFalse):\n\nand won\u0027t use parameter data_prefix inside function as global. \n\nAnd may be it would be good to have an explanation about param: ignored, because it seems that it isn\u0027t used in the function.","commit_id":"9f7b18fd5164ae8863f70ff8d1a9705f964a3406"},{"author":{"_account_id":7478,"name":"Nadya Shakhat","email":"nadmi4@gmail.com","username":"nprivalova"},"change_message_id":"18319ce9e8f5837bbd3f77e9c57ab5d8366a703f","unresolved":false,"context_lines":[{"line_number":35,"context_line":"from ceilometer import storage"},{"line_number":36,"context_line":"from ceilometer.tests import base as test_base"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"class MockHBaseTable(happybase.Table):"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    def __init__(self, name, connection, data_prefix):"}],"source_content_type":"text/x-python","patch_set":2,"id":"1abeadc6_2c9882bf","line":38,"updated":"2014-08-20 16:08:05.000000000","message":"Ilya, am I right that production table and test-table will look different? In test case we use one table, right?","commit_id":"d6f02bebb3824153b5b081df3750bf02887528ef"},{"author":{"_account_id":7729,"name":"Ilya Tyaptin","email":"ityaptin@mirantis.com","username":"ityaptin"},"change_message_id":"e8e9b4240ea1bd352bcb7afa450e6561ca93f4f3","unresolved":false,"context_lines":[{"line_number":35,"context_line":"from ceilometer import storage"},{"line_number":36,"context_line":"from ceilometer.tests import base as test_base"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"class MockHBaseTable(happybase.Table):"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    def __init__(self, name, connection, data_prefix):"}],"source_content_type":"text/x-python","patch_set":2,"id":"1abeadc6_edc58d5c","line":38,"in_reply_to":"1abeadc6_2c9882bf","updated":"2014-08-21 08:00:58.000000000","message":"Nadya, in tests we use one table set for all tests: one test \u0027meter\u0027 table, one \u0027resource\u0027 table and etc. And data is separated with row prefix, not table prefix.","commit_id":"d6f02bebb3824153b5b081df3750bf02887528ef"},{"author":{"_account_id":10987,"name":"Igor Degtiarov","username":"tovstun","inactive":true},"change_message_id":"80441b8cc40b39c6fa7c9815372396497d078216","unresolved":false,"context_lines":[{"line_number":59,"context_line":"             include_timestamp\u003dFalse, batch_size\u003d10, scan_batching\u003dNone,"},{"line_number":60,"context_line":"             limit\u003dNone, sorted_columns\u003dFalse):"},{"line_number":61,"context_line":"        # Add data prefix for all rows"},{"line_number":62,"context_line":"        if not row_start and not row_stop:"},{"line_number":63,"context_line":"            row_prefix \u003d self.data_prefix + (row_prefix or \"\")"},{"line_number":64,"context_line":"            row_start \u003d None"},{"line_number":65,"context_line":"            row_stop \u003d None"}],"source_content_type":"text/x-python","patch_set":2,"id":"1abeadc6_2146ae4f","line":62,"updated":"2014-08-21 10:05:53.000000000","message":"Why do we need this \"if\" condition, if we can just specify row_prefix param and use modified row_start and row_stop in the way you have done in Lines 67-68?","commit_id":"d6f02bebb3824153b5b081df3750bf02887528ef"},{"author":{"_account_id":7729,"name":"Ilya Tyaptin","email":"ityaptin@mirantis.com","username":"ityaptin"},"change_message_id":"e7af758ea41257fd744d6d35e55db5360bcd7ada","unresolved":false,"context_lines":[{"line_number":59,"context_line":"             include_timestamp\u003dFalse, batch_size\u003d10, scan_batching\u003dNone,"},{"line_number":60,"context_line":"             limit\u003dNone, sorted_columns\u003dFalse):"},{"line_number":61,"context_line":"        # Add data prefix for all rows"},{"line_number":62,"context_line":"        if not row_start and not row_stop:"},{"line_number":63,"context_line":"            row_prefix \u003d self.data_prefix + (row_prefix or \"\")"},{"line_number":64,"context_line":"            row_start \u003d None"},{"line_number":65,"context_line":"            row_stop \u003d None"}],"source_content_type":"text/x-python","patch_set":2,"id":"1abeadc6_e67be7bb","line":62,"in_reply_to":"1abeadc6_2146ae4f","updated":"2014-08-21 12:11:48.000000000","message":"Igor, \u0027row_prefix\u0027 cannot be combined with \u0027row_start\u0027 or \u0027row_stop\u0027. https://github.com/wbolster/happybase/blob/master/happybase/table.py#L307","commit_id":"d6f02bebb3824153b5b081df3750bf02887528ef"},{"author":{"_account_id":10987,"name":"Igor Degtiarov","username":"tovstun","inactive":true},"change_message_id":"83a3e68cb2fb9d8baedb83a8f5614bc611996c0e","unresolved":false,"context_lines":[{"line_number":59,"context_line":"             include_timestamp\u003dFalse, batch_size\u003d10, scan_batching\u003dNone,"},{"line_number":60,"context_line":"             limit\u003dNone, sorted_columns\u003dFalse):"},{"line_number":61,"context_line":"        # Add data prefix for all rows"},{"line_number":62,"context_line":"        if not row_start and not row_stop:"},{"line_number":63,"context_line":"            row_prefix \u003d self.data_prefix + (row_prefix or \"\")"},{"line_number":64,"context_line":"            row_start \u003d None"},{"line_number":65,"context_line":"            row_stop \u003d None"}],"source_content_type":"text/x-python","patch_set":2,"id":"1abeadc6_df15c549","line":62,"in_reply_to":"1abeadc6_e67be7bb","updated":"2014-08-21 15:34:46.000000000","message":"Thanks I got it.","commit_id":"d6f02bebb3824153b5b081df3750bf02887528ef"},{"author":{"_account_id":10987,"name":"Igor Degtiarov","username":"tovstun","inactive":true},"change_message_id":"80441b8cc40b39c6fa7c9815372396497d078216","unresolved":false,"context_lines":[{"line_number":76,"context_line":"        # If returned row are used in impl_hbase we should to restore row"},{"line_number":77,"context_line":"        # format"},{"line_number":78,"context_line":"        for row, data in gen:"},{"line_number":79,"context_line":"            yield (row[data_prefix_len:], data)"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    def row(self, row, columns\u003dNone, timestamp\u003dNone,"},{"line_number":82,"context_line":"            include_timestamp\u003dFalse):"}],"source_content_type":"text/x-python","patch_set":2,"id":"1abeadc6_c1697abf","line":79,"updated":"2014-08-21 10:05:53.000000000","message":"Just a nit. Parentheses are not really needed here.","commit_id":"d6f02bebb3824153b5b081df3750bf02887528ef"},{"author":{"_account_id":7729,"name":"Ilya Tyaptin","email":"ityaptin@mirantis.com","username":"ityaptin"},"change_message_id":"e7af758ea41257fd744d6d35e55db5360bcd7ada","unresolved":false,"context_lines":[{"line_number":76,"context_line":"        # If returned row are used in impl_hbase we should to restore row"},{"line_number":77,"context_line":"        # format"},{"line_number":78,"context_line":"        for row, data in gen:"},{"line_number":79,"context_line":"            yield (row[data_prefix_len:], data)"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    def row(self, row, columns\u003dNone, timestamp\u003dNone,"},{"line_number":82,"context_line":"            include_timestamp\u003dFalse):"}],"source_content_type":"text/x-python","patch_set":2,"id":"1abeadc6_865f9340","line":79,"in_reply_to":"1abeadc6_c1697abf","updated":"2014-08-21 12:11:48.000000000","message":"Done","commit_id":"d6f02bebb3824153b5b081df3750bf02887528ef"},{"author":{"_account_id":7478,"name":"Nadya Shakhat","email":"nadmi4@gmail.com","username":"nprivalova"},"change_message_id":"4bb9e191ce8dc479feebd5c71bd78b4a754a12ee","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"class MockHBaseTable(happybase.Table):"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    def __init__(self, name, connection, data_prefix):"},{"line_number":42,"context_line":"        # data_prefix are added to all rows which are written"},{"line_number":43,"context_line":"        # in this test. It allows to separate data from different tests"},{"line_number":44,"context_line":"        self.data_prefix \u003d data_prefix"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa98f980_5c72ccad","line":41,"updated":"2014-09-03 15:58:49.000000000","message":"are added \u003d\u003e is added. And I think that \"divide\" is better then \"separate\" here. Ask someone else about it:)","commit_id":"58a56f48432d4fc8b9eeed42187c6a4905ca4b12"},{"author":{"_account_id":7729,"name":"Ilya Tyaptin","email":"ityaptin@mirantis.com","username":"ityaptin"},"change_message_id":"1bf3bd6f14a5818d50fd49e645e4abce6de7999b","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"class MockHBaseTable(happybase.Table):"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    def __init__(self, name, connection, data_prefix):"},{"line_number":42,"context_line":"        # data_prefix are added to all rows which are written"},{"line_number":43,"context_line":"        # in this test. It allows to separate data from different tests"},{"line_number":44,"context_line":"        self.data_prefix \u003d data_prefix"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa98f980_bd59ac36","line":41,"in_reply_to":"fa98f980_5c72ccad","updated":"2014-09-05 12:33:51.000000000","message":"Done","commit_id":"58a56f48432d4fc8b9eeed42187c6a4905ca4b12"},{"author":{"_account_id":7478,"name":"Nadya Shakhat","email":"nadmi4@gmail.com","username":"nprivalova"},"change_message_id":"4bb9e191ce8dc479feebd5c71bd78b4a754a12ee","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        # in this test. It allows to separate data from different tests"},{"line_number":44,"context_line":"        self.data_prefix \u003d data_prefix"},{"line_number":45,"context_line":"        # We create happybase Table with prefix from"},{"line_number":46,"context_line":"        # CEILOMETER_TEST_HBASE_TABLE_PREFIX"},{"line_number":47,"context_line":"        prefix \u003d os.getenv(\"CEILOMETER_TEST_HBASE_TABLE_PREFIX\", \u0027test\u0027)"},{"line_number":48,"context_line":"        super(MockHBaseTable, self).__init__("},{"line_number":49,"context_line":"            \"%s_%s\" % (prefix, name),"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa98f980_81792bca","line":46,"updated":"2014-09-03 15:58:49.000000000","message":"Could you please add info about CEILOMETER_TEST_HBASE_TABLE_PREFIX in docs?","commit_id":"58a56f48432d4fc8b9eeed42187c6a4905ca4b12"},{"author":{"_account_id":7729,"name":"Ilya Tyaptin","email":"ityaptin@mirantis.com","username":"ityaptin"},"change_message_id":"1bf3bd6f14a5818d50fd49e645e4abce6de7999b","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        # in this test. It allows to separate data from different tests"},{"line_number":44,"context_line":"        self.data_prefix \u003d data_prefix"},{"line_number":45,"context_line":"        # We create happybase Table with prefix from"},{"line_number":46,"context_line":"        # CEILOMETER_TEST_HBASE_TABLE_PREFIX"},{"line_number":47,"context_line":"        prefix \u003d os.getenv(\"CEILOMETER_TEST_HBASE_TABLE_PREFIX\", \u0027test\u0027)"},{"line_number":48,"context_line":"        super(MockHBaseTable, self).__init__("},{"line_number":49,"context_line":"            \"%s_%s\" % (prefix, name),"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa98f980_dd43d03f","line":46,"in_reply_to":"fa98f980_81792bca","updated":"2014-09-05 12:33:51.000000000","message":"Done","commit_id":"58a56f48432d4fc8b9eeed42187c6a4905ca4b12"},{"author":{"_account_id":7478,"name":"Nadya Shakhat","email":"nadmi4@gmail.com","username":"nprivalova"},"change_message_id":"4bb9e191ce8dc479feebd5c71bd78b4a754a12ee","unresolved":false,"context_lines":[{"line_number":72,"context_line":"                                               include_timestamp, batch_size,"},{"line_number":73,"context_line":"                                               scan_batching, limit,"},{"line_number":74,"context_line":"                                               sorted_columns)"},{"line_number":75,"context_line":"        data_prefix_len \u003d len(self.data_prefix)"},{"line_number":76,"context_line":"        # If returned row are used in impl_hbase we should to restore row"},{"line_number":77,"context_line":"        # format"},{"line_number":78,"context_line":"        for row, data in gen:"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa98f980_bce57839","line":75,"updated":"2014-09-03 15:58:49.000000000","message":"are used \u003d\u003e is used, should to restore \u003d\u003e should restore. And what does it mean \"row is used in impl_hbase\"? Maybe just \"restore original row format\"?","commit_id":"58a56f48432d4fc8b9eeed42187c6a4905ca4b12"},{"author":{"_account_id":7729,"name":"Ilya Tyaptin","email":"ityaptin@mirantis.com","username":"ityaptin"},"change_message_id":"1bf3bd6f14a5818d50fd49e645e4abce6de7999b","unresolved":false,"context_lines":[{"line_number":72,"context_line":"                                               include_timestamp, batch_size,"},{"line_number":73,"context_line":"                                               scan_batching, limit,"},{"line_number":74,"context_line":"                                               sorted_columns)"},{"line_number":75,"context_line":"        data_prefix_len \u003d len(self.data_prefix)"},{"line_number":76,"context_line":"        # If returned row are used in impl_hbase we should to restore row"},{"line_number":77,"context_line":"        # format"},{"line_number":78,"context_line":"        for row, data in gen:"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa98f980_5d77e09f","line":75,"in_reply_to":"fa98f980_bce57839","updated":"2014-09-05 12:33:51.000000000","message":"Done","commit_id":"58a56f48432d4fc8b9eeed42187c6a4905ca4b12"},{"author":{"_account_id":7478,"name":"Nadya Shakhat","email":"nadmi4@gmail.com","username":"nprivalova"},"change_message_id":"4bb9e191ce8dc479feebd5c71bd78b4a754a12ee","unresolved":false,"context_lines":[{"line_number":126,"context_line":"        self.connection \u003d storage.get_connection("},{"line_number":127,"context_line":"            self.url, \u0027ceilometer.metering.storage\u0027)"},{"line_number":128,"context_line":"        self.alarm_connection \u003d storage.get_connection("},{"line_number":129,"context_line":"            self.url, \u0027ceilometer.alarm.storage\u0027)"},{"line_number":130,"context_line":"        # Unique for current test prefix which uses in HBase rows for"},{"line_number":131,"context_line":"        # separate test data"},{"line_number":132,"context_line":"        data_prefix \u003d str(uuid.uuid4().hex)"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa98f980_7c223053","line":129,"updated":"2014-09-03 15:58:49.000000000","message":"my suggestion:\nUnique prefix for each test to keep data distinguished because all test data is stored in one table","commit_id":"58a56f48432d4fc8b9eeed42187c6a4905ca4b12"},{"author":{"_account_id":7729,"name":"Ilya Tyaptin","email":"ityaptin@mirantis.com","username":"ityaptin"},"change_message_id":"1bf3bd6f14a5818d50fd49e645e4abce6de7999b","unresolved":false,"context_lines":[{"line_number":126,"context_line":"        self.connection \u003d storage.get_connection("},{"line_number":127,"context_line":"            self.url, \u0027ceilometer.metering.storage\u0027)"},{"line_number":128,"context_line":"        self.alarm_connection \u003d storage.get_connection("},{"line_number":129,"context_line":"            self.url, \u0027ceilometer.alarm.storage\u0027)"},{"line_number":130,"context_line":"        # Unique for current test prefix which uses in HBase rows for"},{"line_number":131,"context_line":"        # separate test data"},{"line_number":132,"context_line":"        data_prefix \u003d str(uuid.uuid4().hex)"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa98f980_7d7ae488","line":129,"in_reply_to":"fa98f980_7c223053","updated":"2014-09-05 12:33:51.000000000","message":"Done","commit_id":"58a56f48432d4fc8b9eeed42187c6a4905ca4b12"},{"author":{"_account_id":7478,"name":"Nadya Shakhat","email":"nadmi4@gmail.com","username":"nprivalova"},"change_message_id":"4bb9e191ce8dc479feebd5c71bd78b4a754a12ee","unresolved":false,"context_lines":[{"line_number":134,"context_line":"        def table(self, name):"},{"line_number":135,"context_line":"            return MockHBaseTable(name, self, data_prefix)"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"        # Mock only real HBase connection, MConnection \"table\" method"},{"line_number":138,"context_line":"        # stay origin. So tests with HBase mock work correct."},{"line_number":139,"context_line":"        mock.patch(\u0027happybase.Connection.table\u0027, new\u003dtable).start()"},{"line_number":140,"context_line":"        # We shouldn\u0027t delete data and tables of previous tests,"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa98f980_9c943444","line":137,"updated":"2014-09-03 15:58:49.000000000","message":"it would be sad if they work incorrect ;)","commit_id":"58a56f48432d4fc8b9eeed42187c6a4905ca4b12"},{"author":{"_account_id":7729,"name":"Ilya Tyaptin","email":"ityaptin@mirantis.com","username":"ityaptin"},"change_message_id":"1bf3bd6f14a5818d50fd49e645e4abce6de7999b","unresolved":false,"context_lines":[{"line_number":134,"context_line":"        def table(self, name):"},{"line_number":135,"context_line":"            return MockHBaseTable(name, self, data_prefix)"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"        # Mock only real HBase connection, MConnection \"table\" method"},{"line_number":138,"context_line":"        # stay origin. So tests with HBase mock work correct."},{"line_number":139,"context_line":"        mock.patch(\u0027happybase.Connection.table\u0027, new\u003dtable).start()"},{"line_number":140,"context_line":"        # We shouldn\u0027t delete data and tables of previous tests,"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa98f980_9d6dc8ce","line":137,"in_reply_to":"fa98f980_9c943444","updated":"2014-09-05 12:33:51.000000000","message":"Done","commit_id":"58a56f48432d4fc8b9eeed42187c6a4905ca4b12"},{"author":{"_account_id":7478,"name":"Nadya Shakhat","email":"nadmi4@gmail.com","username":"nprivalova"},"change_message_id":"4bb9e191ce8dc479feebd5c71bd78b4a754a12ee","unresolved":false,"context_lines":[{"line_number":136,"context_line":""},{"line_number":137,"context_line":"        # Mock only real HBase connection, MConnection \"table\" method"},{"line_number":138,"context_line":"        # stay origin. So tests with HBase mock work correct."},{"line_number":139,"context_line":"        mock.patch(\u0027happybase.Connection.table\u0027, new\u003dtable).start()"},{"line_number":140,"context_line":"        # We shouldn\u0027t delete data and tables of previous tests,"},{"line_number":141,"context_line":"        # because it too long."},{"line_number":142,"context_line":"        # All tests tables will be delete in setup-test-env.sh"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa98f980_3c98a869","line":139,"updated":"2014-09-03 15:58:49.000000000","message":"of previous test \u003d\u003e after each test","commit_id":"58a56f48432d4fc8b9eeed42187c6a4905ca4b12"},{"author":{"_account_id":7729,"name":"Ilya Tyaptin","email":"ityaptin@mirantis.com","username":"ityaptin"},"change_message_id":"1bf3bd6f14a5818d50fd49e645e4abce6de7999b","unresolved":false,"context_lines":[{"line_number":136,"context_line":""},{"line_number":137,"context_line":"        # Mock only real HBase connection, MConnection \"table\" method"},{"line_number":138,"context_line":"        # stay origin. So tests with HBase mock work correct."},{"line_number":139,"context_line":"        mock.patch(\u0027happybase.Connection.table\u0027, new\u003dtable).start()"},{"line_number":140,"context_line":"        # We shouldn\u0027t delete data and tables of previous tests,"},{"line_number":141,"context_line":"        # because it too long."},{"line_number":142,"context_line":"        # All tests tables will be delete in setup-test-env.sh"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa98f980_bd70cca4","line":139,"in_reply_to":"fa98f980_3c98a869","updated":"2014-09-05 12:33:51.000000000","message":"Done","commit_id":"58a56f48432d4fc8b9eeed42187c6a4905ca4b12"},{"author":{"_account_id":7478,"name":"Nadya Shakhat","email":"nadmi4@gmail.com","username":"nprivalova"},"change_message_id":"4bb9e191ce8dc479feebd5c71bd78b4a754a12ee","unresolved":false,"context_lines":[{"line_number":138,"context_line":"        # stay origin. So tests with HBase mock work correct."},{"line_number":139,"context_line":"        mock.patch(\u0027happybase.Connection.table\u0027, new\u003dtable).start()"},{"line_number":140,"context_line":"        # We shouldn\u0027t delete data and tables of previous tests,"},{"line_number":141,"context_line":"        # because it too long."},{"line_number":142,"context_line":"        # All tests tables will be delete in setup-test-env.sh"},{"line_number":143,"context_line":"        mock.patch(\"happybase.Connection.disable_table\","},{"line_number":144,"context_line":"                   new\u003dmock.MagicMock()).start()"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa98f980_5c864c14","line":141,"updated":"2014-09-03 15:58:49.000000000","message":"be delete \u003d\u003e be deleted","commit_id":"58a56f48432d4fc8b9eeed42187c6a4905ca4b12"},{"author":{"_account_id":7729,"name":"Ilya Tyaptin","email":"ityaptin@mirantis.com","username":"ityaptin"},"change_message_id":"1bf3bd6f14a5818d50fd49e645e4abce6de7999b","unresolved":false,"context_lines":[{"line_number":138,"context_line":"        # stay origin. So tests with HBase mock work correct."},{"line_number":139,"context_line":"        mock.patch(\u0027happybase.Connection.table\u0027, new\u003dtable).start()"},{"line_number":140,"context_line":"        # We shouldn\u0027t delete data and tables of previous tests,"},{"line_number":141,"context_line":"        # because it too long."},{"line_number":142,"context_line":"        # All tests tables will be delete in setup-test-env.sh"},{"line_number":143,"context_line":"        mock.patch(\"happybase.Connection.disable_table\","},{"line_number":144,"context_line":"                   new\u003dmock.MagicMock()).start()"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa98f980_dd6af0b1","line":141,"in_reply_to":"fa98f980_5c864c14","updated":"2014-09-05 12:33:51.000000000","message":"Done","commit_id":"58a56f48432d4fc8b9eeed42187c6a4905ca4b12"},{"author":{"_account_id":10987,"name":"Igor Degtiarov","username":"tovstun","inactive":true},"change_message_id":"58eae31ce4efff5438be451691eabecd820c00d7","unresolved":false,"context_lines":[{"line_number":139,"context_line":"            self.url, \u0027ceilometer.metering.storage\u0027)"},{"line_number":140,"context_line":"        self.alarm_connection \u003d storage.get_connection("},{"line_number":141,"context_line":"            self.url, \u0027ceilometer.alarm.storage\u0027)"},{"line_number":142,"context_line":"        #  Unique prefix for each test to keep data distinguished because"},{"line_number":143,"context_line":"        # all test data is stored in one table"},{"line_number":144,"context_line":"        data_prefix \u003d str(uuid.uuid4().hex)"},{"line_number":145,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"fa98f980_fb75cacc","line":142,"updated":"2014-09-08 11:42:33.000000000","message":"doesn\u0027t need two spaces at the beginning of the comment line","commit_id":"073f5429e65fafa1818bb878c28ebe7383428434"},{"author":{"_account_id":7729,"name":"Ilya Tyaptin","email":"ityaptin@mirantis.com","username":"ityaptin"},"change_message_id":"fa94114b2bc73c4e6bffa58facd4f2e677b0bf13","unresolved":false,"context_lines":[{"line_number":139,"context_line":"            self.url, \u0027ceilometer.metering.storage\u0027)"},{"line_number":140,"context_line":"        self.alarm_connection \u003d storage.get_connection("},{"line_number":141,"context_line":"            self.url, \u0027ceilometer.alarm.storage\u0027)"},{"line_number":142,"context_line":"        #  Unique prefix for each test to keep data distinguished because"},{"line_number":143,"context_line":"        # all test data is stored in one table"},{"line_number":144,"context_line":"        data_prefix \u003d str(uuid.uuid4().hex)"},{"line_number":145,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"fa98f980_d6729bac","line":142,"in_reply_to":"fa98f980_fb75cacc","updated":"2014-09-08 11:48:26.000000000","message":"Done","commit_id":"073f5429e65fafa1818bb878c28ebe7383428434"},{"author":{"_account_id":3012,"name":"Dina Belova","email":"dbelova@mirantis.com","username":"dbelova"},"change_message_id":"53122845227fdc9677a57c694be02103c214542a","unresolved":false,"context_lines":[{"line_number":139,"context_line":"            self.url, \u0027ceilometer.metering.storage\u0027)"},{"line_number":140,"context_line":"        self.alarm_connection \u003d storage.get_connection("},{"line_number":141,"context_line":"            self.url, \u0027ceilometer.alarm.storage\u0027)"},{"line_number":142,"context_line":"        # Unique prefix for each test to keep data distinguished because"},{"line_number":143,"context_line":"        # all test data is stored in one table"},{"line_number":144,"context_line":"        data_prefix \u003d str(uuid.uuid4().hex)"},{"line_number":145,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"fa98f980_9b455317","line":142,"updated":"2014-09-19 13:24:25.000000000","message":"is distinguished","commit_id":"8efedd0a215a188b9b5d067b78b328790e35ecfd"},{"author":{"_account_id":7729,"name":"Ilya Tyaptin","email":"ityaptin@mirantis.com","username":"ityaptin"},"change_message_id":"1bad4b2cee0339295cda45424c08e99be1f34e3c","unresolved":false,"context_lines":[{"line_number":139,"context_line":"            self.url, \u0027ceilometer.metering.storage\u0027)"},{"line_number":140,"context_line":"        self.alarm_connection \u003d storage.get_connection("},{"line_number":141,"context_line":"            self.url, \u0027ceilometer.alarm.storage\u0027)"},{"line_number":142,"context_line":"        # Unique prefix for each test to keep data distinguished because"},{"line_number":143,"context_line":"        # all test data is stored in one table"},{"line_number":144,"context_line":"        data_prefix \u003d str(uuid.uuid4().hex)"},{"line_number":145,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"fa98f980_db00bb04","line":142,"in_reply_to":"fa98f980_9b455317","updated":"2014-09-19 13:49:26.000000000","message":"Done","commit_id":"8efedd0a215a188b9b5d067b78b328790e35ecfd"},{"author":{"_account_id":3012,"name":"Dina Belova","email":"dbelova@mirantis.com","username":"dbelova"},"change_message_id":"53122845227fdc9677a57c694be02103c214542a","unresolved":false,"context_lines":[{"line_number":147,"context_line":"            return MockHBaseTable(name, self, data_prefix)"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"        # Mock only real HBase connection, MConnection \"table\" method"},{"line_number":150,"context_line":"        # stay origin."},{"line_number":151,"context_line":"        mock.patch(\u0027happybase.Connection.table\u0027, new\u003dtable).start()"},{"line_number":152,"context_line":"        # We shouldn\u0027t delete data and tables after each test,"},{"line_number":153,"context_line":"        # because it too long."}],"source_content_type":"text/x-python","patch_set":10,"id":"fa98f980_db66fbba","line":150,"updated":"2014-09-19 13:24:25.000000000","message":"stays","commit_id":"8efedd0a215a188b9b5d067b78b328790e35ecfd"},{"author":{"_account_id":7729,"name":"Ilya Tyaptin","email":"ityaptin@mirantis.com","username":"ityaptin"},"change_message_id":"1bad4b2cee0339295cda45424c08e99be1f34e3c","unresolved":false,"context_lines":[{"line_number":147,"context_line":"            return MockHBaseTable(name, self, data_prefix)"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"        # Mock only real HBase connection, MConnection \"table\" method"},{"line_number":150,"context_line":"        # stay origin."},{"line_number":151,"context_line":"        mock.patch(\u0027happybase.Connection.table\u0027, new\u003dtable).start()"},{"line_number":152,"context_line":"        # We shouldn\u0027t delete data and tables after each test,"},{"line_number":153,"context_line":"        # because it too long."}],"source_content_type":"text/x-python","patch_set":10,"id":"fa98f980_cdfe3e05","line":150,"in_reply_to":"fa98f980_db66fbba","updated":"2014-09-19 13:49:26.000000000","message":"Done","commit_id":"8efedd0a215a188b9b5d067b78b328790e35ecfd"},{"author":{"_account_id":3012,"name":"Dina Belova","email":"dbelova@mirantis.com","username":"dbelova"},"change_message_id":"53122845227fdc9677a57c694be02103c214542a","unresolved":false,"context_lines":[{"line_number":150,"context_line":"        # stay origin."},{"line_number":151,"context_line":"        mock.patch(\u0027happybase.Connection.table\u0027, new\u003dtable).start()"},{"line_number":152,"context_line":"        # We shouldn\u0027t delete data and tables after each test,"},{"line_number":153,"context_line":"        # because it too long."},{"line_number":154,"context_line":"        # All tests tables will be delete in setup-test-env.sh"},{"line_number":155,"context_line":"        mock.patch(\"happybase.Connection.disable_table\","},{"line_number":156,"context_line":"                   new\u003dmock.MagicMock()).start()"}],"source_content_type":"text/x-python","patch_set":10,"id":"fa98f980_db4fdb32","line":153,"updated":"2014-09-19 13:24:25.000000000","message":"it *lasts for* too long","commit_id":"8efedd0a215a188b9b5d067b78b328790e35ecfd"},{"author":{"_account_id":7729,"name":"Ilya Tyaptin","email":"ityaptin@mirantis.com","username":"ityaptin"},"change_message_id":"1bad4b2cee0339295cda45424c08e99be1f34e3c","unresolved":false,"context_lines":[{"line_number":150,"context_line":"        # stay origin."},{"line_number":151,"context_line":"        mock.patch(\u0027happybase.Connection.table\u0027, new\u003dtable).start()"},{"line_number":152,"context_line":"        # We shouldn\u0027t delete data and tables after each test,"},{"line_number":153,"context_line":"        # because it too long."},{"line_number":154,"context_line":"        # All tests tables will be delete in setup-test-env.sh"},{"line_number":155,"context_line":"        mock.patch(\"happybase.Connection.disable_table\","},{"line_number":156,"context_line":"                   new\u003dmock.MagicMock()).start()"}],"source_content_type":"text/x-python","patch_set":10,"id":"fa98f980_ed014205","line":153,"in_reply_to":"fa98f980_db4fdb32","updated":"2014-09-19 13:49:26.000000000","message":"Done","commit_id":"8efedd0a215a188b9b5d067b78b328790e35ecfd"},{"author":{"_account_id":3012,"name":"Dina Belova","email":"dbelova@mirantis.com","username":"dbelova"},"change_message_id":"53122845227fdc9677a57c694be02103c214542a","unresolved":false,"context_lines":[{"line_number":151,"context_line":"        mock.patch(\u0027happybase.Connection.table\u0027, new\u003dtable).start()"},{"line_number":152,"context_line":"        # We shouldn\u0027t delete data and tables after each test,"},{"line_number":153,"context_line":"        # because it too long."},{"line_number":154,"context_line":"        # All tests tables will be delete in setup-test-env.sh"},{"line_number":155,"context_line":"        mock.patch(\"happybase.Connection.disable_table\","},{"line_number":156,"context_line":"                   new\u003dmock.MagicMock()).start()"},{"line_number":157,"context_line":"        mock.patch(\"happybase.Connection.delete_table\","}],"source_content_type":"text/x-python","patch_set":10,"id":"fa98f980_fb5d7fed","line":154,"range":{"start_line":154,"start_character":35,"end_line":154,"end_character":41},"updated":"2014-09-19 13:24:25.000000000","message":"deleted","commit_id":"8efedd0a215a188b9b5d067b78b328790e35ecfd"},{"author":{"_account_id":7729,"name":"Ilya Tyaptin","email":"ityaptin@mirantis.com","username":"ityaptin"},"change_message_id":"1bad4b2cee0339295cda45424c08e99be1f34e3c","unresolved":false,"context_lines":[{"line_number":151,"context_line":"        mock.patch(\u0027happybase.Connection.table\u0027, new\u003dtable).start()"},{"line_number":152,"context_line":"        # We shouldn\u0027t delete data and tables after each test,"},{"line_number":153,"context_line":"        # because it too long."},{"line_number":154,"context_line":"        # All tests tables will be delete in setup-test-env.sh"},{"line_number":155,"context_line":"        mock.patch(\"happybase.Connection.disable_table\","},{"line_number":156,"context_line":"                   new\u003dmock.MagicMock()).start()"},{"line_number":157,"context_line":"        mock.patch(\"happybase.Connection.delete_table\","}],"source_content_type":"text/x-python","patch_set":10,"id":"fa98f980_0d09262c","line":154,"range":{"start_line":154,"start_character":35,"end_line":154,"end_character":41},"in_reply_to":"fa98f980_fb5d7fed","updated":"2014-09-19 13:49:26.000000000","message":"Done","commit_id":"8efedd0a215a188b9b5d067b78b328790e35ecfd"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"485584f9430b7844b9296d5185440205411542f0","unresolved":false,"context_lines":[{"line_number":36,"context_line":"from ceilometer.tests import base as test_base"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"class MockHBaseTable(happybase.Table):"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    def __init__(self, name, connection, data_prefix):"},{"line_number":42,"context_line":"        # data_prefix is added to all rows which are written"}],"source_content_type":"text/x-python","patch_set":12,"id":"da9df570_c621dba0","line":39,"updated":"2014-09-23 17:53:51.000000000","message":"this would be cleaner in a separate file.","commit_id":"6b812119713da892f6918e60b6c13aaff6e19ab3"},{"author":{"_account_id":7729,"name":"Ilya Tyaptin","email":"ityaptin@mirantis.com","username":"ityaptin"},"change_message_id":"4c4c985886640313bd9b3c62f74efd145dd6bc30","unresolved":false,"context_lines":[{"line_number":36,"context_line":"from ceilometer.tests import base as test_base"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"class MockHBaseTable(happybase.Table):"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    def __init__(self, name, connection, data_prefix):"},{"line_number":42,"context_line":"        # data_prefix is added to all rows which are written"}],"source_content_type":"text/x-python","patch_set":12,"id":"da9df570_889fcb4f","line":39,"in_reply_to":"da9df570_c621dba0","updated":"2014-09-24 10:27:28.000000000","message":"Done","commit_id":"6b812119713da892f6918e60b6c13aaff6e19ab3"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"485584f9430b7844b9296d5185440205411542f0","unresolved":false,"context_lines":[{"line_number":49,"context_line":"            \"%s_%s\" % (prefix, name),"},{"line_number":50,"context_line":"            connection)"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    def put(self, row, data, timestamp\u003dNone):"},{"line_number":53,"context_line":"        row \u003d self.data_prefix + row"},{"line_number":54,"context_line":"        return super(MockHBaseTable, self).put(row, data,"},{"line_number":55,"context_line":"                                               timestamp)"}],"source_content_type":"text/x-python","patch_set":12,"id":"da9df570_2192919f","line":52,"updated":"2014-09-23 17:53:51.000000000","message":"can we define this as:\n def put(self, row, *args, **kwargs):\n\nso we don\u0027t need to worry about defaults of values we don\u0027t ever use?","commit_id":"6b812119713da892f6918e60b6c13aaff6e19ab3"},{"author":{"_account_id":7729,"name":"Ilya Tyaptin","email":"ityaptin@mirantis.com","username":"ityaptin"},"change_message_id":"4c4c985886640313bd9b3c62f74efd145dd6bc30","unresolved":false,"context_lines":[{"line_number":49,"context_line":"            \"%s_%s\" % (prefix, name),"},{"line_number":50,"context_line":"            connection)"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    def put(self, row, data, timestamp\u003dNone):"},{"line_number":53,"context_line":"        row \u003d self.data_prefix + row"},{"line_number":54,"context_line":"        return super(MockHBaseTable, self).put(row, data,"},{"line_number":55,"context_line":"                                               timestamp)"}],"source_content_type":"text/x-python","patch_set":12,"id":"da9df570_a8ae4f83","line":52,"in_reply_to":"da9df570_2192919f","updated":"2014-09-24 10:27:28.000000000","message":"Done","commit_id":"6b812119713da892f6918e60b6c13aaff6e19ab3"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"485584f9430b7844b9296d5185440205411542f0","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        # row_prefix could not be combined with row_start or row_stop"},{"line_number":63,"context_line":"        if not row_start and not row_stop:"},{"line_number":64,"context_line":"            row_prefix \u003d self.data_prefix + (row_prefix or \"\")"},{"line_number":65,"context_line":"            row_start \u003d None"},{"line_number":66,"context_line":"            row_stop \u003d None"},{"line_number":67,"context_line":"        elif row_start and not row_stop:"},{"line_number":68,"context_line":"            # Adding data_prefix to row_start and row_stop does not work"}],"source_content_type":"text/x-python","patch_set":12,"id":"da9df570_c159c5ff","line":65,"updated":"2014-09-23 17:53:51.000000000","message":"is this not already assumed? or can row_start/stop be some empty string/list value?","commit_id":"6b812119713da892f6918e60b6c13aaff6e19ab3"},{"author":{"_account_id":7729,"name":"Ilya Tyaptin","email":"ityaptin@mirantis.com","username":"ityaptin"},"change_message_id":"4c4c985886640313bd9b3c62f74efd145dd6bc30","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        # row_prefix could not be combined with row_start or row_stop"},{"line_number":63,"context_line":"        if not row_start and not row_stop:"},{"line_number":64,"context_line":"            row_prefix \u003d self.data_prefix + (row_prefix or \"\")"},{"line_number":65,"context_line":"            row_start \u003d None"},{"line_number":66,"context_line":"            row_stop \u003d None"},{"line_number":67,"context_line":"        elif row_start and not row_stop:"},{"line_number":68,"context_line":"            # Adding data_prefix to row_start and row_stop does not work"}],"source_content_type":"text/x-python","patch_set":12,"id":"da9df570_68cb8753","line":65,"in_reply_to":"da9df570_c159c5ff","updated":"2014-09-24 10:27:28.000000000","message":"Yes, row_start or row_stop can be empty line.","commit_id":"6b812119713da892f6918e60b6c13aaff6e19ab3"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"485584f9430b7844b9296d5185440205411542f0","unresolved":false,"context_lines":[{"line_number":144,"context_line":"        data_prefix \u003d str(uuid.uuid4().hex)"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"        def table(self, name):"},{"line_number":147,"context_line":"            return MockHBaseTable(name, self, data_prefix)"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"        # Mock only real HBase connection, MConnection \"table\" method"},{"line_number":150,"context_line":"        # stays origin."}],"source_content_type":"text/x-python","patch_set":12,"id":"da9df570_c6139b64","line":147,"updated":"2014-09-23 17:53:51.000000000","message":"is this right? we\u0027re passing in self?","commit_id":"6b812119713da892f6918e60b6c13aaff6e19ab3"},{"author":{"_account_id":7729,"name":"Ilya Tyaptin","email":"ityaptin@mirantis.com","username":"ityaptin"},"change_message_id":"4c4c985886640313bd9b3c62f74efd145dd6bc30","unresolved":false,"context_lines":[{"line_number":144,"context_line":"        data_prefix \u003d str(uuid.uuid4().hex)"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"        def table(self, name):"},{"line_number":147,"context_line":"            return MockHBaseTable(name, self, data_prefix)"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"        # Mock only real HBase connection, MConnection \"table\" method"},{"line_number":150,"context_line":"        # stays origin."}],"source_content_type":"text/x-python","patch_set":12,"id":"da9df570_a8dc8f13","line":147,"in_reply_to":"da9df570_c6139b64","updated":"2014-09-24 10:27:28.000000000","message":"Yes, we put to \u0027table\u0027 function connection instance as \u0027self\u0027. This connection we put to table. I\u0027ll change \u0027self\u0027 to \u0027conn\u0027.","commit_id":"6b812119713da892f6918e60b6c13aaff6e19ab3"}],"tools/clear_test_hbase_tables.py":[{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"485584f9430b7844b9296d5185440205411542f0","unresolved":false,"context_lines":[{"line_number":23,"context_line":"               (os.getenv(\"CEILOMETER_TEST_HBASE_URL\"),"},{"line_number":24,"context_line":"                os.getenv(\"CEILOMETER_TEST_HBASE_TABLE_PREFIX\", \"test\")))"},{"line_number":25,"context_line":"        conn \u003d storage.get_connection(url, \u0027ceilometer.metering.storage\u0027)"},{"line_number":26,"context_line":"        conn.clear()"},{"line_number":27,"context_line":"        alarm_conn \u003d storage.get_connection(url, \u0027ceilometer.alarm.storage\u0027)"},{"line_number":28,"context_line":"        alarm_conn.clear()"},{"line_number":29,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"da9df570_013bcdd1","line":26,"updated":"2014-09-23 17:53:51.000000000","message":"this seems like it\u0027d be cleaner to have just a single file that pulls in the an argument whether it\u0027s a delete/create action... unless this is to accommodate known features for future?","commit_id":"6b812119713da892f6918e60b6c13aaff6e19ab3"},{"author":{"_account_id":7729,"name":"Ilya Tyaptin","email":"ityaptin@mirantis.com","username":"ityaptin"},"change_message_id":"4c4c985886640313bd9b3c62f74efd145dd6bc30","unresolved":false,"context_lines":[{"line_number":23,"context_line":"               (os.getenv(\"CEILOMETER_TEST_HBASE_URL\"),"},{"line_number":24,"context_line":"                os.getenv(\"CEILOMETER_TEST_HBASE_TABLE_PREFIX\", \"test\")))"},{"line_number":25,"context_line":"        conn \u003d storage.get_connection(url, \u0027ceilometer.metering.storage\u0027)"},{"line_number":26,"context_line":"        conn.clear()"},{"line_number":27,"context_line":"        alarm_conn \u003d storage.get_connection(url, \u0027ceilometer.alarm.storage\u0027)"},{"line_number":28,"context_line":"        alarm_conn.clear()"},{"line_number":29,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"da9df570_08091b95","line":26,"in_reply_to":"da9df570_013bcdd1","updated":"2014-09-24 10:27:28.000000000","message":"Yes, single file will be cleaner that two.","commit_id":"6b812119713da892f6918e60b6c13aaff6e19ab3"}]}