)]}'
{"ceilometer/api/controllers/v2.py":[{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"81a6fc0984d0b3c1a3f32376e841debdd7ed977a","unresolved":false,"context_lines":[{"line_number":1329,"context_line":"                self.filter_expr \u003d json.loads(self.original_query.filter)"},{"line_number":1330,"context_line":"                self._validate_filter(self.filter_expr)"},{"line_number":1331,"context_line":"            except (ValueError, jsonschema.exceptions.ValidationError) as e:"},{"line_number":1332,"context_line":"                raise ClientSideError(\"Failed JSON filter validation %s\" %"},{"line_number":1333,"context_line":"                                      e.message)"},{"line_number":1334,"context_line":"            self._replace_isotime_with_datetime(self.filter_expr)"},{"line_number":1335,"context_line":"            self._convert_operator_to_lower_case(self.filter_expr)"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa98f980_c1061e21","line":1332,"updated":"2014-09-09 19:29:29.000000000","message":"I would write something ike this as error message: \"The validation of the filter expression failed: %s\"","commit_id":"0bf96f97501bfdb68c8b4931dc58432bc7ddcae1"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"81a6fc0984d0b3c1a3f32376e841debdd7ed977a","unresolved":false,"context_lines":[{"line_number":1340,"context_line":"        if self.original_query.orderby is wtypes.Unset:"},{"line_number":1341,"context_line":"            self.orderby \u003d None"},{"line_number":1342,"context_line":"        else:"},{"line_number":1343,"context_line":"            self.orderby \u003d json.loads(self.original_query.orderby)"},{"line_number":1344,"context_line":"            self._validate_orderby(self.orderby)"},{"line_number":1345,"context_line":"            self._convert_orderby_to_lower_case(self.orderby)"},{"line_number":1346,"context_line":"            self._normalize_field_names_in_orderby(self.orderby)"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa98f980_81a25649","line":1343,"updated":"2014-09-09 19:29:29.000000000","message":"The \u0027orderby\u0027 field is also validated against a JSON schema, therefore this block should be handled the same way as the filter expression.","commit_id":"0bf96f97501bfdb68c8b4931dc58432bc7ddcae1"},{"author":{"_account_id":7729,"name":"Ilya Tyaptin","email":"ityaptin@mirantis.com","username":"ityaptin"},"change_message_id":"2f5d6a3ed5bf48227aaeb534b93849127ff577e5","unresolved":false,"context_lines":[{"line_number":1328,"context_line":"            try:"},{"line_number":1329,"context_line":"                self.filter_expr \u003d json.loads(self.original_query.filter)"},{"line_number":1330,"context_line":"                self._validate_filter(self.filter_expr)"},{"line_number":1331,"context_line":"            except (ValueError, jsonschema.exceptions.ValidationError) as e:"},{"line_number":1332,"context_line":"                raise ClientSideError(\"Filter expression not valid  %s\" %"},{"line_number":1333,"context_line":"                                      e.message)"},{"line_number":1334,"context_line":"            self._replace_isotime_with_datetime(self.filter_expr)"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa98f980_4cf7b7f5","line":1331,"updated":"2014-09-10 07:48:42.000000000","message":"May you mark exception message for ClientSideError as translatable? \n\nIn agreement with http://docs.openstack.org/developer/oslo.i18n/usage.html exception messages should to be marked as translatable. Also in other ClientSideError exceptions in this module exception message are marked.","commit_id":"729b9aaa9a3911e9544a4112134d2c076299595d"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"503d93e8d842a597d12eb01ae82ef4af511bbf3f","unresolved":false,"context_lines":[{"line_number":1329,"context_line":"                self.filter_expr \u003d json.loads(self.original_query.filter)"},{"line_number":1330,"context_line":"                self._validate_filter(self.filter_expr)"},{"line_number":1331,"context_line":"            except (ValueError, jsonschema.exceptions.ValidationError) as e:"},{"line_number":1332,"context_line":"                raise ClientSideError(_(\"Filter expression not valid %s\") %"},{"line_number":1333,"context_line":"                                      e.message)"},{"line_number":1334,"context_line":"            self._replace_isotime_with_datetime(self.filter_expr)"},{"line_number":1335,"context_line":"            self._convert_operator_to_lower_case(self.filter_expr)"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa98f980_f869def9","line":1332,"updated":"2014-09-11 12:03:53.000000000","message":"The full error message looks like the following:\n\n \"Filter expression not valid {u\u0027\u003d\u0027: {u\u0027not-valid-field\u0027: u\u0027project-2\u0027}} is not valid under any of the given schemas\"\n\nIt\u0027s not that well readable, therefore I would suggest to change the base error string here to something like:\n\n \"The validation of filter expression has failed because of the following reason: %s\"\n\nAnd also please use a colon (:) after the base text to separate it from the message of the error that occured.","commit_id":"284b9dac7b4639f4d4502b6896a2624e2bb6aaf4"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"503d93e8d842a597d12eb01ae82ef4af511bbf3f","unresolved":false,"context_lines":[{"line_number":1344,"context_line":"                self.orderby \u003d json.loads(self.original_query.orderby)"},{"line_number":1345,"context_line":"                self._validate_orderby(self.orderby)"},{"line_number":1346,"context_line":"            except (ValueError, jsonschema.exceptions.ValidationError) as e:"},{"line_number":1347,"context_line":"                raise ClientSideError(_(\"Order-by expression not valid %s\") %"},{"line_number":1348,"context_line":"                                      e.message)"},{"line_number":1349,"context_line":"            self._convert_orderby_to_lower_case(self.orderby)"},{"line_number":1350,"context_line":"            self._normalize_field_names_in_orderby(self.orderby)"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa98f980_b852f632","line":1347,"updated":"2014-09-11 12:03:53.000000000","message":"This text should be changed similarly as the above one.","commit_id":"284b9dac7b4639f4d4502b6896a2624e2bb6aaf4"}]}