)]}'
{"id":"openstack%2Fceilometer~121104","triplet_id":"openstack%2Fceilometer~master~Iba4a3b91d5ee978213fdd6fcf8bb62b315324a52","project":"openstack/ceilometer","branch":"master","topic":"swift-partitioning-bug1365351","hashtags":[],"change_id":"Iba4a3b91d5ee978213fdd6fcf8bb62b315324a52","subject":"Partition swift pollster resources by tenant","status":"MERGED","created":"2014-09-12 13:08:49.000000000","updated":"2014-09-18 07:25:59.000000000","submitted":"2014-09-18 07:25:58.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":10,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"2f6dcd8ce4cf0fa4b23741ac0ac5b0a8a6dc155d","_number":121104,"virtual_id_number":121104,"owner":{"_account_id":8052,"name":"Nejc Saje","email":"nejc@saje.info","username":"nsaje"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},{"value":0,"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},{"value":0,"_account_id":7052,"name":"Fabio Giannetti","email":"fgiannet@cisco.com","username":"fabgia"},{"value":0,"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},{"value":0,"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},{"value":0,"_account_id":3012,"name":"Dina Belova","email":"dbelova@mirantis.com","username":"dbelova"},{"value":0,"date":"2014-09-15 14:56:23.000000000","_account_id":8052,"name":"Nejc Saje","email":"nejc@saje.info","username":"nsaje"},{"value":2,"date":"2014-09-18 07:25:58.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"all":[{"value":0,"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},{"value":2,"date":"2014-09-15 12:38:04.000000000","_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},{"value":1,"date":"2014-09-17 14:46:35.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":7052,"name":"Fabio Giannetti","email":"fgiannet@cisco.com","username":"fabgia"},{"value":0,"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},{"value":2,"date":"2014-09-18 03:16:14.000000000","_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},{"value":1,"date":"2014-09-17 11:39:58.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":3012,"name":"Dina Belova","email":"dbelova@mirantis.com","username":"dbelova"},{"value":0,"_account_id":8052,"name":"Nejc Saje","email":"nejc@saje.info","username":"nsaje"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"all":[{"value":0,"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},{"value":0,"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},{"value":0,"_account_id":7052,"name":"Fabio Giannetti","email":"fgiannet@cisco.com","username":"fabgia"},{"value":0,"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},{"value":1,"date":"2014-09-18 03:16:14.000000000","_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},{"value":0,"_account_id":3012,"name":"Dina Belova","email":"dbelova@mirantis.com","username":"dbelova"},{"value":0,"_account_id":8052,"name":"Nejc Saje","email":"nejc@saje.info","username":"nsaje"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},{"_account_id":3012,"name":"Dina Belova","email":"dbelova@mirantis.com","username":"dbelova"},{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},{"_account_id":7052,"name":"Fabio Giannetti","email":"fgiannet@cisco.com","username":"fabgia"},{"_account_id":8052,"name":"Nejc Saje","email":"nejc@saje.info","username":"nsaje"},{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2014-09-12 13:09:34.000000000","updated_by":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"reviewer":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"state":"REVIEWER"},{"updated":"2014-09-12 13:10:24.000000000","updated_by":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"reviewer":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"state":"REVIEWER"},{"updated":"2014-09-15 12:38:04.000000000","updated_by":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"reviewer":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"state":"REVIEWER"},{"updated":"2014-09-17 11:39:58.000000000","updated_by":{"_account_id":3012,"name":"Dina Belova","email":"dbelova@mirantis.com","username":"dbelova"},"reviewer":{"_account_id":3012,"name":"Dina Belova","email":"dbelova@mirantis.com","username":"dbelova"},"state":"REVIEWER"},{"updated":"2014-09-17 14:46:35.000000000","updated_by":{"_account_id":7052,"name":"Fabio Giannetti","email":"fgiannet@cisco.com","username":"fabgia"},"reviewer":{"_account_id":7052,"name":"Fabio Giannetti","email":"fgiannet@cisco.com","username":"fabgia"},"state":"REVIEWER"},{"updated":"2014-09-18 03:16:14.000000000","updated_by":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"reviewer":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"state":"REVIEWER"},{"updated":"2014-09-18 07:25:58.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"4306be8c23dc7c9722f2e126d1245a100e7b2dc3","author":{"_account_id":8052,"name":"Nejc Saje","email":"nejc@saje.info","username":"nsaje"},"date":"2014-09-12 13:08:49.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"091964bae8448fbcff4511869628a90ccfa82acd","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-09-12 14:53:08.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded.\n\n- gate-ceilometer-pep8 http://logs.openstack.org/04/121104/1/check/gate-ceilometer-pep8/4688cad : SUCCESS in 4m 47s\n- gate-ceilometer-docs http://docs-draft.openstack.org/04/121104/1/check/gate-ceilometer-docs/8bc639d/doc/build/html/ : SUCCESS in 6m 48s\n- gate-ceilometer-python26 http://logs.openstack.org/04/121104/1/check/gate-ceilometer-python26/2ca9401 : SUCCESS in 6m 16s\n- gate-ceilometer-python27 http://logs.openstack.org/04/121104/1/check/gate-ceilometer-python27/6900bcd : SUCCESS in 6m 56s\n- gate-ceilometer-python33 http://logs.openstack.org/04/121104/1/check/gate-ceilometer-python33/6938abb : SUCCESS in 6m 05s\n- check-tempest-dsvm-full http://logs.openstack.org/04/121104/1/check/check-tempest-dsvm-full/16206f3 : SUCCESS in 44m 17s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/04/121104/1/check/check-tempest-dsvm-postgres-full/16cef69 : SUCCESS in 1h 06m 04s\n- check-tempest-dsvm-neutron-full http://logs.openstack.org/04/121104/1/check/check-tempest-dsvm-neutron-full/c6836a2 : SUCCESS in 47m 44s\n- check-tempest-dsvm-neutron-heat-slow http://logs.openstack.org/04/121104/1/check/check-tempest-dsvm-neutron-heat-slow/dabdb84 : SUCCESS in 20m 30s\n- check-grenade-dsvm http://logs.openstack.org/04/121104/1/check/check-grenade-dsvm/bd678b6 : SUCCESS in 39m 30s\n- check-devstack-dsvm-cells http://logs.openstack.org/04/121104/1/check/check-devstack-dsvm-cells/f4cc29a : SUCCESS in 13m 27s\n- check-swift-dsvm-functional http://logs.openstack.org/04/121104/1/check/check-swift-dsvm-functional/045ff87 : SUCCESS in 18m 23s\n- gate-tempest-dsvm-ceilometer-mongodb http://logs.openstack.org/04/121104/1/check/gate-tempest-dsvm-ceilometer-mongodb/899ae6c : SUCCESS in 30m 41s (non-voting)\n- gate-tempest-dsvm-ceilometer-mongodb-full http://logs.openstack.org/04/121104/1/check/gate-tempest-dsvm-ceilometer-mongodb-full/0cac3d5 : SUCCESS in 54m 45s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"84945919aeb2ac09a5a4f4b74e490bafb60f32ab","author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"date":"2014-09-12 15:46:14.000000000","message":"Patch Set 1:\n\n(1 comment)\n\nIn general I\u0027m +1 on this, but worry about whether or not we have sufficient test coverage here or in tempest to actually cover it?","accounts_in_message":[],"_revision_number":1},{"id":"e8afdc76ebcbd48edf57222d61a02c581e3f0ed3","author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"date":"2014-09-12 16:24:31.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)\n\nNice idea, a quick suggestion inline.\n\nCheers,\nEoghan","accounts_in_message":[],"_revision_number":1},{"id":"2af84cf2117f8189a65f9d2e5babef4ca8dc4b73","author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"date":"2014-09-15 03:00:00.000000000","message":"Patch Set 1: Code-Review-1\n\n(2 comments)","accounts_in_message":[],"_revision_number":1},{"id":"5570e4e3db6cf92afff70b586b45538c1c0a5107","author":{"_account_id":8052,"name":"Nejc Saje","email":"nejc@saje.info","username":"nsaje"},"date":"2014-09-15 08:04:59.000000000","message":"Patch Set 1:\n\n(2 comments)","accounts_in_message":[],"_revision_number":1},{"id":"53f9e9d92c20c1b832d99ecd4ee13ff873adc92d","author":{"_account_id":8052,"name":"Nejc Saje","email":"nejc@saje.info","username":"nsaje"},"date":"2014-09-15 08:11:42.000000000","message":"Patch Set 1:\n\n@Chris: You\u0027re right, I\u0027ll add explicit checking that swiftclient is only called for the assigned tenants. As for Tempest, do we even have any functional testing in there?","accounts_in_message":[],"_revision_number":1},{"id":"47de5767bcc5a7cf5e6201cbb528331c6d79b7d4","author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"date":"2014-09-15 08:42:21.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"80a1c5c0303a1ae7378c7d43fa455b37c7446cd4","author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"date":"2014-09-15 09:35:15.000000000","message":"Patch Set 1:\n\nAs far as I know functional testing that includes ceilo + swift is limited or none. I\u0027ve got a patchset pending (https://review.openstack.org/#/c/115971/) but it is stalled out because it can\u0027t pass the havana-\u003eicehouse grenade tests.\n\nI don\u0027t mean to suggest that this patch needs tempest tests to land, more that I\u0027m making a reminder (to all of us) to keep it in mind for later.","accounts_in_message":[],"_revision_number":1},{"id":"c0785c36df03665d434f52ddee13d9c37128340f","author":{"_account_id":8052,"name":"Nejc Saje","email":"nejc@saje.info","username":"nsaje"},"date":"2014-09-15 10:53:20.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"486ea596860af65543e3811a2a15220772a3dc68","author":{"_account_id":8052,"name":"Nejc Saje","email":"nejc@saje.info","username":"nsaje"},"date":"2014-09-15 10:57:49.000000000","message":"Patch Set 2:\n\nI stored the retrieved endpoint into the base class, so it\u0027s only ever retrieved once for all subclasses. That required not-so-idiomatic explicitly referencing the base class, so feel free to voice any concerns about that.\n\nI added the test to check that only the assigned tenants are polled and a test that the endpoint is only retrieved once.","accounts_in_message":[],"_revision_number":2},{"id":"ba13f804a17136c598e21a1341ae3e09654757c5","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-09-15 11:56:04.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded.\n\n- gate-ceilometer-pep8 http://logs.openstack.org/04/121104/2/check/gate-ceilometer-pep8/ba51742 : SUCCESS in 5m 12s\n- gate-ceilometer-docs http://docs-draft.openstack.org/04/121104/2/check/gate-ceilometer-docs/6970adc/doc/build/html/ : SUCCESS in 7m 50s\n- gate-ceilometer-python26 http://logs.openstack.org/04/121104/2/check/gate-ceilometer-python26/408a3bd : SUCCESS in 4m 46s\n- gate-ceilometer-python27 http://logs.openstack.org/04/121104/2/check/gate-ceilometer-python27/abfcb26 : SUCCESS in 6m 22s\n- gate-ceilometer-python33 http://logs.openstack.org/04/121104/2/check/gate-ceilometer-python33/966c5a5 : SUCCESS in 5m 47s\n- check-tempest-dsvm-full http://logs.openstack.org/04/121104/2/check/check-tempest-dsvm-full/3d8ea30 : SUCCESS in 55m 52s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/04/121104/2/check/check-tempest-dsvm-postgres-full/daba884 : SUCCESS in 1h 02m 40s\n- check-tempest-dsvm-neutron-full http://logs.openstack.org/04/121104/2/check/check-tempest-dsvm-neutron-full/91a16cf : SUCCESS in 49m 53s\n- check-tempest-dsvm-neutron-heat-slow http://logs.openstack.org/04/121104/2/check/check-tempest-dsvm-neutron-heat-slow/c860f7d : SUCCESS in 20m 17s\n- check-grenade-dsvm http://logs.openstack.org/04/121104/2/check/check-grenade-dsvm/c74bc94 : SUCCESS in 37m 32s\n- check-devstack-dsvm-cells http://logs.openstack.org/04/121104/2/check/check-devstack-dsvm-cells/e619ef4 : SUCCESS in 14m 09s\n- check-swift-dsvm-functional http://logs.openstack.org/04/121104/2/check/check-swift-dsvm-functional/3baad75 : SUCCESS in 20m 17s\n- gate-tempest-dsvm-ceilometer-mongodb http://logs.openstack.org/04/121104/2/check/gate-tempest-dsvm-ceilometer-mongodb/068dd1f : SUCCESS in 32m 03s (non-voting)\n- gate-tempest-dsvm-ceilometer-mongodb-full http://logs.openstack.org/04/121104/2/check/gate-tempest-dsvm-ceilometer-mongodb-full/9d35bea : SUCCESS in 55m 24s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"3e349b1b4fd4bee15bc043febb0424f37707c4f6","author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"date":"2014-09-15 12:07:50.000000000","message":"Patch Set 2: Code-Review-1\n\n(2 comments)\n\nThanks for this Nejc, I think the usage of the class-level variable in the Base class is OK.\n\nJust a further suggestion inline.\n\nCheers,\nEoghan","accounts_in_message":[],"_revision_number":2},{"id":"822ef1ae4d1689edfddadeb5b9a5d0dee2ccad45","author":{"_account_id":8052,"name":"Nejc Saje","email":"nejc@saje.info","username":"nsaje"},"date":"2014-09-15 12:26:36.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"72b8345d086763be16851e7d9b0c2f68faf27dcb","author":{"_account_id":8052,"name":"Nejc Saje","email":"nejc@saje.info","username":"nsaje"},"date":"2014-09-15 12:34:53.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"23b27749a8b91c22ef626e689ed01c217c85cfbd","author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"date":"2014-09-15 12:38:04.000000000","message":"Patch Set 3: Code-Review+2\n\nThanks Nejc for the quick turn-around.\n\nCheers,\nEoghan","accounts_in_message":[],"_revision_number":3},{"id":"be505d5270b08d8c0e312a198c1ebdc7dda436ef","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-09-15 14:25:29.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded.\n\n- gate-ceilometer-pep8 http://logs.openstack.org/04/121104/3/check/gate-ceilometer-pep8/0ba8335 : SUCCESS in 4m 54s\n- gate-ceilometer-docs http://docs-draft.openstack.org/04/121104/3/check/gate-ceilometer-docs/bd9770b/doc/build/html/ : SUCCESS in 3m 41s\n- gate-ceilometer-python26 http://logs.openstack.org/04/121104/3/check/gate-ceilometer-python26/babcbe5 : SUCCESS in 4m 55s\n- gate-ceilometer-python27 http://logs.openstack.org/04/121104/3/check/gate-ceilometer-python27/95db6ff : SUCCESS in 4m 53s\n- gate-ceilometer-python33 http://logs.openstack.org/04/121104/3/check/gate-ceilometer-python33/5a536d6 : SUCCESS in 7m 00s\n- check-tempest-dsvm-full http://logs.openstack.org/04/121104/3/check/check-tempest-dsvm-full/3a81f1f : SUCCESS in 52m 30s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/04/121104/3/check/check-tempest-dsvm-postgres-full/1f6a070 : SUCCESS in 1h 18m 32s\n- check-tempest-dsvm-neutron-full http://logs.openstack.org/04/121104/3/check/check-tempest-dsvm-neutron-full/2caba21 : SUCCESS in 52m 06s\n- check-tempest-dsvm-neutron-heat-slow http://logs.openstack.org/04/121104/3/check/check-tempest-dsvm-neutron-heat-slow/fa41fc9 : SUCCESS in 19m 55s\n- check-grenade-dsvm http://logs.openstack.org/04/121104/3/check/check-grenade-dsvm/d0278a3 : SUCCESS in 41m 26s\n- check-devstack-dsvm-cells http://logs.openstack.org/04/121104/3/check/check-devstack-dsvm-cells/d7724c4 : SUCCESS in 14m 14s\n- check-swift-dsvm-functional http://logs.openstack.org/04/121104/3/check/check-swift-dsvm-functional/d55eac3 : SUCCESS in 18m 03s\n- gate-tempest-dsvm-ceilometer-mongodb http://logs.openstack.org/04/121104/3/check/gate-tempest-dsvm-ceilometer-mongodb/c9ea1f9 : SUCCESS in 27m 09s (non-voting)\n- gate-tempest-dsvm-ceilometer-mongodb-full http://logs.openstack.org/04/121104/3/check/gate-tempest-dsvm-ceilometer-mongodb-full/b8f7945 : SUCCESS in 45m 10s (non-voting)","accounts_in_message":[],"_revision_number":3},{"id":"f516e1f42af459fee923beef9897858fc2561fa4","author":{"_account_id":7052,"name":"Fabio Giannetti","email":"fgiannet@cisco.com","username":"fabgia"},"date":"2014-09-15 14:42:49.000000000","message":"Patch Set 3: Code-Review-1\n\nNejc, I understand the benefits from a performance perspective because now you can move the polling of one endpoint across several central agents subdividing it by tenants.\nMy concern here is troubleshooting. Before it was fairly easy to troubleshoot issues because there will be a lack of meters corresponding to a particular service but now you will need to see which tenants you got the data and which you didn\u0027t which is hard.\nThis seems to me to be a corner case anyway, so my concern is that we give people a level of granularity that (if misused) they will regret ... \nPlease tell me if I am on the wrong path here ...","accounts_in_message":[],"_revision_number":3},{"id":"7e9e1edcbecb0803bba58b11629e0d2523cb2fd8","author":{"_account_id":8052,"name":"Nejc Saje","email":"nejc@saje.info","username":"nsaje"},"date":"2014-09-15 14:56:23.000000000","message":"Patch Set 3:\n\nYou have valid concerns Fabio. There are debug logs logging which resources/tenants/... a particular agent is polling (https://github.com/openstack/ceilometer/blob/master/ceilometer/coordination.py#L139). All a user has to do is check out all the central agents\u0027 logs and see which one is spewing errors.\n\nDina \u0026 Igor tested fine-grained partitioning of the compute agent in multinode environment, and it worked great.","accounts_in_message":[],"_revision_number":3},{"id":"f496111850da718fbf76675cdfc28527a66d5f27","author":{"_account_id":7052,"name":"Fabio Giannetti","email":"fgiannet@cisco.com","username":"fabgia"},"date":"2014-09-15 15:01:30.000000000","message":"Patch Set 3:\n\nNejc, ok but the issue is that in prod you don\u0027t have your logs set in debug mode. :-)\nWould it be possible to partition based on Domain (or as it would be in the future called root project), in this way you have a compromise between granularity and easiness to debug since you could report that your are polling for domain X in the info log and then I can easily find all the tenants in that domain and identify if the pollster has missed something...","accounts_in_message":[],"_revision_number":3},{"id":"e66a84a768a95091386218960f4c4d0293f86812","author":{"_account_id":8052,"name":"Nejc Saje","email":"nejc@saje.info","username":"nsaje"},"date":"2014-09-15 15:14:18.000000000","message":"Patch Set 3:\n\nIt\u0027s true there are no debug logs, but there are WARNING and ERROR logs. If something\u0027s wrong, there should be warnings/errors in the offending agent. Are we doing ourselves a favour by not doing workload-partitioning at all? (which is the case with partitioning endpoints, I don\u0027t know what domains are though) In that case we could just run agents in active/passive mode.","accounts_in_message":[],"_revision_number":3},{"id":"b0c43c270b65fe34bc4a44e9016efe00d5cebb95","author":{"_account_id":7052,"name":"Fabio Giannetti","email":"fgiannet@cisco.com","username":"fabgia"},"date":"2014-09-15 15:18:06.000000000","message":"Patch Set 3:\n\nOk, but hang on a sec. You are partitioning by service and by region already and in NORMAL environment this is the rule.\nThe case you trying to solve here is a corner case where in a specific env. there is only 1 instance on swift in 1 region and the central agent that takes it has a lot more work. This seems to me a bad deployment strategy rather than a real issue to solve.","accounts_in_message":[],"_revision_number":3},{"id":"b2cd4c8d72012a2b75250c9c05a60358dd6bb70c","author":{"_account_id":8052,"name":"Nejc Saje","email":"nejc@saje.info","username":"nsaje"},"date":"2014-09-16 07:03:52.000000000","message":"Patch Set 3:\n\nCurrently, Ceilometer has almost non-existent support for multi-service. Perhaps this should change in the future (I don\u0027t know if it\u0027s a common deployment strategy to have multiple Swift endpoints in a single region?), but currently, most pollsters simply instantiate their service\u0027s client without regard for the possibility of there being multiple endpoints in that region.\n\nSo what you say is a corner case is actually the most common case (and the only one that was supported for Swift at all): 1 service in 1 region. Partitioning the set of endpoints is just a \u0027hack\u0027 to get some partitioning at all, which happens to support multi-service as well, but that was not the main purpose of it.\n\nThe intent behind the workload-partitioning patches was to distribute the workload as evenly as possible, which means preferring fine-grained resources. We went down that route and this patch is in line with that spirit.","accounts_in_message":[],"_revision_number":3},{"id":"39dcef3ebbdb12a6f1595cca2501c07f830ec757","author":{"_account_id":3012,"name":"Dina Belova","email":"dbelova@mirantis.com","username":"dbelova"},"date":"2014-09-17 11:39:58.000000000","message":"Patch Set 3: Code-Review+1\n\nFabio, ok, I got your concerns. Actually I suppose that might be a separated change, but anyway - what do you propose to do now in Nejc\u0027s change? For me his change looks quite consistent, and the problem you described seems needs to be solved globally I guess","accounts_in_message":[],"_revision_number":3},{"id":"c90384e8e535b1ea728efd407f4b32718f723ab9","author":{"_account_id":7052,"name":"Fabio Giannetti","email":"fgiannet@cisco.com","username":"fabgia"},"date":"2014-09-17 14:46:35.000000000","message":"Patch Set 3: Code-Review+1\n\nOk. Maybe we should discuss these kind of stuff at the summit and have a long term plan.\nThanks.","accounts_in_message":[],"_revision_number":3},{"id":"bb2c4ad1722877c7a0e5a9a79b0481251ce5e5d8","author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"date":"2014-09-18 03:16:14.000000000","message":"Patch Set 3: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":3},{"id":"9aca63c16fbe055c2ab60dba4210d3b3c6e312af","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-09-18 03:16:15.000000000","message":"Patch Set 3: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":3},{"id":"ecfe2aa04bb55238df4689f947010b8fe75a8437","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-09-18 07:25:58.000000000","message":"Patch Set 3: Verified+2\n\nBuild succeeded.\n\n- gate-ceilometer-docs http://docs-draft.openstack.org/04/121104/3/gate/gate-ceilometer-docs/2a1a703/doc/build/html/ : SUCCESS in 6m 42s\n- gate-ceilometer-pep8 http://logs.openstack.org/04/121104/3/gate/gate-ceilometer-pep8/9c63230 : SUCCESS in 4m 34s\n- gate-ceilometer-python26 http://logs.openstack.org/04/121104/3/gate/gate-ceilometer-python26/376e8a2 : SUCCESS in 5m 25s\n- gate-ceilometer-python27 http://logs.openstack.org/04/121104/3/gate/gate-ceilometer-python27/2dd333f : SUCCESS in 4m 39s\n- gate-ceilometer-python33 http://logs.openstack.org/04/121104/3/gate/gate-ceilometer-python33/dad7afd : SUCCESS in 6m 09s\n- gate-tempest-dsvm-full http://logs.openstack.org/04/121104/3/gate/gate-tempest-dsvm-full/01a83bc : SUCCESS in 47m 03s\n- gate-tempest-dsvm-postgres-full http://logs.openstack.org/04/121104/3/gate/gate-tempest-dsvm-postgres-full/6a1cd24 : SUCCESS in 1h 03m 28s\n- gate-tempest-dsvm-neutron-full http://logs.openstack.org/04/121104/3/gate/gate-tempest-dsvm-neutron-full/fae1695 : SUCCESS in 1h 05m 59s\n- gate-tempest-dsvm-neutron-heat-slow http://logs.openstack.org/04/121104/3/gate/gate-tempest-dsvm-neutron-heat-slow/c13563f : SUCCESS in 25m 12s\n- gate-grenade-dsvm http://logs.openstack.org/04/121104/3/gate/gate-grenade-dsvm/274246b : SUCCESS in 49m 50s\n- gate-devstack-dsvm-cells http://logs.openstack.org/04/121104/3/gate/gate-devstack-dsvm-cells/5bc8ac0 : SUCCESS in 17m 08s\n- gate-swift-dsvm-functional http://logs.openstack.org/04/121104/3/gate/gate-swift-dsvm-functional/c41de2b : SUCCESS in 20m 50s","accounts_in_message":[],"_revision_number":3},{"id":"a269569c043fe8a48440774488cf1d0a2508d11a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-09-18 07:25:59.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"87afc5ada176d2062bc0cc81c248d6813941a7d4","revisions":{"161b380d8f034e0ed048aaa3188c34495d823927":{"kind":"REWORK","_number":1,"created":"2014-09-12 13:08:49.000000000","uploader":{"_account_id":8052,"name":"Nejc Saje","email":"nejc@saje.info","username":"nsaje"},"ref":"refs/changes/04/121104/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ceilometer","ref":"refs/changes/04/121104/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ceilometer refs/changes/04/121104/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ceilometer refs/changes/04/121104/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ceilometer refs/changes/04/121104/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ceilometer refs/changes/04/121104/1"}}},"commit":{"parents":[{"commit":"254d58b52fcb6882f9c357ce91200c45c786d591","subject":"Use central agent manager\u0027s keystone token in discoveries","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ceilometer/commit/254d58b52fcb6882f9c357ce91200c45c786d591"}]}],"author":{"name":"Nejc Saje","email":"nsaje@redhat.com","date":"2014-09-09 07:44:35.000000000","tz":-240},"committer":{"name":"Nejc Saje","email":"nsaje@redhat.com","date":"2014-09-12 13:02:24.000000000","tz":-240},"subject":"Partition swift pollster resources by tenant","message":"Partition swift pollster resources by tenant\n\nSince the latest discovery change, Swift pollsters on different\nagents only decide which who should poll. Most of the time there\u0027s\nonly one endpoint, so only one agent gets to do any work.\n\nThis patch fixes this by introducing a new TenantDiscovery, which\nenables Swift (and other in the future) pollsters to partition the\nset of keystone tenants among them and then each poll the samples\nfor their assigned subset of tenants.\n\nCloses-Bug: #1365351\nChange-Id: Iba4a3b91d5ee978213fdd6fcf8bb62b315324a52\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ceilometer/commit/161b380d8f034e0ed048aaa3188c34495d823927"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ceilometer/commit/161b380d8f034e0ed048aaa3188c34495d823927"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"254d58b52fcb6882f9c357ce91200c45c786d591","is_merged_in_target_branch":false,"change_id":"I9875f15c4be25c2ac125458caa9a09927afdf3b2","change_number":121103,"patch_set_number":1,"change_status":"MERGED"}],"branch":"refs/heads/master"},"88c1c483e24aa80e4f82951b2c325fe1f5411c61":{"kind":"REWORK","_number":2,"created":"2014-09-15 10:53:20.000000000","uploader":{"_account_id":8052,"name":"Nejc Saje","email":"nejc@saje.info","username":"nsaje"},"ref":"refs/changes/04/121104/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ceilometer","ref":"refs/changes/04/121104/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ceilometer refs/changes/04/121104/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ceilometer refs/changes/04/121104/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ceilometer refs/changes/04/121104/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ceilometer refs/changes/04/121104/2"}}},"commit":{"parents":[{"commit":"b0116dbb22535725492f738fdf2a2d53ec62efe3","subject":"Use central agent manager\u0027s keystone token in discoveries","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ceilometer/commit/b0116dbb22535725492f738fdf2a2d53ec62efe3"}]}],"author":{"name":"Nejc Saje","email":"nsaje@redhat.com","date":"2014-09-09 07:44:35.000000000","tz":-240},"committer":{"name":"Nejc Saje","email":"nsaje@redhat.com","date":"2014-09-15 10:53:05.000000000","tz":-240},"subject":"Partition swift pollster resources by tenant","message":"Partition swift pollster resources by tenant\n\nSince the latest discovery change, Swift pollsters on different\nagents only decide which who should poll. Most of the time there\u0027s\nonly one endpoint, so only one agent gets to do any work.\n\nThis patch fixes this by introducing a new TenantDiscovery, which\nenables Swift (and other in the future) pollsters to partition the\nset of keystone tenants among them and then each poll the samples\nfor their assigned subset of tenants.\n\nCloses-Bug: #1365351\nChange-Id: Iba4a3b91d5ee978213fdd6fcf8bb62b315324a52\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ceilometer/commit/88c1c483e24aa80e4f82951b2c325fe1f5411c61"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ceilometer/commit/88c1c483e24aa80e4f82951b2c325fe1f5411c61"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"b0116dbb22535725492f738fdf2a2d53ec62efe3","is_merged_in_target_branch":true,"change_id":"I9875f15c4be25c2ac125458caa9a09927afdf3b2","change_number":121103,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/master"},"87afc5ada176d2062bc0cc81c248d6813941a7d4":{"kind":"REWORK","_number":3,"created":"2014-09-15 12:34:53.000000000","uploader":{"_account_id":8052,"name":"Nejc Saje","email":"nejc@saje.info","username":"nsaje"},"ref":"refs/changes/04/121104/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ceilometer","ref":"refs/changes/04/121104/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ceilometer refs/changes/04/121104/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ceilometer refs/changes/04/121104/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ceilometer refs/changes/04/121104/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ceilometer refs/changes/04/121104/3"}}},"commit":{"parents":[{"commit":"b0116dbb22535725492f738fdf2a2d53ec62efe3","subject":"Use central agent manager\u0027s keystone token in discoveries","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ceilometer/commit/b0116dbb22535725492f738fdf2a2d53ec62efe3"}]}],"author":{"name":"Nejc Saje","email":"nsaje@redhat.com","date":"2014-09-09 07:44:35.000000000","tz":-240},"committer":{"name":"Nejc Saje","email":"nsaje@redhat.com","date":"2014-09-15 12:34:39.000000000","tz":-240},"subject":"Partition swift pollster resources by tenant","message":"Partition swift pollster resources by tenant\n\nSince the latest discovery change, Swift pollsters on different\nagents only decide which who should poll. Most of the time there\u0027s\nonly one endpoint, so only one agent gets to do any work.\n\nThis patch fixes this by introducing a new TenantDiscovery, which\nenables Swift (and other in the future) pollsters to partition the\nset of keystone tenants among them and then each poll the samples\nfor their assigned subset of tenants.\n\nCloses-Bug: #1365351\nChange-Id: Iba4a3b91d5ee978213fdd6fcf8bb62b315324a52\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ceilometer/commit/87afc5ada176d2062bc0cc81c248d6813941a7d4"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ceilometer/commit/87afc5ada176d2062bc0cc81c248d6813941a7d4"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"b0116dbb22535725492f738fdf2a2d53ec62efe3","is_merged_in_target_branch":true,"change_id":"I9875f15c4be25c2ac125458caa9a09927afdf3b2","change_number":121103,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
