)]}'
{"ceilometer/objectstore/swift_middleware.py":[{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"a98435f52715a9be78874943ad142959937c28cc","unresolved":false,"context_lines":[{"line_number":145,"context_line":"            return iter_response(iterable)"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"    def publish_sample(self, env, bytes_received, bytes_sent):"},{"line_number":148,"context_line":"        path \u003d urllib2.quote(env.get(\u0027SCRIPT_NAME\u0027, \u0027\u0027) + env[\u0027PATH_INFO\u0027])"},{"line_number":149,"context_line":"        method \u003d env[\u0027REQUEST_METHOD\u0027]"},{"line_number":150,"context_line":"        headers \u003d {}"},{"line_number":151,"context_line":"        for header in env:"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa98f980_086dbecc","line":148,"updated":"2014-09-18 08:01:57.000000000","message":"I know nothing about swift URL format, but why adding SCRIPT_NAME?","commit_id":"04606545860f1860df2af8fc36217103fd19b75b"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"0b98faa671a84d7153bb18920b94a30f58c30027","unresolved":false,"context_lines":[{"line_number":145,"context_line":"            return iter_response(iterable)"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"    def publish_sample(self, env, bytes_received, bytes_sent):"},{"line_number":148,"context_line":"        path \u003d urllib2.quote(env.get(\u0027SCRIPT_NAME\u0027, \u0027\u0027) + env[\u0027PATH_INFO\u0027])"},{"line_number":149,"context_line":"        method \u003d env[\u0027REQUEST_METHOD\u0027]"},{"line_number":150,"context_line":"        headers \u003d {}"},{"line_number":151,"context_line":"        for header in env:"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa98f980_beb229e3","line":148,"in_reply_to":"fa98f980_086dbecc","updated":"2014-09-18 11:43:29.000000000","message":"i think i was playing with code to see what was throwing error... the above was to move it more inline with original swift code: https://github.com/openstack/swift/blob/master/swift/common/swob.py#L873-L876\n\ni think we can remove it but it does reflect how swift middleware originally worked when we imported swift tarball","commit_id":"04606545860f1860df2af8fc36217103fd19b75b"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"f89dd8183c87d7a992803a9a0e99702ce9aafb43","unresolved":false,"context_lines":[{"line_number":145,"context_line":"            return iter_response(iterable)"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"    def publish_sample(self, env, bytes_received, bytes_sent):"},{"line_number":148,"context_line":"        path \u003d urllib2.quote(env.get(\u0027SCRIPT_NAME\u0027, \u0027\u0027) + env[\u0027PATH_INFO\u0027])"},{"line_number":149,"context_line":"        method \u003d env[\u0027REQUEST_METHOD\u0027]"},{"line_number":150,"context_line":"        headers \u003d {}"},{"line_number":151,"context_line":"        for header in env:"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa98f980_780b607d","line":148,"in_reply_to":"fa98f980_b5c23184","updated":"2014-09-19 02:43:15.000000000","message":"i think it may ultimately be the same but let\u0027s pull it out... to be honest, i\u0027m not sure what the original intent was but based on other middleware, they don\u0027t really use split_path from swob (which adds script_name)...","commit_id":"04606545860f1860df2af8fc36217103fd19b75b"},{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"232f10ed2dbf90b9e26425e1857ab41840e05844","unresolved":false,"context_lines":[{"line_number":145,"context_line":"            return iter_response(iterable)"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"    def publish_sample(self, env, bytes_received, bytes_sent):"},{"line_number":148,"context_line":"        path \u003d urllib2.quote(env.get(\u0027SCRIPT_NAME\u0027, \u0027\u0027) + env[\u0027PATH_INFO\u0027])"},{"line_number":149,"context_line":"        method \u003d env[\u0027REQUEST_METHOD\u0027]"},{"line_number":150,"context_line":"        headers \u003d {}"},{"line_number":151,"context_line":"        for header in env:"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa98f980_b5c23184","line":148,"in_reply_to":"fa98f980_beb229e3","updated":"2014-09-19 01:10:11.000000000","message":"I\u0027m not sure whether we should align with http://docs.openstack.org/developer/swift/development_middleware.html#creating-your-own-middleware.\n\nJust wondering if we have SCRIPT_NAME encoded in the path, should we change Ln161 where parsing the path?","commit_id":"04606545860f1860df2af8fc36217103fd19b75b"}]}