)]}'
{"ceilometer/transformer/conversions.py":[{"author":{"_account_id":8052,"name":"Nejc Saje","email":"nejc@saje.info","username":"nsaje"},"change_message_id":"7d4224f2036d840e4b5b64719e1d2b2649128ad5","unresolved":false,"context_lines":[{"line_number":128,"context_line":"            # so that the current volume gives a lower bound on growth"},{"line_number":129,"context_line":"            volume_delta \u003d s.volume - prev_volume"},{"line_number":130,"context_line":"            if s.type \u003d\u003d sample.TYPE_CUMULATIVE and prev_volume \u003e s.volume:"},{"line_number":131,"context_line":"                volume_delta \u003d s.volume"},{"line_number":132,"context_line":"            if s.type \u003d\u003d sample.TYPE_DELTA:"},{"line_number":133,"context_line":"                volume_delta \u003d s.volume"},{"line_number":134,"context_line":"            rate_of_change \u003d ((1.0 * volume_delta / time_delta)"}],"source_content_type":"text/x-python","patch_set":1,"id":"da9df570_78929e58","line":131,"updated":"2014-09-23 09:04:50.000000000","message":"was this supposed to be s.volume - prev_volume?","commit_id":"333dacedb8bc55aebe598201e185e5065257c7f0"},{"author":{"_account_id":8052,"name":"Nejc Saje","email":"nejc@saje.info","username":"nsaje"},"change_message_id":"dfcc0e9e3b23a44d5ffb19677504726bc2ab872a","unresolved":false,"context_lines":[{"line_number":128,"context_line":"            # so that the current volume gives a lower bound on growth"},{"line_number":129,"context_line":"            volume_delta \u003d s.volume - prev_volume"},{"line_number":130,"context_line":"            if s.type \u003d\u003d sample.TYPE_CUMULATIVE and prev_volume \u003e s.volume:"},{"line_number":131,"context_line":"                volume_delta \u003d s.volume"},{"line_number":132,"context_line":"            if s.type \u003d\u003d sample.TYPE_DELTA:"},{"line_number":133,"context_line":"                volume_delta \u003d s.volume"},{"line_number":134,"context_line":"            rate_of_change \u003d ((1.0 * volume_delta / time_delta)"}],"source_content_type":"text/x-python","patch_set":1,"id":"da9df570_b8af9d93","line":131,"in_reply_to":"da9df570_6e48142e","updated":"2014-09-23 14:28:30.000000000","message":"Ah, yes. It just confused me because both if statements have the same body. Why not combine them with an \u0027or\u0027? And could you please add the reasoning for your patch in the comment on L128?","commit_id":"333dacedb8bc55aebe598201e185e5065257c7f0"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"1cedb732eaaa9089c07b36d0d4300976a15347af","unresolved":false,"context_lines":[{"line_number":128,"context_line":"            # so that the current volume gives a lower bound on growth"},{"line_number":129,"context_line":"            volume_delta \u003d s.volume - prev_volume"},{"line_number":130,"context_line":"            if s.type \u003d\u003d sample.TYPE_CUMULATIVE and prev_volume \u003e s.volume:"},{"line_number":131,"context_line":"                volume_delta \u003d s.volume"},{"line_number":132,"context_line":"            if s.type \u003d\u003d sample.TYPE_DELTA:"},{"line_number":133,"context_line":"                volume_delta \u003d s.volume"},{"line_number":134,"context_line":"            rate_of_change \u003d ((1.0 * volume_delta / time_delta)"}],"source_content_type":"text/x-python","patch_set":1,"id":"da9df570_6e48142e","line":131,"in_reply_to":"da9df570_78929e58","updated":"2014-09-23 10:25:48.000000000","message":"Previously, it is s.volume also, I think I have not changed the behaviour when type is cumulative.\n\nI choose to modify the code because I think such code is a bit complicated, not so straightforward since DELTA is implicit:\n\n            volume_delta \u003d (s.volume - prev_volume\n                            if ((prev_volume \u003c\u003d s.volume and\n                                 s.type \u003d\u003d sample.TYPE_CUMULATIVE) or\n                                s.type \u003d\u003d sample.TYPE_GAUGE)\n                            else s.volume)\n\nmeanwhile, they are both 5 lines","commit_id":"333dacedb8bc55aebe598201e185e5065257c7f0"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"f6e40fa1a93a774abb264e5bc1d805104f6d455d","unresolved":false,"context_lines":[{"line_number":128,"context_line":"            # so that the current volume gives a lower bound on growth"},{"line_number":129,"context_line":"            volume_delta \u003d s.volume - prev_volume"},{"line_number":130,"context_line":"            if s.type \u003d\u003d sample.TYPE_CUMULATIVE and prev_volume \u003e s.volume:"},{"line_number":131,"context_line":"                volume_delta \u003d s.volume"},{"line_number":132,"context_line":"            if s.type \u003d\u003d sample.TYPE_DELTA:"},{"line_number":133,"context_line":"                volume_delta \u003d s.volume"},{"line_number":134,"context_line":"            rate_of_change \u003d ((1.0 * volume_delta / time_delta)"}],"source_content_type":"text/x-python","patch_set":1,"id":"da9df570_56e10fcf","line":131,"in_reply_to":"da9df570_b8af9d93","updated":"2014-09-24 03:59:05.000000000","message":"As I said, I think complicated logical expression is not very easy to understand. Meanwhile, it is not convenient to comment on different branch.\n\nDone.","commit_id":"333dacedb8bc55aebe598201e185e5065257c7f0"},{"author":{"_account_id":8052,"name":"Nejc Saje","email":"nejc@saje.info","username":"nsaje"},"change_message_id":"913031b9d8adcb3359ef437f758dc347a9bafd5d","unresolved":false,"context_lines":[{"line_number":131,"context_line":"                volume_delta \u003d s.volume"},{"line_number":132,"context_line":"            # Sample which type is DELTA should not calculate delta again."},{"line_number":133,"context_line":"            if s.type \u003d\u003d sample.TYPE_DELTA:"},{"line_number":134,"context_line":"                volume_delta \u003d s.volume"},{"line_number":135,"context_line":"            rate_of_change \u003d ((1.0 * volume_delta / time_delta)"},{"line_number":136,"context_line":"                              if time_delta else 0.0)"},{"line_number":137,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"da9df570_ce163bf1","line":134,"updated":"2014-09-24 11:49:24.000000000","message":"What about this more pythonic and DRY way\n\n cumulative_reset \u003d s.type \u003d\u003d sample.TYPE_CUMULATIVE and prev_volume \u003e s.volume\n existing_delta \u003d s.type \u003d\u003d sample.TYPE_DELTA\n volume_delta \u003d s.volume - prev_volume\n                if not (cumulative_reset or existing_delta)\n                else s.volume\n\n? Sorry if I\u0027m being nitpicky but I must admit I don\u0027t like seeing the same branch body twice at all :-).","commit_id":"cb886ebd0a796b4044cba06c70b0a9be6a1ea91f"}]}