)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8052,"name":"Nejc Saje","email":"nejc@saje.info","username":"nsaje"},"change_message_id":"caf0394cf3ddbcf333e6959641a168ed9f4ad88a","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"dbsync: Acknowledge \u0027metering_connection\u0027 option"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Support \u0027metering_connection\u0027 option in ceilometer-dbsync."},{"line_number":10,"context_line":"Closes-Bug: #1373269"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I02f439ae89f265e088ca539ab355561d1b7b1c31"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"da9df570_345abaf3","line":9,"updated":"2014-09-24 13:12:43.000000000","message":"Can you put a space between these two lines? Otherwise I think some scripts can have issues.","commit_id":"673502eecc7fba53bb5ce697cc57ce2638dfc057"},{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"bc3d8edae481581da637a599c119784a1b5a3c37","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"dbsync: Acknowledge \u0027metering_connection\u0027 option"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Support \u0027metering_connection\u0027 option in ceilometer-dbsync."},{"line_number":10,"context_line":"Closes-Bug: #1373269"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I02f439ae89f265e088ca539ab355561d1b7b1c31"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"da9df570_ce7fe4a9","line":9,"in_reply_to":"da9df570_345abaf3","updated":"2014-09-26 00:56:41.000000000","message":"Done","commit_id":"673502eecc7fba53bb5ce697cc57ce2638dfc057"}],"ceilometer/cmd/storage.py":[{"author":{"_account_id":3012,"name":"Dina Belova","email":"dbelova@mirantis.com","username":"dbelova"},"change_message_id":"f239e63f0bf79401a58137aa20c68f32b23641ac","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"def dbsync():"},{"line_number":31,"context_line":"    service.prepare_service()"},{"line_number":32,"context_line":"    storage.get_connection_from_config(cfg.CONF, \u0027metering\u0027).upgrade()"},{"line_number":33,"context_line":"    storage.get_connection_from_config(cfg.CONF, \u0027alarm\u0027).upgrade()"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"da9df570_c0032c40","line":32,"updated":"2014-09-26 08:23:36.000000000","message":"this change actually does nothing, as purpose \u0027metering\u0027 or \u0027alarm\u0027 is needed only to create namespace where to grab connection from, but the \u0027ceilometer.metering.storage\u0027 is the default one: https://github.com/openstack/ceilometer/blob/master/ceilometer/storage/__init__.py#L77\n\nI\u0027m not against the explicit par at passing, but this does nothing","commit_id":"7beccc684d74472949d54b14b72d29ce74479931"},{"author":{"_account_id":3012,"name":"Dina Belova","email":"dbelova@mirantis.com","username":"dbelova"},"change_message_id":"36da686e599b841d183d0d1502a3ec542bf38ede","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"def dbsync():"},{"line_number":31,"context_line":"    service.prepare_service()"},{"line_number":32,"context_line":"    storage.get_connection_from_config(cfg.CONF, \u0027metering\u0027).upgrade()"},{"line_number":33,"context_line":"    storage.get_connection_from_config(cfg.CONF, \u0027alarm\u0027).upgrade()"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"da9df570_068e2c79","line":32,"in_reply_to":"da9df570_a371d2a9","updated":"2014-09-26 09:11:34.000000000","message":"a-ha, okay, misread the code :)","commit_id":"7beccc684d74472949d54b14b72d29ce74479931"},{"author":{"_account_id":8052,"name":"Nejc Saje","email":"nejc@saje.info","username":"nsaje"},"change_message_id":"5dd4357e614503f41d31d868ae701f378f89ca36","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"def dbsync():"},{"line_number":31,"context_line":"    service.prepare_service()"},{"line_number":32,"context_line":"    storage.get_connection_from_config(cfg.CONF, \u0027metering\u0027).upgrade()"},{"line_number":33,"context_line":"    storage.get_connection_from_config(cfg.CONF, \u0027alarm\u0027).upgrade()"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"da9df570_a371d2a9","line":32,"in_reply_to":"da9df570_c0032c40","updated":"2014-09-26 08:37:21.000000000","message":"Not true, without this patch, config option metering_connection is ignored. https://github.com/openstack/ceilometer/blob/master/ceilometer/storage/__init__.py#L81","commit_id":"7beccc684d74472949d54b14b72d29ce74479931"}]}