)]}'
{"ceilometer/agent.py":[{"author":{"_account_id":8052,"name":"Nejc Saje","email":"nejc@saje.info","username":"nsaje"},"change_message_id":"05036fc2f0d03c68c6b91748e9a4689b96643e05","unresolved":false,"context_lines":[{"line_number":89,"context_line":"            self.publishers[pipeline.source.name] \u003d publish_context"},{"line_number":90,"context_line":"        else:"},{"line_number":91,"context_line":"            # this is a multi-sink source"},{"line_number":92,"context_line":"            self.publishers[pipeline.source.name].add_pipelines([pipeline])"},{"line_number":93,"context_line":"        self.pollster_matches.update([(pipeline.source, pollster)])"},{"line_number":94,"context_line":"        key \u003d Resources.key(pipeline.source, pollster)"},{"line_number":95,"context_line":"        self.resources[key].setup(pipeline)"}],"source_content_type":"text/x-python","patch_set":1,"id":"da9df570_5bae6be7","line":92,"updated":"2014-09-25 13:01:36.000000000","message":"Executed in both branches, could we put it outside and remove the else branch?","commit_id":"84b339ca618a8d7ae5841b4bac8885b3287f72e1"},{"author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"change_message_id":"db5db8956074582a46e380f53e5814efffd08cf0","unresolved":false,"context_lines":[{"line_number":89,"context_line":"            self.publishers[pipeline.source.name] \u003d publish_context"},{"line_number":90,"context_line":"        else:"},{"line_number":91,"context_line":"            # this is a multi-sink source"},{"line_number":92,"context_line":"            self.publishers[pipeline.source.name].add_pipelines([pipeline])"},{"line_number":93,"context_line":"        self.pollster_matches.update([(pipeline.source, pollster)])"},{"line_number":94,"context_line":"        key \u003d Resources.key(pipeline.source, pollster)"},{"line_number":95,"context_line":"        self.resources[key].setup(pipeline)"}],"source_content_type":"text/x-python","patch_set":1,"id":"da9df570_ca62823d","line":92,"in_reply_to":"da9df570_5bae6be7","updated":"2014-09-25 14:14:02.000000000","message":"Good catch! Done in latest.","commit_id":"84b339ca618a8d7ae5841b4bac8885b3287f72e1"},{"author":{"_account_id":8052,"name":"Nejc Saje","email":"nejc@saje.info","username":"nsaje"},"change_message_id":"31f7930a5672617dd3d3be43d5e6a225fb4b9fc2","unresolved":false,"context_lines":[{"line_number":69,"context_line":"    def __init__(self, agent_manager):"},{"line_number":70,"context_line":"        self.manager \u003d agent_manager"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"        # elements of the Cartesian product of pipelines X pollsters"},{"line_number":73,"context_line":"        # with a common interval"},{"line_number":74,"context_line":"        self.pollster_matches \u003d set()"},{"line_number":75,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"da9df570_dd66b7ec","line":72,"updated":"2014-09-26 07:16:19.000000000","message":"Would it be more clear if it said \u0027... of sources X pollsters\u0027?","commit_id":"9e8ee681055f3561efbbfed4215b42df985e4183"},{"author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"change_message_id":"868c7ecc3fd89487882f3ff8132e52b97db44bbc","unresolved":false,"context_lines":[{"line_number":69,"context_line":"    def __init__(self, agent_manager):"},{"line_number":70,"context_line":"        self.manager \u003d agent_manager"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"        # elements of the Cartesian product of pipelines X pollsters"},{"line_number":73,"context_line":"        # with a common interval"},{"line_number":74,"context_line":"        self.pollster_matches \u003d set()"},{"line_number":75,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"da9df570_6ce437e1","line":72,"in_reply_to":"da9df570_dd66b7ec","updated":"2014-09-26 11:20:56.000000000","message":"Fair point, fixed in latest.","commit_id":"9e8ee681055f3561efbbfed4215b42df985e4183"},{"author":{"_account_id":8052,"name":"Nejc Saje","email":"nejc@saje.info","username":"nsaje"},"change_message_id":"4170f25c29620a1e15c3f4523f2b90c5e6670299","unresolved":false,"context_lines":[{"line_number":87,"context_line":"                self.manager.context)"},{"line_number":88,"context_line":"            publish_context.add_pipelines([pipeline])"},{"line_number":89,"context_line":"            self.publishers[pipeline.source.name] \u003d publish_context"},{"line_number":90,"context_line":"        else:"},{"line_number":91,"context_line":"            # this is a multi-sink source"},{"line_number":92,"context_line":"            self.publishers[pipeline.source.name].add_pipelines([pipeline])"},{"line_number":93,"context_line":"        self.pollster_matches.update([(pipeline.source, pollster)])"}],"source_content_type":"text/x-python","patch_set":3,"id":"da9df570_57bc60dc","line":90,"updated":"2014-09-26 11:32:30.000000000","message":"How come this branch was re-added? :-)","commit_id":"5fbfba22d8c3bb3479b93d87321849975d39f447"},{"author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"change_message_id":"0fdd693b3349d3855ad6b0c2b316453a07bc0946","unresolved":false,"context_lines":[{"line_number":87,"context_line":"                self.manager.context)"},{"line_number":88,"context_line":"            publish_context.add_pipelines([pipeline])"},{"line_number":89,"context_line":"            self.publishers[pipeline.source.name] \u003d publish_context"},{"line_number":90,"context_line":"        else:"},{"line_number":91,"context_line":"            # this is a multi-sink source"},{"line_number":92,"context_line":"            self.publishers[pipeline.source.name].add_pipelines([pipeline])"},{"line_number":93,"context_line":"        self.pollster_matches.update([(pipeline.source, pollster)])"}],"source_content_type":"text/x-python","patch_set":3,"id":"da9df570_b7b90c7b","line":90,"in_reply_to":"da9df570_57bc60dc","updated":"2014-09-26 11:44:45.000000000","message":"Magic! ... the branch that refuses to die ;)","commit_id":"5fbfba22d8c3bb3479b93d87321849975d39f447"}],"ceilometer/tests/agentbase.py":[{"author":{"_account_id":8052,"name":"Nejc Saje","email":"nejc@saje.info","username":"nsaje"},"change_message_id":"31f7930a5672617dd3d3be43d5e6a225fb4b9fc2","unresolved":false,"context_lines":[{"line_number":592,"context_line":"        amalgamated_resources \u003d set([\u0027test://\u0027, \u0027another://\u0027])"},{"line_number":593,"context_line":"        self.assertEqual(amalgamated_resources,"},{"line_number":594,"context_line":"                         set(self.Pollster.samples[0][1]))"},{"line_number":595,"context_line":"        for pipe_line in self.mgr.pipeline_manager.pipelines:"},{"line_number":596,"context_line":"            self.assertEqual(1, len(pipe_line.publishers[0].samples))"},{"line_number":597,"context_line":"            published \u003d pipe_line.publishers[0].samples[0]"},{"line_number":598,"context_line":"            self.assertEqual(amalgamated_resources,"}],"source_content_type":"text/x-python","patch_set":2,"id":"da9df570_7d606c01","side":"PARENT","line":595,"updated":"2014-09-26 07:16:19.000000000","message":"Couldn\u0027t we still check that the correct samples were published for individual pipelines? Or is it redundant?","commit_id":"94ebf0042925c93f5bc178df18cd4d8c8491b0d3"},{"author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"change_message_id":"868c7ecc3fd89487882f3ff8132e52b97db44bbc","unresolved":false,"context_lines":[{"line_number":592,"context_line":"        amalgamated_resources \u003d set([\u0027test://\u0027, \u0027another://\u0027])"},{"line_number":593,"context_line":"        self.assertEqual(amalgamated_resources,"},{"line_number":594,"context_line":"                         set(self.Pollster.samples[0][1]))"},{"line_number":595,"context_line":"        for pipe_line in self.mgr.pipeline_manager.pipelines:"},{"line_number":596,"context_line":"            self.assertEqual(1, len(pipe_line.publishers[0].samples))"},{"line_number":597,"context_line":"            published \u003d pipe_line.publishers[0].samples[0]"},{"line_number":598,"context_line":"            self.assertEqual(amalgamated_resources,"}],"source_content_type":"text/x-python","patch_set":2,"id":"da9df570_ccf9a381","side":"PARENT","line":595,"in_reply_to":"da9df570_7d606c01","updated":"2014-09-26 11:20:56.000000000","message":"Good catch, I\u0027ve added assertions along those lines to latest.","commit_id":"94ebf0042925c93f5bc178df18cd4d8c8491b0d3"},{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"03e1f37fa5b65b7b56d417f35b21777253eb91e5","unresolved":false,"context_lines":[{"line_number":594,"context_line":"        samples \u003d self.Pollster.samples"},{"line_number":595,"context_line":"        if samples[0][1] \u003d\u003d [\u0027test://\u0027]:"},{"line_number":596,"context_line":"            self.assertEqual([\u0027another://\u0027], samples[1][1])"},{"line_number":597,"context_line":"        elif self.Pollster.samples[0][1] \u003d\u003d [\u0027another://\u0027]:"},{"line_number":598,"context_line":"            self.assertEqual([\u0027test://\u0027], samples[1][1])"},{"line_number":599,"context_line":"        else:"},{"line_number":600,"context_line":"            self.fail(\u0027unexpected sample resources %s\u0027 % samples)"}],"source_content_type":"text/x-python","patch_set":2,"id":"da9df570_c36976bf","line":597,"updated":"2014-09-26 09:00:25.000000000","message":"why can\u0027t direct use samples as Ln595?","commit_id":"9e8ee681055f3561efbbfed4215b42df985e4183"},{"author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"change_message_id":"868c7ecc3fd89487882f3ff8132e52b97db44bbc","unresolved":false,"context_lines":[{"line_number":594,"context_line":"        samples \u003d self.Pollster.samples"},{"line_number":595,"context_line":"        if samples[0][1] \u003d\u003d [\u0027test://\u0027]:"},{"line_number":596,"context_line":"            self.assertEqual([\u0027another://\u0027], samples[1][1])"},{"line_number":597,"context_line":"        elif self.Pollster.samples[0][1] \u003d\u003d [\u0027another://\u0027]:"},{"line_number":598,"context_line":"            self.assertEqual([\u0027test://\u0027], samples[1][1])"},{"line_number":599,"context_line":"        else:"},{"line_number":600,"context_line":"            self.fail(\u0027unexpected sample resources %s\u0027 % samples)"}],"source_content_type":"text/x-python","patch_set":2,"id":"da9df570_4c2db3fd","line":597,"in_reply_to":"da9df570_c36976bf","updated":"2014-09-26 11:20:56.000000000","message":"Good catch, that\u0027s what I\u0027d intended to do!","commit_id":"9e8ee681055f3561efbbfed4215b42df985e4183"},{"author":{"_account_id":8052,"name":"Nejc Saje","email":"nejc@saje.info","username":"nsaje"},"change_message_id":"21f6540c0ccfb106c9a3c149fe727022e9effa57","unresolved":false,"context_lines":[{"line_number":572,"context_line":"    def test_multiple_pipelines_different_static_resources(self):"},{"line_number":573,"context_line":"        # assert that the individual lists of static resources for each"},{"line_number":574,"context_line":"        # pipeline with a common interval is passed to individual"},{"line_number":575,"context_line":"        # pollsters matching each pipeline"},{"line_number":576,"context_line":"        self.pipeline_cfg[0][\u0027resources\u0027] \u003d [\u0027test://\u0027]"},{"line_number":577,"context_line":"        self.pipeline_cfg.append({"},{"line_number":578,"context_line":"            \u0027name\u0027: \"another_pipeline\","}],"source_content_type":"text/x-python","patch_set":5,"id":"da9df570_f294828c","line":575,"updated":"2014-09-26 11:53:46.000000000","message":"Do you think it would be worth extracting most of this method into a helper method, then have two scenarios: 1st the same as currently, 2nd, instead of pipelines having different static resources, they\u0027d have different discovery configurations?","commit_id":"64a5f4ecfb84edd9bded7e9966801192a1d8d25b"},{"author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"change_message_id":"f6828251da283fb3dde985d5a80a3b93c90431d2","unresolved":false,"context_lines":[{"line_number":572,"context_line":"    def test_multiple_pipelines_different_static_resources(self):"},{"line_number":573,"context_line":"        # assert that the individual lists of static resources for each"},{"line_number":574,"context_line":"        # pipeline with a common interval is passed to individual"},{"line_number":575,"context_line":"        # pollsters matching each pipeline"},{"line_number":576,"context_line":"        self.pipeline_cfg[0][\u0027resources\u0027] \u003d [\u0027test://\u0027]"},{"line_number":577,"context_line":"        self.pipeline_cfg.append({"},{"line_number":578,"context_line":"            \u0027name\u0027: \"another_pipeline\","}],"source_content_type":"text/x-python","patch_set":5,"id":"da9df570_264fab6c","line":575,"in_reply_to":"da9df570_32e28a2f","updated":"2014-09-26 12:29:21.000000000","message":"Great idea, thanks! Fixed in latest.","commit_id":"64a5f4ecfb84edd9bded7e9966801192a1d8d25b"},{"author":{"_account_id":8052,"name":"Nejc Saje","email":"nejc@saje.info","username":"nsaje"},"change_message_id":"2b1142562cc206ef905947b55c9257557c5a7460","unresolved":false,"context_lines":[{"line_number":572,"context_line":"    def test_multiple_pipelines_different_static_resources(self):"},{"line_number":573,"context_line":"        # assert that the individual lists of static resources for each"},{"line_number":574,"context_line":"        # pipeline with a common interval is passed to individual"},{"line_number":575,"context_line":"        # pollsters matching each pipeline"},{"line_number":576,"context_line":"        self.pipeline_cfg[0][\u0027resources\u0027] \u003d [\u0027test://\u0027]"},{"line_number":577,"context_line":"        self.pipeline_cfg.append({"},{"line_number":578,"context_line":"            \u0027name\u0027: \"another_pipeline\","}],"source_content_type":"text/x-python","patch_set":5,"id":"da9df570_32e28a2f","line":575,"in_reply_to":"da9df570_f294828c","updated":"2014-09-26 11:55:19.000000000","message":"Or, on second thought, it could remain a single method, but we could add a different discovery to each pipeline as well, in addition to static resources (since they\u0027re combined anyway).","commit_id":"64a5f4ecfb84edd9bded7e9966801192a1d8d25b"}]}