)]}'
{"ceilometer/tests/objectstore/test_swift.py":[{"author":{"_account_id":3012,"name":"Dina Belova","email":"dbelova@mirantis.com","username":"dbelova"},"change_message_id":"1839f5e48f49d13cd17c9c67b3a45b0f66503085","unresolved":false,"context_lines":[{"line_number":191,"context_line":"        self.assertEqual(expected, mock_method.call_args_list)"},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"    def test_get_endpoint(self):"},{"line_number":194,"context_line":"        raised_ex \u003d False"},{"line_number":195,"context_line":"        try:"},{"line_number":196,"context_line":"            self.pollster._get_endpoint(mock.Mock())"},{"line_number":197,"context_line":"        except Exception:"}],"source_content_type":"text/x-python","patch_set":1,"id":"da9df570_20edd8b7","line":194,"updated":"2014-09-26 08:14:39.000000000","message":"was trying to find more elegant way of this checking, but the only thing I can propose is to use less wide Exception definition. I suppose we can find the exception really raising in this case and check it\u0027s not raising, not just Exception.\n\nWhat do you think?","commit_id":"e23a90da2a8eec8b9826a048de8c85abc808139c"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"bb27f949db811394882f24b736a4deb736225a52","unresolved":false,"context_lines":[{"line_number":195,"context_line":"        try:"},{"line_number":196,"context_line":"            self.pollster._get_endpoint(mock.Mock())"},{"line_number":197,"context_line":"        except Exception:"},{"line_number":198,"context_line":"            raised_ex \u003d True"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"        self.assertFalse(raised_ex)"},{"line_number":201,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"da9df570_46d5941a","line":198,"updated":"2014-09-26 09:20:39.000000000","message":"just do\n\nelse:\n   self.fail(...)\n\nNo need for raised_ex variable","commit_id":"e23a90da2a8eec8b9826a048de8c85abc808139c"},{"author":{"_account_id":3012,"name":"Dina Belova","email":"dbelova@mirantis.com","username":"dbelova"},"change_message_id":"b6357cb92a7cc935428d935b0fbea567dc9a778b","unresolved":false,"context_lines":[{"line_number":195,"context_line":"        try:"},{"line_number":196,"context_line":"            self.pollster._get_endpoint(mock.Mock())"},{"line_number":197,"context_line":"        except Exception:"},{"line_number":198,"context_line":"            raised_ex \u003d True"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"        self.assertFalse(raised_ex)"},{"line_number":201,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"da9df570_c6cb4451","line":198,"in_reply_to":"da9df570_46d5941a","updated":"2014-09-26 09:25:22.000000000","message":"a-ha, so there is more elegant variant :)","commit_id":"e23a90da2a8eec8b9826a048de8c85abc808139c"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"4a6f2d903125c3c2384cf667cfb5674c5f600f14","unresolved":false,"context_lines":[{"line_number":190,"context_line":"                    for t in ASSIGNED_TENANTS]"},{"line_number":191,"context_line":"        self.assertEqual(expected, mock_method.call_args_list)"},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"    def test_get_endpoint(self):"},{"line_number":194,"context_line":"        try:"},{"line_number":195,"context_line":"            self.pollster._get_endpoint(mock.Mock())"},{"line_number":196,"context_line":"        except Exception:"}],"source_content_type":"text/x-python","patch_set":2,"id":"da9df570_b5273f11","line":193,"updated":"2014-09-26 15:48:52.000000000","message":"i\u0027m not sure what these tests are doing but they pass with or without your change.\n\ni don\u0027t think you need to add any tests to be honest.","commit_id":"b88cce7fb166b3cc309e2f252e17fb8f4955ee75"},{"author":{"_account_id":12193,"name":"Hisashi Osanai","email":"osanai.hisashi@jp.fujitsu.com","username":"ho"},"change_message_id":"d1002c9eeb6246ed4475fd4c5633a32632cbf6c5","unresolved":false,"context_lines":[{"line_number":190,"context_line":"                    for t in ASSIGNED_TENANTS]"},{"line_number":191,"context_line":"        self.assertEqual(expected, mock_method.call_args_list)"},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"    def test_get_endpoint(self):"},{"line_number":194,"context_line":"        try:"},{"line_number":195,"context_line":"            self.pollster._get_endpoint(mock.Mock())"},{"line_number":196,"context_line":"        except Exception:"}],"source_content_type":"text/x-python","patch_set":2,"id":"baa201ad_25182484","line":193,"in_reply_to":"da9df570_b5273f11","updated":"2014-09-29 11:45:51.000000000","message":"Thanks for the review. I recognized that this unit test doesn\u0027t have a meaning for my change but I found out that there is no unit test clearly for the method _get_endpoint so I added.\nDone","commit_id":"b88cce7fb166b3cc309e2f252e17fb8f4955ee75"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"e7c44e8ca20c9004ddd970e2bd88747e3a3b2977","unresolved":false,"context_lines":[{"line_number":194,"context_line":"        try:"},{"line_number":195,"context_line":"            self.pollster._get_endpoint(mock.Mock())"},{"line_number":196,"context_line":"        except Exception:"},{"line_number":197,"context_line":"            self.fail(\u0027Raised an unexpected exception.\u0027)"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"    def test_get_endpoint_endpoint_notfound(self):"},{"line_number":200,"context_line":"        self.pollster._ENDPOINT \u003d None"}],"source_content_type":"text/x-python","patch_set":2,"id":"da9df570_06a54746","line":197,"updated":"2014-09-26 13:04:37.000000000","message":"If you do not expect it fail, there\u0027s no need to catch the exception at all. The test will fail if anything raises.","commit_id":"b88cce7fb166b3cc309e2f252e17fb8f4955ee75"},{"author":{"_account_id":12193,"name":"Hisashi Osanai","email":"osanai.hisashi@jp.fujitsu.com","username":"ho"},"change_message_id":"d1002c9eeb6246ed4475fd4c5633a32632cbf6c5","unresolved":false,"context_lines":[{"line_number":194,"context_line":"        try:"},{"line_number":195,"context_line":"            self.pollster._get_endpoint(mock.Mock())"},{"line_number":196,"context_line":"        except Exception:"},{"line_number":197,"context_line":"            self.fail(\u0027Raised an unexpected exception.\u0027)"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"    def test_get_endpoint_endpoint_notfound(self):"},{"line_number":200,"context_line":"        self.pollster._ENDPOINT \u003d None"}],"source_content_type":"text/x-python","patch_set":2,"id":"baa201ad_f757af24","line":197,"in_reply_to":"da9df570_06a54746","updated":"2014-09-29 11:45:51.000000000","message":"Thanks for the review. I wanted to express \"do not expect it fail\" in the code but your right we understand the meaning of this so I removed it.\nDone","commit_id":"b88cce7fb166b3cc309e2f252e17fb8f4955ee75"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"e7c44e8ca20c9004ddd970e2bd88747e3a3b2977","unresolved":false,"context_lines":[{"line_number":203,"context_line":"                side_effect\u003dself.fake_ks_service_catalog_url_for):"},{"line_number":204,"context_line":"            endpoint \u003d self.pollster._get_endpoint(self.manager.keystone)"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"        self.assertEqual(None, endpoint)"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"    def test_get_endpoint_only_once(self):"},{"line_number":209,"context_line":"        mock_url_for \u003d mock.MagicMock()"}],"source_content_type":"text/x-python","patch_set":2,"id":"da9df570_86b9377b","line":206,"updated":"2014-09-26 13:04:37.000000000","message":"assertIsNone","commit_id":"b88cce7fb166b3cc309e2f252e17fb8f4955ee75"},{"author":{"_account_id":12193,"name":"Hisashi Osanai","email":"osanai.hisashi@jp.fujitsu.com","username":"ho"},"change_message_id":"d1002c9eeb6246ed4475fd4c5633a32632cbf6c5","unresolved":false,"context_lines":[{"line_number":203,"context_line":"                side_effect\u003dself.fake_ks_service_catalog_url_for):"},{"line_number":204,"context_line":"            endpoint \u003d self.pollster._get_endpoint(self.manager.keystone)"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"        self.assertEqual(None, endpoint)"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"    def test_get_endpoint_only_once(self):"},{"line_number":209,"context_line":"        mock_url_for \u003d mock.MagicMock()"}],"source_content_type":"text/x-python","patch_set":2,"id":"baa201ad_3a267ebb","line":206,"in_reply_to":"da9df570_86b9377b","updated":"2014-09-29 11:45:51.000000000","message":"Thanks. I replaced it.\nDone","commit_id":"b88cce7fb166b3cc309e2f252e17fb8f4955ee75"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"a836f014e9bb2dee8130681892a7a1b30f13b882","unresolved":false,"context_lines":[{"line_number":190,"context_line":"                    for t in ASSIGNED_TENANTS]"},{"line_number":191,"context_line":"        self.assertEqual(expected, mock_method.call_args_list)"},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"    def test_get_endpoint(self):"},{"line_number":194,"context_line":"        self.pollster._get_endpoint(mock.Mock())"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"    def test_get_endpoint_endpoint_notfound(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"baa201ad_f0fb3545","line":193,"updated":"2014-09-29 13:03:52.000000000","message":"i prefer these tests be added in a separate patch since it\u0027s not related to bug","commit_id":"3b9e38c3b04f31f8c4cc6236bbb07fd88ebba9a1"}]}