)]}'
{"ceilometer/neutron_client.py":[{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"339abafbca9a0040ee08e176cdf3368363ba24b2","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        try:"},{"line_number":88,"context_line":"            resp \u003d self.client.list_vips()"},{"line_number":89,"context_line":"            return resp.get(\u0027vips\u0027)"},{"line_number":90,"context_line":"        except exceptions.NeutronClientException as e:"},{"line_number":91,"context_line":"            LOG.debug(\"Vip info not found due to %s\" % str(e))"},{"line_number":92,"context_line":"            return []"},{"line_number":93,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"baa201ad_0f1cde12","line":90,"updated":"2014-10-01 13:35:22.000000000","message":"this is the only solution i know of... my only comment is this would be better if it was a decorator similar to how we implemented @loggged.","commit_id":"9a409824ab9f7735d3a80b9e562ed088879a8da6"},{"author":{"_account_id":10987,"name":"Igor Degtiarov","username":"tovstun","inactive":true},"change_message_id":"f505d6c5d6aef5cc3cf6c26635f59ccafa7dab15","unresolved":false,"context_lines":[{"line_number":88,"context_line":"            resp \u003d self.client.list_vips()"},{"line_number":89,"context_line":"            return resp.get(\u0027vips\u0027)"},{"line_number":90,"context_line":"        except exceptions.NeutronClientException as e:"},{"line_number":91,"context_line":"            LOG.debug(\"Vip info not found due to %s\" % str(e))"},{"line_number":92,"context_line":"            return []"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    @logged"}],"source_content_type":"text/x-python","patch_set":1,"id":"baa201ad_f895b3e4","line":91,"updated":"2014-09-30 19:55:04.000000000","message":"I try to guess why you use str(e) instead of e, error message is come in str type.","commit_id":"9a409824ab9f7735d3a80b9e562ed088879a8da6"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"091c2dc18f294ec2df05baca9f43347b0c2d7619","unresolved":false,"context_lines":[{"line_number":43,"context_line":"            return func(*args, **kwargs)"},{"line_number":44,"context_line":"        except exceptions.NeutronClientException as e:"},{"line_number":45,"context_line":"            # handles 404\u0027s when services are disabled in neutron"},{"line_number":46,"context_line":"            LOG.debug(e)"},{"line_number":47,"context_line":"            return []"},{"line_number":48,"context_line":"        except Exception as e:"},{"line_number":49,"context_line":"            LOG.exception(e)"}],"source_content_type":"text/x-python","patch_set":2,"id":"baa201ad_fe72e67a","line":46,"updated":"2014-10-01 15:58:00.000000000","message":"one additional comment... i\u0027m guessing it\u0027s a pretty generic exception we\u0027re catching? is there one more specific to disabled services? and if not? maybe we should change this to LOG.warn?\n\nand add a comment saying it\u0027s possible that the bug was related to disabled services?","commit_id":"2a01d95f5add837459e1164f7596d336f59fd02b"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"f0b8e7921050f190d37d4d25249e8cb555750849","unresolved":false,"context_lines":[{"line_number":43,"context_line":"            return func(*args, **kwargs)"},{"line_number":44,"context_line":"        except exceptions.NeutronClientException as e:"},{"line_number":45,"context_line":"            # handles 404\u0027s when services are disabled in neutron"},{"line_number":46,"context_line":"            LOG.debug(e)"},{"line_number":47,"context_line":"            return []"},{"line_number":48,"context_line":"        except Exception as e:"},{"line_number":49,"context_line":"            LOG.exception(e)"}],"source_content_type":"text/x-python","patch_set":2,"id":"baa201ad_60e810b5","line":46,"in_reply_to":"baa201ad_b46f9dc4","updated":"2014-10-01 18:54:46.000000000","message":"hmm.. do you have an example of what gets logged when say LBaas service is enabled? i\u0027m thinking it\u0027s better to show it in warning rather than debug... debug for me is similar to white noise and any real exception will definitely get lost.","commit_id":"2a01d95f5add837459e1164f7596d336f59fd02b"},{"author":{"_account_id":6924,"name":"Pradeep Kilambi","email":"pkilambi@redhat.com","username":"pkilambi"},"change_message_id":"6936baafd199cb398be309f91cda090e2189801e","unresolved":false,"context_lines":[{"line_number":43,"context_line":"            return func(*args, **kwargs)"},{"line_number":44,"context_line":"        except exceptions.NeutronClientException as e:"},{"line_number":45,"context_line":"            # handles 404\u0027s when services are disabled in neutron"},{"line_number":46,"context_line":"            LOG.debug(e)"},{"line_number":47,"context_line":"            return []"},{"line_number":48,"context_line":"        except Exception as e:"},{"line_number":49,"context_line":"            LOG.exception(e)"}],"source_content_type":"text/x-python","patch_set":2,"id":"baa201ad_b46f9dc4","line":46,"in_reply_to":"baa201ad_fe72e67a","updated":"2014-10-01 17:02:38.000000000","message":"There isnt a specific exception. We could do a string match on the message and see if it says not found and then raise. But to me if we hit this exception, there is no reason to raise it back on ceilometer side and instead we just log it and return an empty list. \n\nregarding warn vs debug - I\u0027m worried it might raise unnecessary concerns in the logs when the user indeed wants to disable network services. Hence i chose a debug. This isnt necessarily an error or a warning from ceilometer stand point. \n\nIf you feel strongly about it. I can change it.","commit_id":"2a01d95f5add837459e1164f7596d336f59fd02b"}]}