)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"35cb2465a08427ab8d7943e5b87193a930eade9a","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Make compute discovery pollster-based, not agent-level"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Partially-Implements-Blueprint: merge-compute-central-agents"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I02c9a12b0fcd55a7d59688853f3c08e505b4bf3f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5a890539_2a6234d9","line":9,"updated":"2014-12-02 12:23:28.000000000","message":"You can just use Blueprint or Implements, it\u0027s enough.","commit_id":"49b61aa4b63cca6fc130c3ebbe9f84611ff05d0f"},{"author":{"_account_id":3012,"name":"Dina Belova","email":"dbelova@mirantis.com","username":"dbelova"},"change_message_id":"4b49000094524f86cbba030d16726d4da7c7149c","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Make compute discovery pollster-based, not agent-level"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Partially-Implements-Blueprint: merge-compute-central-agents"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I02c9a12b0fcd55a7d59688853f3c08e505b4bf3f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5a890539_1f5a0ef2","line":9,"in_reply_to":"5a890539_2a6234d9","updated":"2014-12-02 17:46:27.000000000","message":"ok!","commit_id":"49b61aa4b63cca6fc130c3ebbe9f84611ff05d0f"}],"ceilometer/agent.py":[{"author":{"_account_id":12927,"name":"Lan Qi song","email":"lqs933@foxmail.com","username":"lqisong"},"change_message_id":"e95c4ffa8657daeeff846536718c80e6108d5ccc","unresolved":false,"context_lines":[{"line_number":100,"context_line":"        self.resources[key].setup(pipeline)"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"    def poll_and_publish(self):"},{"line_number":103,"context_line":"        \"\"\"Polling sample and publish into pipeline.\"\"\""},{"line_number":104,"context_line":"        agent_resources \u003d self.manager.discover()"},{"line_number":105,"context_line":"        cache \u003d {}"},{"line_number":106,"context_line":"        discovery_cache \u003d {}"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a890539_3a30469d","side":"PARENT","line":103,"updated":"2014-12-05 01:52:52.000000000","message":"I think this line should also be removed, since agent_resources always return empty list []. Am I right?","commit_id":"a32d2ef26c409eb8fbadd493d6541dea625131b1"},{"author":{"_account_id":3012,"name":"Dina Belova","email":"dbelova@mirantis.com","username":"dbelova"},"change_message_id":"cac26eabc1d042ab59f51b0b13a0995d74488f6e","unresolved":false,"context_lines":[{"line_number":100,"context_line":"        self.resources[key].setup(pipeline)"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"    def poll_and_publish(self):"},{"line_number":103,"context_line":"        \"\"\"Polling sample and publish into pipeline.\"\"\""},{"line_number":104,"context_line":"        agent_resources \u003d self.manager.discover()"},{"line_number":105,"context_line":"        cache \u003d {}"},{"line_number":106,"context_line":"        discovery_cache \u003d {}"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a890539_3a5f4a11","side":"PARENT","line":103,"in_reply_to":"5a890539_3a30469d","updated":"2014-12-05 16:48:53.000000000","message":"Done","commit_id":"a32d2ef26c409eb8fbadd493d6541dea625131b1"},{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"7d26b68f2f7fec9fa04235889adeca8ee4c16fd2","unresolved":false,"context_lines":[{"line_number":101,"context_line":""},{"line_number":102,"context_line":"    def poll_and_publish(self):"},{"line_number":103,"context_line":"        \"\"\"Polling sample and publish into pipeline.\"\"\""},{"line_number":104,"context_line":"        agent_resources \u003d self.manager.discover()"},{"line_number":105,"context_line":"        cache \u003d {}"},{"line_number":106,"context_line":"        discovery_cache \u003d {}"},{"line_number":107,"context_line":"        for source, pollster in self.pollster_matches:"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a890539_56232a58","line":104,"updated":"2014-12-05 04:52:43.000000000","message":"agreed, no need to call discover with default None parameters","commit_id":"2b1a82bc9f582f90e5df9abba8bfb1fedc29855b"},{"author":{"_account_id":3012,"name":"Dina Belova","email":"dbelova@mirantis.com","username":"dbelova"},"change_message_id":"cac26eabc1d042ab59f51b0b13a0995d74488f6e","unresolved":false,"context_lines":[{"line_number":101,"context_line":""},{"line_number":102,"context_line":"    def poll_and_publish(self):"},{"line_number":103,"context_line":"        \"\"\"Polling sample and publish into pipeline.\"\"\""},{"line_number":104,"context_line":"        agent_resources \u003d self.manager.discover()"},{"line_number":105,"context_line":"        cache \u003d {}"},{"line_number":106,"context_line":"        discovery_cache \u003d {}"},{"line_number":107,"context_line":"        for source, pollster in self.pollster_matches:"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a890539_5a5c161a","line":104,"in_reply_to":"5a890539_56232a58","updated":"2014-12-05 16:48:53.000000000","message":"Done","commit_id":"2b1a82bc9f582f90e5df9abba8bfb1fedc29855b"},{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"7d26b68f2f7fec9fa04235889adeca8ee4c16fd2","unresolved":false,"context_lines":[{"line_number":113,"context_line":"                    [pollster.obj.default_discovery], discovery_cache)"},{"line_number":114,"context_line":"            key \u003d Resources.key(source, pollster)"},{"line_number":115,"context_line":"            source_resources \u003d list(self.resources[key].get(discovery_cache))"},{"line_number":116,"context_line":"            polling_resources \u003d (source_resources or pollster_resources or"},{"line_number":117,"context_line":"                                 agent_resources)"},{"line_number":118,"context_line":"            if not polling_resources:"},{"line_number":119,"context_line":"                LOG.info(_(\"Skip polling pollster %s, no resources found\"),"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a890539_d6163af2","line":116,"updated":"2014-12-05 04:52:43.000000000","message":"also remove agent_resources here","commit_id":"2b1a82bc9f582f90e5df9abba8bfb1fedc29855b"},{"author":{"_account_id":3012,"name":"Dina Belova","email":"dbelova@mirantis.com","username":"dbelova"},"change_message_id":"cac26eabc1d042ab59f51b0b13a0995d74488f6e","unresolved":false,"context_lines":[{"line_number":113,"context_line":"                    [pollster.obj.default_discovery], discovery_cache)"},{"line_number":114,"context_line":"            key \u003d Resources.key(source, pollster)"},{"line_number":115,"context_line":"            source_resources \u003d list(self.resources[key].get(discovery_cache))"},{"line_number":116,"context_line":"            polling_resources \u003d (source_resources or pollster_resources or"},{"line_number":117,"context_line":"                                 agent_resources)"},{"line_number":118,"context_line":"            if not polling_resources:"},{"line_number":119,"context_line":"                LOG.info(_(\"Skip polling pollster %s, no resources found\"),"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a890539_7a98f2cc","line":116,"in_reply_to":"5a890539_d6163af2","updated":"2014-12-05 16:48:53.000000000","message":"Done","commit_id":"2b1a82bc9f582f90e5df9abba8bfb1fedc29855b"}],"ceilometer/compute/manager.py":[{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"d41515a4360f2c55a0bdf38e424bc3e60029874b","unresolved":false,"context_lines":[{"line_number":22,"context_line":"LOG \u003d log.getLogger(__name__)"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"class AgentManager(agent.AgentManager):"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    def __init__(self):"},{"line_number":28,"context_line":"        super(AgentManager, self).__init__(\u0027compute\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a890539_0b6bacb9","line":25,"updated":"2014-12-02 19:29:33.000000000","message":"You should edit this parent class (ceilometer.agent.AgentManager) and remove the 2nd argument since it\u0027s not used anymore AFAICS.","commit_id":"49b61aa4b63cca6fc130c3ebbe9f84611ff05d0f"}],"ceilometer/tests/agentbase.py":[{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"5ef8ac55261a45b6f820c0ed014131330d2fa3e6","unresolved":false,"context_lines":[{"line_number":457,"context_line":"        self._do_test_per_agent_discovery([\u0027discovered_1\u0027, \u0027discovered_2\u0027],"},{"line_number":458,"context_line":"                                          [\u0027static_1\u0027, \u0027static_2\u0027])"},{"line_number":459,"context_line":""},{"line_number":460,"context_line":"    def test_per_agent_discovery_overridden_by_per_pollster_discovery(self):"},{"line_number":461,"context_line":"        discovered_resources \u003d [\u0027discovered_1\u0027, \u0027discovered_2\u0027]"},{"line_number":462,"context_line":"        self.mgr.discovery_manager \u003d self.create_discovery_manager()"},{"line_number":463,"context_line":"        self.Pollster.discovery \u003d \u0027testdiscovery\u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a961159_fa3f4e23","side":"PARENT","line":460,"updated":"2014-12-09 16:49:57.000000000","message":"why are all these tests being removed? they don\u0027t seem to be related to the change you\u0027re making","commit_id":"28a253104a1c6e4d584930257e3067ae74995808"},{"author":{"_account_id":3012,"name":"Dina Belova","email":"dbelova@mirantis.com","username":"dbelova"},"change_message_id":"dcbdefea75cbdfffa831b0fd1c3c268b01f87868","unresolved":false,"context_lines":[{"line_number":457,"context_line":"        self._do_test_per_agent_discovery([\u0027discovered_1\u0027, \u0027discovered_2\u0027],"},{"line_number":458,"context_line":"                                          [\u0027static_1\u0027, \u0027static_2\u0027])"},{"line_number":459,"context_line":""},{"line_number":460,"context_line":"    def test_per_agent_discovery_overridden_by_per_pollster_discovery(self):"},{"line_number":461,"context_line":"        discovered_resources \u003d [\u0027discovered_1\u0027, \u0027discovered_2\u0027]"},{"line_number":462,"context_line":"        self.mgr.discovery_manager \u003d self.create_discovery_manager()"},{"line_number":463,"context_line":"        self.Pollster.discovery \u003d \u0027testdiscovery\u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a961159_0291fa46","side":"PARENT","line":460,"in_reply_to":"3a961159_fa3f4e23","updated":"2014-12-10 09:08:17.000000000","message":"now we don\u0027t have agent-level discovery at all, after compute discovery became pollster-based in this change. So we simple do not have per-agent discovery after this change... So there is nothing to be tested \u003e_\u003c","commit_id":"28a253104a1c6e4d584930257e3067ae74995808"}],"ceilometer/tests/compute/test_manager.py":[{"author":{"_account_id":10987,"name":"Igor Degtiarov","username":"tovstun","inactive":true},"change_message_id":"80bd7623fd77324520dea68285f5237377080841","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        self.assertIsNotNone(list(mgr.pollster_manager))"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"class TestRunTasks(agentbase.BaseAgentManagerTestCase):"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    def _fake_instance(self, name, state):"},{"line_number":40,"context_line":"        instance \u003d mock.MagicMock()"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a890539_3778eec3","side":"PARENT","line":37,"updated":"2014-11-13 12:06:16.000000000","message":"Dina, could you explain why we don\u0027t need these tests.","commit_id":"32fb415d7871cf89004ece63ad2e6ce4f26dd776"},{"author":{"_account_id":3012,"name":"Dina Belova","email":"dbelova@mirantis.com","username":"dbelova"},"change_message_id":"c0ae473e29170051d7ed668dcf6c0d8022897361","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        self.assertIsNotNone(list(mgr.pollster_manager))"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"class TestRunTasks(agentbase.BaseAgentManagerTestCase):"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    def _fake_instance(self, name, state):"},{"line_number":40,"context_line":"        instance \u003d mock.MagicMock()"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a890539_1968ee86","side":"PARENT","line":37,"in_reply_to":"5a890539_3778eec3","updated":"2014-11-18 20:53:56.000000000","message":"Igor, all of them are compute-discovery-dependent in the old-style, but we have enough general discovery unit tests after Necj has merged his discovery-unifying change. As this commit basically moves compute discovery logic to the general one, we need no more these specific tests.","commit_id":"32fb415d7871cf89004ece63ad2e6ce4f26dd776"}]}