)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"2d63a3561eb6863ee838c4a11d7765042f00f419","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Samta Rangare \u003csrangare@mvista.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-10-12 23:41:29 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Get Alarms ordered by name"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Alarms are ordered at storage level."},{"line_number":10,"context_line":"Existing test (test_alarm_history_with_on_behalf_of_filter)"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"baa201ad_8fec4e2b","line":7,"updated":"2014-10-13 09:19:36.000000000","message":"The bug report is about to order by timestamp, please check.","commit_id":"2058249dfbb71a91dd457fe58a13774dca383580"},{"author":{"_account_id":10987,"name":"Igor Degtiarov","username":"tovstun","inactive":true},"change_message_id":"f364c007d3a2b9f07052828beb9b04ed9b50f8d2","unresolved":false,"context_lines":[{"line_number":11,"context_line":"has also been changed as alarms are ordered by name now."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I3fa11c8859266a99343abe4a266ffb675e6beb5a"},{"line_number":14,"context_line":"Fixes Bug: 1287119"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"baa201ad_48a89c77","line":14,"updated":"2014-10-13 11:35:12.000000000","message":"Good practice is to use \"Closes-Bug:\", for more details please look at https://wiki.openstack.org/wiki/GitCommitMessages","commit_id":"2058249dfbb71a91dd457fe58a13774dca383580"}],"ceilometer/alarm/storage/impl_sqlalchemy.py":[{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"2d63a3561eb6863ee838c4a11d7765042f00f419","unresolved":false,"context_lines":[{"line_number":173,"context_line":"        if state is not None:"},{"line_number":174,"context_line":"            query \u003d query.filter(models.Alarm.state \u003d\u003d state)"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"        query \u003d query.order_by(asc(models.Alarm.name))"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"        alarms \u003d self._retrieve_alarms(query)"},{"line_number":179,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"baa201ad_dda28f99","line":176,"updated":"2014-10-13 09:19:36.000000000","message":"This should be timestamp instead of name and also desc,  just like in case of the default orderby for query_alarms.","commit_id":"2058249dfbb71a91dd457fe58a13774dca383580"},{"author":{"_account_id":12256,"name":"Samta Rangare","email":"samtarangare@gmail.com","username":"samta"},"change_message_id":"71596794ff557869224e12c177e2f8dd333b2d04","unresolved":false,"context_lines":[{"line_number":173,"context_line":"        if state is not None:"},{"line_number":174,"context_line":"            query \u003d query.filter(models.Alarm.state \u003d\u003d state)"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"        query \u003d query.order_by(asc(models.Alarm.name))"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"        alarms \u003d self._retrieve_alarms(query)"},{"line_number":179,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"baa201ad_7eba76e2","line":176,"in_reply_to":"baa201ad_03ce7583","updated":"2014-10-13 13:02:35.000000000","message":"Ok, then i will submit new patch with \"Timestamp\". Thanks ildiko.","commit_id":"2058249dfbb71a91dd457fe58a13774dca383580"},{"author":{"_account_id":12256,"name":"Samta Rangare","email":"samtarangare@gmail.com","username":"samta"},"change_message_id":"49f63da04475a6a92fce0bae76988bc9faa850c2","unresolved":false,"context_lines":[{"line_number":173,"context_line":"        if state is not None:"},{"line_number":174,"context_line":"            query \u003d query.filter(models.Alarm.state \u003d\u003d state)"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"        query \u003d query.order_by(asc(models.Alarm.name))"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"        alarms \u003d self._retrieve_alarms(query)"},{"line_number":179,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"baa201ad_65bca96d","line":176,"in_reply_to":"baa201ad_053afd33","updated":"2014-10-13 10:59:40.000000000","message":"IMO as well \"timestamp\" would be more appropriate as it tells about more resent or older alarms.","commit_id":"2058249dfbb71a91dd457fe58a13774dca383580"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"d88adae825e9c71d7ff506a5dafd8e54a4e0cc61","unresolved":false,"context_lines":[{"line_number":173,"context_line":"        if state is not None:"},{"line_number":174,"context_line":"            query \u003d query.filter(models.Alarm.state \u003d\u003d state)"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"        query \u003d query.order_by(asc(models.Alarm.name))"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"        alarms \u003d self._retrieve_alarms(query)"},{"line_number":179,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"baa201ad_03ce7583","line":176,"in_reply_to":"baa201ad_65bca96d","updated":"2014-10-13 12:16:19.000000000","message":"That was my thought also, I agree. If someone would like to order it by name, then the complex query endpoint provides the possibility to do that.","commit_id":"2058249dfbb71a91dd457fe58a13774dca383580"},{"author":{"_account_id":12256,"name":"Samta Rangare","email":"samtarangare@gmail.com","username":"samta"},"change_message_id":"fb23b93234cb475542392ce470ac37bd36efbb91","unresolved":false,"context_lines":[{"line_number":173,"context_line":"        if state is not None:"},{"line_number":174,"context_line":"            query \u003d query.filter(models.Alarm.state \u003d\u003d state)"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"        query \u003d query.order_by(asc(models.Alarm.name))"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"        alarms \u003d self._retrieve_alarms(query)"},{"line_number":179,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"baa201ad_e5941946","line":176,"in_reply_to":"baa201ad_65d02954","updated":"2014-10-13 10:40:44.000000000","message":"https://bugs.launchpad.net/ceilometer/+bug/1287119\nCheck here Nejc Saje comments. Please let me know your views, based on that i will submit next patch.\nThanks.","commit_id":"2058249dfbb71a91dd457fe58a13774dca383580"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"647eea7852c2e420f3e0045f84325bdef80cde02","unresolved":false,"context_lines":[{"line_number":173,"context_line":"        if state is not None:"},{"line_number":174,"context_line":"            query \u003d query.filter(models.Alarm.state \u003d\u003d state)"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"        query \u003d query.order_by(asc(models.Alarm.name))"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"        alarms \u003d self._retrieve_alarms(query)"},{"line_number":179,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"baa201ad_65d02954","line":176,"in_reply_to":"baa201ad_6f4aca84","updated":"2014-10-13 10:32:19.000000000","message":"Where is that review comment you\u0027re referring to?","commit_id":"2058249dfbb71a91dd457fe58a13774dca383580"},{"author":{"_account_id":12256,"name":"Samta Rangare","email":"samtarangare@gmail.com","username":"samta"},"change_message_id":"2f36c06f4333c9a5aa6186164fcdbd22fdbc39b4","unresolved":false,"context_lines":[{"line_number":173,"context_line":"        if state is not None:"},{"line_number":174,"context_line":"            query \u003d query.filter(models.Alarm.state \u003d\u003d state)"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"        query \u003d query.order_by(asc(models.Alarm.name))"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"        alarms \u003d self._retrieve_alarms(query)"},{"line_number":179,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"baa201ad_6f4aca84","line":176,"in_reply_to":"baa201ad_dda28f99","updated":"2014-10-13 09:32:44.000000000","message":"Hi ildiko..thanks for review\nI got another review from Nejc Saje and it turns out to be that listing should be done based on \"name\" not \"timestamp\".","commit_id":"2058249dfbb71a91dd457fe58a13774dca383580"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"40a20df3e3bbebd62eaea252e8307deaf14bf56e","unresolved":false,"context_lines":[{"line_number":173,"context_line":"        if state is not None:"},{"line_number":174,"context_line":"            query \u003d query.filter(models.Alarm.state \u003d\u003d state)"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"        query \u003d query.order_by(asc(models.Alarm.name))"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"        alarms \u003d self._retrieve_alarms(query)"},{"line_number":179,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"baa201ad_053afd33","line":176,"in_reply_to":"baa201ad_e5941946","updated":"2014-10-13 10:50:06.000000000","message":"A-ha, ok. Well, to be honest, I don\u0027t see more value in the name based ordering than in the timestamp based one. The complex query uses timestamp and my view is, if we change the behavior for the simple query, then it should be at least consistent between the two endpoints. But I\u0027m open to have a discussion about this, if it\u0027s needed.","commit_id":"2058249dfbb71a91dd457fe58a13774dca383580"}],"ceilometer/alarm/storage/pymongo_base.py":[{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"2d63a3561eb6863ee838c4a11d7765042f00f419","unresolved":false,"context_lines":[{"line_number":112,"context_line":"            q[\u0027rule.meter_name\u0027] \u003d meter"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"        return self._retrieve_alarms(q,"},{"line_number":115,"context_line":"                                     [(\"name\","},{"line_number":116,"context_line":"                                       pymongo.ASCENDING)],"},{"line_number":117,"context_line":"                                     None)"},{"line_number":118,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"baa201ad_5dba1fe2","line":115,"updated":"2014-10-13 09:19:36.000000000","message":"According to the bug report, this should be \"timestamp\" and not \"name\".","commit_id":"2058249dfbb71a91dd457fe58a13774dca383580"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"2d63a3561eb6863ee838c4a11d7765042f00f419","unresolved":false,"context_lines":[{"line_number":113,"context_line":""},{"line_number":114,"context_line":"        return self._retrieve_alarms(q,"},{"line_number":115,"context_line":"                                     [(\"name\","},{"line_number":116,"context_line":"                                       pymongo.ASCENDING)],"},{"line_number":117,"context_line":"                                     None)"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"    def get_alarm_changes(self, alarm_id, on_behalf_of,"}],"source_content_type":"text/x-python","patch_set":4,"id":"baa201ad_1dc89773","line":116,"updated":"2014-10-13 09:19:36.000000000","message":"I would prefer DESCENDING order here, just like in case of the default orderby for query_alarms.","commit_id":"2058249dfbb71a91dd457fe58a13774dca383580"}],"ceilometer/tests/storage/test_storage_scenarios.py":[{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"2d63a3561eb6863ee838c4a11d7765042f00f419","unresolved":false,"context_lines":[{"line_number":2406,"context_line":"        alarms \u003d list(self.alarm_conn.get_alarms())"},{"line_number":2407,"context_line":"        self.assertEqual(len(alarms), 3)"},{"line_number":2408,"context_line":""},{"line_number":2409,"context_line":"    def test_list_alarms_ordered_by_name(self):"},{"line_number":2410,"context_line":"        self.add_some_alarms()"},{"line_number":2411,"context_line":"        alarms \u003d list(self.alarm_conn.get_alarms())"},{"line_number":2412,"context_line":"        self.assertEqual(len(alarms), 3)"}],"source_content_type":"text/x-python","patch_set":4,"id":"baa201ad_bd706bdd","line":2409,"updated":"2014-10-13 09:19:36.000000000","message":"It should check here timestamp ordering according to my previous comments.","commit_id":"2058249dfbb71a91dd457fe58a13774dca383580"}]}