)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"822d723e65bd3651babe0287130030c45149d60b","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Standardize timestamp fields of ceilometer API"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"For currently, the timestamp in query fields is not unified, this"},{"line_number":10,"context_line":"patch standardize the usage of timestamp query fileds:"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"- unify the time query filed in API to *timestamp* supported only."},{"line_number":13,"context_line":"- unify the time releted fileds of filters to start_timestamp and"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"5a890539_971e35ba","line":10,"updated":"2014-11-29 11:30:42.000000000","message":"nit: s/standardize/standardizes/","commit_id":"a47a9cabc030c4218b7b172b305d8cf373b13855"},{"author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"change_message_id":"c4a82c35a8f2570dfa88ebf34e4b3b559766c20e","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Standardize timestamp fields of ceilometer API"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"For currently, the timestamp in query fields is not unified, this"},{"line_number":10,"context_line":"patch standardize the usage of timestamp query fileds:"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"- unify the time query filed in API to *timestamp* supported only."},{"line_number":13,"context_line":"- unify the time releted fileds of filters to start_timestamp and"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"5a890539_961857ce","line":10,"in_reply_to":"5a890539_971e35ba","updated":"2014-12-04 09:11:41.000000000","message":"Done","commit_id":"a47a9cabc030c4218b7b172b305d8cf373b13855"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"822d723e65bd3651babe0287130030c45149d60b","unresolved":false,"context_lines":[{"line_number":10,"context_line":"patch standardize the usage of timestamp query fileds:"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"- unify the time query filed in API to *timestamp* supported only."},{"line_number":13,"context_line":"- unify the time releted fileds of filters to start_timestamp and"},{"line_number":14,"context_line":"  end_timestamp to simplify the process logic."},{"line_number":15,"context_line":"- improve the _query_to_kwargs method to give explicit presentation"},{"line_number":16,"context_line":"  if user input unsupported query fields."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"5a890539_d777dd06","line":13,"updated":"2014-11-29 11:30:42.000000000","message":"nit: s/releted/related/","commit_id":"a47a9cabc030c4218b7b172b305d8cf373b13855"},{"author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"change_message_id":"c4a82c35a8f2570dfa88ebf34e4b3b559766c20e","unresolved":false,"context_lines":[{"line_number":10,"context_line":"patch standardize the usage of timestamp query fileds:"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"- unify the time query filed in API to *timestamp* supported only."},{"line_number":13,"context_line":"- unify the time releted fileds of filters to start_timestamp and"},{"line_number":14,"context_line":"  end_timestamp to simplify the process logic."},{"line_number":15,"context_line":"- improve the _query_to_kwargs method to give explicit presentation"},{"line_number":16,"context_line":"  if user input unsupported query fields."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"5a890539_b67ab3ee","line":13,"in_reply_to":"5a890539_d777dd06","updated":"2014-12-04 09:11:41.000000000","message":"Done","commit_id":"a47a9cabc030c4218b7b172b305d8cf373b13855"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"822d723e65bd3651babe0287130030c45149d60b","unresolved":false,"context_lines":[{"line_number":13,"context_line":"- unify the time releted fileds of filters to start_timestamp and"},{"line_number":14,"context_line":"  end_timestamp to simplify the process logic."},{"line_number":15,"context_line":"- improve the _query_to_kwargs method to give explicit presentation"},{"line_number":16,"context_line":"  if user input unsupported query fields."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: Ic3ade312efa89edd01d2ee5ae31d341805b11f79"},{"line_number":19,"context_line":"Closes-bug: #1295104"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"5a890539_b772510f","line":16,"updated":"2014-11-29 11:30:42.000000000","message":"nit: s/input/specifies/","commit_id":"a47a9cabc030c4218b7b172b305d8cf373b13855"},{"author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"change_message_id":"c4a82c35a8f2570dfa88ebf34e4b3b559766c20e","unresolved":false,"context_lines":[{"line_number":13,"context_line":"- unify the time releted fileds of filters to start_timestamp and"},{"line_number":14,"context_line":"  end_timestamp to simplify the process logic."},{"line_number":15,"context_line":"- improve the _query_to_kwargs method to give explicit presentation"},{"line_number":16,"context_line":"  if user input unsupported query fields."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: Ic3ade312efa89edd01d2ee5ae31d341805b11f79"},{"line_number":19,"context_line":"Closes-bug: #1295104"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"5a890539_d67d7fe8","line":16,"in_reply_to":"5a890539_b772510f","updated":"2014-12-04 09:11:41.000000000","message":"Done","commit_id":"a47a9cabc030c4218b7b172b305d8cf373b13855"}],"ceilometer/api/controllers/v2.py":[{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"55ede8194e5f716ea1d645a8aa790692a0019f01","unresolved":false,"context_lines":[{"line_number":424,"context_line":"                               \u0027end_timestamp_op\u0027, \u0027start_timestamp_op\u0027]"},{"line_number":425,"context_line":"    if \u0027start_timestamp\u0027 in valid_keys:"},{"line_number":426,"context_line":"        internal_keys +\u003d internal_timestamp_keys"},{"line_number":427,"context_line":"        valid_keys +\u003d [\u0027timestamp\u0027, \u0027offset\u0027]"},{"line_number":428,"context_line":"    internal_keys.append(\u0027self\u0027)"},{"line_number":429,"context_line":"    valid_keys \u003d set(valid_keys) - set(internal_keys)"},{"line_number":430,"context_line":"    translation \u003d {\u0027user_id\u0027: \u0027user\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"baa201ad_73ea2f75","line":427,"updated":"2014-10-17 03:19:26.000000000","message":"should offset be search_offset?","commit_id":"923689fad04337bda58238322e33550df38cd235"},{"author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"change_message_id":"129344cd3963addb5ac67baa18997ca632a41cc4","unresolved":false,"context_lines":[{"line_number":424,"context_line":"                               \u0027end_timestamp_op\u0027, \u0027start_timestamp_op\u0027]"},{"line_number":425,"context_line":"    if \u0027start_timestamp\u0027 in valid_keys:"},{"line_number":426,"context_line":"        internal_keys +\u003d internal_timestamp_keys"},{"line_number":427,"context_line":"        valid_keys +\u003d [\u0027timestamp\u0027, \u0027offset\u0027]"},{"line_number":428,"context_line":"    internal_keys.append(\u0027self\u0027)"},{"line_number":429,"context_line":"    valid_keys \u003d set(valid_keys) - set(internal_keys)"},{"line_number":430,"context_line":"    translation \u003d {\u0027user_id\u0027: \u0027user\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"baa201ad_c9c6ce67","line":427,"in_reply_to":"baa201ad_73ea2f75","updated":"2014-10-17 06:21:51.000000000","message":"Done","commit_id":"923689fad04337bda58238322e33550df38cd235"},{"author":{"_account_id":7478,"name":"Nadya Shakhat","email":"nadmi4@gmail.com","username":"nprivalova"},"change_message_id":"e95fcdaf18708be0dd82ca01241aea504c4e7e59","unresolved":false,"context_lines":[{"line_number":598,"context_line":"    end_timestamp_op: Final timestamp operator to use for query"},{"line_number":599,"context_line":"    \"\"\""},{"line_number":600,"context_line":""},{"line_number":601,"context_line":"    if args is None:"},{"line_number":602,"context_line":"        return {}"},{"line_number":603,"context_line":"    search_offset \u003d int(args.get(\u0027search_offset\u0027, 0))"},{"line_number":604,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"3a961159_be588cfb","line":601,"updated":"2014-12-08 13:42:37.000000000","message":"It\u0027s interesting, why we returned None and 0\u0027s before? Have you changed a behavior?","commit_id":"33065c16f6b7ffb1f3595a10559b395542e7e30d"},{"author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"change_message_id":"afc4af1b3aea37c016a59542e8b0fc31fa610f9c","unresolved":false,"context_lines":[{"line_number":598,"context_line":"    end_timestamp_op: Final timestamp operator to use for query"},{"line_number":599,"context_line":"    \"\"\""},{"line_number":600,"context_line":""},{"line_number":601,"context_line":"    if args is None:"},{"line_number":602,"context_line":"        return {}"},{"line_number":603,"context_line":"    search_offset \u003d int(args.get(\u0027search_offset\u0027, 0))"},{"line_number":604,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"3a961159_f12cbe04","line":601,"in_reply_to":"3a961159_be588cfb","updated":"2014-12-10 07:19:29.000000000","message":"the _get_query_timestamps is only used in _query_to_kwargs method, please see L556 of left part of this page, actually, the \"search_offset\" wasn\u0027t used previously, the None value is because _query_to_kwargs method get the value of the returning dict by indexing key. For now, if args is None, we return a {}, that means the \"kwargs\" will don\u0027t include the timestamp keys, but all the filters class have default value \"None\"(e.g. ceilometer.storage.EventFilter#__init__()).","commit_id":"33065c16f6b7ffb1f3595a10559b395542e7e30d"}],"ceilometer/storage/__init__.py":[{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"55ede8194e5f716ea1d645a8aa790692a0019f01","unresolved":false,"context_lines":[{"line_number":134,"context_line":"    def __repr__(self):"},{"line_number":135,"context_line":"        return (\"\u003cSampleFilter(user: %s,\""},{"line_number":136,"context_line":"                \" project: %s,\""},{"line_number":137,"context_line":"                \" start: %s,\""},{"line_number":138,"context_line":"                \" start_timestamp_op: %s,\""},{"line_number":139,"context_line":"                \" end: %s,\""},{"line_number":140,"context_line":"                \" end_timestamp_op: %s,\""}],"source_content_type":"text/x-python","patch_set":3,"id":"baa201ad_330a678a","line":137,"updated":"2014-10-17 03:19:26.000000000","message":"I think we need to change this","commit_id":"923689fad04337bda58238322e33550df38cd235"},{"author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"change_message_id":"129344cd3963addb5ac67baa18997ca632a41cc4","unresolved":false,"context_lines":[{"line_number":134,"context_line":"    def __repr__(self):"},{"line_number":135,"context_line":"        return (\"\u003cSampleFilter(user: %s,\""},{"line_number":136,"context_line":"                \" project: %s,\""},{"line_number":137,"context_line":"                \" start: %s,\""},{"line_number":138,"context_line":"                \" start_timestamp_op: %s,\""},{"line_number":139,"context_line":"                \" end: %s,\""},{"line_number":140,"context_line":"                \" end_timestamp_op: %s,\""}],"source_content_type":"text/x-python","patch_set":3,"id":"baa201ad_69d322d5","line":137,"in_reply_to":"baa201ad_330a678a","updated":"2014-10-17 06:21:51.000000000","message":"Done","commit_id":"923689fad04337bda58238322e33550df38cd235"},{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"55ede8194e5f716ea1d645a8aa790692a0019f01","unresolved":false,"context_lines":[{"line_number":136,"context_line":"                \" project: %s,\""},{"line_number":137,"context_line":"                \" start: %s,\""},{"line_number":138,"context_line":"                \" start_timestamp_op: %s,\""},{"line_number":139,"context_line":"                \" end: %s,\""},{"line_number":140,"context_line":"                \" end_timestamp_op: %s,\""},{"line_number":141,"context_line":"                \" resource: %s,\""},{"line_number":142,"context_line":"                \" meter: %s,\""}],"source_content_type":"text/x-python","patch_set":3,"id":"baa201ad_53fd2b6d","line":139,"updated":"2014-10-17 03:19:26.000000000","message":"ditto","commit_id":"923689fad04337bda58238322e33550df38cd235"},{"author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"change_message_id":"129344cd3963addb5ac67baa18997ca632a41cc4","unresolved":false,"context_lines":[{"line_number":136,"context_line":"                \" project: %s,\""},{"line_number":137,"context_line":"                \" start: %s,\""},{"line_number":138,"context_line":"                \" start_timestamp_op: %s,\""},{"line_number":139,"context_line":"                \" end: %s,\""},{"line_number":140,"context_line":"                \" end_timestamp_op: %s,\""},{"line_number":141,"context_line":"                \" resource: %s,\""},{"line_number":142,"context_line":"                \" meter: %s,\""}],"source_content_type":"text/x-python","patch_set":3,"id":"baa201ad_89dda6e2","line":139,"in_reply_to":"baa201ad_53fd2b6d","updated":"2014-10-17 06:21:51.000000000","message":"Done","commit_id":"923689fad04337bda58238322e33550df38cd235"},{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"55ede8194e5f716ea1d645a8aa790692a0019f01","unresolved":false,"context_lines":[{"line_number":185,"context_line":"        self.traits_filter \u003d traits_filter or []"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"    def __repr__(self):"},{"line_number":188,"context_line":"        return (\"\u003cEventFilter(start_time: %s,\""},{"line_number":189,"context_line":"                \" end_time: %s,\""},{"line_number":190,"context_line":"                \" event_type: %s,\""},{"line_number":191,"context_line":"                \" traits: %s)\u003e\" %"}],"source_content_type":"text/x-python","patch_set":3,"id":"baa201ad_93fa3373","line":188,"updated":"2014-10-17 03:19:26.000000000","message":"ditto","commit_id":"923689fad04337bda58238322e33550df38cd235"},{"author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"change_message_id":"129344cd3963addb5ac67baa18997ca632a41cc4","unresolved":false,"context_lines":[{"line_number":185,"context_line":"        self.traits_filter \u003d traits_filter or []"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"    def __repr__(self):"},{"line_number":188,"context_line":"        return (\"\u003cEventFilter(start_time: %s,\""},{"line_number":189,"context_line":"                \" end_time: %s,\""},{"line_number":190,"context_line":"                \" event_type: %s,\""},{"line_number":191,"context_line":"                \" traits: %s)\u003e\" %"}],"source_content_type":"text/x-python","patch_set":3,"id":"baa201ad_c9e32ea2","line":188,"in_reply_to":"baa201ad_93fa3373","updated":"2014-10-17 06:21:51.000000000","message":"Done","commit_id":"923689fad04337bda58238322e33550df38cd235"},{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"55ede8194e5f716ea1d645a8aa790692a0019f01","unresolved":false,"context_lines":[{"line_number":186,"context_line":""},{"line_number":187,"context_line":"    def __repr__(self):"},{"line_number":188,"context_line":"        return (\"\u003cEventFilter(start_time: %s,\""},{"line_number":189,"context_line":"                \" end_time: %s,\""},{"line_number":190,"context_line":"                \" event_type: %s,\""},{"line_number":191,"context_line":"                \" traits: %s)\u003e\" %"},{"line_number":192,"context_line":"                (self.start_timestamp,"}],"source_content_type":"text/x-python","patch_set":3,"id":"baa201ad_b3f57784","line":189,"updated":"2014-10-17 03:19:26.000000000","message":"ditto","commit_id":"923689fad04337bda58238322e33550df38cd235"},{"author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"change_message_id":"129344cd3963addb5ac67baa18997ca632a41cc4","unresolved":false,"context_lines":[{"line_number":186,"context_line":""},{"line_number":187,"context_line":"    def __repr__(self):"},{"line_number":188,"context_line":"        return (\"\u003cEventFilter(start_time: %s,\""},{"line_number":189,"context_line":"                \" end_time: %s,\""},{"line_number":190,"context_line":"                \" event_type: %s,\""},{"line_number":191,"context_line":"                \" traits: %s)\u003e\" %"},{"line_number":192,"context_line":"                (self.start_timestamp,"}],"source_content_type":"text/x-python","patch_set":3,"id":"baa201ad_e9de32d9","line":189,"in_reply_to":"baa201ad_b3f57784","updated":"2014-10-17 06:21:51.000000000","message":"Done","commit_id":"923689fad04337bda58238322e33550df38cd235"}],"ceilometer/storage/impl_sqlalchemy.py":[{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"55ede8194e5f716ea1d645a8aa790692a0019f01","unresolved":false,"context_lines":[{"line_number":682,"context_line":"                                                      aggregate)"},{"line_number":683,"context_line":"            return"},{"line_number":684,"context_line":""},{"line_number":685,"context_line":"        if not sample_filter.end_timestamp or not sample_filter.end_timestamp:"},{"line_number":686,"context_line":"            res \u003d self._make_stats_query(sample_filter,"},{"line_number":687,"context_line":"                                         None,"},{"line_number":688,"context_line":"                                         aggregate).first()"}],"source_content_type":"text/x-python","patch_set":3,"id":"baa201ad_73378f4d","line":685,"updated":"2014-10-17 03:19:26.000000000","message":"should be \n if not sample_filter.start_timestamp or not sample_filter.end_timestamp:","commit_id":"923689fad04337bda58238322e33550df38cd235"},{"author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"change_message_id":"129344cd3963addb5ac67baa18997ca632a41cc4","unresolved":false,"context_lines":[{"line_number":682,"context_line":"                                                      aggregate)"},{"line_number":683,"context_line":"            return"},{"line_number":684,"context_line":""},{"line_number":685,"context_line":"        if not sample_filter.end_timestamp or not sample_filter.end_timestamp:"},{"line_number":686,"context_line":"            res \u003d self._make_stats_query(sample_filter,"},{"line_number":687,"context_line":"                                         None,"},{"line_number":688,"context_line":"                                         aggregate).first()"}],"source_content_type":"text/x-python","patch_set":3,"id":"baa201ad_49e73eac","line":685,"in_reply_to":"baa201ad_73378f4d","updated":"2014-10-17 06:21:51.000000000","message":"Done","commit_id":"923689fad04337bda58238322e33550df38cd235"}],"ceilometer/tests/api/v2/test_alarm_scenarios.py":[{"author":{"_account_id":7049,"name":"Kai Qiang Wu(Kennan)","email":"wkq5325@gmail.com","username":"Kennan"},"change_message_id":"9c11fcf564713cd8affaf1de330c569f15b5e4d2","unresolved":false,"context_lines":[{"line_number":2170,"context_line":"                                       expect_errors\u003dTrue, status\u003d400)"},{"line_number":2171,"context_line":"        self.assertEqual(\u0027Unknown argument: \"alarm_id\": unrecognized\u0027"},{"line_number":2172,"context_line":"                         \" field in query: [\u003cQuery u\u0027alarm_id\u0027 eq\""},{"line_number":2173,"context_line":"                         \" u\u0027b\u0027 Unset\u003e], valid keys: [\u0027project\u0027, \""},{"line_number":2174,"context_line":"                         \"\u0027search_offset\u0027, \u0027timestamp\u0027, \u0027type\u0027, \u0027user\u0027]\","},{"line_number":2175,"context_line":"                         resp.json[\u0027error_message\u0027][\u0027faultstring\u0027])"},{"line_number":2176,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"3a961159_3eb6673e","line":2173,"updated":"2014-12-08 05:45:35.000000000","message":"better use same format, space first, not end with space","commit_id":"33065c16f6b7ffb1f3595a10559b395542e7e30d"},{"author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"change_message_id":"56cc367ffb078dc9c1e8c7a7272bfa5241deb5ec","unresolved":false,"context_lines":[{"line_number":2170,"context_line":"                                       expect_errors\u003dTrue, status\u003d400)"},{"line_number":2171,"context_line":"        self.assertEqual(\u0027Unknown argument: \"alarm_id\": unrecognized\u0027"},{"line_number":2172,"context_line":"                         \" field in query: [\u003cQuery u\u0027alarm_id\u0027 eq\""},{"line_number":2173,"context_line":"                         \" u\u0027b\u0027 Unset\u003e], valid keys: [\u0027project\u0027, \""},{"line_number":2174,"context_line":"                         \"\u0027search_offset\u0027, \u0027timestamp\u0027, \u0027type\u0027, \u0027user\u0027]\","},{"line_number":2175,"context_line":"                         resp.json[\u0027error_message\u0027][\u0027faultstring\u0027])"},{"line_number":2176,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"3a961159_7e68eff5","line":2173,"in_reply_to":"3a961159_3eb6673e","updated":"2014-12-08 06:17:46.000000000","message":"Is there any check for this? sorry I don\u0027t think this is a problem because after the space there is a \"quote\". just for 80 characters limit.","commit_id":"33065c16f6b7ffb1f3595a10559b395542e7e30d"},{"author":{"_account_id":7049,"name":"Kai Qiang Wu(Kennan)","email":"wkq5325@gmail.com","username":"Kennan"},"change_message_id":"25ef0dc0b1e64a0ceb5245a255710e069e5a69c7","unresolved":false,"context_lines":[{"line_number":2170,"context_line":"                                       expect_errors\u003dTrue, status\u003d400)"},{"line_number":2171,"context_line":"        self.assertEqual(\u0027Unknown argument: \"alarm_id\": unrecognized\u0027"},{"line_number":2172,"context_line":"                         \" field in query: [\u003cQuery u\u0027alarm_id\u0027 eq\""},{"line_number":2173,"context_line":"                         \" u\u0027b\u0027 Unset\u003e], valid keys: [\u0027project\u0027, \""},{"line_number":2174,"context_line":"                         \"\u0027search_offset\u0027, \u0027timestamp\u0027, \u0027type\u0027, \u0027user\u0027]\","},{"line_number":2175,"context_line":"                         resp.json[\u0027error_message\u0027][\u0027faultstring\u0027])"},{"line_number":2176,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"3a961159_a1b07ade","line":2173,"in_reply_to":"3a961159_7e68eff5","updated":"2014-12-08 07:04:18.000000000","message":"it is style insistence,\n\n\" u\u0027b\u0027 Unset\u003e], valid keys: [\u0027project\u0027,\"\n\n\" \u0027search_offset\u0027, \u0027timestamp\u0027, \u0027type\u0027,\"\n\n\" \u0027user\u0027]\",\n\nis better, I just means better.","commit_id":"33065c16f6b7ffb1f3595a10559b395542e7e30d"},{"author":{"_account_id":3012,"name":"Dina Belova","email":"dbelova@mirantis.com","username":"dbelova"},"change_message_id":"d805d67164e0ce3594f532f20d5d873c9b39c6a0","unresolved":false,"context_lines":[{"line_number":2170,"context_line":"                                       expect_errors\u003dTrue, status\u003d400)"},{"line_number":2171,"context_line":"        self.assertEqual(\u0027Unknown argument: \"alarm_id\": unrecognized\u0027"},{"line_number":2172,"context_line":"                         \" field in query: [\u003cQuery u\u0027alarm_id\u0027 eq\""},{"line_number":2173,"context_line":"                         \" u\u0027b\u0027 Unset\u003e], valid keys: [\u0027project\u0027, \""},{"line_number":2174,"context_line":"                         \"\u0027search_offset\u0027, \u0027timestamp\u0027, \u0027type\u0027, \u0027user\u0027]\","},{"line_number":2175,"context_line":"                         resp.json[\u0027error_message\u0027][\u0027faultstring\u0027])"},{"line_number":2176,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"3a961159_e72452c8","line":2173,"in_reply_to":"3a961159_a1b07ade","updated":"2014-12-08 09:20:02.000000000","message":"actually that\u0027s matter of personal taste. Personally I love the format\n\n\"bla \"\n\n\"foo \"\n\nmore than\n\n\" bla\"\n\n\" foo\"","commit_id":"33065c16f6b7ffb1f3595a10559b395542e7e30d"},{"author":{"_account_id":7049,"name":"Kai Qiang Wu(Kennan)","email":"wkq5325@gmail.com","username":"Kennan"},"change_message_id":"9c11fcf564713cd8affaf1de330c569f15b5e4d2","unresolved":false,"context_lines":[{"line_number":2181,"context_line":"                                       expect_errors\u003dTrue, status\u003d400)"},{"line_number":2182,"context_line":"        self.assertEqual(\u0027Unknown argument: \"abcd\": unrecognized\u0027"},{"line_number":2183,"context_line":"                         \" field in query: [\u003cQuery u\u0027abcd\u0027 eq\""},{"line_number":2184,"context_line":"                         \" u\u0027abcd\u0027 Unset\u003e], valid keys: [\u0027project\u0027, \""},{"line_number":2185,"context_line":"                         \"\u0027search_offset\u0027, \u0027timestamp\u0027, \u0027type\u0027, \u0027user\u0027]\","},{"line_number":2186,"context_line":"                         resp.json[\u0027error_message\u0027][\u0027faultstring\u0027])"},{"line_number":2187,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"3a961159_de956389","line":2184,"updated":"2014-12-08 05:45:35.000000000","message":"ditto","commit_id":"33065c16f6b7ffb1f3595a10559b395542e7e30d"}],"ceilometer/tests/api/v2/test_query.py":[{"author":{"_account_id":7049,"name":"Kai Qiang Wu(Kennan)","email":"wkq5325@gmail.com","username":"Kennan"},"change_message_id":"9c11fcf564713cd8affaf1de330c569f15b5e4d2","unresolved":false,"context_lines":[{"line_number":346,"context_line":"            alarm_storage_base.Connection.get_alarm_changes)"},{"line_number":347,"context_line":"        valid_keys \u003d [\u0027alarm_id\u0027, \u0027on_behalf_of\u0027, \u0027project\u0027, \u0027search_offset\u0027,"},{"line_number":348,"context_line":"                      \u0027timestamp\u0027, \u0027type\u0027, \u0027user\u0027]"},{"line_number":349,"context_line":"        msg \u003d (\"unrecognized field in query: %s, \""},{"line_number":350,"context_line":"               \"valid keys: %s\") % (q, valid_keys)"},{"line_number":351,"context_line":"        expected_exc \u003d wsme.exc.UnknownArgument(\u0027abc\u0027, msg)"},{"line_number":352,"context_line":"        self.assertEqual(str(expected_exc), str(exc))"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a961159_5e05f3c0","line":349,"updated":"2014-12-08 05:45:35.000000000","message":"I think sentence should mind have capital letter","commit_id":"33065c16f6b7ffb1f3595a10559b395542e7e30d"},{"author":{"_account_id":7049,"name":"Kai Qiang Wu(Kennan)","email":"wkq5325@gmail.com","username":"Kennan"},"change_message_id":"25ef0dc0b1e64a0ceb5245a255710e069e5a69c7","unresolved":false,"context_lines":[{"line_number":346,"context_line":"            alarm_storage_base.Connection.get_alarm_changes)"},{"line_number":347,"context_line":"        valid_keys \u003d [\u0027alarm_id\u0027, \u0027on_behalf_of\u0027, \u0027project\u0027, \u0027search_offset\u0027,"},{"line_number":348,"context_line":"                      \u0027timestamp\u0027, \u0027type\u0027, \u0027user\u0027]"},{"line_number":349,"context_line":"        msg \u003d (\"unrecognized field in query: %s, \""},{"line_number":350,"context_line":"               \"valid keys: %s\") % (q, valid_keys)"},{"line_number":351,"context_line":"        expected_exc \u003d wsme.exc.UnknownArgument(\u0027abc\u0027, msg)"},{"line_number":352,"context_line":"        self.assertEqual(str(expected_exc), str(exc))"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a961159_c19e6656","line":349,"in_reply_to":"3a961159_3e2ca7ab","updated":"2014-12-08 07:04:18.000000000","message":"OK. Thanks. I noticed other test have capital letter in sentence. so maybe someone wrote such in v2. You have no choice in your test.\n\nI am ok with that","commit_id":"33065c16f6b7ffb1f3595a10559b395542e7e30d"},{"author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"change_message_id":"56cc367ffb078dc9c1e8c7a7272bfa5241deb5ec","unresolved":false,"context_lines":[{"line_number":346,"context_line":"            alarm_storage_base.Connection.get_alarm_changes)"},{"line_number":347,"context_line":"        valid_keys \u003d [\u0027alarm_id\u0027, \u0027on_behalf_of\u0027, \u0027project\u0027, \u0027search_offset\u0027,"},{"line_number":348,"context_line":"                      \u0027timestamp\u0027, \u0027type\u0027, \u0027user\u0027]"},{"line_number":349,"context_line":"        msg \u003d (\"unrecognized field in query: %s, \""},{"line_number":350,"context_line":"               \"valid keys: %s\") % (q, valid_keys)"},{"line_number":351,"context_line":"        expected_exc \u003d wsme.exc.UnknownArgument(\u0027abc\u0027, msg)"},{"line_number":352,"context_line":"        self.assertEqual(str(expected_exc), str(exc))"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a961159_3e2ca7ab","line":349,"in_reply_to":"3a961159_5e05f3c0","updated":"2014-12-08 06:17:46.000000000","message":"the exception message is same to v2.py, please see: https://review.openstack.org/#/c/128856/9/ceilometer/api/controllers/v2.py L470, maybe you are right, but I think this is unrelated to this patch, maybe there will be a cosmetic patch do works like this.","commit_id":"33065c16f6b7ffb1f3595a10559b395542e7e30d"},{"author":{"_account_id":7049,"name":"Kai Qiang Wu(Kennan)","email":"wkq5325@gmail.com","username":"Kennan"},"change_message_id":"9c11fcf564713cd8affaf1de330c569f15b5e4d2","unresolved":false,"context_lines":[{"line_number":361,"context_line":"        valid_keys \u003d [\u0027message_id\u0027, \u0027metaquery\u0027, \u0027meter\u0027, \u0027project\u0027,"},{"line_number":362,"context_line":"                      \u0027resource\u0027, \u0027search_offset\u0027, \u0027source\u0027, \u0027timestamp\u0027,"},{"line_number":363,"context_line":"                      \u0027user\u0027]"},{"line_number":364,"context_line":"        msg \u003d (\"unrecognized field in query: %s, \""},{"line_number":365,"context_line":"               \"valid keys: %s\") % (q, valid_keys)"},{"line_number":366,"context_line":"        expected_exc \u003d wsme.exc.UnknownArgument(\u0027abc\u0027, msg)"},{"line_number":367,"context_line":"        self.assertEqual(str(expected_exc), str(exc))"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a961159_9e0f5be1","line":364,"updated":"2014-12-08 05:45:35.000000000","message":"ditto","commit_id":"33065c16f6b7ffb1f3595a10559b395542e7e30d"},{"author":{"_account_id":7049,"name":"Kai Qiang Wu(Kennan)","email":"wkq5325@gmail.com","username":"Kennan"},"change_message_id":"9c11fcf564713cd8affaf1de330c569f15b5e4d2","unresolved":false,"context_lines":[{"line_number":375,"context_line":"            api._query_to_kwargs, q, storage_base.Connection.get_meters)"},{"line_number":376,"context_line":"        valid_keys \u003d [\u0027metaquery\u0027, \u0027pagination\u0027, \u0027project\u0027, \u0027resource\u0027,"},{"line_number":377,"context_line":"                      \u0027source\u0027, \u0027user\u0027]"},{"line_number":378,"context_line":"        msg \u003d (\"unrecognized field in query: %s, \""},{"line_number":379,"context_line":"               \"valid keys: %s\") % (q, valid_keys)"},{"line_number":380,"context_line":"        expected_exc \u003d wsme.exc.UnknownArgument(\u0027abc\u0027, msg)"},{"line_number":381,"context_line":"        self.assertEqual(str(expected_exc), str(exc))"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a961159_be1417f6","line":378,"updated":"2014-12-08 05:45:35.000000000","message":"ditto","commit_id":"33065c16f6b7ffb1f3595a10559b395542e7e30d"},{"author":{"_account_id":7049,"name":"Kai Qiang Wu(Kennan)","email":"wkq5325@gmail.com","username":"Kennan"},"change_message_id":"9c11fcf564713cd8affaf1de330c569f15b5e4d2","unresolved":false,"context_lines":[{"line_number":389,"context_line":"            api._query_to_kwargs, q, storage_base.Connection.get_resources)"},{"line_number":390,"context_line":"        valid_keys \u003d [\u0027metaquery\u0027, \u0027pagination\u0027, \u0027project\u0027, \u0027resource\u0027,"},{"line_number":391,"context_line":"                      \u0027search_offset\u0027, \u0027source\u0027, \u0027timestamp\u0027, \u0027user\u0027]"},{"line_number":392,"context_line":"        msg \u003d (\"unrecognized field in query: %s, \""},{"line_number":393,"context_line":"               \"valid keys: %s\") % (q, valid_keys)"},{"line_number":394,"context_line":"        expected_exc \u003d wsme.exc.UnknownArgument(\u0027abc\u0027, msg)"},{"line_number":395,"context_line":"        self.assertEqual(str(expected_exc), str(exc))"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a961159_def803c7","line":392,"updated":"2014-12-08 05:45:35.000000000","message":"ditto","commit_id":"33065c16f6b7ffb1f3595a10559b395542e7e30d"},{"author":{"_account_id":7049,"name":"Kai Qiang Wu(Kennan)","email":"wkq5325@gmail.com","username":"Kennan"},"change_message_id":"9c11fcf564713cd8affaf1de330c569f15b5e4d2","unresolved":false,"context_lines":[{"line_number":403,"context_line":"            api._query_to_kwargs, q, alarm_storage_base.Connection.get_alarms)"},{"line_number":404,"context_line":"        valid_keys \u003d [\u0027alarm_id\u0027, \u0027enabled\u0027, \u0027meter\u0027, \u0027name\u0027, \u0027pagination\u0027,"},{"line_number":405,"context_line":"                      \u0027project\u0027, \u0027state\u0027, \u0027type\u0027, \u0027user\u0027]"},{"line_number":406,"context_line":"        msg \u003d (\"unrecognized field in query: %s, \""},{"line_number":407,"context_line":"               \"valid keys: %s\") % (q, valid_keys)"},{"line_number":408,"context_line":"        expected_exc \u003d wsme.exc.UnknownArgument(\u0027abc\u0027, msg)"},{"line_number":409,"context_line":"        self.assertEqual(str(expected_exc), str(exc))"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a961159_1e036bb9","line":406,"updated":"2014-12-08 05:45:35.000000000","message":"ditto","commit_id":"33065c16f6b7ffb1f3595a10559b395542e7e30d"}]}