)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"df70226bd36198929c5c9998a92bc7591044edb9","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Lena Novokshonova \u003cenovokshonova@mirantis.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-10-31 12:21:21 +0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":" Add new notifications types for volumes/snapshots"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change allows to collect and view notifications of different types -"},{"line_number":10,"context_line":"volume/snapshot.create.start, volume/snapshot.create.end,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7a8c0949_cc820752","line":7,"updated":"2014-10-31 10:01:26.000000000","message":"nit: the leading space is not needed","commit_id":"f58a5459910e04955284f3f6d3cc9affd34ffa77"},{"author":{"_account_id":13273,"name":"Lena Novokshonova","email":"enovokshonova@mirantis.com","username":"enovokshonova"},"change_message_id":"2343d642bc14d5438f3300b584545bb5f8294124","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Lena Novokshonova \u003cenovokshonova@mirantis.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-10-31 12:21:21 +0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":" Add new notifications types for volumes/snapshots"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change allows to collect and view notifications of different types -"},{"line_number":10,"context_line":"volume/snapshot.create.start, volume/snapshot.create.end,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7a8c0949_cc2cc74d","line":7,"in_reply_to":"7a8c0949_cc820752","updated":"2014-10-31 10:11:47.000000000","message":"Done","commit_id":"f58a5459910e04955284f3f6d3cc9affd34ffa77"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"df70226bd36198929c5c9998a92bc7591044edb9","unresolved":false,"context_lines":[{"line_number":12,"context_line":"volume.resize.start, volume.resize.end,"},{"line_number":13,"context_line":"volume.attach.start, volume.attach.end,"},{"line_number":14,"context_line":"volume.detach.start, volume.detach.end."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I592605bcea483d06f219a4d02d3a70a9fc0e27a3"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7a8c0949_acb69b3b","line":15,"updated":"2014-10-31 10:01:26.000000000","message":"-1: you should link your bp here","commit_id":"f58a5459910e04955284f3f6d3cc9affd34ffa77"},{"author":{"_account_id":13273,"name":"Lena Novokshonova","email":"enovokshonova@mirantis.com","username":"enovokshonova"},"change_message_id":"2343d642bc14d5438f3300b584545bb5f8294124","unresolved":false,"context_lines":[{"line_number":12,"context_line":"volume.resize.start, volume.resize.end,"},{"line_number":13,"context_line":"volume.attach.start, volume.attach.end,"},{"line_number":14,"context_line":"volume.detach.start, volume.detach.end."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I592605bcea483d06f219a4d02d3a70a9fc0e27a3"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7a8c0949_cca127ab","line":15,"in_reply_to":"7a8c0949_acb69b3b","updated":"2014-10-31 10:11:47.000000000","message":"Spec for this change https://review.openstack.org/#/c/130572. When it will be merged I will add link to the bp","commit_id":"f58a5459910e04955284f3f6d3cc9affd34ffa77"},{"author":{"_account_id":7478,"name":"Nadya Shakhat","email":"nadmi4@gmail.com","username":"nprivalova"},"change_message_id":"7707cf96f04fa3da3095a9c5cfe3db90549632a5","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add new notifications types for volumes/snapshots"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change allows to collect and view notifications of different types -"},{"line_number":10,"context_line":"volume/snapshot.create.start, volume/snapshot.create.end,"},{"line_number":11,"context_line":"volume/snapshot.delete.start, volume/snapshot.delete.end,"},{"line_number":12,"context_line":"volume/snapshot.update.start, volume/snapshot.update.end,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"5a890539_24c4963f","line":9,"updated":"2014-11-10 12:39:19.000000000","message":"And one to make the message shorter:\nvolume/snapeshot.(create | delete | update).(start | end) and\nvolume.(resize | attach | detach).(start | end)\n\nBut it\u0027s only a suggestion :)","commit_id":"f01246339c4352053341be2ad6bf56928d505e0e"},{"author":{"_account_id":13273,"name":"Lena Novokshonova","email":"enovokshonova@mirantis.com","username":"enovokshonova"},"change_message_id":"7a36154598c380694092d5931462d4a3ecc62f96","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add new notifications types for volumes/snapshots"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change allows to collect and view notifications of different types -"},{"line_number":10,"context_line":"volume/snapshot.create.start, volume/snapshot.create.end,"},{"line_number":11,"context_line":"volume/snapshot.delete.start, volume/snapshot.delete.end,"},{"line_number":12,"context_line":"volume/snapshot.update.start, volume/snapshot.update.end,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"5a890539_cf95ab89","line":9,"in_reply_to":"5a890539_24c4963f","updated":"2014-11-10 13:07:03.000000000","message":"Ok, thanks, I will fix it in new patch)","commit_id":"f01246339c4352053341be2ad6bf56928d505e0e"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"7eb818876b00cddc230dda596c0617d0c8f816e1","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This change allows to collect and view notifications of different types -"},{"line_number":10,"context_line":"volume/snapshot.(create | delete | update).(start | end) and"},{"line_number":11,"context_line":"volume.(resize | attach | detach).(start | end)."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I592605bcea483d06f219a4d02d3a70a9fc0e27a3"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"5a890539_28c0bb29","line":12,"updated":"2014-11-12 03:17:30.000000000","message":"-1 for no blueprint link, please hold this patch","commit_id":"6ff18da738b9e0ad83dc1c34be5485c180c21cf3"},{"author":{"_account_id":13273,"name":"Lena Novokshonova","email":"enovokshonova@mirantis.com","username":"enovokshonova"},"change_message_id":"6914c51ca7b03f4be676df1f2ad11038eac2faa8","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This change allows to collect and view notifications of different types -"},{"line_number":10,"context_line":"volume/snapshot.(create | delete | update).(start | end) and"},{"line_number":11,"context_line":"volume.(resize | attach | detach).(start | end)."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I592605bcea483d06f219a4d02d3a70a9fc0e27a3"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"5a890539_ce5e5a76","line":12,"in_reply_to":"5a890539_28c0bb29","updated":"2014-11-12 10:19:04.000000000","message":"I said already: Spec for this change https://review.openstack.org/#/c/130572. When it will be merged I will add link to the bp. It was 31oct in https://review.openstack.org/#/c/131147/3//COMMIT_MSG,cm","commit_id":"6ff18da738b9e0ad83dc1c34be5485c180c21cf3"}],"ceilometer/tests/volume/test_notifications.py":[{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"19d64530f5d2be99f8ab106134d5a8ef4ae65507","unresolved":false,"context_lines":[{"line_number":238,"context_line":""},{"line_number":239,"context_line":"    def _verify_volume_common_counter(self, c, name, volume):"},{"line_number":240,"context_line":"        self.assertIsNotNone(c)"},{"line_number":241,"context_line":"        self.assertEqual(c.name, name)"},{"line_number":242,"context_line":"        self.assertEqual(fake_uuid(\u0027c\u0027), c.resource_id)"},{"line_number":243,"context_line":"        self.assertEqual(NOW, c.timestamp)"},{"line_number":244,"context_line":"        self.assertEqual(volume, c.volume)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a8c0949_a22731b5","line":241,"updated":"2014-11-07 08:53:49.000000000","message":"It would be better if:\n\n    self.assertEqual(name, c.name)","commit_id":"b2ffbd60de5f4b816d52ad009dd78b2bffef4848"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"19d64530f5d2be99f8ab106134d5a8ef4ae65507","unresolved":false,"context_lines":[{"line_number":324,"context_line":"        self._check_volume_size(NOTIFICATION_VOLUME_UPDATE_START)"},{"line_number":325,"context_line":"        self._check_volume_size(NOTIFICATION_VOLUME_UPDATE_END)"},{"line_number":326,"context_line":""},{"line_number":327,"context_line":"    def _verify_snapshot_common_counter(self, c, name, volume):"},{"line_number":328,"context_line":"        self.assertIsNotNone(c)"},{"line_number":329,"context_line":"        self.assertEqual(c.name, name)"},{"line_number":330,"context_line":"        self.assertEqual(fake_uuid(\u0027c\u0027), c.resource_id)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a8c0949_e242190f","line":327,"updated":"2014-11-07 08:53:49.000000000","message":"It looks much like _verify_volume_common_counter, and the other inner helper methods for snapshot and volume are looks similar too.\n\nHow about create a base test class, it has some attributes, such as self.host, self.name, self.size_keyname, then we inherit from it to create testVolume, testSnapshot, then add test_volume_notifications and test_snapshot_notifications to corresponding class? Then we can reduce four similar methods.","commit_id":"b2ffbd60de5f4b816d52ad009dd78b2bffef4848"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"19d64530f5d2be99f8ab106134d5a8ef4ae65507","unresolved":false,"context_lines":[{"line_number":326,"context_line":""},{"line_number":327,"context_line":"    def _verify_snapshot_common_counter(self, c, name, volume):"},{"line_number":328,"context_line":"        self.assertIsNotNone(c)"},{"line_number":329,"context_line":"        self.assertEqual(c.name, name)"},{"line_number":330,"context_line":"        self.assertEqual(fake_uuid(\u0027c\u0027), c.resource_id)"},{"line_number":331,"context_line":"        self.assertEqual(NOW, c.timestamp)"},{"line_number":332,"context_line":"        self.assertEqual(volume, c.volume)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a8c0949_025c8524","line":329,"updated":"2014-11-07 08:53:49.000000000","message":"ditto","commit_id":"b2ffbd60de5f4b816d52ad009dd78b2bffef4848"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"6a1d4a98c0e849fa9762d53774318876fc3d7dda","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":2,"context_line":"# not use this file except in compliance with the License. You may obtain"},{"line_number":3,"context_line":"#    a copy of the License at"},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"#         http://www.apache.org/licenses/LICENSE-2.0"},{"line_number":6,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a890539_a8ebcbae","line":3,"updated":"2014-11-12 03:19:05.000000000","message":"nit: align all these license announcement?","commit_id":"6ff18da738b9e0ad83dc1c34be5485c180c21cf3"},{"author":{"_account_id":7729,"name":"Ilya Tyaptin","email":"ityaptin@mirantis.com","username":"ityaptin"},"change_message_id":"32efa035e5b4449e77325f4885f9d9840a7e9f1e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":2,"context_line":"# not use this file except in compliance with the License. You may obtain"},{"line_number":3,"context_line":"#    a copy of the License at"},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"#         http://www.apache.org/licenses/LICENSE-2.0"},{"line_number":6,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":7,"id":"5a890539_426ddb97","line":3,"updated":"2014-11-12 12:08:42.000000000","message":"If I correctly understood ZhiQiang Fan\u0027s comment, it will be cool if you move all lines of licence announcement to 3 characters left.","commit_id":"ed91e257d1d695414c21932b13350747bfce40f6"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"4d8b5601fe77f28eac0d385d5daa725e79c99420","unresolved":false,"context_lines":[{"line_number":214,"context_line":""},{"line_number":215,"context_line":"class TestNotifications(base.BaseTestCase):"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"    def SetUp(self):"},{"line_number":218,"context_line":"        self.host \u003d None"},{"line_number":219,"context_line":"        self.handlerCRUD \u003d None"},{"line_number":220,"context_line":"        self.handler \u003d None"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a890539_d8a9bce0","line":217,"updated":"2014-11-12 13:11:54.000000000","message":"I think you should add a line of\n\n    super(TestNotifications, self).setUp()\n\nin case of something is done in father class.\n\nand you should use the correct name: setUp","commit_id":"26b6cba0b6fa2c3863e1325a8880ecb7982ecb76"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"4d8b5601fe77f28eac0d385d5daa725e79c99420","unresolved":false,"context_lines":[{"line_number":216,"context_line":""},{"line_number":217,"context_line":"    def SetUp(self):"},{"line_number":218,"context_line":"        self.host \u003d None"},{"line_number":219,"context_line":"        self.handlerCRUD \u003d None"},{"line_number":220,"context_line":"        self.handler \u003d None"},{"line_number":221,"context_line":"        self.handlerSize \u003d None"},{"line_number":222,"context_line":"        self.name \u003d None"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a890539_98a574b7","line":219,"updated":"2014-11-12 13:11:54.000000000","message":"Usually, we use c-style variable name, but as you can see, even the testtools we\u0027re using not obey this style, so feel free to change it or not. (I still suggest to use c-style......)","commit_id":"26b6cba0b6fa2c3863e1325a8880ecb7982ecb76"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"4d8b5601fe77f28eac0d385d5daa725e79c99420","unresolved":false,"context_lines":[{"line_number":260,"context_line":""},{"line_number":261,"context_line":"class TestVolumeNotifications(TestNotifications):"},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"    def SetUp(self):"},{"line_number":264,"context_line":"        self.host \u003d \u0027volumes.example.com\u0027"},{"line_number":265,"context_line":"        self.handlerCRUD \u003d notifications.VolumeCRUD(mock.Mock())"},{"line_number":266,"context_line":"        self.handler \u003d notifications.Volume(mock.Mock())"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a890539_78ea8810","line":263,"updated":"2014-11-12 13:11:54.000000000","message":"ditto","commit_id":"26b6cba0b6fa2c3863e1325a8880ecb7982ecb76"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"4d8b5601fe77f28eac0d385d5daa725e79c99420","unresolved":false,"context_lines":[{"line_number":270,"context_line":"        self.size \u003d VOLUME_META[\u0027size\u0027]"},{"line_number":271,"context_line":""},{"line_number":272,"context_line":"    def test_volume_notifications(self):"},{"line_number":273,"context_line":"        self.SetUp()"},{"line_number":274,"context_line":"        self._check_crud("},{"line_number":275,"context_line":"            NOTIFICATION_VOLUME_EXISTS, \u0027volume.exists\u0027)"},{"line_number":276,"context_line":"        self._check_crud("}],"source_content_type":"text/x-python","patch_set":8,"id":"5a890539_d82a9c2b","line":273,"updated":"2014-11-12 13:11:54.000000000","message":"remove this line if you use correct setUp() name","commit_id":"26b6cba0b6fa2c3863e1325a8880ecb7982ecb76"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"4d8b5601fe77f28eac0d385d5daa725e79c99420","unresolved":false,"context_lines":[{"line_number":327,"context_line":""},{"line_number":328,"context_line":"class TestSnapshotNotifications(TestNotifications):"},{"line_number":329,"context_line":""},{"line_number":330,"context_line":"    def SetUp(self):"},{"line_number":331,"context_line":"        self.host \u003d \u0027snapshots.example.com\u0027"},{"line_number":332,"context_line":"        self.handlerCRUD \u003d notifications.SnapshotCRUD(mock.Mock())"},{"line_number":333,"context_line":"        self.handler \u003d notifications.Snapshot(mock.Mock())"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a890539_f8dd9871","line":330,"updated":"2014-11-12 13:11:54.000000000","message":"ditto","commit_id":"26b6cba0b6fa2c3863e1325a8880ecb7982ecb76"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"4d8b5601fe77f28eac0d385d5daa725e79c99420","unresolved":false,"context_lines":[{"line_number":337,"context_line":"        self.size \u003d SNAPSHOT_META[\u0027volume_size\u0027]"},{"line_number":338,"context_line":""},{"line_number":339,"context_line":"    def test_snapshot_notifications(self):"},{"line_number":340,"context_line":"        self.SetUp()"},{"line_number":341,"context_line":"        self._check_crud("},{"line_number":342,"context_line":"            NOTIFICATION_SNAPSHOT_EXISTS, \u0027snapshot.exists\u0027)"},{"line_number":343,"context_line":"        self._check_crud("}],"source_content_type":"text/x-python","patch_set":8,"id":"5a890539_381ba01c","line":340,"updated":"2014-11-12 13:11:54.000000000","message":"ditto","commit_id":"26b6cba0b6fa2c3863e1325a8880ecb7982ecb76"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"24a3178ae50ddea95e71c46592d2a4cf0b9c15b5","unresolved":false,"context_lines":[{"line_number":219,"context_line":"        self.host \u003d None"},{"line_number":220,"context_line":"        self.handler_crud \u003d None"},{"line_number":221,"context_line":"        self.handler \u003d None"},{"line_number":222,"context_line":"        self.handlerSize \u003d None"},{"line_number":223,"context_line":"        self.name \u003d None"},{"line_number":224,"context_line":"        self.nameSize \u003d None"},{"line_number":225,"context_line":"        self.size \u003d None"}],"source_content_type":"text/x-python","patch_set":9,"id":"5a890539_367d70e8","line":222,"updated":"2014-11-12 14:35:00.000000000","message":"thanks for taking my advise, can the handlerSize and nameSize keep name style consistent too?","commit_id":"47b63d9e6ae120fbcab73260f9943bbe83ff67d1"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"24a3178ae50ddea95e71c46592d2a4cf0b9c15b5","unresolved":false,"context_lines":[{"line_number":262,"context_line":"class TestVolumeNotifications(TestNotifications):"},{"line_number":263,"context_line":""},{"line_number":264,"context_line":"    def setUp(self):"},{"line_number":265,"context_line":"        super(TestNotifications, self).setUp()"},{"line_number":266,"context_line":"        self.host \u003d \u0027volumes.example.com\u0027"},{"line_number":267,"context_line":"        self.handler_crud \u003d notifications.VolumeCRUD(mock.Mock())"},{"line_number":268,"context_line":"        self.handler \u003d notifications.Volume(mock.Mock())"}],"source_content_type":"text/x-python","patch_set":9,"id":"5a890539_96262415","line":265,"updated":"2014-11-12 14:35:00.000000000","message":"super usually uses its own class name, not its parent class name. Although, it may work here.","commit_id":"47b63d9e6ae120fbcab73260f9943bbe83ff67d1"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"24a3178ae50ddea95e71c46592d2a4cf0b9c15b5","unresolved":false,"context_lines":[{"line_number":329,"context_line":"class TestSnapshotNotifications(TestNotifications):"},{"line_number":330,"context_line":""},{"line_number":331,"context_line":"    def setUp(self):"},{"line_number":332,"context_line":"        super(TestNotifications, self).setUp()"},{"line_number":333,"context_line":"        self.host \u003d \u0027snapshots.example.com\u0027"},{"line_number":334,"context_line":"        self.handler_crud \u003d notifications.SnapshotCRUD(mock.Mock())"},{"line_number":335,"context_line":"        self.handler \u003d notifications.Snapshot(mock.Mock())"}],"source_content_type":"text/x-python","patch_set":9,"id":"5a890539_361650a8","line":332,"updated":"2014-11-12 14:35:00.000000000","message":"ditto","commit_id":"47b63d9e6ae120fbcab73260f9943bbe83ff67d1"}],"ceilometer/volume/notifications.py":[{"author":{"_account_id":10987,"name":"Igor Degtiarov","username":"tovstun","inactive":true},"change_message_id":"f2c9ce95e3a376d310b49b020ff72009451ef759","unresolved":false,"context_lines":[{"line_number":79,"context_line":"            type\u003dsample.TYPE_GAUGE,"},{"line_number":80,"context_line":"            unit\u003d\u0027volume\u0027,"},{"line_number":81,"context_line":"            volume\u003d1,"},{"line_number":82,"context_line":"            resource_id\u003dmessage[\u0027payload\u0027][\u0027volume_id\u0027],"},{"line_number":83,"context_line":"            user_id\u003dmessage[\u0027payload\u0027][\u0027user_id\u0027],"},{"line_number":84,"context_line":"            project_id\u003dmessage[\u0027payload\u0027][\u0027tenant_id\u0027],"},{"line_number":85,"context_line":"            message\u003dmessage)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9aa7fdbe_1b729e49","line":82,"updated":"2014-10-29 08:47:27.000000000","message":"Could you clarify why do we need to move up resource_id, under user_id and project_id? Is it a principle change?","commit_id":"dbcfce128b511a386dc6ebbc9ded5a84d75719d1"},{"author":{"_account_id":10987,"name":"Igor Degtiarov","username":"tovstun","inactive":true},"change_message_id":"fd95d76e919cb7a9cd99a35a5d64492d16e65477","unresolved":false,"context_lines":[{"line_number":79,"context_line":"            type\u003dsample.TYPE_GAUGE,"},{"line_number":80,"context_line":"            unit\u003d\u0027volume\u0027,"},{"line_number":81,"context_line":"            volume\u003d1,"},{"line_number":82,"context_line":"            resource_id\u003dmessage[\u0027payload\u0027][\u0027volume_id\u0027],"},{"line_number":83,"context_line":"            user_id\u003dmessage[\u0027payload\u0027][\u0027user_id\u0027],"},{"line_number":84,"context_line":"            project_id\u003dmessage[\u0027payload\u0027][\u0027tenant_id\u0027],"},{"line_number":85,"context_line":"            message\u003dmessage)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a8c0949_ff4dc0c5","line":82,"in_reply_to":"7a8c0949_094b3a5a","updated":"2014-10-30 12:11:14.000000000","message":"Thank you for clarification. I got principle changes.","commit_id":"dbcfce128b511a386dc6ebbc9ded5a84d75719d1"},{"author":{"_account_id":13273,"name":"Lena Novokshonova","email":"enovokshonova@mirantis.com","username":"enovokshonova"},"change_message_id":"9006ee287655e551589acc5545f16f60fcdf42fe","unresolved":false,"context_lines":[{"line_number":79,"context_line":"            type\u003dsample.TYPE_GAUGE,"},{"line_number":80,"context_line":"            unit\u003d\u0027volume\u0027,"},{"line_number":81,"context_line":"            volume\u003d1,"},{"line_number":82,"context_line":"            resource_id\u003dmessage[\u0027payload\u0027][\u0027volume_id\u0027],"},{"line_number":83,"context_line":"            user_id\u003dmessage[\u0027payload\u0027][\u0027user_id\u0027],"},{"line_number":84,"context_line":"            project_id\u003dmessage[\u0027payload\u0027][\u0027tenant_id\u0027],"},{"line_number":85,"context_line":"            message\u003dmessage)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a8c0949_094b3a5a","line":82,"in_reply_to":"9aa7fdbe_1b729e49","updated":"2014-10-30 10:08:58.000000000","message":"No, order is not important, unless you mean it. Principle changes in the VolumeCRUD and SnapshotCRUD","commit_id":"dbcfce128b511a386dc6ebbc9ded5a84d75719d1"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"19d64530f5d2be99f8ab106134d5a8ef4ae65507","unresolved":false,"context_lines":[{"line_number":149,"context_line":"            user_id\u003dmessage[\u0027payload\u0027][\u0027user_id\u0027],"},{"line_number":150,"context_line":"            project_id\u003dmessage[\u0027payload\u0027][\u0027tenant_id\u0027],"},{"line_number":151,"context_line":"            resource_id\u003dmessage[\u0027payload\u0027][\u0027snapshot_id\u0027],"},{"line_number":152,"context_line":"            message\u003dmessage)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a8c0949_7fa6c654","line":152,"updated":"2014-11-07 08:53:49.000000000","message":"are you using Eclipse and delete the last new line?","commit_id":"b2ffbd60de5f4b816d52ad009dd78b2bffef4848"},{"author":{"_account_id":7478,"name":"Nadya Shakhat","email":"nadmi4@gmail.com","username":"nprivalova"},"change_message_id":"2f33a3f2443dfb6b6865fc2ce69c45e56fe02409","unresolved":false,"context_lines":[{"line_number":66,"context_line":"class VolumeCRUD(VolumeCRUDBase):"},{"line_number":67,"context_line":"    def process_notification(self, message):"},{"line_number":68,"context_line":"        yield sample.Sample.from_notification("},{"line_number":69,"context_line":"            name\u003dmessage[\u0027event_type\u0027],"},{"line_number":70,"context_line":"            type\u003dsample.TYPE_DELTA,"},{"line_number":71,"context_line":"            unit\u003d\u0027volume\u0027,"},{"line_number":72,"context_line":"            volume\u003d1,"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a890539_c4b912eb","line":69,"updated":"2014-11-10 12:34:47.000000000","message":"Just to clarify. Everywhere type is GAUGE but here it\u0027s DELTA. It should be in Cinder docs I guess. Are you sure we should use delta here?","commit_id":"f01246339c4352053341be2ad6bf56928d505e0e"},{"author":{"_account_id":13273,"name":"Lena Novokshonova","email":"enovokshonova@mirantis.com","username":"enovokshonova"},"change_message_id":"c5cc93d91bc31ba9b6516e8075f177d12731ea57","unresolved":false,"context_lines":[{"line_number":66,"context_line":"class VolumeCRUD(VolumeCRUDBase):"},{"line_number":67,"context_line":"    def process_notification(self, message):"},{"line_number":68,"context_line":"        yield sample.Sample.from_notification("},{"line_number":69,"context_line":"            name\u003dmessage[\u0027event_type\u0027],"},{"line_number":70,"context_line":"            type\u003dsample.TYPE_DELTA,"},{"line_number":71,"context_line":"            unit\u003d\u0027volume\u0027,"},{"line_number":72,"context_line":"            volume\u003d1,"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a890539_24e576a8","line":69,"in_reply_to":"5a890539_c4b912eb","updated":"2014-11-10 12:48:04.000000000","message":"Nadya, I can mistake, but I think that here Delta(Changing over time (bandwidth)) closer than Gauge(Discrete items (floating IPs, image uploads) and fluctuating values (disk I/O))","commit_id":"f01246339c4352053341be2ad6bf56928d505e0e"}]}