)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8435,"name":"William C. Arnold","email":"barnold@us.ibm.com","username":"barnold"},"change_message_id":"098d3e779c5d3d592bffb339cad4ea9742141c34","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Use alarm\u0027s evaluation periods in sufficient test"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently, we use constant value quorum\u003d1 to check if datapoints"},{"line_number":10,"context_line":"is enough or not, however, this is not quite right to alarm rule."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Image evaluation periods is set to, for i.e., 3 for an instance on"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a961159_53ef6186","line":9,"updated":"2015-01-13 15:31:06.000000000","message":"if there are enough datapoints","commit_id":"09a1bff585096be66c6fd4ea4c0d4ba1ea515bf6"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"5ed9b52949afac5497c5e3a63b6db9024869571a","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Use alarm\u0027s evaluation periods in sufficient test"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently, we use constant value quorum\u003d1 to check if datapoints"},{"line_number":10,"context_line":"is enough or not, however, this is not quite right to alarm rule."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Image evaluation periods is set to, for i.e., 3 for an instance on"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a961159_c0fde73c","line":9,"in_reply_to":"3a961159_53ef6186","updated":"2015-01-15 12:47:20.000000000","message":"Done","commit_id":"09a1bff585096be66c6fd4ea4c0d4ba1ea515bf6"},{"author":{"_account_id":8435,"name":"William C. Arnold","email":"barnold@us.ibm.com","username":"barnold"},"change_message_id":"098d3e779c5d3d592bffb339cad4ea9742141c34","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Use alarm\u0027s evaluation periods in sufficient test"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently, we use constant value quorum\u003d1 to check if datapoints"},{"line_number":10,"context_line":"is enough or not, however, this is not quite right to alarm rule."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Image evaluation periods is set to, for i.e., 3 for an instance on"},{"line_number":13,"context_line":"cpu_util greater or equal than 80%, here are the cases which current"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a961159_d34c31cc","line":10,"updated":"2015-01-13 15:31:06.000000000","message":"for an alarm rule","commit_id":"09a1bff585096be66c6fd4ea4c0d4ba1ea515bf6"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"5ed9b52949afac5497c5e3a63b6db9024869571a","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Use alarm\u0027s evaluation periods in sufficient test"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently, we use constant value quorum\u003d1 to check if datapoints"},{"line_number":10,"context_line":"is enough or not, however, this is not quite right to alarm rule."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Image evaluation periods is set to, for i.e., 3 for an instance on"},{"line_number":13,"context_line":"cpu_util greater or equal than 80%, here are the cases which current"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a961159_e0f6635d","line":10,"in_reply_to":"3a961159_d34c31cc","updated":"2015-01-15 12:47:20.000000000","message":"Done","commit_id":"09a1bff585096be66c6fd4ea4c0d4ba1ea515bf6"},{"author":{"_account_id":8435,"name":"William C. Arnold","email":"barnold@us.ibm.com","username":"barnold"},"change_message_id":"098d3e779c5d3d592bffb339cad4ea9742141c34","unresolved":false,"context_lines":[{"line_number":10,"context_line":"is enough or not, however, this is not quite right to alarm rule."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Image evaluation periods is set to, for i.e., 3 for an instance on"},{"line_number":13,"context_line":"cpu_util greater or equal than 80%, here are the cases which current"},{"line_number":14,"context_line":"may not work as expected:"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"1. when system start or instance is just created, we may only get one"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a961159_13f5d950","line":13,"updated":"2015-01-13 15:31:06.000000000","message":". Here are the cases","commit_id":"09a1bff585096be66c6fd4ea4c0d4ba1ea515bf6"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"5ed9b52949afac5497c5e3a63b6db9024869571a","unresolved":false,"context_lines":[{"line_number":10,"context_line":"is enough or not, however, this is not quite right to alarm rule."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Image evaluation periods is set to, for i.e., 3 for an instance on"},{"line_number":13,"context_line":"cpu_util greater or equal than 80%, here are the cases which current"},{"line_number":14,"context_line":"may not work as expected:"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"1. when system start or instance is just created, we may only get one"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a961159_4099f71d","line":13,"in_reply_to":"3a961159_13f5d950","updated":"2015-01-15 12:47:20.000000000","message":"Done","commit_id":"09a1bff585096be66c6fd4ea4c0d4ba1ea515bf6"},{"author":{"_account_id":8435,"name":"William C. Arnold","email":"barnold@us.ibm.com","username":"barnold"},"change_message_id":"098d3e779c5d3d592bffb339cad4ea9742141c34","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"1. when system start or instance is just created, we may only get one"},{"line_number":17,"context_line":"or two samples for the instance"},{"line_number":18,"context_line":"2. when system is somewhere broken, or instance is restart (which will"},{"line_number":19,"context_line":"be shutoff), sample may fail to be collected in some time, so we only"},{"line_number":20,"context_line":"get one or two sample in that time range"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a961159_36fd6309","line":18,"updated":"2015-01-13 15:31:06.000000000","message":"or an instance is restarted (after being shutoff)","commit_id":"09a1bff585096be66c6fd4ea4c0d4ba1ea515bf6"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"5ed9b52949afac5497c5e3a63b6db9024869571a","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"1. when system start or instance is just created, we may only get one"},{"line_number":17,"context_line":"or two samples for the instance"},{"line_number":18,"context_line":"2. when system is somewhere broken, or instance is restart (which will"},{"line_number":19,"context_line":"be shutoff), sample may fail to be collected in some time, so we only"},{"line_number":20,"context_line":"get one or two sample in that time range"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a961159_60b19390","line":18,"in_reply_to":"3a961159_36fd6309","updated":"2015-01-15 12:47:20.000000000","message":"Done","commit_id":"09a1bff585096be66c6fd4ea4c0d4ba1ea515bf6"},{"author":{"_account_id":8435,"name":"William C. Arnold","email":"barnold@us.ibm.com","username":"barnold"},"change_message_id":"098d3e779c5d3d592bffb339cad4ea9742141c34","unresolved":false,"context_lines":[{"line_number":19,"context_line":"be shutoff), sample may fail to be collected in some time, so we only"},{"line_number":20,"context_line":"get one or two sample in that time range"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"To avoid data peak, for i.e, instance cpu_util may be 50%, 50%, 50%, 90%,"},{"line_number":23,"context_line":"in such case, alarm will not be triggered, but if instance cpu_util"},{"line_number":24,"context_line":"is None, None, None, 90%, current code will think alarm should be triggered,"},{"line_number":25,"context_line":"which is not consistent and may confuse end users."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a961159_162dc78f","line":22,"updated":"2015-01-13 15:31:06.000000000","message":"We want to avoid a spurious data peak, for instance","commit_id":"09a1bff585096be66c6fd4ea4c0d4ba1ea515bf6"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"5ed9b52949afac5497c5e3a63b6db9024869571a","unresolved":false,"context_lines":[{"line_number":19,"context_line":"be shutoff), sample may fail to be collected in some time, so we only"},{"line_number":20,"context_line":"get one or two sample in that time range"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"To avoid data peak, for i.e, instance cpu_util may be 50%, 50%, 50%, 90%,"},{"line_number":23,"context_line":"in such case, alarm will not be triggered, but if instance cpu_util"},{"line_number":24,"context_line":"is None, None, None, 90%, current code will think alarm should be triggered,"},{"line_number":25,"context_line":"which is not consistent and may confuse end users."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a961159_5bd48846","line":22,"in_reply_to":"3a961159_162dc78f","updated":"2015-01-15 12:47:20.000000000","message":"Done","commit_id":"09a1bff585096be66c6fd4ea4c0d4ba1ea515bf6"}],"ceilometer/alarm/evaluator/threshold.py":[{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"a29075fa729a625b2d4e9bb7f9070f06ba544ab1","unresolved":false,"context_lines":[{"line_number":106,"context_line":"        \"\"\""},{"line_number":107,"context_line":"        sufficient \u003d len(statistics) \u003e\u003d alarm.rule[\u0027evaluation_periods\u0027]"},{"line_number":108,"context_line":"        if not sufficient and alarm.state !\u003d evaluator.UNKNOWN:"},{"line_number":109,"context_line":"            LOG.warn(_(\u0027Expecting %(expected)d datapoints but only get \u0027"},{"line_number":110,"context_line":"                       \u0027%(actual)d\u0027) % {"},{"line_number":111,"context_line":"                \u0027expected\u0027: alarm.rule[\u0027evaluation_periods\u0027],"},{"line_number":112,"context_line":"                \u0027actual\u0027: len(statistics)})"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_fabb7c72","line":109,"updated":"2015-01-15 06:30:06.000000000","message":"maybe use _LW instead here? since we have switched to oslo.i18n","commit_id":"09a1bff585096be66c6fd4ea4c0d4ba1ea515bf6"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"5ed9b52949afac5497c5e3a63b6db9024869571a","unresolved":false,"context_lines":[{"line_number":106,"context_line":"        \"\"\""},{"line_number":107,"context_line":"        sufficient \u003d len(statistics) \u003e\u003d alarm.rule[\u0027evaluation_periods\u0027]"},{"line_number":108,"context_line":"        if not sufficient and alarm.state !\u003d evaluator.UNKNOWN:"},{"line_number":109,"context_line":"            LOG.warn(_(\u0027Expecting %(expected)d datapoints but only get \u0027"},{"line_number":110,"context_line":"                       \u0027%(actual)d\u0027) % {"},{"line_number":111,"context_line":"                \u0027expected\u0027: alarm.rule[\u0027evaluation_periods\u0027],"},{"line_number":112,"context_line":"                \u0027actual\u0027: len(statistics)})"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_20030b77","line":109,"in_reply_to":"3a961159_fabb7c72","updated":"2015-01-15 12:47:20.000000000","message":"Done","commit_id":"09a1bff585096be66c6fd4ea4c0d4ba1ea515bf6"}],"ceilometer/tests/alarm/evaluator/test_threshold.py":[{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"6e4d0acb700a037a1d4b880c7bea34c9e6198fbf","unresolved":false,"context_lines":[{"line_number":164,"context_line":"            expected \u003d [mock.call(alarm.alarm_id, state\u003d\u0027insufficient data\u0027)"},{"line_number":165,"context_line":"                        for alarm in self.alarms]"},{"line_number":166,"context_line":"            update_calls \u003d self.api_client.alarms.set_state.call_args_list"},{"line_number":167,"context_line":"            self.assertEqual(update_calls, expected)"},{"line_number":168,"context_line":"            expected \u003d [mock.call("},{"line_number":169,"context_line":"                alarm,"},{"line_number":170,"context_line":"                \u0027ok\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a930d6b_dfcbf050","line":167,"updated":"2015-01-26 21:27:44.000000000","message":"not the end of the world but switch ordering","commit_id":"553d8d96e60cf354406568ed7dd4c563e768e4d0"}]}