)]}'
{"ceilometer/tests/storage/test_storage_scenarios.py":[{"author":{"_account_id":7478,"name":"Nadya Shakhat","email":"nadmi4@gmail.com","username":"nprivalova"},"change_message_id":"dcd8ff2569bd702bcff840b2b6bcb43bfe0e2b4b","unresolved":false,"context_lines":[{"line_number":3103,"context_line":"            s, self.CONF.publisher.metering_secret)"},{"line_number":3104,"context_line":"        self.conn.record_metering_data(msg)"},{"line_number":3105,"context_line":""},{"line_number":3106,"context_line":""},{"line_number":3107,"context_line":"@tests_db.run_with(\u0027mongodb\u0027)"},{"line_number":3108,"context_line":"class MongoAutoReconnectTest(DBTestBase,"},{"line_number":3109,"context_line":"                             tests_db.MixinTestsWithBackendScenarios):"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a890539_441a826f","line":3106,"updated":"2014-11-10 12:25:05.000000000","message":"I\u0027m not sure, but I guess that db2 scenario may be added here too. Or we have a separate set of tests for it?","commit_id":"7b71962b50c20b0ee9a15197faf9b20faec0f782"},{"author":{"_account_id":10987,"name":"Igor Degtiarov","username":"tovstun","inactive":true},"change_message_id":"deb7cc04b8bac2e3e047116ad8e39cbd44c5be7e","unresolved":false,"context_lines":[{"line_number":3103,"context_line":"            s, self.CONF.publisher.metering_secret)"},{"line_number":3104,"context_line":"        self.conn.record_metering_data(msg)"},{"line_number":3105,"context_line":""},{"line_number":3106,"context_line":""},{"line_number":3107,"context_line":"@tests_db.run_with(\u0027mongodb\u0027)"},{"line_number":3108,"context_line":"class MongoAutoReconnectTest(DBTestBase,"},{"line_number":3109,"context_line":"                             tests_db.MixinTestsWithBackendScenarios):"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a890539_956e56c8","line":3106,"in_reply_to":"5a890539_441a826f","updated":"2014-11-10 14:23:59.000000000","message":"Actually not all of tests scenarios for db2 are suitable. It is happened because in db2 we have to mock other methods in contrast to mongodb for ex. get_resource method use find thru resource table in mongodb and thru meter table in db2.","commit_id":"7b71962b50c20b0ee9a15197faf9b20faec0f782"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"91dd318a528e450e639688ba12306749108ff73a","unresolved":false,"context_lines":[{"line_number":3103,"context_line":"            s, self.CONF.publisher.metering_secret)"},{"line_number":3104,"context_line":"        self.conn.record_metering_data(msg)"},{"line_number":3105,"context_line":""},{"line_number":3106,"context_line":""},{"line_number":3107,"context_line":"@tests_db.run_with(\u0027mongodb\u0027)"},{"line_number":3108,"context_line":"class MongoAutoReconnectTest(DBTestBase,"},{"line_number":3109,"context_line":"                             tests_db.MixinTestsWithBackendScenarios):"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a890539_65d84af0","line":3106,"in_reply_to":"5a890539_441a826f","updated":"2014-11-11 03:48:33.000000000","message":"Done","commit_id":"7b71962b50c20b0ee9a15197faf9b20faec0f782"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"2567cd69d018eef1c3bc7f2b3fbb8a7e2c5348e1","unresolved":false,"context_lines":[{"line_number":3139,"context_line":"            mock_find.side_effect \u003d self.create_side_effect(method, raise_exc)"},{"line_number":3140,"context_line":"            mock_find.__name__ \u003d \u0027find\u0027"},{"line_number":3141,"context_line":"            meters \u003d list(self.conn.get_meters())"},{"line_number":3142,"context_line":"            self.assertEqual(9, len(meters))"},{"line_number":3143,"context_line":""},{"line_number":3144,"context_line":"    @tests_db.run_with(\u0027mongodb\u0027, \u0027db2\u0027)"},{"line_number":3145,"context_line":"    def test_mongo_insert(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a890539_48031e42","line":3142,"updated":"2014-11-13 09:23:10.000000000","message":"why is this changing?","commit_id":"50bb34e54b418c347d301184a03cfc7d4e08c699"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"fee82f6c6b559896b44063d2ff3994f0a86898be","unresolved":false,"context_lines":[{"line_number":3139,"context_line":"            mock_find.side_effect \u003d self.create_side_effect(method, raise_exc)"},{"line_number":3140,"context_line":"            mock_find.__name__ \u003d \u0027find\u0027"},{"line_number":3141,"context_line":"            meters \u003d list(self.conn.get_meters())"},{"line_number":3142,"context_line":"            self.assertEqual(9, len(meters))"},{"line_number":3143,"context_line":""},{"line_number":3144,"context_line":"    @tests_db.run_with(\u0027mongodb\u0027, \u0027db2\u0027)"},{"line_number":3145,"context_line":"    def test_mongo_insert(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a890539_3a21b34d","line":3142,"in_reply_to":"5a890539_48031e42","updated":"2014-11-13 13:00:20.000000000","message":"@gordon chung\n\nbecause db2 get_resources() doesn\u0027t use db.resource.find, it use db.meter.find","commit_id":"50bb34e54b418c347d301184a03cfc7d4e08c699"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"2567cd69d018eef1c3bc7f2b3fbb8a7e2c5348e1","unresolved":false,"context_lines":[{"line_number":3190,"context_line":"                source\u003d\u0027test-proxy-update\u0027)"},{"line_number":3191,"context_line":"            data \u003d list(self.conn.get_resources(source\u003d\u0027test-proxy-update\u0027))"},{"line_number":3192,"context_line":"            self.assertEqual(datetime.datetime(2014, 10, 15, 17, 39),"},{"line_number":3193,"context_line":"                             data[0].last_sample_timestamp)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a890539_c8962ef0","line":3193,"updated":"2014-11-13 09:23:10.000000000","message":"why is this changing?","commit_id":"50bb34e54b418c347d301184a03cfc7d4e08c699"},{"author":{"_account_id":7478,"name":"Nadya Shakhat","email":"nadmi4@gmail.com","username":"nprivalova"},"change_message_id":"1037d6dda8d4e15324f54f514973d335d739a202","unresolved":false,"context_lines":[{"line_number":3190,"context_line":"                source\u003d\u0027test-proxy-update\u0027)"},{"line_number":3191,"context_line":"            data \u003d list(self.conn.get_resources(source\u003d\u0027test-proxy-update\u0027))"},{"line_number":3192,"context_line":"            self.assertEqual(datetime.datetime(2014, 10, 15, 17, 39),"},{"line_number":3193,"context_line":"                             data[0].last_sample_timestamp)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a890539_538c0180","line":3193,"in_reply_to":"5a890539_25aa5085","updated":"2014-11-19 10:43:44.000000000","message":"@Gordon, but who knows when it\u0027s merged? If the test may check mongo and db2 scenario both why not? If the change you pointed is merged the author will just remove \u0027db2\u0027 scenario from here and create a new test","commit_id":"50bb34e54b418c347d301184a03cfc7d4e08c699"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"0c7c6dbb717706b01689b63caf44b948dc41b306","unresolved":false,"context_lines":[{"line_number":3190,"context_line":"                source\u003d\u0027test-proxy-update\u0027)"},{"line_number":3191,"context_line":"            data \u003d list(self.conn.get_resources(source\u003d\u0027test-proxy-update\u0027))"},{"line_number":3192,"context_line":"            self.assertEqual(datetime.datetime(2014, 10, 15, 17, 39),"},{"line_number":3193,"context_line":"                             data[0].last_sample_timestamp)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a890539_4b4a7d28","line":3193,"in_reply_to":"5a890539_538c0180","updated":"2014-11-19 14:50:35.000000000","message":"let\u0027s add an ibm dev to this... there\u0027s 2 issues:\n\n  1. this seems to be testing a mongo specific reconnect test against db2 (we\u0027re only using mongo to simulate db2nosql -- ultimately db2nosql has it\u0027s own client and settings).\n  2. tbh, this is not necessary in the scope of bug anyways.","commit_id":"50bb34e54b418c347d301184a03cfc7d4e08c699"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"fee82f6c6b559896b44063d2ff3994f0a86898be","unresolved":false,"context_lines":[{"line_number":3190,"context_line":"                source\u003d\u0027test-proxy-update\u0027)"},{"line_number":3191,"context_line":"            data \u003d list(self.conn.get_resources(source\u003d\u0027test-proxy-update\u0027))"},{"line_number":3192,"context_line":"            self.assertEqual(datetime.datetime(2014, 10, 15, 17, 39),"},{"line_number":3193,"context_line":"                             data[0].last_sample_timestamp)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a890539_da934f4d","line":3193,"in_reply_to":"5a890539_c8962ef0","updated":"2014-11-13 13:00:20.000000000","message":"@gordon chung\n\ndb2 resource table doesn\u0027t have the attribute last_sample_timestamp, resource.find cannot filter resource by last_sample_timestamp on db level, it will raise IndexError when we run the old error. So we have to get_resource on connection level, then check the last_sample_timestamp on Resource object. IMO, the result is same for mongodb, but can support db2 reconnection test too.","commit_id":"50bb34e54b418c347d301184a03cfc7d4e08c699"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"1b616dd3545b245c9a6e6b779dd195a8e1458f0b","unresolved":false,"context_lines":[{"line_number":3190,"context_line":"                source\u003d\u0027test-proxy-update\u0027)"},{"line_number":3191,"context_line":"            data \u003d list(self.conn.get_resources(source\u003d\u0027test-proxy-update\u0027))"},{"line_number":3192,"context_line":"            self.assertEqual(datetime.datetime(2014, 10, 15, 17, 39),"},{"line_number":3193,"context_line":"                             data[0].last_sample_timestamp)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a890539_25aa5085","line":3193,"in_reply_to":"5a890539_da934f4d","updated":"2014-11-14 09:25:42.000000000","message":"i\u0027m inclined to say let\u0027s assume mongodb and db2nosql drivers are going to diverge so let\u0027s not make tests accommodate both.\n\nsee: https://review.openstack.org/#/c/122511/","commit_id":"50bb34e54b418c347d301184a03cfc7d4e08c699"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"dd6adaa56ffbab18f9eaece41c334f709705e47b","unresolved":false,"context_lines":[{"line_number":3129,"context_line":"        self.CONF.set_override(\u0027retry_interval\u0027, 0, group\u003d\u0027database\u0027)"},{"line_number":3130,"context_line":""},{"line_number":3131,"context_line":"    @tests_db.run_with(\u0027mongodb\u0027, \u0027db2\u0027)"},{"line_number":3132,"context_line":"    def test_mongo_client(self):"},{"line_number":3133,"context_line":"        if self.CONF.database.mongodb_replica_set:"},{"line_number":3134,"context_line":"            self.assertIsInstance(self.conn.conn.conn.conn,"},{"line_number":3135,"context_line":"                                  pymongo.MongoReplicaSetClient)"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a890539_eb8f8d74","line":3132,"updated":"2014-11-29 07:29:17.000000000","message":"I think this test should be removed or write another test class to test the option, but I\u0027m not sure if it is OK to do this in this patch, wait for core reviewers opinion","commit_id":"e5342ddca021389f74d63975fe6c9a8f1bd4ca7d"},{"author":{"_account_id":12927,"name":"Lan Qi song","email":"lqs933@foxmail.com","username":"lqisong"},"change_message_id":"50ac32bcd1e27f4fef12a943bbfc88ddadba7003","unresolved":false,"context_lines":[{"line_number":3146,"context_line":"                return method(*args, **kwargs)"},{"line_number":3147,"context_line":"        return side_effect"},{"line_number":3148,"context_line":""},{"line_number":3149,"context_line":"    @tests_db.run_with(\u0027mongodb\u0027, \u0027db2\u0027)"},{"line_number":3150,"context_line":"    def test_mongo_find(self):"},{"line_number":3151,"context_line":"        raise_exc \u003d [False, True]"},{"line_number":3152,"context_line":"        method \u003d self.conn.db.resource.find"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a890539_eb194d24","line":3149,"updated":"2014-11-29 08:40:53.000000000","message":"If you do this change here, I think the class  \"MongoAutoReconnectTest\" should be rename too.\n\nAnd I didn\u0027t find anything about this change in commit message. Is it better to propose a new patch to cover this \"db2\" change?","commit_id":"e5342ddca021389f74d63975fe6c9a8f1bd4ca7d"}]}