)]}'
{"ceilometer/compute/pollsters/disk.py":[{"author":{"_account_id":12927,"name":"Lan Qi song","email":"lqs933@foxmail.com","username":"lqisong"},"change_message_id":"e0fc3e929d9165bdacc175d051922f86ad2512f0","unresolved":false,"context_lines":[{"line_number":27,"context_line":"from ceilometer.compute import plugin"},{"line_number":28,"context_line":"from ceilometer.compute.pollsters import util"},{"line_number":29,"context_line":"from ceilometer.compute.virt import inspector as virt_inspector"},{"line_number":30,"context_line":"from ceilometer.compute.virt.libvirt import inspector as libvirt_inspector"},{"line_number":31,"context_line":"from ceilometer.openstack.common.gettextutils import _"},{"line_number":32,"context_line":"from ceilometer.openstack.common import log"},{"line_number":33,"context_line":"from ceilometer import sample"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a890539_4ba0a1a5","line":30,"updated":"2014-11-29 09:10:07.000000000","message":"A little odd to me here. In my opinion, the pollster code shouldn\u0027t need know there is a “libvirt” implementation of inspector abstract class here. Why not cover there exceptions in virt_inspector the same as the \"InstanceNotFoundException\"  even if it\u0027s only happened in Libvirt inspector.\n\nWhat\u0027s your opinion?  You can ignore this comment, if it looks fine too you. Others LGTM.","commit_id":"fc36484659d0ea508894708cbf40f67f48809108"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"8fe9c685379b4427217204e1343fadf86aaf6ea5","unresolved":false,"context_lines":[{"line_number":27,"context_line":"from ceilometer.compute import plugin"},{"line_number":28,"context_line":"from ceilometer.compute.pollsters import util"},{"line_number":29,"context_line":"from ceilometer.compute.virt import inspector as virt_inspector"},{"line_number":30,"context_line":"from ceilometer.compute.virt.libvirt import inspector as libvirt_inspector"},{"line_number":31,"context_line":"from ceilometer.openstack.common.gettextutils import _"},{"line_number":32,"context_line":"from ceilometer.openstack.common import log"},{"line_number":33,"context_line":"from ceilometer import sample"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a890539_1976f306","line":30,"in_reply_to":"5a890539_4ba0a1a5","updated":"2014-11-29 19:52:34.000000000","message":"I agree that the exceptions in libvirt module can be more generic, I will do this in next patch\n\nThanks","commit_id":"fc36484659d0ea508894708cbf40f67f48809108"}],"ceilometer/compute/pollsters/memory.py":[{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"0cf54cc0e02c8560e6493b0534bf39669f10968a","unresolved":false,"context_lines":[{"line_number":33,"context_line":"                memory_info \u003d manager.inspector.inspect_memory_usage("},{"line_number":34,"context_line":"                    instance, self._inspection_duration)"},{"line_number":35,"context_line":"                if not memory_info:"},{"line_number":36,"context_line":"                    continue"},{"line_number":37,"context_line":"                LOG.debug(_(\"MEMORY USAGE: %(instance)s %(usage)f\"),"},{"line_number":38,"context_line":"                          ({\u0027instance\u0027: instance.__dict__,"},{"line_number":39,"context_line":"                            \u0027usage\u0027: memory_info.usage}))"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a890539_8eab85d5","line":36,"updated":"2014-11-19 21:34:01.000000000","message":"seems somewhat hacky but i can\u0027t think of another solution.","commit_id":"06e9b1d5e93077133fb1aaccd077befc5656fc2c"},{"author":{"_account_id":3012,"name":"Dina Belova","email":"dbelova@mirantis.com","username":"dbelova"},"change_message_id":"ca55acf1668b578c6f6fadec9c2676ce7519262c","unresolved":false,"context_lines":[{"line_number":33,"context_line":"                memory_info \u003d manager.inspector.inspect_memory_usage("},{"line_number":34,"context_line":"                    instance, self._inspection_duration)"},{"line_number":35,"context_line":"                if not memory_info:"},{"line_number":36,"context_line":"                    continue"},{"line_number":37,"context_line":"                LOG.debug(_(\"MEMORY USAGE: %(instance)s %(usage)f\"),"},{"line_number":38,"context_line":"                          ({\u0027instance\u0027: instance.__dict__,"},{"line_number":39,"context_line":"                            \u0027usage\u0027: memory_info.usage}))"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a890539_d4f689d6","line":36,"in_reply_to":"5a890539_8eab85d5","updated":"2014-11-24 15:45:05.000000000","message":"agreed.... probably if some log line like \u0027No memory data could be inspected\u0027 should be here? Also I wonder if this can be just passed only in case of libvirt - I suppose we may grab the hypervisor inspector from manager class and continue only if it\u0027s libvirt being used. And some comments inline will be really appreciated to these lines in code.\n\nThanks!","commit_id":"06e9b1d5e93077133fb1aaccd077befc5656fc2c"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"91557fb71e144f015fb39f6419b21f9a13f44dce","unresolved":false,"context_lines":[{"line_number":33,"context_line":"                memory_info \u003d manager.inspector.inspect_memory_usage("},{"line_number":34,"context_line":"                    instance, self._inspection_duration)"},{"line_number":35,"context_line":"                if not memory_info:"},{"line_number":36,"context_line":"                    continue"},{"line_number":37,"context_line":"                LOG.debug(_(\"MEMORY USAGE: %(instance)s %(usage)f\"),"},{"line_number":38,"context_line":"                          ({\u0027instance\u0027: instance.__dict__,"},{"line_number":39,"context_line":"                            \u0027usage\u0027: memory_info.usage}))"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a890539_92e5633a","line":36,"in_reply_to":"5a890539_d4f689d6","updated":"2014-11-28 18:01:23.000000000","message":"@Dina Belova\n\nOnly Libvirt has this issue, because it is very strict to get memory usage, so None is a regular routine if Libvirt cannot get it, other inspector will raise an exception or return some meaningful value.\n\nLog messages are already printed in that inspector driver module, so we can just silently continue","commit_id":"06e9b1d5e93077133fb1aaccd077befc5656fc2c"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"612ed59c2d5c8854a90c3477edad636d0e6ce1b6","unresolved":false,"context_lines":[{"line_number":54,"context_line":"                # Libvirt cannot get memory usage information if it is not"},{"line_number":55,"context_line":"                # configured properly or not supported by underlying,"},{"line_number":56,"context_line":"                # it will raise non-fatal exception in such cases."},{"line_number":57,"context_line":"                LOG.warn(_LW(\u0027Exception while getting samples of %(pollster)s \u0027"},{"line_number":58,"context_line":"                             \u0027for %(instance_id)s: %(exc)s\u0027),"},{"line_number":59,"context_line":"                         {\u0027pollster\u0027: self.__class__.__name__,"},{"line_number":60,"context_line":"                          \u0027instance_id\u0027: instance.id, \u0027exc\u0027: e})"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a961159_5a064987","line":57,"range":{"start_line":57,"start_character":46,"end_line":57,"end_character":53},"updated":"2014-12-11 19:03:12.000000000","message":"this message isn\u0027t much different from the general exception case below... i\u0027m not really sure what conditions would fall here or in the one below.","commit_id":"47c1094bb51ce65cdc9dac13fa96fa932df0b93c"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"6c302b1f66891ed993c5f0c93a1f3e4916325df2","unresolved":false,"context_lines":[{"line_number":54,"context_line":"                # Libvirt cannot get memory usage information if it is not"},{"line_number":55,"context_line":"                # configured properly or not supported by underlying,"},{"line_number":56,"context_line":"                # it will raise non-fatal exception in such cases."},{"line_number":57,"context_line":"                LOG.warn(_LW(\u0027Exception while getting samples of %(pollster)s \u0027"},{"line_number":58,"context_line":"                             \u0027for %(instance_id)s: %(exc)s\u0027),"},{"line_number":59,"context_line":"                         {\u0027pollster\u0027: self.__class__.__name__,"},{"line_number":60,"context_line":"                          \u0027instance_id\u0027: instance.id, \u0027exc\u0027: e})"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a961159_6cc7a964","line":57,"in_reply_to":"3a961159_49f669fa","updated":"2014-12-12 20:41:04.000000000","message":"i guess the counter is that if it\u0027s a non-libvirt scenario this, ie. hyper-v can raise the same exception... it might be under-reporting a real exception.\n\nmaybe this should be left at libvirt specific level?","commit_id":"47c1094bb51ce65cdc9dac13fa96fa932df0b93c"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"7b7e85eed64006a6280acc86de09f71cd2c9925a","unresolved":false,"context_lines":[{"line_number":54,"context_line":"                # Libvirt cannot get memory usage information if it is not"},{"line_number":55,"context_line":"                # configured properly or not supported by underlying,"},{"line_number":56,"context_line":"                # it will raise non-fatal exception in such cases."},{"line_number":57,"context_line":"                LOG.warn(_LW(\u0027Exception while getting samples of %(pollster)s \u0027"},{"line_number":58,"context_line":"                             \u0027for %(instance_id)s: %(exc)s\u0027),"},{"line_number":59,"context_line":"                         {\u0027pollster\u0027: self.__class__.__name__,"},{"line_number":60,"context_line":"                          \u0027instance_id\u0027: instance.id, \u0027exc\u0027: e})"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a961159_49f669fa","line":57,"in_reply_to":"3a961159_5a064987","updated":"2014-12-12 15:57:29.000000000","message":"yes, the message is not quite different, but the point is the log level\n\nfor libvirt scenario, if vm is not supported to be inspected for memory info, then we cannot get memory usage, and such case is normal, so it should not log as exception level","commit_id":"47c1094bb51ce65cdc9dac13fa96fa932df0b93c"},{"author":{"_account_id":7052,"name":"Fabio Giannetti","email":"fgiannet@cisco.com","username":"fabgia"},"change_message_id":"fe12cc24c4b9670c688a55e2c435734f03caa4e5","unresolved":false,"context_lines":[{"line_number":54,"context_line":"                # Libvirt cannot get memory usage information if it is not"},{"line_number":55,"context_line":"                # configured properly or not supported by underlying,"},{"line_number":56,"context_line":"                # it will raise non-fatal exception in such cases."},{"line_number":57,"context_line":"                LOG.warn(_LW(\u0027Exception while getting samples of %(pollster)s \u0027"},{"line_number":58,"context_line":"                             \u0027for %(instance_id)s: %(exc)s\u0027),"},{"line_number":59,"context_line":"                         {\u0027pollster\u0027: self.__class__.__name__,"},{"line_number":60,"context_line":"                          \u0027instance_id\u0027: instance.id, \u0027exc\u0027: e})"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a961159_e30abf88","line":57,"in_reply_to":"3a961159_6cc7a964","updated":"2014-12-13 04:50:50.000000000","message":"I have to agree with Gordon. If this is a libvirt specific should be handled at that level and the warning should also be more specific stating something like::\n\nLibvirt cannot retrieve memory usage information during samples generation of %(pollster)s\n\nOr something along this line","commit_id":"47c1094bb51ce65cdc9dac13fa96fa932df0b93c"}]}